From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6F3A423F5; Tue, 17 Jan 2023 02:26:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 59060400D4; Tue, 17 Jan 2023 02:26:27 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 0E1EA40042 for ; Tue, 17 Jan 2023 02:26:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673918785; x=1705454785; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CG+WAnFFheqofBkzEoTG6gZ2Z8mnnxp/sxA7CdcW8nY=; b=HscOs4J8+berQOdmL1cwdPQBOwHZUQccTjylAJuk9T97vT7HuCNlcWpH lkBgOYgaaaUvFpIBaH+hBNlKZTP0ZGfkoNlqP1gAsYxz+L6qWE0i12HdB FybH1D26+Qb5DMumHW7GZcm1Dq1LnQFkALkBpm8P9s63y18Eb5AwbZ6e/ ggSLCfnsGvDDEnk52rR35lUsXt8aZweABB6J5Hw3vD+EFOZBoV9DZF3Gp euqdmWy8VFVCdlNXsuNXFdSt5v5s1W1z8dTXdPC/dfa24DrM8tn8c63Z1 PPJpq/VmlkI4RTwP4mB9gBf7Eh/NVKvJ9hwymAuMtgMDZTJDFmAv2tkZS A==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="312446328" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="312446328" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 17:26:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="661128333" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="661128333" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 16 Jan 2023 17:26:23 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 17:26:22 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 17:26:22 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 17:26:22 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 17:26:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S3Ut8KGt8dRlMih5KOdqI5Yqvwz/HV0pdnVJkrSjOzXI/Hl6aK25IdIctp/Chiuny5S9ndA1oQEpXyC7UR501K4JbNT6w4zsgQxm8IJB+Of2M8/28X8t34nBkZW4mkDJpsLTgy9JS9pCzd1kKw3/Xha91Shx01vlqc/BGCwVsWP7sGV3mbcRvaMCJSd7LYHL04G586o7gr0U/TU+2U86y1+Uwi0/5J9wdHYG+TxUQwVJd9dNxtn/R7ICvgl8vhTVJLvAQsqpVRk1wYGoNhJNdmKmbSBSzEAiUL22XHmLdtGlyyuVc3C//guLqt+tM3joK52xxF7Q3lo9n8VncgLkEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXYYeYTjkSqsh5gt4021Lvt0oStvW6m0gJMMZOiHFOo=; b=Dmem44U6R0JVEHgdiGfCi8FTbyOsZedeHtKw25RlrE08GCUzRrmXuzIPUC9bAXsr+07n3sj5U2tbMh9tv1r72SclCn86U7RhpDhEqE8dOU1hFMc+IEosyatep6NEfg5Ehjq8ww8uVtn67jUHiJPqQ9q2E5FqmQ3FrSPAe4GYqAvkhQKMqVVfXATXb9jpjrc1m+UTeOg8dm0XJgJA8RG5+7b9HuUdpBjDKLebrMzvTBuv1SsugkPqLFEugTQIA9XlM9hVO2ly+luHpa2VxCJIbKvJDp5COXq8s9w4xe7mIX6dVa5L52ntowCHENwVgflXhBqtV78IPXV0Udey8iPI9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB6613.namprd11.prod.outlook.com (2603:10b6:806:254::9) by CY5PR11MB6510.namprd11.prod.outlook.com (2603:10b6:930:42::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Tue, 17 Jan 2023 01:26:20 +0000 Received: from SA1PR11MB6613.namprd11.prod.outlook.com ([fe80::ab30:b5db:8ea4:6eac]) by SA1PR11MB6613.namprd11.prod.outlook.com ([fe80::ab30:b5db:8ea4:6eac%7]) with mapi id 15.20.5986.019; Tue, 17 Jan 2023 01:26:20 +0000 From: "Su, Simei" To: Stephen Hemminger , "dev@dpdk.org" CC: "Wu, Wenjun1" , "Burakov, Anatoly" Subject: RE: [PATCH v3 3/7] net/e1000: fix whitespace Thread-Topic: [PATCH v3 3/7] net/e1000: fix whitespace Thread-Index: AQHZKgjBCLNfVo7j/EK+WAmUTdArO66h0NFA Date: Tue, 17 Jan 2023 01:26:19 +0000 Message-ID: References: <20230116172732.84976-1-stephen@networkplumber.org> <20230117001453.94082-1-stephen@networkplumber.org> <20230117001453.94082-4-stephen@networkplumber.org> In-Reply-To: <20230117001453.94082-4-stephen@networkplumber.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6613:EE_|CY5PR11MB6510:EE_ x-ms-office365-filtering-correlation-id: 37f1fb85-430d-47c4-c6a6-08daf829d65b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +hvhmr+A7+Q9JIo/E9UxoGxO91uko9nnONwyVup94k1TyMDxiRuqRJQhrbRy/chjXLkE9T+SaZls94sppfdxfMK6ioEefcwb0MoSGQCq1j4RsWruEqkwtvIhhPJmvjV+AmqoxglnfPdJCbJwMr4mQcj1lUKJIO8M7tDEgCfRQE6P+niuo8f/nIhdokVKUYMdm51sUm+E3q3BoxPBk7PkeD7jJ5g7mp6CZnrYdj60RCqfXpYFhWbc3HFnI8WYoytU2txoW59vEGl0utLaq1dFCn8lFh+DIFTcl2anICewgaGnvjfhk9PhK5UaUq5Jh9VIgu9EEZ/OZNGkQWOfjMenisbn1JEWt9eu0TUmwVTO3NFhuRSagtPDRIXe/3lRn0R4PIH5q/BU4Jivws851/jsIXNVU+nbIBaG76WMnyoi4tb8LdncuUHQ79xqQ0ynDlWcrTjb6V8yx/aBuZtCv6ztsex0H5RAsFSYcIEmSUWt5RnXAv0P2pf+u2/3wdBJRJPdC4CgueixuHWbK4e6lNGkTvZrH+h8nGNIXwGtwD5QeL3lzfMUFVwvD+9rBrdPxrOxZc4+6Z6IcbxNhyRGBpT6B/a63H47MqEygYjLBo6VNzlKaQQzWbX082tFVpEK01jIeSLAF8WwfXo18WRoETE4/kt2+U1WUzmcN7ofwUUsltFTWvNBpayJ4A528UqVDqRVkm0/ZkeBZYlCgkiE/ndrKK8w5Ym7sYZP7m5nG6W/B2A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR11MB6613.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199015)(86362001)(33656002)(64756008)(53546011)(186003)(4326008)(8676002)(66556008)(76116006)(66946007)(66446008)(26005)(41300700001)(9686003)(66476007)(316002)(6506007)(7696005)(83380400001)(71200400001)(54906003)(110136005)(478600001)(122000001)(2906002)(38100700002)(38070700005)(52536014)(82960400001)(107886003)(5660300002)(8936002)(55016003)(309714004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZWw+DMzD8yuIsIcLRW/+OiS0pgy5lhkwO37X3l0Acuwf+Qc79N30Nh60Q8ml?= =?us-ascii?Q?QMdVRxNIf6so+L75Awy8xBj7j0Flmhhg/GUcXDo7RSru2w96y9/J9lS9VFym?= =?us-ascii?Q?tJiq+UAv4+TXjvxBZZpzCYwtMZn7YkJh0JdSy2vlWNFjbyCHHldskgJIq56K?= =?us-ascii?Q?CB+89yjq5fSk2ZeF0jYAH0jcA08ixzkGy4LYBnF337IbUoNqUKMKKWA3FD5x?= =?us-ascii?Q?h5Fr9L+E9UAKFmMAZ9bHVjtYDylWzA9elzZPkluIrPA4ShIg1wT+eW44W74a?= =?us-ascii?Q?A+eej9kZaNeor39WR0VOZ90CubzMjZaZMFqcMkiZ+E5hg9eat6ZSa89DwJPH?= =?us-ascii?Q?ldFnrICyjFb3sHVXC2fQZdx88nKPJJ8Oq3J6SE+BH8hKasbdM+khN9X0weOz?= =?us-ascii?Q?x3DgDX/1LFyceW23yI3RHWCnSaU0qeR2poVa5kyz+fRmchUf4ddP67S6u5lq?= =?us-ascii?Q?WaJ88vxwMa2eKJd/fChyhhCwG2s3cDRnKbIvzMdBSD1fjpW2tLurNSAyAZZ+?= =?us-ascii?Q?4njpLUdMYDVvypcziOJmz/Cn1CGVhPVW7phaU2hl/Tt0bmShBD6z6DHprPJD?= =?us-ascii?Q?fDr/MKNS3XIbyQZPQN4wcp3FIB3xKpYexZ44ajwkBUWNOOM52VOjutK+nj7X?= =?us-ascii?Q?ULdaEGFWIjtjJHf6lpty9YXBtiM+3scKFk2KreQEF+6N9l4L3H7xQaOw9ey9?= =?us-ascii?Q?izmni2qkPT/uZdFm9/vT04AXmuBkwlskAqBeQ5fgq0diAOT8qjS9BdgxOxNZ?= =?us-ascii?Q?o1pL1FSsr7E03WjuieSd6/folBm/5lxcsFsxFfGE+KKRXsvUgGdov5xjAPFK?= =?us-ascii?Q?IuLCmSVKnqkFEYoFCEzRxk5wVqRNrgobi1GwFlrNZ1cjsKqvU/IdGdTsrchZ?= =?us-ascii?Q?I1fsmUhbwsjlYchT+oVrPd9dHfhlRBAWT/nDiOPsH/cKx5nKc0ADkIAgijPi?= =?us-ascii?Q?a/7C40MtyJYvqV7KowEOUEVPo3F59MKpYtMo9Rn9G2m+LzoD7WdfEg6FD4Tb?= =?us-ascii?Q?C0Hq4COZeo5MEPN/zLa+q7A1wx6IiRGn2BBLUoUWbFXVjtiOiRZZnFbsNKU7?= =?us-ascii?Q?zxIDacxas2PillhDLpkju7unpSXXTRu7ALJfqkX1Jinkmm4oLi5AycJeiZsc?= =?us-ascii?Q?eRCw4PfGE/vbfMwpVllogIJ1zYAOG+qM7a/YxujXwQts2bd3sTIeDw535ek3?= =?us-ascii?Q?lMu702d2bpDWE/AahaqoxJsB7iJ/HOuC0W9hmc5dOUCCgHWKK3gaFqELEd30?= =?us-ascii?Q?P8H8zEqN7GDCgRvqTuGRo4HGVm0kbDJKgXWH4bFgfNmh4FxHXqHQ1M+SPlFx?= =?us-ascii?Q?3PxxtV5vSfYno0NwuHrTNKSXq4ZR9SFh4WYRypW409qLIu9LTI4rJc+biP6r?= =?us-ascii?Q?ZlYOB+RqRMUiMefLj7hw/5isHEGgjEcwNpu35d+DAhk415lSmGBtoyy2pCuG?= =?us-ascii?Q?fx4VUSAYRVY0mmKk/mHxexWjwsrw1vfQyguSlgV92EvQHaNeF2MDpe3tbRlE?= =?us-ascii?Q?dSz6jIpgqNVmLYVM7xJmliRhyngP3/A05PrpHcEsul0EtWgWX8EM9jIEOEng?= =?us-ascii?Q?aMxrrsmNOlyKSHGKouU8rPyaWdAxPHXJnMinkYzx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6613.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37f1fb85-430d-47c4-c6a6-08daf829d65b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 01:26:19.9877 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G04ZS1+NjtvZEq7m5Tn31PxQymhKno1GeGdAXt/ESQ3x/QBF1YcLf5V5kc/uXuRJLpiDAvxl7Sy9pbfenemgAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6510 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, January 17, 2023 8:15 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Su, Simei > ; Wu, Wenjun1 ; Burakov, > Anatoly > Subject: [PATCH v3 3/7] net/e1000: fix whitespace >=20 > The style standard is to use blank after keywords. > I.e "if (" not "if(" >=20 > Signed-off-by: Stephen Hemminger > --- > drivers/net/e1000/em_ethdev.c | 2 +- > drivers/net/e1000/igb_ethdev.c | 16 ++++++++-------- > drivers/net/e1000/igb_pf.c | 2 +- > drivers/net/e1000/igb_rxtx.c | 6 +++--- > 4 files changed, 13 insertions(+), 13 deletions(-) >=20 > diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.= c > index 8ee9be12ad19..3cb09538b2df 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c > @@ -872,7 +872,7 @@ eth_em_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *rte_stats) > E1000_DEV_PRIVATE_TO_STATS(dev->data->dev_private); > int pause_frames; >=20 > - if(hw->phy.media_type =3D=3D e1000_media_type_copper || > + if (hw->phy.media_type =3D=3D e1000_media_type_copper || > (E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) { > stats->symerrs +=3D E1000_READ_REG(hw,E1000_SYMERRS); > stats->sec +=3D E1000_READ_REG(hw, E1000_SEC); diff --git > a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index > 8858f975f8cc..e89bfa248fb0 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -735,7 +735,7 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev) > /* for secondary processes, we don't initialise any further as primary > * has already done this work. Only check we don't need a different > * RX function */ > - if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY){ > + if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) { > if (eth_dev->data->scattered_rx) > eth_dev->rx_pkt_burst =3D ð_igb_recv_scattered_pkts; > return 0; > @@ -927,7 +927,7 @@ eth_igbvf_dev_init(struct rte_eth_dev *eth_dev) > /* for secondary processes, we don't initialise any further as primary > * has already done this work. Only check we don't need a different > * RX function */ > - if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY){ > + if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) { > if (eth_dev->data->scattered_rx) > eth_dev->rx_pkt_burst =3D ð_igb_recv_scattered_pkts; > return 0; > @@ -1683,7 +1683,7 @@ igb_read_stats_registers(struct e1000_hw *hw, > struct e1000_hw_stats *stats) > uint64_t old_rpthc =3D stats->rpthc; > uint64_t old_hgptc =3D stats->hgptc; >=20 > - if(hw->phy.media_type =3D=3D e1000_media_type_copper || > + if (hw->phy.media_type =3D=3D e1000_media_type_copper || > (E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) { > stats->symerrs +=3D > E1000_READ_REG(hw,E1000_SYMERRS); @@ -3498,12 > +3498,12 @@ static void igbvf_set_vfta_all(struct rte_eth_dev *dev, bool = on) > E1000_DEV_PRIVATE_TO_VFTA(dev->data->dev_private); > int i =3D 0, j =3D 0, vfta =3D 0, mask =3D 1; >=20 > - for (i =3D 0; i < IGB_VFTA_SIZE; i++){ > + for (i =3D 0; i < IGB_VFTA_SIZE; i++) { > vfta =3D shadow_vfta->vfta[i]; > - if(vfta){ > + if (vfta) { > mask =3D 1; > - for (j =3D 0; j < 32; j++){ > - if(vfta & mask) > + for (j =3D 0; j < 32; j++) { > + if (vfta & mask) > igbvf_set_vfta(hw, > (uint16_t)((i<<5)+j), on); > mask<<=3D1; > @@ -3528,7 +3528,7 @@ igbvf_vlan_filter_set(struct rte_eth_dev *dev, > uint16_t vlan_id, int on) >=20 > /*vind is not used in VF driver, set to 0, check ixgbe_set_vfta_vf*/ > ret =3D igbvf_set_vfta(hw, vlan_id, !!on); > - if(ret){ > + if (ret) { > PMD_INIT_LOG(ERR, "Unable to set VF vlan"); > return ret; > } > diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c inde= x > c7588ea57eaa..b1f74eb841d2 100644 > --- a/drivers/net/e1000/igb_pf.c > +++ b/drivers/net/e1000/igb_pf.c > @@ -78,7 +78,7 @@ void igb_pf_host_init(struct rte_eth_dev *eth_dev) >=20 > if (hw->mac.type =3D=3D e1000_i350) > nb_queue =3D 1; > - else if(hw->mac.type =3D=3D e1000_82576) > + else if (hw->mac.type =3D=3D e1000_82576) > /* per datasheet, it should be 2, but 1 seems correct */ > nb_queue =3D 1; > else > diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c = index > f32dee46df82..2d4a1292053e 100644 > --- a/drivers/net/e1000/igb_rxtx.c > +++ b/drivers/net/e1000/igb_rxtx.c > @@ -196,13 +196,13 @@ struct igb_tx_queue { #ifdef > RTE_PMD_USE_PREFETCH > #define rte_igb_prefetch(p) rte_prefetch0(p) > #else > -#define rte_igb_prefetch(p) do {} while(0) > +#define rte_igb_prefetch(p) do {} while (0) > #endif >=20 > #ifdef RTE_PMD_PACKET_PREFETCH > #define rte_packet_prefetch(p) rte_prefetch1(p) #else > -#define rte_packet_prefetch(p) do {} while(0) > +#define rte_packet_prefetch(p) do {} while (0) > #endif >=20 > /* > @@ -2276,7 +2276,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) > /* 011b Def_Q ignore, according to VT_CTL.DEF_PL */ > mrqc |=3D 0x3 << E1000_MRQC_DEF_Q_SHIFT; > E1000_WRITE_REG(hw, E1000_MRQC, mrqc); > - } else if(RTE_ETH_DEV_SRIOV(dev).active =3D=3D 0) { > + } else if (RTE_ETH_DEV_SRIOV(dev).active =3D=3D 0) { > /* > * SRIOV inactive scheme > */ > -- > 2.39.0 Acked-by: Simei Su Thanks Simei