From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F97341C30; Tue, 7 Feb 2023 15:07:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E586410DF; Tue, 7 Feb 2023 15:07:13 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 9131640F18; Tue, 7 Feb 2023 15:07:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675778831; x=1707314831; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=luH1+Zq+vhd4SZzNZPsp2XQ/Fl7x2leedihJWuX3Jbo=; b=Q7pzKpJe3g5W4WFSMEbelbq2wbQyCW33dN89mMjq48goRnzeCOsU7uLK 3Yipy1XKbE7ZERX1ymQNpmltfo3y/qeuffT+hTpQXG3sR7F5t9/Uxqqeh dN5yGSXUCliBV9UfEf3zNhbWwhGRW7bbZY+ruh/6rxE59BxyjvvGpIl5G Cwzl4bzoI7BJK38viGDRJIH8DVMg9O7A79IBFce8//g6MtPuP3z0e0HB2 FEm9IB0YQyi6/nqsuJ+6hZPYP6NQyDzOJ0+WpaGKBAxf+51ptjXggaVTx X5BmM+GBG5Uqw0fO/YH4hQymG5P4KluaqxIXnT/5IHOMSOjeg/hXKXN8j Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="328156318" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="328156318" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 06:05:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="660241415" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="660241415" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 07 Feb 2023 06:05:47 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 7 Feb 2023 06:05:47 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 7 Feb 2023 06:05:47 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 7 Feb 2023 06:05:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cHqTWoDkvaUMNUOqddMhxdzHxzE44nISZgqZAMgY2j94jSVyWo8+KppZcCAAGnews3qGkw5+U5SQVG+5mXrgmzZHSJK1edc9JhMju1Ho30UGZHA2/TzI3rYOv2l8CsdrO2Ti9RT2R6YviOqBpPvxLW3z3C0jrIFzvlgPkmEEp2p4QhAEUmNY5SSq/Tb0m5nL2ExzoaegghYanRTI9OqaI++bCRlZih2RyaGRDFZz6rPvtCxZq56trcF8fZuFLoVaVkjatW8tHM9STWt8nmW/dtLeTRiFrbDfrhf7IVIRmt4YVpGIxTLwyWUrbE8+AprYnpus62ugtLui3j14pcZbEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=luH1+Zq+vhd4SZzNZPsp2XQ/Fl7x2leedihJWuX3Jbo=; b=C17ut/xQHA+eFq92tezvvbNCcK/Csg6zXFKacqCbjD4BHXKiwQ9wP0e+PPcH4nTlYtGKu8rEB5FA6a7LeRCKcJp2vw8dit5CAKpp2a7aLepXZB++Tl4Xj4kr2jMGUqvQHu71ANP1E41kZ2bl3IsSdoCrpUE9BF0Ck6o2PG4BPTUwe+b8q8kIa9noaFrIgAmKz43WyPja6gQgeokklWR6xs23RAz1o/KZYF4BPo98A7eje4TfNALBg8s31lcqWtiTTclrEw7IRjIjv0+v8eP2P+yN2RvxQkas8yZ15tL6gV8TeNS1B0PpZ1SeaWHrKjDmFhRKHZPfamf/FWNyxePo7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB6613.namprd11.prod.outlook.com (2603:10b6:806:254::9) by DM6PR11MB4548.namprd11.prod.outlook.com (2603:10b6:5:2ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 14:05:45 +0000 Received: from SA1PR11MB6613.namprd11.prod.outlook.com ([fe80::ab30:b5db:8ea4:6eac]) by SA1PR11MB6613.namprd11.prod.outlook.com ([fe80::ab30:b5db:8ea4:6eac%9]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 14:05:45 +0000 From: "Su, Simei" To: Thomas Monjalon , "Zhang, Helin" CC: David Marchand , "dev@dpdk.org" , "Zhang, Yuying" , "Xing, Beilei" , "Mcnamara, John" , "stable@dpdk.org" , "Zhang, Qi Z" , Dapeng Yu , Wenxuan Wu Subject: RE: [PATCH v2] net/i40e: don't check link status on device start Thread-Topic: [PATCH v2] net/i40e: don't check link status on device start Thread-Index: AQHZDtQHozGiwTsNnUuO3cxqDrMNGK6M2mCAgAkflQCABo+BAIAAAdaAgAAB94CAAAErgIAAALWAgASFP0CAIp18gIAAKeYw Date: Tue, 7 Feb 2023 14:05:45 +0000 Message-ID: References: <20221212143715.29649-1-david.marchand@redhat.com> <18020950.sWSEgdgrri@thomas> In-Reply-To: <18020950.sWSEgdgrri@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6613:EE_|DM6PR11MB4548:EE_ x-ms-office365-filtering-correlation-id: d6f14437-ae91-45ec-772a-08db0914683f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v6Stb+NupaYfaMyI/lFiWSt4wiQW/oGM0689wMF6ccnRvLS2T+t7Hvh1x1PvqSby+Gg4cx/QydL5p3n2Lshe2ji7k3IXuOKrys82nIpKK1LkKRei+9dV6MJ1IG38alZv2SNswgjGO3AVXO5DPDdTJZlGmQS+76krHjRHeLyxjRrC/e5T2pvVpcsOMunpV3P08sVWZ0B4ExoI0PQM+m//4HDnvthacfcF6v07afDSt65NyLXvutswJo4Y2ukjRt/EtgXTGOHHy/P3C1yAelKoGlWza4pRUqRwUQnpyLIBeQ7YQapOdT2DHmMIGjUmleTO4UN7G3Q3exwjrELzvIdjcGhYLTq/1s6pRaCZlQOP2HdowAcLMx4K10nQ6WD6kXRh8RC1XdeydyZlB1R/a8QQGW5anK5VuFSo04DQiwqDW7SFHdfJXBvljwDtqHMq50/ESTv8fWyM6Syuq1ggPXOY9s3mzZgazrw+4unvgF6Kfkfhc9CftgIfvXswreL52TIdrri9DagrH6vtVqFrorME15dJqZeuT/gqqOraf5Y395I7x8RE5OXeF6/0m+8mBRjgMw0kVyEWC63GnJgrtG3s451srFaeB7JiT6NVKG5ziwWE0xG+NdQKOoZu/p9qpUtMWASF8xoBgTt9DLchR/+Dn4fJMV962tl9X7AhuNIZlBevDKOBlUlBDdJCSlxsfvIYQRduKze5BjtObFNGEKeIvJ7N6U/aI3xx6XfBKvOuKwjYxA4nljICxOiB+mdPBgf2cJ1PnecPJ91qzmh3wmbKOg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR11MB6613.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199018)(122000001)(38100700002)(82960400001)(2906002)(110136005)(54906003)(6636002)(7696005)(71200400001)(86362001)(107886003)(478600001)(55016003)(53546011)(38070700005)(6506007)(966005)(186003)(9686003)(83380400001)(5660300002)(33656002)(41300700001)(8936002)(76116006)(8676002)(64756008)(66556008)(66476007)(66446008)(316002)(66946007)(52536014)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3iQ6TjY3WTerQQUpZnv0rFzIdiy7oRfp2F6ob1z6msXCuk6BXLWGoEMWRV+6?= =?us-ascii?Q?YFU2GNLTwojDg6zIVaUXLrM3SRUxt6AwA5IcvKvC93nTpHylwDTp29PHQQ7N?= =?us-ascii?Q?M7F5dQakLdEJBFbw3oNPyRvvtwtJCYMxF29GseFkHGCiac3HhHl1s+PhcDYI?= =?us-ascii?Q?vA1k78FzmcZwQ8mVvBK9FViQIjmiEvbaufz7BL1+xXvxaQE7CLhTitfeXVax?= =?us-ascii?Q?BsT1ZnWBN5u2hvRhSuT+5iXwQzY0PLWqs54M6AUHEpM1GRghzBzCCDM2vBr+?= =?us-ascii?Q?f6ZVy0V4adMMm9bPVh4TK9lAyY9J6yuRlslFmsEm8KOF25WvyqJdyOD7DCip?= =?us-ascii?Q?86CiDwaGaO4tPW8ZpeghFgrXm+B/g2JDvs/nemBMcIV4iQcg7WXkRPXbQ9H+?= =?us-ascii?Q?21ZKYyoB6KO/1R20/E76CUpdMGmg7miU0B/fEl+jOmT2PL1ZLE03bytU6BI3?= =?us-ascii?Q?jhDZdr4YqVWTBjZoej131yByOGjbrIb0ACLCIPR5/ok+I7GhdCA2JXT6+PRo?= =?us-ascii?Q?kSc7SjyIGAupxiBAZJZ/Dm49qHBPkkV9c1VqIkyGGXfNrMPK1KUuKW9Wc3Dv?= =?us-ascii?Q?KjWzUY2+GG6hCEp/gyXSjq5DWFW+V4USQAwb2yEXQlvu9C2/qovXSNwxPbS/?= =?us-ascii?Q?+mcRJLb3Laj/IH2RJdEHfOhZmMdJJE25rxnjvKElqpkJE9tlChz97yPQSo42?= =?us-ascii?Q?OBOoL1vnyXSensuuMpW6mheiaqC7AXDrE0+OyrYlW46vqZ9bE50r89vdIrmA?= =?us-ascii?Q?Ajhl7WLewWNm+Fq2w6Zm9jLWHp0shL7ZXdeKc8qQIUwFKVwVabBPeYMjBX7Z?= =?us-ascii?Q?aI/dwTbbZKlqaXhy0n7NtZLyxCD/0ei8aGGpG2wi5PUFI5WeVa4+WydB7yfA?= =?us-ascii?Q?aQJe6J28ft3TqRDoXAw3eRM4e07Xcb+uOJFjeqYJA+mDpLCjsAzIJKFn9h9+?= =?us-ascii?Q?GJtoD2yhBGOw7QdCQls5MigTan9le2/RGx9KlNH9jInx4WmIXm6YXA6tpK0i?= =?us-ascii?Q?qFNH5i4raSmYgb3re0cUj/5qDPbDnEAhAGSUt0a8MwRZ2e/wKFBy1gff5dvZ?= =?us-ascii?Q?ag6J+xrsci6STZ0QnZXSmyXGfYnAV0gXTxtJujY54ZDI/uymYxtRtXck8Gz+?= =?us-ascii?Q?9/RPnVaDxC5bu4j7q+xSnQDEkgiUtf0fRIxQ7gld+TfAuEQc8tJRlvsHqmis?= =?us-ascii?Q?9ru/n6D/JX644Hwr+u/uyfgZCGX2Ekt7KgZ96T65C16g//qJuWPe74CW3GX/?= =?us-ascii?Q?WSTAuRzdEnco0aypmFXwp3Iix+cKDLv3eTrMg4p+boZ+dzWT4CJBGHSQ/9XI?= =?us-ascii?Q?UEqddCdbGdlI/cc8TStYnhDJuknnliYy3oY08wXVhKD5JWRLm/mjXeLcl8p9?= =?us-ascii?Q?c20rdY98CQ04wBqmnboH3r7izb1CEjh8NRdVftOS6VMYJxp1MQujqtE+K2QP?= =?us-ascii?Q?P17a5vf6puKmjCRVlsVohfZGuzoQoF/6OSssSPY89i1SM6FgGUB193NMe1Jx?= =?us-ascii?Q?zLHnV3XWabI0Upf2+Jpoua1KE92vaSmu2tToU0H1mGkXr8yqIQky3w6yakU4?= =?us-ascii?Q?BEWyguemXFAy8wQY5NFrfhEM3WB7TVu2c7hF4OGGkfkgxvoSzDhQNE+KpWU2?= =?us-ascii?Q?Do5vbSXIUAg5q+nn/3xIgwMmKv45VhX1B4iHpSKwmkHS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6613.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6f14437-ae91-45ec-772a-08db0914683f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 14:05:45.5574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ccOP6nHUEzAB+Iv70PFAMxFBHnTZb3AHsNX1qr4hxwvkpRaV+u8Q3fp8BPxPQFYP9xyAMG0Ab5V123i2moDK/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4548 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, February 7, 2023 7:32 PM > To: Zhang, Helin ; Su, Simei > Cc: David Marchand ; dev@dpdk.org; Zhang, > Yuying ; Xing, Beilei ; > Mcnamara, John ; stable@dpdk.org; Zhang, Qi Z > ; Dapeng Yu ; Wenxuan Wu > > Subject: Re: [PATCH v2] net/i40e: don't check link status on device start >=20 > 16/01/2023 12:02, Su, Simei: > > From: David Marchand > > > On Fri, Jan 13, 2023 at 2:51 PM Zhang, Helin > wrote: > > > > From: David Marchand > > > > > On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin > > > > > > > > > > > From: David Marchand > > > > > > > Hello i40e maintainers, John, > > > > > > > > > > > > > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand > > > > > > > wrote: > > > > > > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand > > > > > > > wrote: > > > > > > > > > Hi i40e maintainers, > > > > > > > > > > > > > > > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > The mentioned changes broke existing applications when > > > > > > > > > > the link status of i40e ports is down at the time the p= ort is > started. > > > > > > > > > > Revert those changes, the original issue will need a di= fferent > fix. > > > > > > Hi David > > > > > > > > > > > > Does it break all the application or just a specific applicatio= n? > > > > > > > > > > I don't see how it would not affect all applications seeing how > > > > > the original patch is dumb. > > > > > > > > > > > We may need to understand the issue you met, and try to fix it = later. > > > > > > > > > > Just unplug the cable or fake a link down on your i40e port, > > > > > start your application or port, then plug the cable back. > > > > > The max frame size will never get applied to hw. > > > > > > > > Got it, I will forward to a right expert to check. Thank you very > > > > much for > > > reaching out to us! > > > > > > I hope I get a reply _soon_. > > > Or I will just apply those reverts. > > > > If applying those reverts, some issues still exist on our side. I sent = one patch > to patchwork: > > > https://patchwork.dpdk.org/project/dpdk/patch/20230116105318.19412-1-si > mei.su@intel.com/. > > You can try this patch to see whether it can solve the issue on your si= de. > > At the same time, on our side, we need to do regression test further > > to check if this patch will affect other cases, the regression takes so= me time. > > > > Thanks, > > Simei >=20 > Simei, do you have any update in this thread? > Last reply was 3 weeks ago. I hope regression test don't take so much tim= e. >=20 >=20 The latest patch for this issue is https://patchwork.dpdk.org/project/dpdk/= patch/20230202123632.56730-1-simei.su@intel.com/ which needs to be reworked= further. Thanks, Simei