From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4976142B8A; Wed, 24 May 2023 11:25:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C89341101; Wed, 24 May 2023 11:25:38 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 17402410F9 for ; Wed, 24 May 2023 11:25:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684920336; x=1716456336; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WmOW+HAB0kts+nDvqgnl7zSl//rgw+qttUfdyeW3FhA=; b=Dzq6E8d85BDOlr+DKgz7fqKQIK8kUkPgmFp9vnXJyYobw7JXEgiyysb8 adX4pXdSVzu2WRVmEqmkvBbdJ93Wm2hz9BiP+tuLrJZZUkqsD3Gc93yVm wMYEoCnTv0q8wXEqFk0SBtKHaOaeSp338Z6ebEQnGvjx1gG/us3Fu/BaC oSXS+iCA5w00VSdQcpuNVZ3BtNS9WeAhYke+nEwc4Pnv07d6dLRJs6Ld8 tYnNOwOfsVhCf1DFg1a3ornN0OEldw7ljrmjVSbqWRcwLLSd59f2mDaE3 tKvJ/90pXWtcXpDAFLcjsgZ/6t2fDw03sekL2O0JIBA6sG130iV8zdld1 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="342974293" X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="342974293" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 02:25:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="735129686" X-IronPort-AV: E=Sophos;i="6.00,188,1681196400"; d="scan'208";a="735129686" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 24 May 2023 02:25:34 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 02:25:34 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 02:25:34 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 02:25:34 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 02:25:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZ4H5RczwEunQq7dtQnmcr4SbVVsecEOM16dql53h5Npjnn81BBT51Ls0yXUFgM3jiVd3cqvglwrK862UUhgSDwjGkroiIwB7OLjKsKCQiHE+OII2WlEPhcBAxqsiwAHdpHYVCixW1W9J/KTfOtH46Fvs2bR9Fj5gS1++ECIFxs8VtranEXyBBw6239TZKgw+gagToCFudX/hy9ACXmBt0ih1vdifx8btRCwsS+HX5Ny9AxE1Xhtldlh2h4VbjLSD1QA7APyclT/iU19IX0RQiuQA/sdDzrYKv962IorOLx5n6WE7mN3YohDBLZP2azgi+hu/wvDx/53RtcvELxlJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZuGAOlQ9ZLg5k+MDixaHgS0c9ibbBbpijPMSgEeX4D0=; b=T4GklHa6guWiq2o6LFmXEncl68VGROqAxxOeLW1M832UvKRAgqzthe7Jnb44m1ynZKPeiX53KSG+E5BOBfMuvOkkd/fkbmxEtOS9f8JuBruwgS5BRuDpaHLYpd4e80TUZmflaT3BMZdGnsLCSxnrERPo0CrwbOSx7Kpn0sS/wy7no6FHsODeufa5ZQO9nIVB+QHjH4O8HIngcK8kPLQvaOze5/PPqRkjpzijZNQnKoRtY/9hj6vQB+ZES57qG8Ki20KUUG0SSo6Y0sardK/oB3t/sr8dWcFErJMdXHzxUUFacVzxjEZV6OJb1evGj0Q8xuuELk3+z213MS66xP1I6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB6613.namprd11.prod.outlook.com (2603:10b6:806:254::9) by IA0PR11MB8400.namprd11.prod.outlook.com (2603:10b6:208:482::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 09:25:31 +0000 Received: from SA1PR11MB6613.namprd11.prod.outlook.com ([fe80::795d:1d57:2270:3a45]) by SA1PR11MB6613.namprd11.prod.outlook.com ([fe80::795d:1d57:2270:3a45%6]) with mapi id 15.20.6411.028; Wed, 24 May 2023 09:25:30 +0000 From: "Su, Simei" To: Thomas Monjalon CC: "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , "Rybalchenko, Kirill" , "Zhang, Qi Z" , "dev@dpdk.org" , "Wu, Wenjun1" , "david.marchand@redhat.com" Subject: RE: [RFC v2 1/3] ethdev: add frequency adjustment API Thread-Topic: [RFC v2 1/3] ethdev: add frequency adjustment API Thread-Index: AQHZZg4ZVZRBDOqOwUOLzKZ8l0olsq9bpAeAgA3SaFA= Date: Wed, 24 May 2023 09:25:30 +0000 Message-ID: References: <20230331022258.382085-1-simei.su@intel.com> <20230403092248.81551-1-simei.su@intel.com> <20230403092248.81551-2-simei.su@intel.com> <4222577.mogB4TqSGs@thomas> In-Reply-To: <4222577.mogB4TqSGs@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6613:EE_|IA0PR11MB8400:EE_ x-ms-office365-filtering-correlation-id: 895f4055-f5ae-47ab-b415-08db5c38d194 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nuTp3y3Lb1L/Ov0NsIHrFRq1e+y2V37D+KhYWEDVluOicLu3YuGu6D3pBD0p1BS55dUYif2VfvdQNLcvncwmX1ADYU8qiyAaWb8qRTjgFQpz5Wrft1Ch9Z9sHgDIShxSOZIdH3EZ0ezyH7iD8MJUwKlz1125xZ3GOh2qmQAO/voPxGJROztgrq8pEIjuZQOHUsG7XOfFv5iNOgac118Zl0hgxY9dyVgN8eVq+41k+6/iS2FjW/5wgyg9BKAtCH+0InkzjVd+FqSOxd6kGC8iPgS7mfpy0mwV0ehSRpsvHC4Pb7vMs82kLf7rn20Fkfqy+b7GlzKaCOGJdG66pNNTNzW0W7RviKD5GDI7ui94YiQwmKjYD7zH5aitdowjghO9NBbV307zE6o8r+O6RlXvgasLQgnNhhJBCj6sWi8Q58SOPTYbNmpWw1Nzn+xoztd03AioZfKU9DyHShoUTJeciF/CtZqGHAblPJNGQ6zIBvI81BPTBeYs0pC6LjZCCmhaEc8p+wa9CtUA1GuQs7OB6sR131qmQcHg0uZUCzHOSztYyDWdMHFI2L4bW6N6q1oUL5nDB8QzPtJ44WLeUwps4LF3uUzFOOUrsMpOKp1wLSM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR11MB6613.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(346002)(136003)(396003)(39860400002)(376002)(451199021)(66476007)(66556008)(76116006)(66946007)(64756008)(478600001)(66446008)(6916009)(41300700001)(7696005)(966005)(54906003)(316002)(71200400001)(52536014)(38070700005)(4326008)(86362001)(5660300002)(8676002)(8936002)(33656002)(82960400001)(122000001)(26005)(186003)(53546011)(38100700002)(55016003)(9686003)(6506007)(83380400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cwvmuC/OTGPgPpZs3YDIeQcte8yskbpp8ZweX88O+OGCWVStEAbV44usYoOG?= =?us-ascii?Q?0pt0BOnPVQe6ZtTl8w18h3OVpo+/24JadJOuf3K60AbPNTwJhDpxjqr8THwf?= =?us-ascii?Q?t+IOE03iQuy+cW27s4ayyr+IEXaV7nCSPVswjjp+u/Px74Z10fW5z0phBx7Y?= =?us-ascii?Q?IIw/douSQPeVscBP7LP2FWCrHdICJFCWm8PteB2sHWUTZle55gN6ZoZ6dMiC?= =?us-ascii?Q?fjdqLGqhP0dgllz79Unvu0fhpz7wMhXZb81czDyR3aFDRpmQopMqVi/uOn5+?= =?us-ascii?Q?zgZkbhHGyP7MA3M6gti1bX+Qa5JV97AYVuRYTVkE75nFRCOyH8g84aH1VLfw?= =?us-ascii?Q?5bdmN9t29WzbPLPpA9jr3WDTp2Aer+rmtxfkEA14YbP8W7u/MvmdPZMo5L8e?= =?us-ascii?Q?MbVru3d01Of0NLr28zGT2xJLt63u6n1vNZxPVd8ifBe0pacz6slQFtcpnZZz?= =?us-ascii?Q?sPs9asGjyE5CTdAqK+BLWb8buP/E8ZJeetPdoeLY90LJOV22V7qxWkcExncC?= =?us-ascii?Q?aqgRgL6P+w3XAXv9cIY6JLaJ1kd+r96gXyzzGMNzvej/wxE/5gSdHRz2B9nB?= =?us-ascii?Q?pfmHxM8iNZpnhxb4As0KMMsYaE+r6l4U5HBT8NGZpID1dxupbX6RPE8EEQ9e?= =?us-ascii?Q?zuEAvTelswADf11U7clRzj0uKMORrPfBb+dAGcaJNSYCzMWmgJybsuicG2Gs?= =?us-ascii?Q?AO1AodpbvleDz4hip3g+524aqIE89kksHw1s9Uv4b3/h6dmmg0GuvZsMmDIj?= =?us-ascii?Q?qeCJ1c8Ig0FkBGz/o39jx7XIFBu9ZMWqgHPMJg5NV41kYpxZbyrQ3WmMamHP?= =?us-ascii?Q?H0P8FYR03nfe/lZ9N09f/+1uF9wCy3VlYL10QNxcrIQwGzjWleX89S0EAv4X?= =?us-ascii?Q?a2472cnl8b0vnbWdHyY4yRIFMZ89dT2ZI6MnFy2f8SKPjIVdlryr0eKFDgqQ?= =?us-ascii?Q?dL4P4pvqo4XWeWdfN4QTHkf5sBG7A8mwaLcOdozILUa9yI+msRzgT8LeCJeY?= =?us-ascii?Q?io1Wtg8/bP1DdfEUHWpZ4J4I4b65bE0b8/EtmvysWbyCetBuqFhQKY2wpuzu?= =?us-ascii?Q?Mo93/L5+vf6MzcCwfSGaAWxaL3r2D02jb6Dtb/hOwb3r3QEFklY9h5KKasuL?= =?us-ascii?Q?fo0ry7iHwFBncdAw4bzRTqvmPl/zFDJJryuV/BcgUt4DwgSkGSqGWbX6igg8?= =?us-ascii?Q?THMlcJPPo8c/GO/8bo76GhE6wQmBXAL+Ow5Qq4Z/8JCnNZ5F0Cg1tWFaC9Ai?= =?us-ascii?Q?qyIvakL4XNO2FgIQHeTmEF14HykqqJD4+0q1hcI85Uw6dI4MFeturOoL/NQk?= =?us-ascii?Q?fJSbe1WQC+0NL0o0c14aHU+k4/rL+LJfRws8trifD15imlJCvRIbSg/kBejl?= =?us-ascii?Q?hJrYGUWOqg6IFdAixNh4k/NZ0doJ9JVus2Q9pJ8uKXB92H3gbgPG8Bd3lhQ0?= =?us-ascii?Q?hzS9OjrxwjYjpNE8+t7ygzdNS+HPiKeVL/aehZ8dl/E9Tp+z0r9XCB2IOs0S?= =?us-ascii?Q?GlMcRLNyCRyxhsZUskFFdBJHUin9JkGQmHr0j4wGVSoe9l3ft6M1554BusQd?= =?us-ascii?Q?oRQbSzBqKa96Ubq3CKGxdpjuMOvM1j4ADeQaAHkS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6613.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 895f4055-f5ae-47ab-b415-08db5c38d194 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 09:25:30.7120 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rY7Bd2Kbum7BqFckJ/RNAbIZHgfuSVStP1efrH9S3g0zCShSxNG334FL3AkQZB3+CldQPwmU7iQT+ZCSkZM6Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8400 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, Thanks a lot for your review. I have already sent RFC v3 patch based on you= r comments. https://patchwork.dpdk.org/project/dpdk/cover/20230522132332.102030-1-simei= .su@intel.com/ Thanks, Simei > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, May 15, 2023 10:18 PM > To: Su, Simei > Cc: ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; Rybalchenko, > Kirill ; Zhang, Qi Z = ; > dev@dpdk.org; Wu, Wenjun1 ; > david.marchand@redhat.com > Subject: Re: [RFC v2 1/3] ethdev: add frequency adjustment API >=20 > Hello, >=20 > 03/04/2023 11:22, Simei Su: > > This patch introduces a new timesync API "rte_eth_timesync_adjust_freq" > > which enables frequency adjustment during PTP timesync. >=20 > You should explain how it compares with existing functions like > rte_eth_timesync_adjust_time(). >=20 > [...] > > /** > > + * Adjust the clock increment rate on an Ethernet device. > > + * > > + * This is usually used in conjunction with other Ethdev timesync > > + functions to > > + * synchronize the device time using the IEEE1588/802.1AS protocol. >=20 > All timesync functions have this sentence, but it does not help to unders= tand > how to combine them. >=20 > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param ppm > > + * Parts per million with 16-bit fractional field >=20 > Sorry I don't understand what this parameter is about. > Probably because I'm not an expert of IEEE1588/802.1AS protocol. > Please make it possible to understand for basic users. >=20 > > + * > > + * @return > > + * - 0: Success. > > + * - -ENODEV: The port ID is invalid. > > + * - -EIO: if device is removed. > > + * - -ENOTSUP: The function is not supported by the Ethernet driver. > > + */ > > +int rte_eth_timesync_adjust_freq(uint16_t port_id, int64_t ppm); >=20 > In general, I think there is an effort to provide in order to make the ti= mesync > API better understandable. > Example of something to explain: how Rx and Tx timestamps of a port are > differents? Is it different of rte_eth_timesync_read_time()? >=20 > The function rte_eth_read_clock() was provided with a better explanation. >=20 > Please make improvements in API documentation as part of this API, I don'= t > want to get more functions without improving explanation of older functio= ns. > Thank you >=20