From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C590445906; Wed, 4 Sep 2024 23:09:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEB8A4025C; Wed, 4 Sep 2024 23:09:54 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2083.outbound.protection.outlook.com [40.107.237.83]) by mails.dpdk.org (Postfix) with ESMTP id 0BD2940151 for ; Wed, 4 Sep 2024 23:09:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XfHRQ/UgS86jr2GSlhiJGVjMD6c3dV2+UnTYwXNJfnjVVYdsSw+3ta0/FFWhUqzy0TrM1REn8lDaKYPowry4p+fujbaFvUqm8oD4CZaZLiZTA3aCz6dPSP1OEh/QMs5+X2w3d7yiTtgnUjWIrzoSdzC34PtBx198/fT+WXWK2B2r2wXGUaCuu7cpgms0BPOExRTEd5XUh97zRiXyE5IyEzFVnal0+Nz23FCWyh6am1ni6YTKrZay+5CCXLYd8+rB3fY/+UT8XxaxoJt6U9KPEzFSIL3X56LMNpAgt2R+/Lx+KDg+L5P9at5SY+FAYg6YiU1uydR8rKRhGaCycnTIPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X5E4+yCM3fv326v19JAgohNj8MEnB9BUz/lmid/kQus=; b=O/67PYe4BYQpqnYp8waw1gSq09lxiFx2L2rGXBwGnkYk1+/z29tjSvyvpRStscS0wZM4XO52LbL+IRqV/nTsghqXlHVP4A10xCNakKJm7uHsFTaTCAFQ0TQ1txUmET/skp50qjF+1Zxf1lSrGy4wIRR5CqbHG85Rff7j16LW2Kg6fZgkX0NeorVxgIZ6PLIkRyuXPOfJHZpe4GoPcBs5JgCuQhTAt2C3Mrq3B2ezvsdBkE0leatKEWKVfBKrMNPurwaNL50hJsq0BhQvTkwOkxGA88RasO82sJGScgicQIeWgTDWgZJ1J3F9EIPsJUehkiaIM0egJo9xR/LqUlu7Vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X5E4+yCM3fv326v19JAgohNj8MEnB9BUz/lmid/kQus=; b=ocy6Edf2wIupULGqUsE9CTkptFKvfazIpXf2ODNOZJoxW/mRZoviVadHgJULvnn26fAFYzeLvKQ0p4I0+NuXSMVU5z59Okkr5b7zbdEy4ZhbzmJpg2hiA+yrypnzoepTrAVJ/umFub7HGfMgJu1yl66VbcBgkBb+xFyM5qd87EQsWyBIfgxJFh2yB8Ddo+IBXQR528fD1Ztbkb2e3dp53n/x6lfZOYIMtv6B2fZczSZME8ummby3lzURo4IfdCPZbgIYzuMt4AlsT8G2eQROfjZuaZxEYAWoy/lfgizWAIga8QPMWEfBd/ADUgxNJH1GSfrdLqX6YXR6y5ZtiIqlyQ== Received: from SA1PR12MB8641.namprd12.prod.outlook.com (2603:10b6:806:388::18) by MN2PR12MB4470.namprd12.prod.outlook.com (2603:10b6:208:260::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.25; Wed, 4 Sep 2024 21:09:48 +0000 Received: from SA1PR12MB8641.namprd12.prod.outlook.com ([fe80::9a57:92fa:9455:5bc0]) by SA1PR12MB8641.namprd12.prod.outlook.com ([fe80::9a57:92fa:9455:5bc0%3]) with mapi id 15.20.7918.020; Wed, 4 Sep 2024 21:09:48 +0000 From: Alexander Kozyrev To: Nithin Dabilpuram CC: "dev@dpdk.org" , Dariusz Sosnowski , Ori Kam , "olivier.matz@6wind.com" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Matan Azrad , "jerinj@marvell.com" , "rbhansali@marvell.com" , "ferruh.yigit@amd.com" Subject: Re: [PATCH] mbuf: add transport mode ESP packet type Thread-Topic: [PATCH] mbuf: add transport mode ESP packet type Thread-Index: AQHa9Kieij4aUQ4NL0mkp3ToPBTvS7JEPvyAgAP0C40= Date: Wed, 4 Sep 2024 21:09:47 +0000 Message-ID: References: <20240822153218.3782170-1-akozyrev@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR12MB8641:EE_|MN2PR12MB4470:EE_ x-ms-office365-filtering-correlation-id: 8e90f228-fe84-4d57-e606-08dccd25e8a1 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?B7avY7FmT3SBp7fYdJEKkpagPl+XfLknv+EASIsi0FVdN8rH+H5xm4GdrK?= =?iso-8859-1?Q?2D2nh0ckxELYDRSEYi3qB4MyMac14Y7Z0QAw/5eSM/QXOiBj2L88bk8UGj?= =?iso-8859-1?Q?ZfZaiPcxugxkOpE7+MhK9Jf0APbuhEO4ixBU5Rfh+MnQUVC15Z9C13VI/U?= =?iso-8859-1?Q?0KTRs5dUNlNn6L2MpfngaewVE7Y93O3NYUCwoSlU3oGGqq/rLXW6WQFRMv?= =?iso-8859-1?Q?ab5/U9jrnrAqfb4R/8neeauU6wUkH4R6SkssYNolDNwGwrvc0lJa/3cRM5?= =?iso-8859-1?Q?bwHQIvcRpk+x3ygESMBSch/cBMnqR1D6FoldevTbr2xOHDM8y6XIR1+BRW?= =?iso-8859-1?Q?seF3S/7gF9J2xtxpz+Hhy+eFj0YMNGEE12+AoC2zgG9vH1Puyokf1LK+az?= =?iso-8859-1?Q?ThW6M5wy5k8MUDhN6J7RErdTYw6eFMaFq57+ZcegM5gYLftbV4wax5oF/d?= =?iso-8859-1?Q?AHUR2zAJdJREpaMI57htGVuCAsMY2idZf9hZq9EQbYvfm3X7LyDNg/OOjp?= =?iso-8859-1?Q?Vw+y3oGOnbB3fAJvo7x2TFHn/UxpRY0lPY8aTf+4f7W1NFW6lH4V7rKZ7Y?= =?iso-8859-1?Q?PSzaBK8oqlzpZN8ta3EBDVP47yTBANT7rQXXjNZbkTfNo7P2pv0E/y0pSx?= =?iso-8859-1?Q?X05AqcTaCZDe66v0x1sN79whqTX3eA9W1K6416/2+B8p4bNN/qQxN3r874?= =?iso-8859-1?Q?fX+1VUNoKlnz/zr6hNcL3kSYLZFw0qeiFUt+gypl36ZERmu6P99GwX/LKm?= =?iso-8859-1?Q?F+VTPCErVkzznTK+TtcmpNhsOauDZ6S9D82UHtiP1AA749YNNlPg/pHq/W?= =?iso-8859-1?Q?5yYTAmD/gVdpUllmDG/7lR9zLi2FwmS4jh9TmC31gZKbiaYwRKoMbnV04L?= =?iso-8859-1?Q?8E3v3y2HNjQE/tbHYXQVlcSqnLgDRMrF1hUFfIXkvtklN2w+9STK9fuwh8?= =?iso-8859-1?Q?/l4YIdHKY0ODa8qVtt7Y7EN0d3BF/6BAPM0nJ1hpQfxt0FytjF18ITZrms?= =?iso-8859-1?Q?MMiWYjVtf0JYKyZYy7WB+azlReMQRzbNp5HUnhA0140yistitnoRsSfb+B?= =?iso-8859-1?Q?OT3rM/bRaxHGQK5URPb0KEsFKIntYPtXbS3/8pPH7Xrr72oqwQ0Skv5J4M?= =?iso-8859-1?Q?fOmEgN04UZQeYSZK/bVWMPWKv0kTWgPJ7AALEpOV35KyXvWw4+eveFZLd2?= =?iso-8859-1?Q?t29CU+TCUmv6eTa4hDqwwH5dziyqyOLU2rvGW/X50+RegtQDlbj8XtcT4p?= =?iso-8859-1?Q?XatSFcr/AIfJIHbIKBJ0vZegfeDQlZghFobsv3kAJQtEHKdXvglw0Djubs?= =?iso-8859-1?Q?zMVcYYS+Uk0tTGoD/vMwAopTbAiX+yd0+xzo4xJW3PSDeAPKNNZUZL97hy?= =?iso-8859-1?Q?LAz9mh7winqQyaI0uB3jmT+XUCQ/iaNVAkLyWYgMf+r+UROyeexIbflbIb?= =?iso-8859-1?Q?ecGvdOXXOYO+oRbGZYCjWtmfLqyhYAoAxhAHYQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR12MB8641.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?SRfuvG7MLI9pTdXNrafCZ0s1MShWdXQsr6wfmeL+3mcigc/n5yvdZWSdx6?= =?iso-8859-1?Q?d/XsFRZnJyh9ivbE00sPR1IEkmqTf1MIg6R+xQGmMVPeUzSNnp08MfNLKl?= =?iso-8859-1?Q?RTNQczUWS0mzzSfMUcgTO4unFgY+GpkHXhR30KnLJTlGWE61y7jvFkxIzD?= =?iso-8859-1?Q?e51yXTgvQEJG2vGVh+1/uMwRLQYoj79On+9rxWxavPqefE9ggEKTVgYtfl?= =?iso-8859-1?Q?/TC2JS58DlpUaIseNX/ghXF2zuovJIGufqo0q1BaWzSTJ9uHt46smYHa8R?= =?iso-8859-1?Q?Vm/C+f50YgIQcLDh5w05FFx7SocrHB9HCdEMva/nKUrq/KlQNiwSEEWsnw?= =?iso-8859-1?Q?NXi5tN0pEnd0bLg23SxrEfueGVdQqL3gkb55SmEZ2i9VTwbWkdEqRPaErz?= =?iso-8859-1?Q?mFpg7xywaTXqnoed+rXkPzWhQUyKfHjIhMXT2H05+09Ppowu0ui8mKuzdm?= =?iso-8859-1?Q?oDbIaZ79LM9eo7F8yqj5TZHt/9O/guAVJ50SIq4hxgcmjgqySKCxjsTZsz?= =?iso-8859-1?Q?lIgwMW/lzUarFkq+kRQAQqEyfzlQ0MPMg1yXZOdH4loPcohyOOhcVDO2op?= =?iso-8859-1?Q?rvod8GQdKvDKYjA/QLGu2O3SItrkaidXP3MJAgyOUN9MEHi2m08wO1GQzw?= =?iso-8859-1?Q?89KlOgCbjwcvsTtuFMAo1znXxNJB83DfGTBo/XMe5tRglxZk5n7xM9b+35?= =?iso-8859-1?Q?2FZeZ9YTuHO62BtYcUTDLIg5nsOaQj6+zJTwAWcjZQ8zHFcMv4y2eyFOjm?= =?iso-8859-1?Q?JSeCPrJc2g96SWM9KG/vJ6cwydZGLqWcFfg1S4cLTTRHMIHo6Lm9tPC5lE?= =?iso-8859-1?Q?3YdguF53SbHWtCpERnXZP4PySEFsMItFZBXdiyb0ayv6/LKA/bI0CFoo/7?= =?iso-8859-1?Q?BW21SJaOuNGhtr7+eQKxPTeJ4XWhxIDAaEQPOJeq154maw0tG3lcT8pZX9?= =?iso-8859-1?Q?9n0hsDuKUUAVqjEtFHThRdhATD1Zr25G8cbifmtrcx1adc+LkQE6uUVZkS?= =?iso-8859-1?Q?b6vryyR9UiP75DIeuT2AqLNafjZ1Cc2FEsYEEjol4XYbQecLh3N0x1U3Kc?= =?iso-8859-1?Q?keJLPCSOqLaBUSpGHmTJuiB4G9naiGjHb9m/FDImnLhtDjLxylUXHcLlWN?= =?iso-8859-1?Q?Qh7WhvfIyVAp9PZNeQF0x4U8G4IjZHwxS2vbuLGEWeFAPZ7XzPRX56OvIO?= =?iso-8859-1?Q?nmyONXWTCvE7k2neO7WAjOy6rQKrtKHaFXEyAQOUD5bpkCX1wSZghcF3Nx?= =?iso-8859-1?Q?lifCogERrvZxA+8rIaNf6Q7gPX0sYDp6m2PBLJetjGqjcmJrn0gXTjpaFf?= =?iso-8859-1?Q?nhjtTPsM1yLSWeWJaM6BtNbfWdz4dYYVgXmF/G+emt6fe60nQGMuAV2xRe?= =?iso-8859-1?Q?NGarP1qne/x0iUb8zT8JvXobxwbWDD/Okedi5M7mqccefCzub7uwMHMQwZ?= =?iso-8859-1?Q?zYxhTVGRrunXb2elrnSIAAJt8w048sh/HX5qOW1wO/Coi05t9JfFlHrZdr?= =?iso-8859-1?Q?jXssaCPkJCXTXCHF1aZf8q3rne18MbpnLt7Zf0xOttnGgSxWdmGDy9AiqO?= =?iso-8859-1?Q?CVS62fKcz/nDNDHYdCTLbzDQ8isyz3Yh5Di1jy6BWdgvk7NRrIUQsECCKq?= =?iso-8859-1?Q?6II7Zgp1KgpP7onCmzLwNmEmpj6RTRozDC?= Content-Type: multipart/alternative; boundary="_000_SA1PR12MB8641E6623C5E317DEDEEAAE3AF9C2SA1PR12MB8641namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR12MB8641.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e90f228-fe84-4d57-e606-08dccd25e8a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2024 21:09:47.9826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EE5M+m+N7Fi5hReC69aggaAiv6TiIHhPOqr8Si2sURdlncK03qRaa8xK+VadW2OMFfRcflGPqXYhgZpwJj4WfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4470 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_SA1PR12MB8641E6623C5E317DEDEEAAE3AF9C2SA1PR12MB8641namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > I think we already discussed this same patch in previous emails > (Aug-Oct 2023) at > https://mails.dpdk.org/archives/dev/2023-October/279390.html and > concluded that it is not needed ? > Did anything change from then ? Yes, Nithin, we found a way to distinguish the modes by looking into the ne= xt header field. And we definitely need RTE_PTYPE_INNER_L4_ESP for ESP over UDP support. Having RTE_PTYPE_INNER_TUNNEL_ESP for this case doesn't make sense, and, I think, it is better to introduce two L4 types for ESP now. What are = your thoughts on this? --_000_SA1PR12MB8641E6623C5E317DEDEEAAE3AF9C2SA1PR12MB8641namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
> I think we already discussed this same patch in previous emails
> (Aug-Oct= 2023) at
> https://mails.dpdk.org/archives/dev/2023-October/279390.html and
> conclude= d that it is not needed ?
> Did anything change from then ?

Yes, Nithin, we foun= d a way to distinguish the modes by looking into the next header field.
And we definitely need RTE_PTYPE_INNER_L4_ESP for ESP over UDP support= .
Having RTE_PTYPE_INNER_TUNNEL_ESP for this case doesn't make sense,
and, I think, it is better to introduce two L4 types for ESP now. What are = your thoughts on this?

--_000_SA1PR12MB8641E6623C5E317DEDEEAAE3AF9C2SA1PR12MB8641namp_--