RE: [RFC PATCH] ethdev: add new API for enable/disable xstat counters by ID

[Shani Peretz <shperetz@nvidia.com>]

I understand what you say about the per queue statistics,
but note that we want to be able to enable/disable stat in general - the stat can be related to a specific queue, or a port, or else. but the PMD get the chance to disable the collection of it and save resources.

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, 24 December 2024 19:19
> To: Shani Peretz <shperetz@nvidia.com>
> Cc: dev@dpdk.org; Aman Singh <aman.deep.singh@intel.com>; Dariusz
> Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@amd.com>; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Anatoly Burakov
> <anatoly.burakov@intel.com>
> Subject: Re: [RFC PATCH] ethdev: add new API for enable/disable xstat counters
> by ID
> 
> External email: Use caution opening links or attachments
> 
> 
> On Mon, 23 Dec 2024 10:46:59 +0000
> Shani Peretz <shperetz@nvidia.com> wrote:
> 
> > Sorry if it wasn't clear, in mlx5 there is limited number of counters, so if there
> are X counters and 2X queues, there won't be enough counters to get statistics
> for all queues at the same time.
> > In this case we thought the best approach would be to allow the user to
> choose which queues they want statistics from.
> > If the counters are exceeded, the user would have the option to disable the
> counter, thereby freeing up the resource for reuse elsewhere.
> >
> 
> Ok, other hardware may have same issue.
> Why not do it per-queue (not the id stuff).
> 
> Kind of related to the existing queue stat counters that need rework.
> The ixgbe has similar mapping problem.
> 
> Let's solve this once across multiple devices.