From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDD3245561; Wed, 3 Jul 2024 15:42:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE9D842DB1; Wed, 3 Jul 2024 15:42:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 1F4B6427E4 for ; Wed, 3 Jul 2024 15:42:36 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4638jgpv004794; Wed, 3 Jul 2024 06:42:36 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 4053du95rt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Jul 2024 06:42:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bsqZ3ibleTqxBXP6o4Lp7CBvTbGBB6cxfHhgRhasdwm4kFDIeM2niyfXXOJwVWIVjlM7EZX+2IW0P+YkNTqG6GRcIVR+MEeoU0PoTXsLztXUNmpdaAGBTQFZ+c1/PRqN/mWWZkgqUoVv7z+OeKWMNH+7/LiTPt/NRio9tnR3ihH9L2gAmcyvQCAUlpME8WQvlHWxGfjgyKCoN+v4QMAk1SAK+WvkWBqxpviFz0IiwkqeuA7gcrLRjV1+TFXwgCUTkOmw+lMztIRZeSVe4O2wvupPFaN2GB5sPIGTMl9GKVLGngknlknH/x4OPcUrJ7Upd3EMGnTNzK209tHX8uas9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V6EYJdi/QC1qsVlML02t/bCboSMLaFSuKZTeWDMPfKM=; b=LP4I72OsmJg49A9XTsrs2WFg1c9R3JrPiWspxSmQ40Cp23hcCBjzwi4RLNlKVEV/IzLWCGTXS4tB8hUlJ6byoQWoYuy7loS0OJLqxkbW0dgsueYYMmARfcKQlqbTf3TUt3ofs1DH8DwtnuzbNsvNMkhpHN6srzZapm5veVro5bcZzDXloV7DlIsM7wmyCacze1OMWbahfHcEJ4DOTzsbcM3101WEx/y7iz92efacSoyAetV1xEyc3dVRNvnSM9OJid/u1v2gOYcfsLUYcd4Iff/NiB9jssHPvmXSL8M+VcqEeoJoJEDsXA+kketLlHa4adLF3JW/cWFjjX03xnQfpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V6EYJdi/QC1qsVlML02t/bCboSMLaFSuKZTeWDMPfKM=; b=gqUUPLSWJ9aiNOSghZiSqhdR2Li42YpEvacnDdUrbTRTNoWPAVulTg9X2RMleR0hakwA7Bf03NUQGM4lQVCtAIxzjIiypBC6moOdiVvraSCzLGso3bSN8C6RJ3QYDNrWFVT7Rqq8DiFBIK/jNgvuoOFS5on4yoQjJaYI1oRbN7o= Received: from SA1PR18MB4533.namprd18.prod.outlook.com (2603:10b6:806:1e0::17) by DM4PR18MB5220.namprd18.prod.outlook.com (2603:10b6:8:53::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.28; Wed, 3 Jul 2024 13:42:30 +0000 Received: from SA1PR18MB4533.namprd18.prod.outlook.com ([fe80::db0a:2b07:52a:dbc]) by SA1PR18MB4533.namprd18.prod.outlook.com ([fe80::db0a:2b07:52a:dbc%4]) with mapi id 15.20.7719.029; Wed, 3 Jul 2024 13:42:29 +0000 From: Volodymyr Fialko To: Thomas Monjalon CC: "dev@dpdk.org" , "cristian.dumitrescu@intel.com" , Jerin Jacob , Anoob Joseph Subject: Re: [PATCH v5] bitmap: add scan from offset function Thread-Topic: [PATCH v5] bitmap: add scan from offset function Thread-Index: AQHazU7ZZed6uyWdLkOTR6x9opz+rQ== Date: Wed, 3 Jul 2024 13:42:29 +0000 Message-ID: References: <20230703093130.198304-1-vfialko@marvell.com> <20230703123909.328480-1-vfialko@marvell.com> <11099356.0mgMEAqHVh@thomas> In-Reply-To: <11099356.0mgMEAqHVh@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR18MB4533:EE_|DM4PR18MB5220:EE_ x-ms-office365-filtering-correlation-id: 93a53039-366f-4d72-a0c1-08dc9b65fb9e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?GJoWdIH1e3rvruyuUMWtSTrewtJRv+V2zEmAxU8gNZGShK1FhMnDYYu+UY?= =?iso-8859-1?Q?IGzLUj6QuluO+W1q0b5UVt9oZdIIS8h5sEId8vsUo6zFO0wG9uIuqaWbS8?= =?iso-8859-1?Q?m4MmlrT6Ps/hSTryRrZbMLJDDtqlINAO4QYSyPfojLOKdxXnFasgZboJrY?= =?iso-8859-1?Q?chW103gvpsIDFX1utrs4ZGGRgk3wmjW733df9rCQhlmP/bkTOfbRnFNYNx?= =?iso-8859-1?Q?kC7Qd8CercJ34R9lThgZ+krgnX//3Zpc1Ce/C54vMCG9sm1zJTVP/mWH6X?= =?iso-8859-1?Q?WqGzZomQt7fYQ2mkiSJiRMamAmItBpcbNIL09uzDb4BqFQq0dHZgx+BF36?= =?iso-8859-1?Q?3jtxbv6THsEfPFJWMtJlUIZLo5roIEBAOo90ZRLNpYmNP3H6lIzCE7nnr7?= =?iso-8859-1?Q?/ELAAIv4/ogcozZAn/qQUSWTx6xXOs/cxj4k6okk8hV0OWWcC2gxpQqd7v?= =?iso-8859-1?Q?tFUSdr0qBVul7iQsleMJvp0i4e/YHuTQRQBFAqHJLREVtxexfZB/iK8igs?= =?iso-8859-1?Q?ktmnkpmWVgoSH8Rc+2KJAvC8V8qeDm08/cOHqSDWZbI8VLr+iTAVAxCvIf?= =?iso-8859-1?Q?PN57uSuBgWJUC+6Wt28L3mghetirbAv/KYtRNjsTP0hnhO9PPrwU0Uo0NB?= =?iso-8859-1?Q?UDUzOa4uMrOtSrZ9UUQvvbF+Zf5xF0+aTBYGZDVo9tHgUmj6fvnrYCui99?= =?iso-8859-1?Q?wteMYQRAJNEJCHc81uTWP9AbxoPB9HNXBSZfWbaCTKZ9HKDqpLPtt+pY9+?= =?iso-8859-1?Q?IwPrSECVieAsEN9FlIUsFakHnjRFaR6YfmYT3IAXBDrMMlTTihuKlE03ib?= =?iso-8859-1?Q?kUFkeU5doIczTU7US6BJhNq81xdbBCZaRtoDmEe6e8relMdhWDy7lZVuaI?= =?iso-8859-1?Q?pFbZIQ3oOkXPlcJIUi2dS2ghMefwFGW6Q/xAOsZcgeT6bX8tJDdJkmk9eX?= =?iso-8859-1?Q?12YhjFsQ6PXv34AkzyOyv9RHZPIC07q2QPHFU/5uuOYx6GA1icYhM8L4oQ?= =?iso-8859-1?Q?NWML8s98mZd4NxokEwbjAPZ24TF6jUsdAr0hHaWL6KGTuwtgSr05zrelqV?= =?iso-8859-1?Q?88YY7UFQXXo4RoqHFTHct9zBYzNVLLp3o9G32frSrQtgC4F95GdeGxDR/F?= =?iso-8859-1?Q?SECPbbtctpCFA1UkKR60KdYsb5+gKstzxETHVAfLcbDPcds0Fh7bPQ9tPz?= =?iso-8859-1?Q?+E9zm56Quy77c94tCxZBkgRZMdOxT5OHb0rIpyczkls3eSxWAsxfnPNSCe?= =?iso-8859-1?Q?ZUZWEyTfwX9BubLaJPsLFUVpz2w8+kPkibtzD3syv4l1QIFhjLnxbf3bN7?= =?iso-8859-1?Q?kLt0nW74RJFGzZrp27bWzgoPABILc/hF04HaXcwPXySNFwQtW9YA9aRvFx?= =?iso-8859-1?Q?6wFdwdVAWGxOdceyi0v4RkupVDuNhUNKI12oYKPdyOhCIP81g4/Os=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR18MB4533.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?YnH/fO1p2aI2gLcPYZ8KcFOjai+/lt3DcOaw2JPeGhiLdCKa94yyCJJYoP?= =?iso-8859-1?Q?CzZ5mQxSuO9si7zrZGD2UGO55xcUvmbJkkKM1fs2eu0N2z/1+Wirxl/Mdr?= =?iso-8859-1?Q?DqjXv0qmUBMXoq8OCkI6n5GWx2AXMO+mlqy31cJFZjflz+Y6rdgRiJh7Yo?= =?iso-8859-1?Q?PCJtb06kSi42jlUj5AWg7Qi4OWm2Z5hyP8Ttidw0b0gcsXQO5yIYA5IiWg?= =?iso-8859-1?Q?Q6j6y5XjAfrHNG2qc/h1+Mo+Mf7rP/2NzxjMrmIOEd08rl4IqrdsqxXERx?= =?iso-8859-1?Q?FAvzrYW1I316XXJzfNvCJtUOiGzjcPkvxMs+0EtMgg2gF7VQSZG/E7s4eL?= =?iso-8859-1?Q?ty6a+boQ3l7oRWXYzf6zC6g9HbcSO7PQ+YsF8u2Fgl3zitulllgoeXHLs8?= =?iso-8859-1?Q?viN9ZIDmGVPp2flybajQn6t2GEs57DxkK60PBbwmKNnCWDefocR7zKJ5pj?= =?iso-8859-1?Q?MVJmY5gpGH4yaj+yoB6eJFVQhl0G0EorAJsEf5tTF8WrYMpWcPQ3psAO+g?= =?iso-8859-1?Q?kIVxxFy/Kny9Qv0s0hokssuNjgYQy34aZUe3dzQpNA+LIMqFJcCYbQamxQ?= =?iso-8859-1?Q?JS7gQhqTns6w7TtDx4H4VPZjuvmLlOo1MZuMWxW9XGkzORdYTI3vSbUidX?= =?iso-8859-1?Q?lOXRcPda49VySSX7aq1sE08xUq5qQwXB2eurD7+7+/r49/4kgBZ4j9LKd7?= =?iso-8859-1?Q?Zm574GgUbrlI95QB69Ogfs+b9zndyHSqN0sMNo7ZW8lPEb9V1Sv1CwrCe8?= =?iso-8859-1?Q?ZFIkUUd63M+0zsq6rsNU59UOBhYnQ3o7h0Uma9TAAxpdmNk5bu9DTuVA1R?= =?iso-8859-1?Q?2i3iADwCRcUaZCXtsAB6UeeeqPOiA7cc9J24Q22Ho7LWlHclTmAc+dDvM5?= =?iso-8859-1?Q?O0fH6567Uvo3uYTd0IF1uDSULkirbDUk8B1Opuu1lLtUnwkg++GTxrJa7x?= =?iso-8859-1?Q?GOPVgaCkLhtgKwKNrGfIQgbJBPkFJ7mc4lC3EBV1Jelwb7FgVylYyAEn0Z?= =?iso-8859-1?Q?OUtJA9retOrIjJ0/BtyGziN5hHos2hVtnn59lQUL5u/oP2s6PmeyEOPIZP?= =?iso-8859-1?Q?WzU3U3FB9wxXey6IuVtTb0p0Pt895HFqfMWyhWcriNCDgYY6g9an4NWHG4?= =?iso-8859-1?Q?uGKm10Dl6qE2t+2WjPklcKyyqPb5utfH4q+LkcISfKJzfDg86+byGruPHq?= =?iso-8859-1?Q?ikSqzlAx1F6hUzhddScTnblkwhCgL2AHMq8MWW0dJVWhpqO4kGCqdbam2S?= =?iso-8859-1?Q?nzl375+R72sMbXgsO9kiE7LYsrO7JthXOZ2auI9dzEwPb6nUDK/WdOYNxc?= =?iso-8859-1?Q?Zp0kQGP/8xHeQQz3CQB/cwcyHfMdVsBZn8GGR1eG+J+/gLofVr79Y9HK4b?= =?iso-8859-1?Q?w68/FveNQ36v/mcNcmiQ8L8yZnGy38iRC3N7XKr78cvvOe8NfX/ol1R/f/?= =?iso-8859-1?Q?zL9OsdIf3qNtDRbUxD/wDwDnY4UhpV8uv4wWhG7TONoYP3/oLn3BC+xMT2?= =?iso-8859-1?Q?ECE3QvwDOkbVF85BPdRQF//g33qI5/UeZTHpIKhBMO2geJshVEQkLgbOL3?= =?iso-8859-1?Q?x3zYl6m0p85Ts1GNicS4WS7/vqk581izxnaeTadWRt0JIZ9UrMZBhwJby3?= =?iso-8859-1?Q?haJvu8slb5mNg=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR18MB4533.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93a53039-366f-4d72-a0c1-08dc9b65fb9e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2024 13:42:29.5058 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XYDaxTJrdwkbHrz6kLzFjtaFgYRUPSnDB01NtYVrF3iXEsJiotWSfRamJgen8Nc3wh1NlW1ErtlxB1j2mL59gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5220 X-Proofpoint-ORIG-GUID: LovCT_843Wikdmok4Ux_sF57U7rljEck X-Proofpoint-GUID: LovCT_843Wikdmok4Ux_sF57U7rljEck X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-03_08,2024-07-03_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Thomas Monjalon =0A= > Sent: Wednesday, July 3, 2024 2:50 PM=0A= > To: Volodymyr Fialko=0A= > Cc: dev@dpdk.org; cristian.dumitrescu@intel.com; Jerin Jacob; Anoob Josep= h=0A= > Subject: Re: [PATCH v5] bitmap: add scan from offset function=0A= >=0A= > 03/07/2023 14:39, Volodymyr Fialko:=0A= > > Currently, in the case when we search for a bit set after a particular= =0A= > > value, the bitmap has to be scanned from the beginning and=0A= > > rte_bitmap_scan() has to be called multiple times until we hit the valu= e.=0A= > >=0A= > > Add a new rte_bitmap_scan_from_offset() function to initialize scan=0A= > > state at the given offset and perform scan, this will allow getting=0A= > > the next set bit after certain offset within one scan call.=0A= > >=0A= > > Signed-off-by: Volodymyr Fialko =0A= > > ---=0A= > > v2:=0A= > > - added rte_bitmap_scan_from_offset=0A= > > v3:=0A= > > - added note for internal use only for init_at function=0A= > > v4:=0A= > > - marked init_at function as __rte_internal=0A= > > v5:=0A= > > - removed __rte_internal due to build errors=0A= > =0A= > What was the build error?=0A= > =0A= > You should not add an internal function in the public header file.=0A= > At least, it should be experimental.=0A= > =0A= =0A= >From our discussion in previous versions(V3, V4), It looks like we agreed t= o=0A= remove both markers.=0A= =0A= > From: Thomas Monjalon =0A= > Sent: Monday, July 3, 2023 2:17 PM=0A= > To: Dumitrescu, Cristian; Volodymyr Fialko=0A= > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran; Anoob Joseph=0A= > Subject: Re: [PATCH v3] bitmap: add scan from offset function=0A= > =0A= > > ----------------------------------------------------------------------= =0A= > > 03/07/2023 12:56, Volodymyr Fialko:=0A= > > > Since it's header-only library, there is issue with using __rte_inten= al (appeared in v4).=0A= > > =0A= > > What is the issue?=0A= > =0A= > From V4 ci build failure(http://mails.dpdk.org/archives/test-report/2023-= July/421235.html):=0A= > In file included from ../examples/ipsec-secgw/event_helper.c:6:=0A= > ../lib/eal/include/rte_bitmap.h:645:2: error: Symbol is not public ABI= =0A= > __rte_bitmap_scan_init_at(bmp, offset);=0A= > ^=0A= > ../lib/eal/include/rte_bitmap.h:150:1: note: from 'diagnose_if' attribut= e on '__rte_bitmap_scan_init_at':=0A= > __rte_internal=0A= > ^~~~~~~~~~~~~~=0A= > ../lib/eal/include/rte_compat.h:42:16: note: expanded from macro '__rte_= internal' =0A= > __attribute__((diagnose_if(1, "Symbol is not public ABI", "error"), \=0A= > ^ ~=0A= > 1 error generated.=0A= =0A= > OK I see.=0A= > So we should give up with __rte_internal for inline functions.=0A= > As it is not supposed to be exposed to the applications,=0A= > I think we can skip the __rte_experimental flag.=0A= =0A= /Volodymyr=0A=