RE: [EXTERNAL] Re: [PATCH v5] bitmap: add scan from offset function

[Volodymyr Fialko <vfialko@marvell.com>]

[-- Attachment #1: Type: text/plain, Size: 3241 bytes --]

From discussion with Thomas in previous versions of this patch, we agreed to omit both markers.

> From: Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>>

> Sent: Monday, July 3, 2023 2:17 PM

> To: Dumitrescu, Cristian; Volodymyr Fialko

> Cc: dev@dpdk.org<mailto:dev@dpdk.org>; Jerin Jacob Kollanukkaran; Anoob Joseph

> Subject: Re: [PATCH v3] bitmap: add scan from offset function

>

> > --------------------------------------------------------------------

> > --

> > 03/07/2023 12:56, Volodymyr Fialko:

> > > Since it's header-only library, there is issue with using __rte_intenal (appeared in v4).
> > > Even if the function itself is not used directly, it get's included to the other public files.
> > > It explains why other functions in this library does not have the rte_internal prefix, but the double underscores.

> >

> > What is the issue?

>

> From V4 ci build failure(http://mails.dpdk.org/archives/test-report/2023-July/421235.html):

>             In file included from ../examples/ipsec-secgw/event_helper.c:6:

>             ../lib/eal/include/rte_bitmap.h:645:2: error: Symbol is not public ABI

>                     __rte_bitmap_scan_init_at(bmp, offset);

>                    ^

>             ../lib/eal/include/rte_bitmap.h:150:1: note: from 'diagnose_if' attribute on '__rte_bitmap_scan_init_at':

>             __rte_internal

>             ^~~~~~~~~~~~~~

>             ../lib/eal/include/rte_compat.h:42:16: note: expanded from macro '__rte_internal'

>             __attribute__((diagnose_if(1, "Symbol is not public ABI", "error"), \

>                                          ^           ~

>             1 error generated.



> OK I see.

> So we should give up with __rte_internal for inline functions.

> As it is not supposed to be exposed to the applications, I think we
> can skip the __rte_experimental flag.


/Volodymyr

From: Stephen Hemminger <stephen@networkplumber.org>
Sent: Friday, October 4, 2024 5:04 AM
To: Volodymyr Fialko <vfialko@marvell.com>
Cc: dev@dpdk.org; cristian.dumitrescu@intel.com; Jerin Jacob <jerinj@marvell.com>; Anoob Joseph <anoobj@marvell.com>; thomas@monjalon.net
Subject: [EXTERNAL] Re: [PATCH v5] bitmap: add scan from offset function
Mon, 3 Jul 2023 14: 39: 08 +0200 Volodymyr Fialko <vfialko@ marvell. com> wrote: > +/** > + * Bitmap initialize internal scan pointers at the given position for the scan function. > + * > + * Note: for private/internal use,
ZjQcmQRYFpfptBannerStart
  On Mon, 3 Jul 2023 14:39:08 +0200

Volodymyr Fialko <vfialko@marvell.com<mailto:vfialko@marvell.com>> wrote:



> +/**

> + * Bitmap initialize internal scan pointers at the given position for the scan function.

> + *

> + * Note: for private/internal use, for public:

> + * @see rte_bitmap_scan_from_offset()

> + *

> + * @param bmp

> + *   Handle to bitmap instance

> + * @param pos

> + *   Bit position to start scan

> + */

> +static inline void

> +__rte_bitmap_scan_init_at(struct rte_bitmap *bmp, uint32_t pos)

> +{

> +        uint64_t *slab1;



Since this exposed in a header file, needs to be internal or experimental.

[-- Attachment #2: Type: text/html, Size: 14628 bytes --]