From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 879CBA00BE; Tue, 19 Apr 2022 12:19:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17DDE4068E; Tue, 19 Apr 2022 12:19:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 9A03640687 for ; Tue, 19 Apr 2022 12:19:27 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23J7Tcav003387; Tue, 19 Apr 2022 03:19:26 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fhemwtmng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Apr 2022 03:19:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VyHcX5PgEgFy3wktGqLQGoKeRtI+G4K4ID87UkuOlrEslQ2J1PwETMM4agUZRHZwWlEqHMok2Rihy4Fot82psrDFChGN9KGcx+nudT1/VPcPzPGRPuff7KUYeynNIJfI7sgvuXAI+dY3sqcvpFDy+86QYxhBb/MJZlsQLswmoNlEqOzy1kmaVI9T4NlYou29h43M48TbtJIzbUN34M+hUyLRUncpTeIqY6AsP0NCiE6egSk5+95I6qGViKt0nZ2O8orcfMecD+U6d+8fNCbQVHuDuCirRqHaosAND3A0fAMy9Gj7bNwgdBJpvTZs7niZsf2ku+2cEAmIXkWJCCSTIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kTf+qBjt7RQWlWJT6FjvofcNrTdqnWOeFBqCiU+bZYk=; b=TA2QK25hKUhFJRPIyOwVm1ksn1SSFbOt4LK8ivXSDBq035765KRpmUmUSlmLV4Pr9AZwHUImIp0Nlkt4JYW8xfapLmrppp+XHjytmnxFguoPjHWlo3rVXGFROrEhFl2Xc29YieYsAfIPuf6XsA9bGEZykjONOw5H1rH9zwlZrB1kuiWkJIwDeWhLOqE1PfDUYZ/S9RFH88TYeimTlBoWia9brzgX6VZTOLsIMYeSAy5CY3eQPgQXZk7a+A81kblPUu+utGAwgeaqHENM3OARAUp2jwl4tRK1L4agfvAPNTc1qytmGtXxqmT0h6ytjRcTWL6AKxepiAY+yW+0j+d8Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kTf+qBjt7RQWlWJT6FjvofcNrTdqnWOeFBqCiU+bZYk=; b=PYDBIMpNrzEDbkB9cDtzolHgtXN4CxIA5RotpJY3Ld0LHMJt5+/7An8YXAttqrCugc3yeX1VQSkapPEAYyGyRUF3NyeFRdJzbh8eN59PTaFX02rnY2ZVq4jOb7YvRdZmunsVH6+At/zSX5XOKj+YpIjNQoee+RlmNibxaItN/Us= Received: from SA1PR18MB4661.namprd18.prod.outlook.com (2603:10b6:806:1d4::16) by BY5PR18MB3331.namprd18.prod.outlook.com (2603:10b6:a03:195::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr 2022 10:19:21 +0000 Received: from SA1PR18MB4661.namprd18.prod.outlook.com ([fe80::966:ca10:350f:3938]) by SA1PR18MB4661.namprd18.prod.outlook.com ([fe80::966:ca10:350f:3938%7]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022 10:19:21 +0000 From: Anoob Joseph To: Akhil Goyal , Thomas Monjalon CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "konstantin.ananyev@intel.com" , "ciara.power@intel.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru Subject: RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Thread-Topic: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Thread-Index: AQHYUcfZGNY8hLZowkaTq8q0R2Dwvqz288WAgAAVEgCAAACZYA== Date: Tue, 19 Apr 2022 10:19:21 +0000 Message-ID: References: <20220217172341.607360-1-gakhil@marvell.com> <20220416192530.173895-1-gakhil@marvell.com> <20220416192530.173895-8-gakhil@marvell.com> <11961195.O9o76ZdvQC@thomas> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 58536fce-7822-4e00-c021-08da21ee11e8 x-ms-traffictypediagnostic: BY5PR18MB3331:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1Zd5Od+fRNECxHkk/NPHIULQj3XQi1D3S1srP1xaoDiCnHpNmXQzl5g+9PD6necXn5MUSYwZbF5tw8Ob1MnJbqxOmunHw2skbETMleJhndMPSIwbfycCgZu9CWsgP1gvyltFpnmBkcjUc7rB7UBUWQBOSJ7T0YBHFYZkFKEjqbcnrlkEu6DxPVcAtYtYnFiWPf0KZxoTNZKhA0L9hVqzVUhl2TgJ0hWd31wqJqnbWAwK2OZKCNMDnC5W64ciUkEbp/Z7txrhInVKwS9OD4z79c+++Cm7YHlqxkUPxdur3Ft7SkMCA0nABJaQ4kkYvSYbYmKRdI5BaWNhBT6gf0uK23Iikv+Wq7Q4RFdrmWR83wb1xMOMO0TpsFoImgl/hbN0mATmgsUlgUrhudD0VqUnTH3sVa4wLTYtCLRzdnKMsfuWod76vna4UOY02e05ecezgioZ9jQRW6VkH6QBi7nob88kCIFHINBoorpChXP/aeVRbAXlT9Vh1wyROJHTE2T5DNEM+tD5ZfhrMWAIR/vOAVPovXotgBxvS+R8XFJS4ySX/VjsJJb12EtR0tjeX0eZf3wNcGtF78xaDyszGd/5D7fq+/JzoAT9IGYdzipaPUy7p6+V21neXzq0jZdIyC2Ck/LsYuCgAcFMrBtLh/Nyjc3gdFxdfMrv2OXK7gVitDAAsrqE5m+CcMj1zwfL0d7RhhrdwNqxzWwvuC/F4QkvFcs46fIfhHku1IcOA7zKlQf8lTxcIvGtNdLUfuUoTxadR/xchz5VgbILJ715HNdyJP1tOihtxi/ocS1XrQmd3pA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR18MB4661.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(7696005)(9686003)(53546011)(107886003)(26005)(186003)(83380400001)(508600001)(2906002)(5660300002)(8936002)(55016003)(54906003)(110136005)(316002)(966005)(71200400001)(52536014)(4326008)(8676002)(64756008)(66476007)(66556008)(66946007)(76116006)(66446008)(38070700005)(33656002)(38100700002)(122000001)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WcC7wQ0iEbzNfON+Idjh8hkaxFvlcqPC3EEnKktsCHHMlUIUQkjH+HMzEbtF?= =?us-ascii?Q?PW46DUAP4oB5oT9t/wu0H0PakhUaIfxqQBzqcUHQzqvT1i+0SV3v+caFvtek?= =?us-ascii?Q?lClLk4P3u1fQsc8KJ7eCqKupDod+ira7nHL33Sr/MxGto6WJ2/6IIjYkBo3W?= =?us-ascii?Q?jTI8nk7+Ar6/i723eEwyrnL1jnNQwtSlqslQ6n8nkvS0NZ5vzqZW/EaopckG?= =?us-ascii?Q?luZdH9CBs5ztSiQQu83V1Nh5RXRpuY4hhdvL9afkHGyrT5zXJinr/In5Np+q?= =?us-ascii?Q?Qq7pWXlHMkkTrw6J3w/OjJIhS4XgaUaJMEWESPwt8yBj5Gf8jb2FnBkEgE+w?= =?us-ascii?Q?gZtuyWhIzioyFmj3ExcaNog/lNOXASu2bAhdeWzud2H1D0g0nlzAwivYDb2m?= =?us-ascii?Q?jKS04/OoiCZp05CLHy6a5g8sifx5FZVu0kzLi9zWpW+cnA/qapSuC7BJVg0W?= =?us-ascii?Q?ZfZa7AuKIrRa7rOcrF4Xpvf/iT2xDpqnbxTBRFM5UTIpk1/bq3pa3n6Gz9Qm?= =?us-ascii?Q?wpjdZ622M2n1cOu1k9TDfvoupbypykkPkayGIm4Mt1Y4Ed0yqhiRDIMxF+5/?= =?us-ascii?Q?41aCzhQRnmV8BAdEMwEfznGQy7ZLnAjnMMHVoV1/ceW3b1V8HgsfI3sBrgbl?= =?us-ascii?Q?QHzROP972ir3LQaQR/C47jnXctOA0q+X+bI3BOgQVZ0ibAsiXamID/WFrKu7?= =?us-ascii?Q?J4YT/EvLNgbhJGEV0sfcT6NGCWkml5sLLzEDnKVDBoCWOQq65Uj5o35vkCVg?= =?us-ascii?Q?S7hhd6OJRJNFgGG/pQN9iQvUPRfxAhPruYzaPkokndAO6L1Y6mnbOUnBQ/xY?= =?us-ascii?Q?SCT0k52cwcdvCbV2430sqkDFl56G6pRa/+kOe7qs3armAqp6H/qim10IpMI4?= =?us-ascii?Q?hOgN+f9q/Akq8tunPGEpll+tsMGkcRphybo64MScYoElhwxZvL1HSRPI28/F?= =?us-ascii?Q?6LMca6RZeRug8EeOw19n8ecZSSa70JLRR+aZ7o+O3B7Kj14rz1eLB8Zbl2G4?= =?us-ascii?Q?YPCStdHEFw3Sz/9Dm0sexE7BMNtQXWfDMKtzGAAXUGM1tdKzk+EDq49I13zN?= =?us-ascii?Q?HxtpHqL0kdTNda7YrKehfCafzAuAqV26MJ8tju+Bn9uC/Y8pOrIbNwWRotTz?= =?us-ascii?Q?h5pYcl6boB8UCHMcjCiD9dpyoP55gScrxBtMeEmB72jS+3cx661c+9Zjg1VP?= =?us-ascii?Q?4MVjnQkvrFEfXOFGniAqWDy6QvJokKamtE1HKZabWjKmpLoN+S4UAaunf99r?= =?us-ascii?Q?MOcP6Slv69pAYIeYxiA8bm80Q93jmLzU6u5ph1fP8FQgC+re9IPlKhPbf10H?= =?us-ascii?Q?0h2Kjs9jktbpAOwCcniJ4EWl2JUuUvcHg2l0SBYbLvAmVmXx/eQPa9rpiYzZ?= =?us-ascii?Q?ETyM2jEloeYpW0fCO3M/MLB3C+DYXrMZ/JsFk2TTun+dDf4eqv7KEQmw9VfZ?= =?us-ascii?Q?0ZEf4FUodimzgVnvwgixemUejnO6g3L2SQJ+H37bR2ywQ1DtxPP4Nh0VgClV?= =?us-ascii?Q?xnrDihCdAWpbcCmdaPKKZDfpP4sbRoWE8oPcS4Dq+PHmlsvzgbJsGZMkp0K9?= =?us-ascii?Q?1uZJlSBxAQcZitM+V3CUf6zIRSaQeuOmaAGsX0pJUB15JG9tO4k1Fe4gOd18?= =?us-ascii?Q?60ujNXh/34o3y7AwgJ6OUTqH9SnE7zNyTRr1NQhvev7x4a0lvDFjnXvYZEz8?= =?us-ascii?Q?igg414UaFwqClrvN0jdf299Ra7+iGrW1iicR23Jm36g4GDC8TlvuhwBebrbV?= =?us-ascii?Q?L0bQ0HAfFA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR18MB4661.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58536fce-7822-4e00-c021-08da21ee11e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 10:19:21.1964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H+uz+eA5F5I87qL8/jWhgty/SFaYTQsqVFI4NRaKUcKZDn632rKG8C2TDUDBqNsbx9MF+/xtuKAIeNLpq61J5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3331 X-Proofpoint-ORIG-GUID: o71kFlp5b88uuRLtk2B87tn89nqEYBKa X-Proofpoint-GUID: o71kFlp5b88uuRLtk2B87tn89nqEYBKa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-19_04,2022-04-15_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, Akhil, > Is there a reference explaining what exactly is a "soft packet expiry"? The SA lifetime/expiry is described in security library. https://elixir.bootlin.com/dpdk/latest/source/lib/security/rte_security.h#L= 295 Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, April 19, 2022 3:44 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; david.marchand@redhat.com; > hemant.agrawal@nxp.com; Anoob Joseph ; > konstantin.ananyev@intel.com; ciara.power@intel.com; > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > > Subject: RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event > subtypes >=20 > Hi Thomas, >=20 > > 16/04/2022 21:25, Akhil Goyal: > > > --- a/lib/ethdev/rte_ethdev.h > > > +++ b/lib/ethdev/rte_ethdev.h > > > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > > > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > > > /** Soft byte expiry of SA */ > > > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY, > > > + /** Soft packet expiry of SA */ > > > > Is there a reference explaining what exactly is a "soft packet expiry"? >=20 > SA expiry is a very common procedure in case of IPsec. > And all stacks must support this feature. > You can refer https://docs.strongswan.org/strongswan- > docs/5.9/config/rekeying.html > For details. > Time expiry means after x seconds SA will expire. > Packet expiry means after x packets processing SA will expire. > Byte expiry means after x bytes of packet processing SA will expire. >=20 > > I think you should also mention what should be done in the event > > handler. >=20 > I believe this is quite obvious as per IPsec specifications. > Application need to start rekeying or SA need to be created again. >=20 > > > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > > > + /** Hard byte expiry of SA */ > > > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > > > + /** Hard packet expiry of SA */ > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, > > > > Same comment for the 3 events. > > > > > /** Max value of this enum */ > > > RTE_ETH_EVENT_IPSEC_MAX > > > }; > > > > What is the impact of this "MAX" value on ABI compatibility? > I see no issues reported while running ABI check. > There is no array being used inside library based on MAX.