From: Jerin Jacob <jerinj@marvell.com>
To: Vamsi Krishna Attunuru <vattunuru@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Vamsi Krishna Attunuru <vattunuru@marvell.com>
Subject: RE: [PATCH v0 1/1] common/cnxk: fix DPI mailbox structure
Date: Fri, 24 Jan 2025 07:20:26 +0000 [thread overview]
Message-ID: <SA1PR18MB47893F7CC6539A91CE6B473DC8E32@SA1PR18MB4789.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20250115123654.1490937-1-vattunuru@marvell.com>
> -----Original Message-----
> From: Vamsi Krishna <vattunuru@marvell.com>
> Sent: Wednesday, January 15, 2025 6:07 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob <jerinj@marvell.com>; Vamsi Krishna Attunuru
> <vattunuru@marvell.com>
> Subject: [PATCH v0 1/1] common/cnxk: fix DPI mailbox structure
>
> From: Vamsi Attunuru <vattunuru@marvell.com>
>
> In the existing DPI mailbox structure, one of the fields spans a 64-bit boundary,
> making it appear unusual and complicatng extraction using bit operations.
>
> Patch enlarges csize fields to ensure that mailbox fields are correctly positioned.
>
> Fixes: b6e395692b6d ("common/cnxk: add DPI DMA support")
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Applied to dpdk-next-net-mrvl/for-main. Thanks
> ---
> drivers/common/cnxk/roc_dpi_priv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_dpi_priv.h
> b/drivers/common/cnxk/roc_dpi_priv.h
> index 1f975915f7..05b6751ca6 100644
> --- a/drivers/common/cnxk/roc_dpi_priv.h
> +++ b/drivers/common/cnxk/roc_dpi_priv.h
> @@ -27,7 +27,7 @@ typedef union dpi_mbox_msg_t {
> /* Command code */
> uint64_t cmd : 4;
> /* Command buffer size in 8-byte words */
> - uint64_t csize : 14;
> + uint64_t csize : 16;
> /* aura of the command buffer */
> uint64_t aura : 20;
> /* SSO PF function */
> --
> 2.34.1
prev parent reply other threads:[~2025-01-24 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 12:36 Vamsi Krishna
2025-01-24 7:20 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR18MB47893F7CC6539A91CE6B473DC8E32@SA1PR18MB4789.namprd18.prod.outlook.com \
--to=jerinj@marvell.com \
--cc=dev@dpdk.org \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).