[PATCH v0 1/1] common/cnxk: fix DPI mailbox structure

[PATCH v0 1/1] common/cnxk: fix DPI mailbox structure

[Vamsi Krishna]

From: Vamsi Attunuru <vattunuru@marvell.com>

In the existing DPI mailbox structure, one of the fields
spans a 64-bit boundary, making it appear unusual and
complicatng extraction using bit operations.

Patch enlarges csize fields to ensure that mailbox fields
are correctly positioned.

Fixes: b6e395692b6d ("common/cnxk: add DPI DMA support")

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
 drivers/common/cnxk/roc_dpi_priv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/cnxk/roc_dpi_priv.h b/drivers/common/cnxk/roc_dpi_priv.h
index 1f975915f7..05b6751ca6 100644
--- a/drivers/common/cnxk/roc_dpi_priv.h
+++ b/drivers/common/cnxk/roc_dpi_priv.h
@@ -27,7 +27,7 @@ typedef union dpi_mbox_msg_t {
 		/* Command code */
 		uint64_t cmd : 4;
 		/* Command buffer size in 8-byte words */
-		uint64_t csize : 14;
+		uint64_t csize : 16;
 		/* aura of the command buffer */
 		uint64_t aura : 20;
 		/* SSO PF function */
-- 
2.34.1

RE: [PATCH v0 1/1] common/cnxk: fix DPI mailbox structure

[Jerin Jacob]

> -----Original Message-----
> From: Vamsi Krishna <vattunuru@marvell.com>
> Sent: Wednesday, January 15, 2025 6:07 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob <jerinj@marvell.com>; Vamsi Krishna Attunuru
> <vattunuru@marvell.com>
> Subject: [PATCH v0 1/1] common/cnxk: fix DPI mailbox structure
> 
> From: Vamsi Attunuru <vattunuru@marvell.com>
> 
> In the existing DPI mailbox structure, one of the fields spans a 64-bit boundary,
> making it appear unusual and complicatng extraction using bit operations.
> 
> Patch enlarges csize fields to ensure that mailbox fields are correctly positioned.
> 
> Fixes: b6e395692b6d ("common/cnxk: add DPI DMA support")
> 
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>

Applied to dpdk-next-net-mrvl/for-main. Thanks

> ---
>  drivers/common/cnxk/roc_dpi_priv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/cnxk/roc_dpi_priv.h
> b/drivers/common/cnxk/roc_dpi_priv.h
> index 1f975915f7..05b6751ca6 100644
> --- a/drivers/common/cnxk/roc_dpi_priv.h
> +++ b/drivers/common/cnxk/roc_dpi_priv.h
> @@ -27,7 +27,7 @@ typedef union dpi_mbox_msg_t {
>  		/* Command code */
>  		uint64_t cmd : 4;
>  		/* Command buffer size in 8-byte words */
> -		uint64_t csize : 14;
> +		uint64_t csize : 16;
>  		/* aura of the command buffer */
>  		uint64_t aura : 20;
>  		/* SSO PF function */
> --
> 2.34.1