From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4494A0032; Tue, 29 Mar 2022 11:51:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC72141151; Tue, 29 Mar 2022 11:51:45 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 5B2C940691 for ; Tue, 29 Mar 2022 11:51:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648547503; x=1680083503; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3OruYhsJ9aHJb40qSarVUqSk/BZqi+9TH2IAruSOt2Y=; b=cijMpiAu0Ssy8HISb0L30639nR7OBMyWBbKPKh2/EpU5Kgl6f/nz6W5f 0AOUdEvFaoct2q402BohjfV+c18zWUhF6OBxysJB4vp5oHILITXozsan4 FbpVWkTEKbMjI+ZskrAf2vx5GWQGR65o8pPrty5kaAko2tk/RL9XcLqVD DXw3hV66YLix365/Eyljq+dt9xM3LVCVXun5aYMZPuWqcLqbsFpplMjCa DfgpHsNbpdTgDTUxnsVtAAm/0GClxVo0oPhcmIZsrGOBJHw5tqIl3WuvU lBo3x0QEwQc7XHb57cRF0gz5zXOH0ztw7m+FJx0v8edDl5OCciGZQju8v A==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="256786858" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="256786858" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 02:51:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="618074851" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 29 Mar 2022 02:51:42 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 29 Mar 2022 02:51:41 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 29 Mar 2022 02:51:41 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 29 Mar 2022 02:51:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqGQhSTw+OigDU/wO0G9Rrm7GMd1RfwQ+lhAfvOuEBHSXVpicVjfXTMpMLoFdwK8b0PRMhtwg1Axtbi2jkkclGXMGifv2sSMAkkhDtXSMVkqjCmduyUKwfBNMA4W3r3Tn1LGoYrmZihvwhO8IZf+D2hHWxnB1w/UwMtarKyzb+/tQXaeUOB9GD/ApuvZfLkojLfXyDEOtxLZEPm+sSaKqRwk2FStRRPDSep2CIl15HoJcWwOQf7q/1u8S0XmB6w0HNb+UMGeJHIk1+UjBhc0gizDLj3qcmBSm9QUVZrRZyKYMBbL7hOB704VOVHbj6hctfB9j9xnPxAJrAraq31ouQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MoDPJvUg/pn9oi26fJFqEJZmo5Nz07iU0G/LPmjxY1s=; b=Nk07mQwgBRVumTfTY1ifoHOXTwgSUz4T7G1qjNykDJfsmw3FrqjAL/9lR4HRmpJSJgjCvgZcQBqpPiGFmdHiYFKpSa+5lk/740JWfAFLwFUM86o3QP2wmC0EGFEPu46J30U8RHhf6qNql0/A/FkhepGw5re32Gm0361JOc39bBjlGYrckvm5JXw9N6ALz+f/s8j+AlTfOVsAP/64XeJdlXLf0r3gjhvLtcn3mRaN6IkyFqAkR/crJ/DjwFtaIimxQ1H7ZafDPBuU98Jhlf2E+VmRvanssaVjyHapkyvfLOc7baPQWefhi0riE68tclnQyM10OpW+Ygtns/epRAZv/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA2PR11MB4906.namprd11.prod.outlook.com (2603:10b6:806:fa::7) by DM8PR11MB5734.namprd11.prod.outlook.com (2603:10b6:8:31::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.17; Tue, 29 Mar 2022 09:51:34 +0000 Received: from SA2PR11MB4906.namprd11.prod.outlook.com ([fe80::21db:9b3d:b421:3ea1]) by SA2PR11MB4906.namprd11.prod.outlook.com ([fe80::21db:9b3d:b421:3ea1%6]) with mapi id 15.20.5102.023; Tue, 29 Mar 2022 09:51:34 +0000 From: "Wang, YuanX" To: "Pai G, Sunil" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" CC: "dev@dpdk.org" , "Hu, Jiayu" , "Ding, Xuan" , "Yang, YvonneX" Subject: RE: [RFC v2 1/2] vhost: support clear in-flight packets for async dequeue Thread-Topic: [RFC v2 1/2] vhost: support clear in-flight packets for async dequeue Thread-Index: AQHYNSxANMGiZ3aHVUiQdnmTaE4TdKzUahGAgAHPjIA= Date: Tue, 29 Mar 2022 09:51:34 +0000 Message-ID: References: <20220117132847.884998-1-yuanx.wang@intel.com> <20220311173414.93216-1-yuanx.wang@intel.com> <20220311173414.93216-2-yuanx.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce6d6406-e3dc-4ea6-1da6-08da1169b5ec x-ms-traffictypediagnostic: DM8PR11MB5734:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rDL1tRu8A/+4y9GvYuahAkozwhxHcFudxXjkX6XQJLZSQ3u2TlvcHjAxIBb/7lWh6HxFFvvaJyz+z1dhIsenFr/S8KrA/rscrI/Lhm/+/2GlpA+f0v6tIAzbUxUPksvSWGoCiGRgbX/wK2YhodC0Vg2ZMafAWqjBC0ry48tyV/P0k9WFupUf4d2cx440VWwIKYv9qKPwsZkDlTIhW8Gfeoo3dmV9a/LH3PfGtOxMCrSZAioxQtOaMLXIWWHqTgu8nAzoQHq1pl4pXStgBktUx5z90/tOsxgGzdrsVEKJnlkt0N34CRhT+2qJJpQfCvMd46DaBP+mEByuqRG4wT0jc5sStyBwPLZwFt6ZR+vIzMTJgwVYdoNf6vIPl+8wGDN1GpkYcTO/l3STYcmQRA8v+b0GyEp4KmLA0P+szi15eOibS3Hw+2MMvTuQAbAXUHbtfJMMMaTYBxL3kmTn/Uu/FWDVG5YlrFo17yjT2oc7tTBvj5mxnWtCEKgin4SEOqqMIla1a6gxyCRWmnalEfkixZdN79gMNwiF0lTxHdF5E+88GgVvwBuFGoN9cWCYqeTUO1fvnAUpaO2/R3P0s/TFhfBh7yL0lgQ+bsFi73gIvFMae+iOkqoBPVpDjFrmuZ54i1fjkBXdj9hDRApdYm/u/ZM/U33qavC2IGzYZPh8H0HwDjzeJh4cEdHNCc8ND+h3YoHPoyho/WDCZ7nK306g7lleqTER95EVTOSrbllPOpwZv34IpdoVux3osYgCj+xghgEtJEsCHaL7cOV42s7VPzZivjc8TbAo+x5+EN41WP0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB4906.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(55016003)(8936002)(7696005)(9686003)(110136005)(71200400001)(82960400001)(186003)(6506007)(6636002)(966005)(316002)(26005)(52536014)(4326008)(38100700002)(33656002)(38070700005)(66556008)(66476007)(66946007)(54906003)(64756008)(66446008)(8676002)(83380400001)(508600001)(107886003)(2906002)(122000001)(76116006)(5660300002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TbQ0VaLG04eCG1IXvKzL0Gh1nsV1jwzdaVnWSdNBIkV5Nfs7Q2UGSmr9UAgD?= =?us-ascii?Q?7BevJDxEJhjTCyUs2LZRyej+oQx7k8hMfVcXTgQRN1fvV2AV4pSIKxiXIQ+K?= =?us-ascii?Q?vq9GTl5XaJqLEUu9eQqW4fgJwER6C7gSOcdrfU9elXznFwfKCFXSfFEnrHFX?= =?us-ascii?Q?E211zgW0VQ+Bf2fB8AwPQT0cky6EvK6G/zo7GBCJ0OgSPmEiEDTytWVW1mKn?= =?us-ascii?Q?lCOfxsZUTWrQ+5bvJvR+vvwGvyawqFyBhEXSIzLQdN2xm3PPffYVWD02zrY6?= =?us-ascii?Q?gHmPqniI0g5CX8PD87Ah3auwDfbTp/oaf9WtXmGqLYz3QntoE6reonasU9wG?= =?us-ascii?Q?RJmxtfMX3FZdeU1eN8mGio9ppAFz5GkTbamHxjqssLkmy7/YvM1SLczklUPC?= =?us-ascii?Q?9GuPWcHqU9FnVCSdhB74s/TeYX5OYkk1QtLFG17cxmaGiCcDY49hEh86a0n1?= =?us-ascii?Q?p4FtWp1bE+8vo4HaYSG+E9NRvGmuNK4PCjUOfm3rIA5aMCmGuHX4yapqX8Yw?= =?us-ascii?Q?wCcvyvpWCRKwLuF9Hi+3rcklckdDtIjH/mgd21KgAinQaVbTK/psG0Hc3Hq1?= =?us-ascii?Q?Ia+ffS+RxpoQOH5qWa36HQ1IrxCJs2j1eDWND7uKosuCKdYmmz9vYhydlXJp?= =?us-ascii?Q?Coz8oQLaeAu5foJCAJ8VxQTQnPiI5C65CcazRZIevfcRJblqe+/Gjes7UXos?= =?us-ascii?Q?V9RAOKU3oyrcftmXb9B/tefx05d4/FUT8UNwNvRu1uZUyGjaqy1mOnY0L0Xh?= =?us-ascii?Q?msidzBMdx/0JWZfBj9e4gF9UJ4FKD6wpeErAGKBbfSmEptjreiMPco1xhQDl?= =?us-ascii?Q?N6/vifLfgPUbQqyXE/edRqJcd2sLqhwPr1ucw40lGK5QXuaqDRzLImCBIhvK?= =?us-ascii?Q?DeMsBS4gJggsql1EvmJUOoCkoEamRV2Y5BFqRklHrpNAUVASCWZjgC7yJe3M?= =?us-ascii?Q?Qq4CCzTzKe6L/NzGqxAvDXUCy99bsR/xZPzCvNGwtM4hERew2LdcVaXm9Mjc?= =?us-ascii?Q?adf777rrMJ8FDx9tLCgcH30ZddHEZdCeFTMuh5CIuPfU6Fcc6yT2CFpFvr5I?= =?us-ascii?Q?6t+aAixH5dnE5pbxYc9QHyVvj40m7zsZA8oKleTz+nIQT54eqPo/xJEkhmZK?= =?us-ascii?Q?41DiEP77x61ufw0D1fXYqckj3U58Lsu+naXow3z7gjHaLCpXMC95t3QL3dwq?= =?us-ascii?Q?wPdXmst4K681thfnJubldzYUg8+qFXigRMMsITE1/4GSL30Iq/9XVh8kRvLn?= =?us-ascii?Q?bb8msuxqMlfU/ia5PrpZ9e8HpAg1P8rtkQ21ZOmIR7SPZ5MvlXAq6N3Og2k/?= =?us-ascii?Q?yCKN4lp8YFXOjN+8U55zMsy31NyYeISztvyw1QtRAvIHLb0i71e+xWHWw9D1?= =?us-ascii?Q?nrmMSvXQBUed8SrsV9VkfTcdfdSG4xwUbuz4BGJzg/rhJXp4+eomwNQwu3Ol?= =?us-ascii?Q?yroWzApKvEPeoyPedM3gWHGdLlg+UcnLlbYldkCIHXTRhT2cZfsilvBMN66v?= =?us-ascii?Q?ESEq2H0uNevyhhLCL19G23EwuWjmgFHNveHlhP0lMr5QGPTH0siRzV1lMZpe?= =?us-ascii?Q?JHRIxRSoAdMKzjV6T/e5jqjdKBQSvqHp7JcJitDfHxSFSmDICmF5KEzQ6qGn?= =?us-ascii?Q?tRdDIqUpDgMa+pPrd5ccUF+WbeHMTm2E+RKU/vq3FPCkd4r8M6xtn6ouTnbN?= =?us-ascii?Q?59QgeX9ekVAEWFd+MJzKk9HNrwwVmW83hAcaGWReM3scLwjBu2WucNj8F/uM?= =?us-ascii?Q?sn9g5yAgug=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce6d6406-e3dc-4ea6-1da6-08da1169b5ec X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2022 09:51:34.6016 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0qOLp2p/lnBjRIWJ8W9xmIr1LJA+/CdMP0+4KL76sjsIxIZ1DDP8f6aiCLajCU6DYvP4TYPfi0KHoAtQxsmo6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5734 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Sunil, > -----Original Message----- > From: Pai G, Sunil > Sent: Monday, March 28, 2022 2:08 PM > To: Wang, YuanX ; maxime.coquelin@redhat.com; > Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Yang, YvonneX > Subject: RE: [RFC v2 1/2] vhost: support clear in-flight packets for asyn= c > dequeue >=20 > Hi Yuan, >=20 > Thanks for the patch, comment inline. >=20 > > +uint16_t > > +rte_vhost_clear_queue(int vid, uint16_t queue_id, struct rte_mbuf > **pkts, > > + uint16_t count, int16_t dma_id, uint16_t vchan_id) { > > + struct virtio_net *dev =3D get_device(vid); > > + struct vhost_virtqueue *vq; > > + uint16_t n_pkts_cpl =3D 0; > > + > > + if (!dev) > > + return 0; > > + > > + VHOST_LOG_DATA(DEBUG, "(%s) %s\n", dev->ifname, __func__); > > + if (unlikely(queue_id >=3D dev->nr_vring)) { > > + VHOST_LOG_DATA(ERR, "(%s) %s: invalid virtqueue > idx %d.\n", > > + dev->ifname, __func__, queue_id); > > + return 0; > > + } > > + > > + vq =3D dev->virtqueue[queue_id]; > > + >=20 > I think the following checks must be protected by spinlock. > Similar to : > https://patches.dpdk.org/project/dpdk/patch/20220328020754.1155063-1- > jiayu.hu@intel.com/ Thanks for the comment. Will fix it in next version. Thanks, Yuan >=20 > > + if (unlikely(!vq->async)) { > > + VHOST_LOG_DATA(ERR, "(%s) %s: async not registered for > queue > > id %d.\n", > > + dev->ifname, __func__, queue_id); > > + return 0; > > + } > > + > > + if (unlikely(!dma_copy_track[dma_id].vchans || > > + > > !dma_copy_track[dma_id].vchans[vchan_id].pkts_cmpl_flag_addr)) > { > > + VHOST_LOG_DATA(ERR, "(%s) %s: invalid channel %d:%u.\n", > dev- > > >ifname, __func__, > > + dma_id, vchan_id); > > + return 0; > > + } > > + > > + if (!rte_spinlock_trylock(&vq->access_lock)) { > > + VHOST_LOG_DATA(ERR, > > + "(%d) %s: failed to clear async queue id %d, > virtqueue > > busy.\n", > > + dev->vid, __func__, queue_id); > > + return 0; > > + } > > + >=20 > >=20 > Thanks and regards, > Sunil