From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33AF0A0C46; Mon, 23 Aug 2021 22:43:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CE5240151; Mon, 23 Aug 2021 22:43:05 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 7EE4F4014D for ; Mon, 23 Aug 2021 22:43:02 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10085"; a="196753221" X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="196753221" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 13:43:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="574754176" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 23 Aug 2021 13:43:00 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 23 Aug 2021 13:42:59 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 23 Aug 2021 13:42:59 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 23 Aug 2021 13:42:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/iOqCC903FsU5YsJ4yzKdoLBH0CP6sPeNjGNBHKW4nFfFPg56/E9gMNIX/GOtLPYeh5EPjBVxzlKhWgrgz4Vq3kr3KGFXfONfpu8rRDqYbIoY/I7/USnTOjN40oc66gx++RFfYfiIrQnOFdESYzeyiT88IFT3o0ZlBVQvkLQN6aFE6adg+9f8xQSZXGhOZW9yoq3+RW1pkZDURLLbWhe65eV8Zoke1ObAY3H/Q+Q3N/aia9Lk3VBLoNrnGk6WaGwu1XfCxhNoTLzVt9oDDIXAemCKDLcyfx833kKanVuO+4UoC5wPklhHKGPrt8wMo0LiqA1ezRWxNFyL5HC0pdcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GSSZyjrQRmMdjfaT8O179MN1g7uqaINzmgFr0jCn118=; b=mxwKTK/FTNDGTGd/ni1G8HA62mqk0WmZ6d4BNhGIlw7jT1oAIfVjTv7sfSpx/w1Edmue5W8b/8zFztSXmM9rhAIP9xGrpS4ez9LL2P9WZeHGlbkoMkIRp40ehESFaQed/EPHQeSdCf1dI/blGVewTaXc0WRncXht+erkEOjZnZnK9MMTu9/T5yJ01aPC5tOssK2dkx03lBqFFMLkEY7tzc7TsB58YahjOqYhjIdkiC6wJkJliPyxjOm0q50mLQyFztelBFZdesotOTpHAKdjaexbWvtR7hlWSJKykmtlKQSz55rCUjStU3SqFY9mOtqItABi4lhXOUeM56vGFCKKpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GSSZyjrQRmMdjfaT8O179MN1g7uqaINzmgFr0jCn118=; b=TX5LbOI70c7/GhxA7QCneobZgZ6t/9LEH1fMnylm+Wu8UQmCEQyM3C2PrYJUlKhFD0EXokAGSuaIcExoFoPyhL3yieicCEPwnBL4QfCYS0VjHiHGLoGBDDwOOzA3USrCcV48V028tcElNRnDuBHkr6YhiNwOgdiVJH/QxMwBxJ4= Received: from SA2PR11MB5196.namprd11.prod.outlook.com (2603:10b6:806:119::18) by SA2PR11MB5194.namprd11.prod.outlook.com (2603:10b6:806:118::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug 2021 20:42:58 +0000 Received: from SA2PR11MB5196.namprd11.prod.outlook.com ([fe80::d9a8:fc8a:e83a:cb23]) by SA2PR11MB5196.namprd11.prod.outlook.com ([fe80::d9a8:fc8a:e83a:cb23%8]) with mapi id 15.20.4436.024; Mon, 23 Aug 2021 20:42:58 +0000 From: "Carrillo, Erik G" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" CC: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object Thread-Index: AQHXmFbWoMYpTfh5s0ahWBzQJoS+cKuBjPVQ Date: Mon, 23 Aug 2021 20:42:58 +0000 Message-ID: References: <20210823194020.1229-1-pbhagavatula@marvell.com> <20210823194020.1229-11-pbhagavatula@marvell.com> In-Reply-To: <20210823194020.1229-11-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45abd6a5-16fa-43c3-53bf-08d9667697a8 x-ms-traffictypediagnostic: SA2PR11MB5194: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GSNEBgOPKenCzptaAiwvJ9j28NX1b2CSpiV+VXg9u/k5mFV4CUjoACO48IzQ654EG/X3w7B7cnQLqeGrqU+fPfV5wW4e1cHOUnFxMNFHNdsf8WfvWhBIk51aI7QefD2OaBYmXTwk3TZX5WL4tiz6xFM4CE8WAp4HfIBSC721vkXljF8NumLv+8OZNRnQ4DDoi77ltKuQkPcFHmdOUducp2sJ7++XkGIc9QAUIyJKoTMPEJtRzjCXLgvw3CM7edKL+Yt1ie2y7H96C7VRVrvJsTQeDh46RD/YQ9G6/0BVm/n/hUWjrnJRvyNUyrDAmbXIzKU08OGg30mvam8Kjo3Bcsy0mvrVdb/pExygTmSkUdSkDCxj/UF20/y/LSk9y5XYyUSLL6t9wAsSwM1r8632uN2DijMex348OtAp5gyDgCzIC9xMeqypHZ4AmZm3sdV9fvCa21aMyGLE8LFC/vJnDQFBtXMkg/abOorlDWHjB1gCuutOxA+GyPSs6+42jAql6NyHTze9TSmx2D8A7aMemjA2XSxD9UCysOofx0hH7PUejOsIOVBw5U0LSFO5qlP1kxmLUY6ZC4RZSs4i0Figz9IwPMNq4o8XPYwnTmxTSfieb+QshUab6PXERbwqfwzzUrd7U3S61ScD1cVDqmaSOjhGzg86NC/vEK/8B3huFlxZbyUWdBEezashgSFcsyox7dqLLomXesZ6zn2lNxUuMQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5196.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(83380400001)(2906002)(33656002)(122000001)(478600001)(38100700002)(26005)(76116006)(38070700005)(9686003)(6506007)(186003)(7696005)(66556008)(66946007)(66446008)(8936002)(316002)(52536014)(54906003)(4326008)(71200400001)(8676002)(110136005)(53546011)(55016002)(5660300002)(86362001)(64756008)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Pc4nFOxB2faV752+rgWZ9TJSPMSxGheVu/cZ4gKqyqE4yjXJUKfGI+Dl0yy1?= =?us-ascii?Q?VzZmvQO28fH8+ksydA426+I73hTt9plRh3g5oXXatpRBE5mIxoQQ2G3/egqZ?= =?us-ascii?Q?neG+eZTB2oN/SkoTPfR2coWx98tAurb59L8WizBy5KXU1ECeO9F1K2PH4IXG?= =?us-ascii?Q?EzAHei/2SfRMHdjF35zqNT+ODP+atlYGwYmLe2eLUF90M5a44wfy/ugi3XtW?= =?us-ascii?Q?0mXv8kfSoNZDeJeKLyMrkbgqcKjw2sZqgxDiMKI0zyscXg/P4x260gYWVNuK?= =?us-ascii?Q?k0s8J2VyY+kPrIeAQvuav4HCMpaXJTNzpMa3PEoR6EymJQAFsQ5KMLxG975p?= =?us-ascii?Q?KTg3Q4ScMQaXr4Wj3es9bO6hFOOTAfowKVTHBgVc8u12I7s4YZE5lsEH0cqr?= =?us-ascii?Q?+tAx6jrJY8UCQ/duuFK4mpcEUqyC2xwi1aKtCSHpMFTYSl/LNjkOO9HPbflF?= =?us-ascii?Q?G9ozUEZBWQamxzwzRYEV+vWYQDvpHktrWw9h+0njVwUFXC24AahI+DDxvsAy?= =?us-ascii?Q?EL67LKxB0ielgwKzcdsA3jfv11Jt4lQCBpioN6W5ZGur6R0RJt1P5+EbBYNN?= =?us-ascii?Q?bG7kbGh7sAOg7GVITm83BFzzI7ciXNSfTCJiHMzvVGFPmWbhpHQleP22W3S6?= =?us-ascii?Q?DSSUfWmyZqCPS6VjnFflpsReYiXOZ8ybO9A25imkXgcmM4zqprXnVSZiWIBh?= =?us-ascii?Q?X468Pi6uGU9u1kUZf/aBDSvek+x39sicvkoD3ungM5xGSsGGxp6n5bi+fKso?= =?us-ascii?Q?UTlaycr76uvu5V1AXF/DpDQ/C2iVVjm85Ez+iXz+IQGKxRb9X/4oNlUxza9C?= =?us-ascii?Q?z1vnsJEArWW/Qqj+ExUyHEam4oDmoTcr+mcHqKL7eaG519AUXozvby8Twgqf?= =?us-ascii?Q?TX7lCHfr36/5nZyJUB6rB0HUK1+p/mbXwycYWvf8folKfv6J17r1siyb855G?= =?us-ascii?Q?VT63nb64siQ6li28/n6lIGOe58SKyK3bxE1DSl6v1TpoTqN17hksL+vUwLVl?= =?us-ascii?Q?gqlaIm00jgL65plSpgbVhaMNPoK1Y2Fcg5Jl+PMhVmfKzg0PTsLYZnOkWCmR?= =?us-ascii?Q?Wcryp5fGjiIZrmh2WAOSPyrvlmzN6XKR9037t4vyuOlk8FMqPH0EQOJSbXG+?= =?us-ascii?Q?PPYIB6H6eWFiwP5b1sFs8H0Tgg3t3/FNB5iuIMSAs46Tkht5YIvZ3s/7NL7q?= =?us-ascii?Q?NhCWdlbxZeV+0NU9gIU861WyqZ/QK2bviiQY0BAWfSUJONFRQghUjRlcEd37?= =?us-ascii?Q?muxXEa/h0bqO7MM8ombEa0vibn9/uoI6HnMy4FWLLDTK84J8afsifS1KnGyL?= =?us-ascii?Q?9uU7o1/xN/BWpd5yIT/isrzZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5196.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45abd6a5-16fa-43c3-53bf-08d9667697a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2021 20:42:58.5474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mlne/MSLqKHJTeKTbvR3Wtm4ZrU9avwFoH+S8OvyNKdPsiN+cJHXOHHys7YmkWhVU+/KFZ5RVuQl4/6YsFXFZiN3avZihTxnPuGUz9klw3w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5194 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pavan, One comment in-line: > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Monday, August 23, 2021 2:40 PM > To: jerinj@marvell.com; Carrillo, Erik G > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Pavan Nikhilesh > Subject: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object >=20 > From: Pavan Nikhilesh >=20 > Reserve fields in rte_event_timer data structure to address future use ca= ses. > Also, remove volatile from rte_event_timer. >=20 > Signed-off-by: Pavan Nikhilesh > --- > lib/eventdev/rte_event_timer_adapter.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/eventdev/rte_event_timer_adapter.h > b/lib/eventdev/rte_event_timer_adapter.h > index cad6d3b4c5..9499460a61 100644 > --- a/lib/eventdev/rte_event_timer_adapter.h > +++ b/lib/eventdev/rte_event_timer_adapter.h > @@ -475,7 +475,7 @@ struct rte_event_timer { > * - op: RTE_EVENT_OP_NEW > * - event_type: RTE_EVENT_TYPE_TIMER > */ > - volatile enum rte_event_timer_state state; > + enum rte_event_timer_state state; > /**< State of the event timer. */ > uint64_t timeout_ticks; > /**< Expiry timer ticks expressed in number of *timer_ticks_ns* > from @@ -492,6 +492,8 @@ struct rte_event_timer { > /**< Memory to store user specific metadata. > * The event timer adapter implementation should not modify this > area. > */ > + uint64_t rsvd[2]; > + /**< Reserved fields for future use. */ This placement puts rsvd after the user_meta field, which should be last si= nce it is a zero-length array. Am I missing something? Thanks, Erik > } __rte_cache_aligned; >=20 > typedef uint16_t (*rte_event_timer_arm_burst_t)( > -- > 2.17.1