From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2DDEA0545; Mon, 20 Jun 2022 11:20:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B02D3427EB; Mon, 20 Jun 2022 11:20:33 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id F16BA40150; Mon, 20 Jun 2022 11:20:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655716832; x=1687252832; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6px2gC5H8/BtYLbm35/ODsvEXu/pkUMa6/fJYqBkEQg=; b=kMsOrIOYqYGp2MJjZCYIip9VrpN00oo81Bveewul5NKIHn6ul2TvVTCU wsaTQu2wUSaD/E/zlZeFbdtB/rLqJT8fjcGUWgWfIs2Ii0VFtsRwv8E87 td9HFjvzb6inq5MoyW9yOnKyt1R+LLmxJP0l/Jv8Ecdr/Zv2hkl7ZQycm 1izYM54FpQmXdpubknf6/zPSR5iY/YyKfkT5hmkqQZcH+ZJNAGQCoSAKm BEBozp22ZxhswvK7VCWEPpeEEqP1MieIFo9RFr+GrJzVZkE6Zq5kVC+nO 0hPijRLtsOF3yCdHBO1xKrTqXqac2T1PYm51+wnNUwc9Td5Ka5z18zCka Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="366172679" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="366172679" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 02:20:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="643029818" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 20 Jun 2022 02:20:30 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 20 Jun 2022 02:20:30 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 20 Jun 2022 02:20:30 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 20 Jun 2022 02:20:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=asmNW9JcTZ31nX9ZKQp6K7eHuUd3bW9MKMpIlMdLMK51sPV/8F17577xb7a2zwUED1trPxzFMmOGH0vLcwAW0jtppUMyZtUOUI6vSnTdaPOSucl5fpQAWE0Wx3xCrBvQBMWsb5d9ulA9QFJXq1deRfeQ6v77b9lc+dzzAwlSJrmWyEdMGGnl5xOOQs056j8uArPhOOrU1bFLrdKYmUp8VWg0DSqTR9zHv+7vFExsumbfZPe4GENgtRHMNOUVLB82ysdskNU2GcHxIMeMVwSfALwPQvJcdl1maXKUwNwZwSIw6rCYM5P5IBqo1VcK/gGJunJ9OyY3lmxVGvA3iHHj9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6px2gC5H8/BtYLbm35/ODsvEXu/pkUMa6/fJYqBkEQg=; b=oVckSD8+rke7F9xadchxCA8EeaWYV3l9M5/0pm5pSX1YQ8Rv4Zz8XGO7J54M731oDi2ervwPznRBplxo0vgdPd1L8bVxmMmNoxhwKIMf9uloskH7xme8u32btVVp2QUYKkBcGeUY4xfafMVbfPTUepv6HWVbGichNVsReJnJ6E+X9KUsfcKGnS0Kb+5L1jjdG3lJcS27nKl4L+MGl9EfXwfL+Akd4MxQlv7N4JFlFItm3BLGztI3cStk437FFcC1577Skd0r7pHlxECXeWEa1GG2N6vWjFVrPpHlLKnw1iXVR51mHk1uw/lYJiFRRgYz0c4eXo+s08lmc+bR+Dfzrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) by SA2PR11MB4985.namprd11.prod.outlook.com (2603:10b6:806:111::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Mon, 20 Jun 2022 09:20:26 +0000 Received: from SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::6058:7e27:dcb8:3e44]) by SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::6058:7e27:dcb8:3e44%3]) with mapi id 15.20.5353.019; Mon, 20 Jun 2022 09:20:26 +0000 From: "Walsh, Conor" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Liu, Yongxin" , "stable@dpdk.org" , "Laatz, Kevin" , Chengwen Feng Subject: RE: [PATCH] dma/idxd: fix AVX2 code in non-datapath functions Thread-Topic: [PATCH] dma/idxd: fix AVX2 code in non-datapath functions Thread-Index: AQHYgjlRc+RLy6GcJEe2se/sKuBica1YCU9Q Date: Mon, 20 Jun 2022 09:20:26 +0000 Message-ID: References: <20220617105920.354707-1-bruce.richardson@intel.com> In-Reply-To: <20220617105920.354707-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 958d62b7-4103-46c5-b3a0-08da529e1c78 x-ms-traffictypediagnostic: SA2PR11MB4985:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PPL165vLCVWd6zbwf25d700jwejw+JyTK08Z6ET1w5GvKm/3upagRQP8fZntArupNVWlMvJo1Grmq4Mvw/7l7XOJvJZ//tiYbZDP9U7O/tkj5TtCf+6BYYKaKGXN1cN8ydeQlJ8p6ulsNzEHkhFKHjW1ru3kFD4yxZtOim7XSX4B5Ds2G+U+J+GWX7QzR6zLXBOBXCmAOXA3mHSplWK8pjEX8dbBkjHIQQow3MLAm2QMrp3vHm5SC48ZZ2G4leQ1mleHA4dcqSGcAbybJJ29SnjGhH8PDQniL3AQod0Nq1pvqisDBDXbX97eCJdXaf/OVCFTXAt2l9nRJFiunFhNHVuO72A9VUlrNocIcQbWuxXUJ21rTNY9d1HQR8FP7K5IwHFiL+QSKNLmRGT2GijpDie1ifSUf1wIBgyEpFf7jzz8w1ecil4qySC9ypXm52s7Ijk7fXsaDxXekJ8GAnNkGayz8KoK0LnoHXUhdlqZjxsB/BpimravsN+SbPZUpXqEqcSovXiRn5fK08lWdSiienbUTJPOBkvoAre5xJFPO3D5lBA9Epq6zKKO2p+f9IICt4/+wdFv3WXxSYPbYjHVE56xv2ccFrgq5cZrdeYhhryVjjFRGm/vEGyxh7a3BE2fEmrJ25p6ppVnjk83bAlJ9INrULUKBEqP97ylRR7+xRljo8J8rpKEXzGQf7jOqibcBYyqzo8CXV/N8qaVqcG2xw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(71200400001)(66446008)(66476007)(66556008)(498600001)(66946007)(86362001)(33656002)(82960400001)(38100700002)(6506007)(7696005)(26005)(9686003)(316002)(76116006)(54906003)(110136005)(186003)(55016003)(2906002)(8676002)(4744005)(4326008)(5660300002)(52536014)(8936002)(122000001)(38070700005)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?80mkZYZJfmMFrR3t89ILtmwmhQgSQT2f2F9ufYoOw7oyhLObcD/v8dOdERdO?= =?us-ascii?Q?ljWxtAezr1MluqbMitA9nUeFtsaRY+glT6mvqHHA+sdcyLELzfRuPLoENk43?= =?us-ascii?Q?kD5ycGeQYeqC1FTBr032X/zw5svlvKUOmnC7HUYNC0+ZMBOMWCg0o6xJ+r88?= =?us-ascii?Q?ln1Le/UKddp9eHITA97iQ5i0AWhch7W1mWTTlIf4sSUppbbd6/MOl+bUV1PQ?= =?us-ascii?Q?UaxXYLKcz7ICRPLYH0XojU5Hzl/VFPuNDn/pswcasbi2SkiLe9h6utQEf30b?= =?us-ascii?Q?l3Z+1W24DNVB/trWDFYUR61w1F8e20tPbWvx6s+W4M74w+BqPSKE6T+v124U?= =?us-ascii?Q?khVYMUzYp9ioZ41L4NM2AUNleXAVbKe4XNVy6PMXAEIDNAnT1lrpphNJOC56?= =?us-ascii?Q?w5w/QmZaeaB8t0yfqnETJqt8jzFfaBQFoNu8X0Yi4FCojZQETsbPnp34Kkfw?= =?us-ascii?Q?sLystZvHtcZ2EscsKgk28gLHl54LWmu2caFty3tzO/2M+Ev4mP8b0HeZ1pz0?= =?us-ascii?Q?nSHJ7HdHe3xe0jdp8Da//sdyGOuGiXjis70wWcGriyecd+HcGax4VbU6659X?= =?us-ascii?Q?nl/V0IZyMWgWU8EuPNYF7tQ3H7V+yvLpaPyyMlho03odQdX+2FMVcyC83VA2?= =?us-ascii?Q?QEkuV+sVcVnGWcjtfrUujzaavHXa9SxHJHausvcwmw79ZXcW7ZyZrci1XEVC?= =?us-ascii?Q?kZFIcBdDJhrHNookxJYbHKVGLiOj78tE8TjKKyYEhBs1vfWxKmBTeGJzQHlp?= =?us-ascii?Q?8occH5UMlgDxbSm5NP4+E77O5gPeEMk1bb8KH/Nvsoy+ehzYRUecLgzuWHvz?= =?us-ascii?Q?3axkLSbPzUBjSJWiq3ppPHtLJEGB78InthygRAxjs/2Co4u7g95hnLJPbwCd?= =?us-ascii?Q?U5VYwcVKNNe6WYk6TZORWYcon0nzQ6EY3IaTEKHJiJPGJbPfJkJYMn/SnzkS?= =?us-ascii?Q?O2gP7QfH/N7mYE8Y2ki0VJ1oy6gYQQvV4mLKGdTIVRb6qTOEfbpuwIMYR0cV?= =?us-ascii?Q?QVS+rDWIvmcHs3d49cVcqhdoZc6MARNw4VURuwpcdNl4FwS4y3ImAljthxdq?= =?us-ascii?Q?92P+dnaJZO4kKab89F0IiPx/v/Jk4nUhVMBcrRjYiv62H/nD6OgbFKCZi+Oc?= =?us-ascii?Q?0RuJk99MinfFFKJRqViYI8+4L9Pbt3n+6qDm+1IQvAwU1H0+l97/o5ahBKhs?= =?us-ascii?Q?0+vMA0kF7rIwy2PBkDxDWGlQVXVndwzM/9YkSEJcP9DuUXb2tbdIiofM4Hxt?= =?us-ascii?Q?ZB9ESIJmOciTNS1HiqllVfjOwN/WbG9TrrfJwehoXNB4I6tVjJpvtrVu2554?= =?us-ascii?Q?7x5J6yiaxmvr/thigNmjHw6RPPTU3MWZVqULvwCu/J1s4Jgi4GUr22Vq6iIG?= =?us-ascii?Q?e062CrLNZGDqOxRj0rM4hOlL1JaSyU/ggEXaJf7sUBWaZavOsb4/mZfwEnwI?= =?us-ascii?Q?CHZO/sZONLwnZQMtSNCvC1mcXH3tukWffzJgaPIZccKJIPXlli0UBnvPjN3l?= =?us-ascii?Q?3vOwldG23LuYOaTW0TCrfr9VocwMi8LFdg2eqvrgt3Mdb/BA3tpc8sI28U6B?= =?us-ascii?Q?KWdDB/3F61hUi8lo0JD8ub+6ufsrNm0etYYr5WrK40xP2gPi6WMqhCWKSy5A?= =?us-ascii?Q?c9/GzIRJu4m+hTFQlMmDq92oVYGClnX1GOP016QJY2/6McdocK5lSI/Uyp9S?= =?us-ascii?Q?XtR06wzSjvsWPEIjd4Ymv+rJofI1/zK+9sPxBbET019uJEIfVROAMP6Maqhc?= =?us-ascii?Q?/HttWIdk7Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 958d62b7-4103-46c5-b3a0-08da529e1c78 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2022 09:20:26.1860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zqWVZcIlJI63Gnjw6NLhkuy5rH7NkK0eZOKE6x/Jfvn8lycGtCjD1mtct3Z/uPzvH8NL700RZTdijcPTVVYttw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4985 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > While all systems which will use the idxd driver for hardware will > support AVX2, if the driver is present the initialization functions e.g. > to register logs, will be called on all systems - irrespective of HW > support. This can cause issues if the system running DPDK does not have > AVX2, and the compiler has included AVX instructions in the > initialization code. >=20 > To fix this, remove AVX2 instruction set from the whole build of the > driver. Instead, we add "target(avx2)" attribute to all datapath > functions, so those - and only those functions - will having AVX2 > instructions in them. >=20 > Bugzilla ID: 1038 > Fixes: 3d36a0a1c7de ("dma/idxd: add data path job submission") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson > --- Acked-by: Conor Walsh