From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD6AB432DD; Thu, 9 Nov 2023 02:42:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 274244021F; Thu, 9 Nov 2023 02:42:07 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 50CC24013F; Thu, 9 Nov 2023 02:42:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699494124; x=1731030124; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9+CHw+a53/WznwaLt8pL9REt33x49mRjncXaBMDQHF4=; b=YsbNjcY6W6STVK56dMCuMRiuDLW5jfAKAsLeedSB/rzn4rChbhZajgOg T+lV5XxE1vLtWIuPiEzBXugoETnwzIQaqq/iJsdHK6ORuEYzUmkZqV7Vs ju6027GoSxgewu8NxwC4rayyjJb8XyZhuj6dBEQ/Y58EIdL0bWbv3HDxG rJ2yPo9nWABNm6QvRE9vt0Qd64QUP134xa2/vx1nZxoKhxIdlFvliVsVO iWlvlGsxJkQoIKlofCEmFnGjzJ/hYcq4xBpEBAe6uKcRt4S6czBd6m9Dy nk3zkDiHQHf0Y/m/G7df5n0ZhwHf6x1V5Iu/eybEgeZOb/LcSo8fisgNy Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="476126036" X-IronPort-AV: E=Sophos;i="6.03,288,1694761200"; d="scan'208";a="476126036" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 17:42:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="713127660" X-IronPort-AV: E=Sophos;i="6.03,287,1694761200"; d="scan'208";a="713127660" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Nov 2023 17:42:02 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 17:42:02 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 17:42:01 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 8 Nov 2023 17:42:01 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 8 Nov 2023 17:42:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=khJzUbkeQiToU5PO0NuMI1gwDvLrpVkujSlZb8+9I6rJWE7xZ0PECmKojwdbfugYoTYKXrGpV+ix8EnOe7qWgeI7rsA06EgTfPK1jwosu1Bk+UTUKJ+DyfdVlLPod0ZK/0Zamo0u3KCyzyBpBAW/5OAMFWCuaBe8Tpztzi37o7fGMMZ6vUs7I0LaWZ7KKUcMJy37xzH3NzgAS4iW8MOx4k0z58Z8E32JMAajKzKCT6+WDbkpCll1O3frbRHlkNCgkXhDzV5pxvG9mV6ZiBYI0h9TCQNbhna7QnbDIvSrnwGMaEm2XDQ/syk5aT/xllMgz4fPpwTeC2o/FXlcYWs09w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rqXVuo9bwnLnItywvx6yRPbU+uKHPQim0hHMLB7Grc0=; b=ITspEXP3ZzW6CV9hllv+jx133zRnFvnXGHBGb8E1EB7f8s87jUmTv6X3AGDmFyc6QtN03lPYsreM2Y55ynugbFZe8IQZ+zpJH5oPTxVPN5rgko5F4sJhhXraecHiMcWBwBDc24BDH0ZJRVLbkqhnXbVk/P3LUSC38I3ch8dWU82zjsHU2uP/RIH4IHhYUhcGIHWHyKz3TMyj4v+kWwSJqlZBQEG4853w4gY7JLAO5NoQCAWA5Y5fBK0GnsPvlE+AhbKodAHeZF4a6HWymH6bsRq5W6BoC3COss3LLrCi9EzfcE5rzeOmGq0k4StA02aqIL2eU+tBylkXmBXaII/U9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA3PR11MB8003.namprd11.prod.outlook.com (2603:10b6:806:2f7::17) by DS0PR11MB7624.namprd11.prod.outlook.com (2603:10b6:8:141::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Thu, 9 Nov 2023 01:42:00 +0000 Received: from SA3PR11MB8003.namprd11.prod.outlook.com ([fe80::cfb:ebd5:d0fb:37b6]) by SA3PR11MB8003.namprd11.prod.outlook.com ([fe80::cfb:ebd5:d0fb:37b6%3]) with mapi id 15.20.6954.028; Thu, 9 Nov 2023 01:42:00 +0000 From: "Deng, KaiwenX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Wu, Jingjing" , "Xing, Beilei" , "Zeng, ZhichaoX" Subject: RE: [PATCH v3] net/iavf: fix mbuf release API selection Thread-Topic: [PATCH v3] net/iavf: fix mbuf release API selection Thread-Index: AQHaDUykg8xU/KikbEm27S/CugPyS7BwMokAgAApwwCAAOQtIA== Date: Thu, 9 Nov 2023 01:42:00 +0000 Message-ID: References: <20231101013433.534399-1-kaiwenx.deng@intel.com> <20231102044316.541458-1-kaiwenx.deng@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA3PR11MB8003:EE_|DS0PR11MB7624:EE_ x-ms-office365-filtering-correlation-id: a41849fa-b3ef-467d-f3a4-08dbe0c510fc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1NhPgaOu4aNzuwmMUeni+SyVif5D+4ms6/r/w+kqG8wCmFvVtUPEXqzd5ZenuJfrl6WtwA8929UGWabKDkqh4iej91U7LIu23MdIewvvXek9XNYisuq/jQYU6dS4VUiuz4GsZzBijGwNx1vOu23PHgdq9wbCJtNn/OcPxF8OvQIgcSzYDw4nI+zAb8Y8R41vqt9P4+0wpgWs53MchWDYTf8sEkzIzf74P8OYLHGwyrOhvFM8XF5VxrtSQWGVKpbie/yWTCTqC8MnIoWd6WT8k7TUPi30ufLOtblAjWD5PT1/MKywey0yIFIZtzeOmrBjeVTFvq8qkg+yNMZkk1bxNmCh8gSsLyIdlvjeveRl/+EL1YAcUEtlm1Xs9i0ngvbGPt/2JUuhexuFLzyaJZ+uJ6bbKedl0FhZYklatzDoe5kdwpQqE9biz8j5aNq4m3A0Fgrpv+siuWIgcbV8/QySvgo/QEmkX2WeP4XnlDZ3zJZTGZ5J2aDG58GjEQDfyCIWm3NIfFCIxr68W3/R16e/8/lGEhUuW1R5+zldVLyjXtsLdLprzyaku8VX2f0Zm9RJm1xEbSbWJt1HrbgurFbItfvZhb8bBhP/zBTP0Iq5hzFCnXEAbTyCl8BTSm69PT+L x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA3PR11MB8003.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(136003)(396003)(366004)(39860400002)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(38070700009)(33656002)(55016003)(316002)(450100002)(83380400001)(8936002)(8676002)(66446008)(110136005)(66476007)(26005)(52536014)(66556008)(76116006)(64756008)(66946007)(71200400001)(4326008)(2906002)(54906003)(5660300002)(9686003)(478600001)(41300700001)(107886003)(7696005)(53546011)(6506007)(82960400001)(86362001)(122000001)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3FarW1sY8vw0mIsXUeOh2M3OXfJGV/RRv4r5TJs46/tPPePv/aJjg8s6qqxF?= =?us-ascii?Q?xE5fU02uCABBsnaSfGBScQMUn9Xct3v6n6obEUdEuEizRYUpjQQ0PWhAIGYD?= =?us-ascii?Q?jop32r22On0o72Vrowa69Wd8VIziutOIM0OPwAefy8rNEUTJdDxAvHsG2lQk?= =?us-ascii?Q?E8fZtFfduaAlfsv/YEmxAuEA/1yStj6T2JdIkskNgAC1p9C/UPPIJ854sDnk?= =?us-ascii?Q?/pph3C2eMkhPC8KcG6JmEn4Vt12l9+QV8IWT487IdkrIhBL/8mTncXTqGCMk?= =?us-ascii?Q?wjmz5rLrnj+DNY3YYYdvBHiRjSJnPIdw1tV+mKkF98FR2OvxWdjgRQZKikew?= =?us-ascii?Q?o5j9VGJJ7Dz8fp9Tlbqly/r0tgVabWhsSMfB3ufB0FfTautsl+5310BXKbZN?= =?us-ascii?Q?ZrnyWG1OE9LaF+MJJSzv8WoApeniKh4yG0wNUsuF1/Mo0XsMlbsMB0rj2HLs?= =?us-ascii?Q?U/KrdKOcZnMX1FiML+jdDF5pSC0l/ZLXZwHd+m/UO6fdL7P5KKX5vcfchfQy?= =?us-ascii?Q?xNy12Y6S3mKpG5Sm40LBk9AecrxxgibR4UH0ae+F23EnYOt7kO5zCHgxmnBO?= =?us-ascii?Q?f4sSnR/AqsUUY6bnPM9+ywHpKLZVNQTN8iYky/+eGhsBXhUJ80F8XO9g/Hjg?= =?us-ascii?Q?+XmOBmF/FXlhnLUqNaf0BQ2BFDe/tnaw0vhqeJ23R1Po06DU3EcBO5xnsTin?= =?us-ascii?Q?3Of2RioqOPxQ2wb/WSkTnimeSLeVAIsqLtb5gg5cqASH/HyHS/fxgreZzXOB?= =?us-ascii?Q?wGmNmtkBGdOI2jthNhaDd2XwK6tz/kIvCrJkxXQJoAVsh3be7z6/yBOL9c7r?= =?us-ascii?Q?Gjm1mXJVE5weLVcTiFYB6PqfvB45vTdvUpk6xwRR8gCvU8o5dy6D15AYc8qv?= =?us-ascii?Q?5cfTZ7ppzIQillsv5VX4We0pVaITrRlv0s6I7tsXiDBCNeVLT005yu/PtIGQ?= =?us-ascii?Q?43Mp0zDyd40Lfw3LQtUpzs4eMjUQHAp6BoGEHxkEdJi/DQX7d2CHJj1/TTd6?= =?us-ascii?Q?O0RVTAWg3D4NtEYWHEW/jxP5Z/pz/wAR/PwMHT+HYVwnXDxE4yHp1H4sb7v7?= =?us-ascii?Q?2LghJfm7nRZfnyG4UPzYKRfzoryUA2oCPSUstDuzd3YWpLzn/bk1GvGdbpvj?= =?us-ascii?Q?lhCd5ffe2QsGAGTqCkAcWoq57b4LefDrVDqWUzm7SGE40GRaLIyOKzV8bq4N?= =?us-ascii?Q?SDD+XEN/P+UzBwbxWsiSAUQTvHJqa0099M2dC8IqXnXb1+TMv580WSsCWH+B?= =?us-ascii?Q?DnGA78QlgawByVls/4vIZA8okpj10nqyvbaMbgRTjlrezz6+gGCxvkFAGRTx?= =?us-ascii?Q?Fb+KsjxQ5loNHFPhJrVZvu0Jt13ZoO0pb3GCGoWCkQB3V0SLK+1cthLkBae6?= =?us-ascii?Q?4/51pgZ4aDOYIPluP3SrEyLJS0Dywq9loQBtiydAe+lmvd9F+eC5DYauAgLe?= =?us-ascii?Q?eA8IBpVJnpJiov4dhftCwxNFqUPmATKkXPWSxPnJrxsKPci7EtJCdUQnGf/a?= =?us-ascii?Q?dRRAPFpY5FvR9GnITlMvRs4kp+RGtcJ8jpeLHzAqpvQ6reifXHht2sXBJ9HS?= =?us-ascii?Q?VLEj7Szg3t6ykbqd2EJCbCGVWZMyWkpMuS/la2tu?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB8003.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a41849fa-b3ef-467d-f3a4-08dbe0c510fc X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2023 01:42:00.0668 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xVRNyjUNFvKvbtNcMAgQegk78rhrBWYPLDk5OqPiL8tK6LLJeUvmfQex7l2d0q8xDi+nWf26TyMa8qR6YvHjYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7624 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, November 8, 2023 8:03 PM > To: Zhang, Qi Z ; Deng, KaiwenX > ; dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Z= eng, > ZhichaoX > Subject: RE: [PATCH v3] net/iavf: fix mbuf release API selection >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, November 8, 2023 5:33 PM > > To: Deng, KaiwenX ; dev@dpdk.org > > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, > > YidingX ; Deng, KaiwenX > > ; Wu, Jingjing ; Xing, > > Beilei ; Zeng, ZhichaoX > > > > Subject: RE: [PATCH v3] net/iavf: fix mbuf release API selection > > > > > > > > > -----Original Message----- > > > From: Kaiwen Deng > > > Sent: Thursday, November 2, 2023 12:43 PM > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, > > > YidingX ; Deng, KaiwenX > > > ; Wu, Jingjing ; > > > Xing, Beilei ; Zeng, ZhichaoX > > > > > > Subject: [PATCH v3] net/iavf: fix mbuf release API selection > > > > > > When AVX2 is forcibly selected and outer checksum offload is > > > configured, the basic Tx path will be selected. Also, the txq mbuf > > > release API is incorrectly set to iavf_tx_queue_release_mbufs_sse. > > > This > > causes coredump. > > > > > > This commit selects release_txq_mbufs to releasing txq mbufs when > > > selecting the basic Tx path. > > > > > > Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Kaiwen Deng > > > --- > > > drivers/net/iavf/iavf_rxtx.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/net/iavf/iavf_rxtx.c > > > b/drivers/net/iavf/iavf_rxtx.c index 610912f635..a16e03d88c 100644 > > > --- a/drivers/net/iavf/iavf_rxtx.c > > > +++ b/drivers/net/iavf/iavf_rxtx.c > > > @@ -4022,6 +4022,7 @@ iavf_set_tx_function(struct rte_eth_dev *dev) > > > PMD_DRV_LOG(DEBUG, > > > "AVX2 does not support outer > > > checksum offload, using Basic Tx (port %d).", > > > dev->data->port_id); > > > + return; > > > > This make the execution routing not consistent between avx2 and avx512. > > I think it will be a better solution if we reset the use_avx2 flag > > here, and use this flag to decide if need to overwrite the release func= tion > later. >=20 > Or you can just "goto normal" and removing function call assignment. I will prepare a new patch. Thanks. >=20 > > > > > } else { > > > dev->tx_pkt_burst =3D > > > iavf_xmit_pkts_vec_avx2_offload; > > > dev->tx_pkt_prepare =3D iavf_prep_pkts; > > > -- > > > 2.34.1