From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from SNT004-OMC1S42.hotmail.com (snt004-omc1s42.hotmail.com [65.54.61.79]) by dpdk.org (Postfix) with ESMTP id 8F2C05689 for ; Thu, 21 Jul 2016 20:58:18 +0200 (CEST) Received: from APC01-SG2-obe.outbound.protection.outlook.com ([65.55.90.9]) by SNT004-OMC1S42.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Thu, 21 Jul 2016 11:58:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q0xfPLh2bOuceDyV7fg6pwIB8sNRFRejK+59fLMRM+U=; b=GO6IsEkY7HKxWNvLrdDGTlmA0aCl142w48FHez/7i6IhvgxoW+FzbYXkPOz64lispjHH9Zu2BanjUH0iPnNjejlTMzTJrWtfs8cu1tD0elF+JVDk26tedSNVirNWEHQlmALOQsTa27sza6SFtG4vus3U+cypccH8RTbKGenQ2F1PCn6HnOA+I1RpoW1KBey+JLxGu9CMA+0dPCGeRzTbc9ritEfKphIM1cOHkCf8UDHIXIOJ0RauITRDwXtlQwnnUQVaOg9bL4Z9Oy8wLzsYQR7JBvn+Uj0rqxgC3Verx4Z2GYHowgSVzj+13uaLUP5vvJP/RP4xgkXzw2Jzqmixqg== Received: from HK2APC01FT003.eop-APC01.prod.protection.outlook.com (10.152.248.55) by HK2APC01HT032.eop-APC01.prod.protection.outlook.com (10.152.249.30) with Microsoft SMTP Server (TLS) id 15.1.523.9; Thu, 21 Jul 2016 18:58:14 +0000 Received: from SG2PR0201MB0998.apcprd02.prod.outlook.com (10.152.248.58) by HK2APC01FT003.mail.protection.outlook.com (10.152.248.173) with Microsoft SMTP Server (TLS) id 15.1.523.9 via Frontend Transport; Thu, 21 Jul 2016 18:58:14 +0000 Received: from SG2PR0201MB0998.apcprd02.prod.outlook.com ([10.162.202.157]) by SG2PR0201MB0998.apcprd02.prod.outlook.com ([10.162.202.157]) with mapi id 15.01.0549.003; Thu, 21 Jul 2016 18:58:12 +0000 From: bynes adam To: Zoltan Kiss CC: "dev@dpdk.org" , Matias Elo , "sergio.gonzalez.monroy@intel.com" , "ferruh.yigit@intel.com" , "damarion@cisco.com" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: remove weak symbols Thread-Index: AQHR4qnY2DHT1tssekmlfKlpzVXaU6AjPkKA Date: Thu, 21 Jul 2016 18:58:12 +0000 Message-ID: References: <1468938920-19679-1-git-send-email-zoltan.kiss@schaman.hu> <1469034676-2424-1-git-send-email-zoltan.kiss@schaman.hu> In-Reply-To: <1469034676-2424-1-git-send-email-zoltan.kiss@schaman.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=softfail (sender IP is 25.152.248.58) smtp.mailfrom=outlook.com; schaman.hu; dkim=none (message not signed) header.d=none;schaman.hu; dmarc=fail action=none header.from=outlook.com; received-spf: SoftFail (protection.outlook.com: domain of transitioning outlook.com discourages use of 25.152.248.58 as permitted sender) x-ms-exchange-messagesentrepresentingtype: 1 x-eopattributedmessage: 0 x-forefront-antispam-report: CIP:25.152.248.58; IPV:NLI; CTRY:GB; EFV:NLI; SFV:NSPM; SFS:(10019020)(98900003); DIR:OUT; SFP:1102; SCL:1; SRVR:HK2APC01HT032; H:SG2PR0201MB0998.apcprd02.prod.outlook.com; FPR:; SPF:None; CAT:NONE; LANG:en; CAT:NONE; x-microsoft-exchange-diagnostics: 1; HK2APC01FT003; 1:vGRjaGhrLKUUENc4dgaJcpjizZYlL2WaUn9vipbNL4/hKdM6YCqGIzJ6fpRWwEKCzVOBLXtDQNsCoTTJQxSC3dutO+BBmzoQGyfSM7NOdALbsKyqaPk9Mlp8BNpEf9sDzshICY32W9NTKVfFQnsH7nbxNUu6Qp7wT6oR+LThrl0k6zPadqg79nafrIfk2EAyEa8qIRtcs0zno8ut/IAtlg2XK7kTSE3fGuJ6JoCywYhlzk0Q4i7S5qwkmAzVqSBFewyXXjOb8Xqt3HDdI6WwCIX+v1qMZsci15SPusTWXrZKkP0XdNGlTBRJ3J1khdF+Lja75pTt2tSbWvqbeAmY/ItcTBYXznVUjCAjxi5xd+CAECFiLevvmADPEP1mSE05lO8L+vUOOqXYlLd/7HeTPAIYTo7lepM2RWG5rsckAiwdTClWkmpwMqk/QhTn7HP3Ejc4Dq+dICvciqbpUtEdhw== x-ms-office365-filtering-correlation-id: 66247cfc-c807-4b74-c04c-08d3b198f4c0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(1601124038)(5061506196)(5061507196)(1603103041)(1603101187)(1601125047); SRVR:HK2APC01HT032; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015012)(82015046); SRVR:HK2APC01HT032; BCL:0; PCL:0; RULEID:; SRVR:HK2APC01HT032; x-forefront-prvs: 0010D93EFE Content-Type: text/plain; charset="us-ascii" Content-ID: <2E1B55C4D2C48542A48DDADBCC67466C@apcprd02.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2016 18:58:12.7531 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT032 X-OriginalArrivalTime: 21 Jul 2016 18:58:18.0123 (UTC) FILETIME=[D7CC45B0:01D1E381] Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: remove weak symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 18:58:19 -0000 On Wed, Jul 20, 2016 at 06:11:16PM +0100, Zoltan Kiss wrote: Hi, Kiss > Using weak symbols have a few issues with static linking: >=20 > - normally the linker searches the .o files already linked, if your weak > one is there, it won't check if there is a strong version > - unless the symbol is directly referred, but it's not the right thing to > rely on > - or --whole-archive specified in the command line, which pulls in a lot > of unwanted stuff --whole-archive on the other hand can ensure all the object files are linke= d, and the strong symbol will take precedence over weak symbol. So we don't ne= ed to take care of the sequence of the object files in the ar or between ar. > - whole-archive also makes libtool dropping the library from the command > line, which is what should happen with dynamic linking, but not with > static (observed on Ubuntu 14.04). This is an important bug if you > build a static library depending on DPDK you mean the libtool bug for --whole-archive? if it does, you shouldn't using the libtool,=20 BTW what's the circumstance you must use the libtool. using you own makefil= e for the library or APP. >=20 > This patch merges the two version and make the behaviour rely on the > config. >=20 > If we can agree in the concept, I can send a series to fix this for the > other weak functions. >=20 > Signed-off-by: Zoltan Kiss > --- >=20 > Notes: > v2: fix commit message >=20 > drivers/net/i40e/i40e_rxtx.c | 36 ++++++++++++++++++++++++++++++++++= +- > drivers/net/i40e/i40e_rxtx_vec.c | 36 ----------------------------------= -- > 2 files changed, 35 insertions(+), 37 deletions(-) >=20 >>From the original design, we follow the rule, we don't want the Macro in th= e file to seperate the different Rx/Tx path for disabled/enabled vector configurat= ion. Adam Bynes