From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94A47438B5; Sat, 13 Jan 2024 18:56:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14B4040268; Sat, 13 Jan 2024 18:56:07 +0100 (CET) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by mails.dpdk.org (Postfix) with ESMTP id C4FDC400EF for ; Sat, 13 Jan 2024 18:56:04 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40DFqm0S003278; Sat, 13 Jan 2024 17:56:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=LP6Q76tcwooqMg4Aonvup5YE24PUIt5SI+xBV9FBSYI=; b=KRbtxF7mPkBrNC44TX9I1WC0kBSjNxxIREtVyKOpiN5aYe5IqDvyCeuDpHgbnEeCcpKX VESPB+jP0WLXfkgX0kAJAsdSF7HBFFjZeHiSicCEwl6fLgeJVBfeVNmadf/y0QrizU8P DZ/j3QuGPiUCuH5YmgBl4Bk6XIO077fbZBK9mIebAEmBqlOzLFu4QFHdWpXnmPQ+f5tg dS/DEzLux6jKsXBbEYVu0ViYMcQ7BD9MWZ3J9kllftvASJZRKn5VhamFdL6yr+2JerYP IoZKkECI7i9tstlWX5ohHxoL3QnmqY+gc3C2b0iO9ST3Ozg9231MrI4jNJ9ffQDTQvf7 1g== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vkha38j7a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 13 Jan 2024 17:56:02 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40DDkSWH004573; Sat, 13 Jan 2024 17:56:02 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vkgy9ua45-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 13 Jan 2024 17:56:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6C69q1j25Fcdea7CYidVsvRdalSMDOQEGUbNZ+aSsigzzX+QAxF20CDHOG+5wM+OhTXH0gT85NUnUoTG9JVlezsDbV5La3ufNCxwnaM3blqWmq89MrMZGMfsUMwp8GnB0zgZbbXhSSE0SYgGcKvklecBgcsagxzk4Em5yEhPUJxlCXotoC6QiXwZCFyH+tJByNHtkHsk+/hyVushVtF/UbAL5ibW9p3Z0XgWA5/BwwakIacSmpatJoBO0m74NTyJxDHyWk6yGNkFQhPSx4cCWXRSXzKoqHxiZw8AYF0Zf+Y3W1Zd/ZE1R9LEA2WJZucxdSZVZxiZAYtCxDmUbhCyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LP6Q76tcwooqMg4Aonvup5YE24PUIt5SI+xBV9FBSYI=; b=ZIguvkXx/c82DnhMO9t5CFfFYUJPcxxluAklM2GFPO7vQxBLHknggLtRfs5qK3HBEiC6B8lugFekxbYZvkzsJm6AXg14VDnwOEOrBzMl9Ev3BhNSkMtlQ0kRo9pXVOcaeMBav/AiqA2xH9BP+8JWt7MWuaGt6ASAv2+bjvhJdapwJhCMsHIHUm6mSQfhl7MyZMjHhwrfVU5fiqHHzNmuGlpMKzFypaBlp4SV/e6ABwHyfaxqvQZyDVF5WlVadNKSx8c9oEchJphR42nqgj6IiMmn4KXZvhEx6SE+0pMl+UJ9fdvNWYBHePELykJZyylgKTMyXTlniF4GdgKFfUEZuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LP6Q76tcwooqMg4Aonvup5YE24PUIt5SI+xBV9FBSYI=; b=qQB4agEX9H5eS+rzynJuZEizuBKHJZleLKlsfJoCasf61S7VhTb19ozRtXeTeZIMi6WfHepQlqSLEl6VP0H6OxgLLjjLpiRJX0+YPfT46r3UX2bHA//fISzdZ02zCchdOS9AhtC1ibCZVvDtOf0SwOMJ+BgRjJmG3us+5Fl7Uu4= Received: from SJ0PR10MB4798.namprd10.prod.outlook.com (2603:10b6:a03:2df::8) by CH2PR10MB4389.namprd10.prod.outlook.com (2603:10b6:610:a9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21; Sat, 13 Jan 2024 17:55:59 +0000 Received: from SJ0PR10MB4798.namprd10.prod.outlook.com ([fe80::bfe7:9456:17cb:cb09]) by SJ0PR10MB4798.namprd10.prod.outlook.com ([fe80::bfe7:9456:17cb:cb09%7]) with mapi id 15.20.7159.020; Sat, 13 Jan 2024 17:55:59 +0000 From: Madhuker Mythri To: Stephen Hemminger CC: "dev@dpdk.org" , "ferruh.yigit@amd.com" Subject: RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements. Thread-Topic: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements. Thread-Index: AQHaRV4Rf7RgLGk4B0C7Hxjh8lHukrDWYyEAgAGlDzA= Date: Sat, 13 Jan 2024 17:55:59 +0000 Message-ID: References: <20240112134821.2067-1-madhuker.mythri@oracle.com> <20240112084648.7f7ff52a@hermes.local> In-Reply-To: <20240112084648.7f7ff52a@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB4798:EE_|CH2PR10MB4389:EE_ x-ms-office365-filtering-correlation-id: db893243-3e64-4a51-b857-08dc1460e697 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q+l0rHgKr50FD85bgr4qKQZirCkK7c0QOq3mr15b5kYqhMSEzfn842+1FfNHSEsUhJLr6cXsJG+2p4pHCMDGFIH9enZqX3tGM0GRYl3EUuS0zDsFXH3zho1WsMcAh/OO5vve7jIs5ePRLSbn1KXlVL1M0dOTqDfty4CdHTlwZCiknbjlqkAPFoxUubFfFuniBls5zuIvkqizj2bqM5LdD9QHwUhheEIT0zUi2ULViEz8lmT/1HopN4OSawrW6QE+RXbCh9uWWOoFoo/0ceYK3FVwMYRD0mSYW8Hl+djojClkDQwTiw7nl294nb0+f8MlSl2R93d89pe3N4Wuza6OX0UTqSxblZLo4wXmM/0LgUViGvrsLSMSv8v9gfn+3go+UwzZKeBqimHfjV3YSl8rDrZUYx6hgg9aw8BBv+tZPjCJY6yH0pCVj99soaMqOGvsxThFQCQMYCESUuunwq/MytqaYKaI/n2beXcU3Or8DuhwHIUjkZkym0z+EtnLRHKxCeVqpx0I6h3RQyWx4gn2EgTllxGHop/wp46m+fww8WmlzXKzqfZUseH1X/rG+zTiddiYWsqIwCAQeVTUkKAxmVJNI+iZ7B+sDJfg/slBWS+9vmAiFgzM4MDM8JB8ryvNa4wVBXqTI3P2DZz4wu2Km/36N5ssiqpXWkkvoiPmnJI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB4798.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(366004)(396003)(136003)(346002)(230273577357003)(230173577357003)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(6506007)(71200400001)(26005)(478600001)(7696005)(53546011)(9686003)(83380400001)(5660300002)(4744005)(2906002)(44832011)(4326008)(76116006)(316002)(66476007)(64756008)(66556008)(6916009)(8676002)(54906003)(66446008)(66946007)(8936002)(52536014)(41300700001)(86362001)(38100700002)(38070700009)(122000001)(33656002)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eS5ZpKMg/h9kmBUWUUG1GItWRUcwHEpF8G3Rc9ff1K7KQOTaVR3u7cYcSk9P?= =?us-ascii?Q?ndzN0arOkM7itjOwY44xsQYJ6dD2Svi4qRRoQ+M64oGxbX8LU7iik2Cgpf8N?= =?us-ascii?Q?SKrO7QkmEQwW5Yv9D7KrxBbpzIb/cKVULG/1QLD1psPA6XPt5SpjN3jBb2zp?= =?us-ascii?Q?0/qJS6UXohIKUfbifBGyj7aSqZVHxLBIwtDZqaS5h6wAx2KdV1E6Ujq8U5D9?= =?us-ascii?Q?4F03C2/W5qFm+quymlrSVgK4kygpGDQAKx7KtnwuqaCrMaxEEf+7phohy+rr?= =?us-ascii?Q?SLYlq/FMbGRB8JV+i6CIlLGozuWi8snP8eJ32+Hk1IicEl1pNUNbfNFcOK1t?= =?us-ascii?Q?dnk/5alykhzcVcKyR+OjpZjfro18EcDye3UW5cQe8kmd/aUyQB7r++AowwOE?= =?us-ascii?Q?zAbAlFINjE2ZDmKIcFmlNt/2ExYdoxH5z2k/Ujgb7I84lZMFy5AE8XJqp4yh?= =?us-ascii?Q?Qys6S9w1bUXvLTVCcqz5XMOJERPiaoGXDiENmumnXRxpngVvN8NwPjI6oteC?= =?us-ascii?Q?nF8gdBjXEUpT9pcJ0ZF7SRnzbwERj9EJTXYp4gV3ILQM57z0K203Fu7gQfzT?= =?us-ascii?Q?8HwR22mYm671jUC+skCBtpwarjr9yfnfCzHbd67hGy7gWoZnXN/yhA1wRlYr?= =?us-ascii?Q?NXhICbFPzH7UcKY3/RsODL0NehJdzvE5iKxmyXYEzLLs4sMiEdpx2IJrwWKR?= =?us-ascii?Q?qcNsRTTgwluHwhlr3ysPXdtO1P3YAY+LXnaNuytbuDfJMNHj6Ov/fxGYuemx?= =?us-ascii?Q?D0xnXXDXF0OrNeqR2EU7VH0gzNCxRVEfLNWndnNCK5YLBj4U1P0LXrSkLTpM?= =?us-ascii?Q?V37BenuYinOpKZY83KzxMI0aLxdCfHd4URcgy0zZPrWHNsPaFe1LLibTOs/E?= =?us-ascii?Q?aTVt/jjylyxka2O3jbOw6h5I977Nygfr9NXf82ZXMo5X8s3TraJv+fKFaf2B?= =?us-ascii?Q?FL9VurXagKOoAisoy2lVy1cjqLZ6rVRTBFtRX/wVPtofvTSE2oetK9n8oi2c?= =?us-ascii?Q?Xt7MJDdsczdFOmP4f3wF2IN/St8rB4KI8mB6aIdzgDxDvZCPTjUTKuw2ZbS3?= =?us-ascii?Q?R33fld86P0mmyFFY/q4iam4l+qtyyxnhNWjUSSFStGUMvV/FvZGyGJYHapgW?= =?us-ascii?Q?TObQU0HjqDny0V0Ph0efgJz/QQxXSfX/254ouwu/C6ctziSVnJd1jaGiOGNe?= =?us-ascii?Q?A4uGBExLAPxNajN9Vy+XcSlpN1KlMhROBv59+P3Zmw8edtAZ7C38kQAFMlBd?= =?us-ascii?Q?3BnU40mimKMbJ+ybZ4rHi77BCr1N8GUoexU+vZ23QHuBXt1kXdhZiU8m5W9g?= =?us-ascii?Q?dD0wTvwAdOxG3X3D3nNJy0XSM20KT4t+DNo34ShYOcHky+++EWW/ry9Y8/nG?= =?us-ascii?Q?tIVW4GNyuse7R1QBeea04gm2v5+AFfcQlEieDGi+qfgnDPRAvgMEGs2q5Gxb?= =?us-ascii?Q?O/hPp+YYq3z8ZFwgCXMBSVRBFgIgyK2nJp0MIJ8yGVDIPZ2vqHg95b3jcC1H?= =?us-ascii?Q?jOBqCOwwmUJ1eRVhqAZIliCdCsBJuuNOksDk8JVkmc2jIlnVn44C/8vYLqMy?= =?us-ascii?Q?n3DwgLRGgOAulYFAI1iPiwQoAWbGGtcpV5Dp8lnJxMb/dYym4HvLHShFkMqd?= =?us-ascii?Q?eA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zjfE/LBcXseKlxlAJuGxRoUPMQLEw6Djg7cCRxEb02Q4QGr7wBw4YpnoP6UJPXyMebfQV0afY7WoIxcCFTN1hWTbcb8XaDDp58qhpW0zr7+DFs3zD/hC0ykWDNN1aPl8amC1juXwfpYX75a+3IDIXFcJCs0DhYnuPSFAK/gxPRoFz3+tNG2fexN0HZ7rliaZDNvy8AOg67ON9uPLger+QCxuwA9XkcpNqjbIimCAvbW3D4WZwTd6TJfjlxM4Z0EpeINNMdfYJO66U/hv0gEcVdgHNLpyh3P57UEDKJIVQ6hS1SWDm6XCVGe0M/n8z4syQ+2Pp7M7keUL/ZAejGFSokowjOpJSp3hWIujOwEPgiJVO3TBGYEKfSNuH/ktbNwBugL4jdNTB++fNQxo35M6/VbRhNV7QTwMP6o2Ff8STPmO2iD0a2NtARfM9VqVEBUD6chOnnOHBMV2mlZRHs5VV+UtuBUwLeE+/aBAN12hvQQIt0UYNqI700FndRL6irdVSxNvbZPbaTxWNKxPFljUlbkwujm3Qn9tOWBS+ZevJEyoRvQuPM87I+LYVi7WRAf4vaSeweX7Xz3Cj5yX5icj4JmZkPvDGAH7qQMZe/qUjpA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db893243-3e64-4a51-b857-08dc1460e697 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2024 17:55:59.7263 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tHfOuenyB0y8MkBOWcOeS1Pc0YMOJMl+TDSCgzDRWOanW3Pz27KuP4CjmJxZNHFF2ZLhPstESGG3gzEin0rItz9BSo7Ss6RYVrzqIgKYnUo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4389 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-13_07,2024-01-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401130150 X-Proofpoint-GUID: 8dR-5MUd9I04qcKgU97uGlp1fSSuJV8- X-Proofpoint-ORIG-GUID: 8dR-5MUd9I04qcKgU97uGlp1fSSuJV8- X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Even, in the original code the IP-address converted to host-order from netw= ork byte order. Now, I just replaced with BPF API's to convert to host-order. -----Original Message----- From: Stephen Hemminger =20 Sent: 12 January 2024 22:17 To: Madhuker Mythri Cc: dev@dpdk.org; ferruh.yigit@amd.com Subject: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per = the Kernel-version upgrade requirements. On Fri, 12 Jan 2024 19:18:21 +0530 madhuker.mythri@oracle.com wrote: > struct ipv4_l3_l4_tuple v4_tuple =3D { > - .src_addr =3D IPv4(*(src_dst_addr + 0), > - *(src_dst_addr + 1), > - *(src_dst_addr + 2), > - *(src_dst_addr + 3)), > - .dst_addr =3D IPv4(*(src_dst_addr + 4), > - *(src_dst_addr + 5), > - *(src_dst_addr + 6), > - *(src_dst_addr + 7)), > + .src_addr =3D bpf_ntohl(nh.iph.saddr), > + .dst_addr =3D bpf_ntohl(nh.iph.daddr), Not sure this is correct. The RSS calculation (Toeplitz) expects that data is in network byte order. = See app/test/test_thash.c for example.