From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B805C4383E; Fri, 5 Jan 2024 16:11:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 432FC402E2; Fri, 5 Jan 2024 16:11:28 +0100 (CET) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by mails.dpdk.org (Postfix) with ESMTP id AC7A2402CC for ; Fri, 5 Jan 2024 16:11:26 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 405EqELD004759; Fri, 5 Jan 2024 15:11:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=lF6VZwLVpdIwKT/uRPpLgYkjlTmo39+XKVTpNWk09/I=; b=jA+FKrkmxu6qIaXDsVXM9+63QIoGU/T47OLK314eOkFAtiyhzVJ8TBrBetO+dsm7fde5 FcZreyvWWEwhQz3Gjw2buwQtbd07jGX8kpE/wDBxeySk1bjZ9hT05OZN/2T9ME5ZoWlS V78w9sf6miSXqjtEYWu8u12ogHemcS+mTc3UgOxjM/zd5bjneBIHAUxM8k/dDKvxtZah ERG+efZuDCvfu3qjWaBie0fHWz9esNKNwUugy/YUC8R8SrJfBKol8NYuCA+6WbQUkcFw +Szi+7niUEvGEfFjKEuxg0+Rq1XAhSgzGs/OWdCoA41J59STTlj+6ldkOJ7lUJJaG3j/ YA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vekwjr1gj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jan 2024 15:11:24 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 405EJt8P013220; Fri, 5 Jan 2024 15:11:24 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3ve12p91ng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jan 2024 15:11:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B6+ZUn809RFOIp83Jn5GvR9izZYYm0Syypaln0N/aEUAzP5KnTs9oVK/olYIhT650ujXx8E0K84CZ94RItW1BvlRiVB6rO8z4HEWCXUEh6ybmkO4703BQxjW8gr+JGHY2psXhzzwJM3AoByuVPWcSGkd6Uh3dt24S5X75IlVv8fz15aSoS15GsevHHqCmjo9/0fnUcVYqOJeRwJmXSHDlvHcYRRC7xwhz6BJxGBVZvJrYuo7SRvKWTMi/xycRb9CCB+/WiCdLenZ5yChRNgY6hrFIUf26DOuGhy98UMZCUE/OtnLHkaeMh/G5g2hXtInIktIWX33xVGWbMdn442lJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lF6VZwLVpdIwKT/uRPpLgYkjlTmo39+XKVTpNWk09/I=; b=hZcfYY2nEKZtqj6oi4I6SapIMKGwHYXgBYFpr/ta2/Rsw19Pq85ZIsIMgtEASoRjN56nhsZdRdadiiqKVWN32o8kIsZifFK1E5XojTqm+wyy2zCVePO9izXBFa/W0oMOkrMjSRwkuLJ3X+cTtBpjfZdVB0MR5AO0B7vQYJR9Cf/kUKavtXIIzyO6G0JZ+38olIAC2U+a9TF87+DnSWQE3QBEhh12x1nqIIe0pB8Kb6BC61JJwJvGcad2BOrRgo9hOkN1M9bYFHrHY2nAsGOiumqbOojVIWJtuMUugBU1wH+c3CeUuy6Bdj/DOf0J2O+saLu7KAnrc3wuS5Es5WhrPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lF6VZwLVpdIwKT/uRPpLgYkjlTmo39+XKVTpNWk09/I=; b=Foe81vLaAy0SctvHLXGOM+Jt70CI6qPBvdhCQm44xDXFwnLtiVJOtN8iLPnW/rOPCReYM9n7QKTBOS9uy8Vu8dY5vS4IKADtYB/4ctlx6UBtf0yDMV5KMK6mv8OuPyPZ6d7HN+zjRnrS7P6UvTqa7yiJx57tMpXkfPP0dwiYyao= Received: from SJ0PR10MB4798.namprd10.prod.outlook.com (2603:10b6:a03:2df::8) by IA0PR10MB7580.namprd10.prod.outlook.com (2603:10b6:208:490::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.17; Fri, 5 Jan 2024 15:11:22 +0000 Received: from SJ0PR10MB4798.namprd10.prod.outlook.com ([fe80::bfe7:9456:17cb:cb09]) by SJ0PR10MB4798.namprd10.prod.outlook.com ([fe80::bfe7:9456:17cb:cb09%7]) with mapi id 15.20.7159.015; Fri, 5 Jan 2024 15:11:22 +0000 From: Madhuker Mythri To: Stephen Hemminger CC: "ferruh.yigit@amd.com" , "dev@dpdk.org" Subject: RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements. Thread-Topic: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements. Thread-Index: AQHaPzO4tzDzcCULFEKTKYP0ti3cpbDKHlGAgAEy4sA= Date: Fri, 5 Jan 2024 15:11:22 +0000 Message-ID: References: <20240104172756.2213-1-madhuker.mythri@oracle.com> <20240104124115.6e6806eb@hermes.local> In-Reply-To: <20240104124115.6e6806eb@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB4798:EE_|IA0PR10MB7580:EE_ x-ms-office365-filtering-correlation-id: 306f79f2-8035-4cc8-c38b-08dc0e0093b8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +W8Ry2TWeRyDvC0EpEvve9AeTMa8W90GNUbngQoa1L5UK8GVtTwrbMI48KiJcmMt0CRlEfsc5CraoxpLa5+zqtVhsxYyh0o+w0OKaIUG6NI5bvgjqKsLMofw4KDmaJO/Njab/z913mVuAkZNE7gzN+LV+CB5RukfZMtRZEqs/R9UGvhLVVlDEDHglTgSN+E9aUzok4Inl/9qyX8LGEMpjBBaL/O2CCnxb6m8fyh6ddVUcgmxRrV9ZBp01c/NaC8IprkzRN3jTNlnlCtWHTlmeKM0gIkF2RmgYrjzfxtxb4R1qMK5527B6CC/06XNLjwD3q2QGwYZNWXWf/y9cNEBRUt3U6yP91W4RI7w6pFA6MSOld9ZOZHcK0pM7WOba7VUfE5ZgufF2dzgIa8dJWbffMUU8AAKKk60ilBsc1yYphpH2g+NYmQUpMs2ONT+lw1l/nmkPJ4wktEyuj1c6J+i0HY85/dAqd51VjEXs/IVqAX8/0Lc5kUyE8mpgJEWGEf2EmQs1r6S2jFh89FZLOBxafDudDlVQGaiQyij4+gGlsckM6fJ69Tp7fr9nmgoi3BFvHDOSj45r5gG2sCxRFt4IDFZ9WYSmBdBcL0LoZei4k3D9Va8oGCCgBPEpTGxoppRdZmPG7820tZpSBKgp0tArFY+wW3sh/FiDAyiSz3asjY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB4798.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(39860400002)(396003)(346002)(366004)(376002)(230273577357003)(230173577357003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(55016003)(9686003)(26005)(55236004)(53546011)(7696005)(6506007)(71200400001)(478600001)(38100700002)(122000001)(86362001)(33656002)(4744005)(2906002)(5660300002)(41300700001)(83380400001)(66946007)(38070700009)(6916009)(66476007)(66446008)(64756008)(54906003)(316002)(76116006)(66556008)(4326008)(8676002)(44832011)(8936002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IuJife4FgI9qVGEcKDN2q7XfbnIEzdgU5cySIeVs4VroKxPnzEmixyWw0yR8?= =?us-ascii?Q?LH8XZa8R4ih+FUV7UFMot9ydBWbFpooPWWDdDKn1+FulvRmMUgTd4hH3ZxLq?= =?us-ascii?Q?+FfCWWdylt9JurHU7QJQf7C1qUZuJ9lNFuRKx4IyDqCcqqzRGnpMuayVFf4U?= =?us-ascii?Q?3dNOMPCpYjFz73YVqMHruLML7SkdlPZvTNqySlrMCzbObJXtbdEq077Q7ljq?= =?us-ascii?Q?V8WLuquIlJpb2j2ksE1GYxeOTfjLcJbpL3+1jSia+lmgaHDZ/A0ZLe7Lp67f?= =?us-ascii?Q?GNIQow3g5QwyyJEsdYoIobwYE0+87rImxQRPIqvH3O4aWJewJDB7NWxhkWqs?= =?us-ascii?Q?zvW0mBybVQ2c9s/2o3cgrY/VSX97flTxHGTJsft8iraX7nf3guDrs2V5NSUl?= =?us-ascii?Q?0oecMcgaf0CVv1r6uq3UaOiCXqH5HrB6eaEioh+Ob/DbnJpkvERdhxTk+Wwd?= =?us-ascii?Q?xglfC3+P9WkRoly5L2RMBR4TLYBdn7VlRJ6X5wG8hZprpPO6vdzH1pTjo9EV?= =?us-ascii?Q?V/nQNdRkTuNzvgjL5o0ic/Rwt8sP9bncrAvmpYKJpg1BHiunU8RLY80kHXXr?= =?us-ascii?Q?X+6ZeufvxMY7cixD/sRUxBRSRpQUAErSwgj7iLlvbbGhmRIUqMGdqsIevMk7?= =?us-ascii?Q?9cpNGqwZw+NV9mRizP/4ugVTDbZ8nN9oJnWg+fc/NloiVlxUYN9NgGRCo84J?= =?us-ascii?Q?XAJszGY0hdRh51B7RrNrybLbzVedx32I0F8x3Dr2yR39prPKDiBTCq9ZJjE5?= =?us-ascii?Q?6LUwpIk9q55z0Crna8x95Y0VastLoALThfPZsC7JiQL5jgQHm4KJusIt4tMZ?= =?us-ascii?Q?126wE+D8t0ttRmcUHaPyzCw7z9E9riFfafBaMxWcIgSBj839hPK4CF4Ovdzj?= =?us-ascii?Q?FM0aE0ylUs/O2gaHwdRgD3m2+kxBUlWxnFU3wDpxHfegeuG1hDP+q1uB41mh?= =?us-ascii?Q?MgZ0OcKEqTJqRiHvbFEKvDdI+Pf2gd60+r94EWDx7OI12fVDcCHKQ1Bmv0Xo?= =?us-ascii?Q?NQ1HQ5w6n3tAYTud7bwTO3ES0XodCR5TY91rTxWsv8fW3gTDqhoJnZLdD2oK?= =?us-ascii?Q?hvoC9pKZ9Me0sYSSEn1M7QuRdxJO+veO62Br0OGJHqfGmVXqpj3+e6Ti1SBs?= =?us-ascii?Q?mp9Gy8YfFGw6jVg/XoUccNH9lylj+yLZ1qGORDLB9RYS6PYyW5knuPPN70rV?= =?us-ascii?Q?6yMt8gP4jcINKLBNzedcPtjp7JMJgajw4zYmi+TZ0EZbXDc6KI3iCe12DVOQ?= =?us-ascii?Q?4qSEOOF3r+TX0uA8d1xOswuShL/Voe/u394jCyqDgLRJLF7zv+QLbavxac8f?= =?us-ascii?Q?bn8GBVhoGzId3QoCgnQjsecwE1t9pqRF2dsjgfrrrm5PTLwRYl66urleIITm?= =?us-ascii?Q?c/+1qXuM7sZmuc9SnI1dIV2vQ0DIJfTezzaminfHcozXEDSWMioi4FrMM52E?= =?us-ascii?Q?E19zl04qRch5AGgnejay6Ng1ZUPlAyG2OVIUr0nET8VlUge+UcW7gEKq69KO?= =?us-ascii?Q?+eVuzdgCxQ65PI6G1W0j0uiVA4tRWre/4WiF33jc6+kvQqEjSdQe7MzY/G6x?= =?us-ascii?Q?ZZ5q0OkjXHoWlKXP+T9PhYUJetsSTX9GrfQTDv7uKH8I87Om1+1JUo68HYq9?= =?us-ascii?Q?VA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NQuBG94GpYGFBMZJPlDAYzLy/kPCTv3kDNPgAd7KirU0EDGy1C/7QhagMI3cclxZ9AXkRKTe3LpDi88sBGC1AE85gvHJNjpafhte9TY2MgcTX2eRD6YQbwqPixLJeTnWi8B5MFxXQQiutPIgRecm6SbikT4mVGqohtg98Fyrt3dsopR0fZ7iGhlyYucjWe6StQ8Pf7irQd0ImtR7+Ac17O7cVA0mKv0nK/D0v93U4wudXo01NTJYRI7iLINzWFIznx1mtE3QmqVQA4CRs1esRG69uWDgG26NJ2qFTp9rYuC5L9uGUO/PCYBmaqQ7I6RQNIgQ9+fcohqC0OegHLoD5VCxV4T7sFgGeLrYvprwPiugw9rmGVETl32YJIgTm9IYsln6CXu9AWMMDiwZPRFHkTcZ0jtRVU+TjabYqY6Fyr/i2q1H4raJh/jBmLXjl/xXOsD7EcGbcJTtQv2J0Qqlj1odIlEzdH+iW21XhSSBubOQHT0yGtR3JScDJx/L2Dfe8UOmERdpJWEgbVXhRg6NHlvoQk32kg/zFDyHJJ6oUwi22f7e3hPBdamkq+SFQN41EQt+HI8LCLhksTbVTuBHSknST/SzXgabBnZfkVdtDCo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 306f79f2-8035-4cc8-c38b-08dc0e0093b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 15:11:22.0453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9N+L0wOk3aNMrT4A1V2UiCrYOOWWLCw9SlhopbELNHlDolNZXaD2b0NHkZdFCeic3mE2LkliKy0WZKneNyWqtZUayqdY70fPABZKCAJynfQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7580 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-05_08,2024-01-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxlogscore=906 mlxscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401050127 X-Proofpoint-GUID: 9VjXJ0Nvq9rz3C6M9gAjyuakwuAoOdLL X-Proofpoint-ORIG-GUID: 9VjXJ0Nvq9rz3C6M9gAjyuakwuAoOdLL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org By using this " bpf_skb_load_bytes_relative()" helper function we can direc= tly retrieve the Network header data fields, so we no need to check for L2-= header VLAN presence. Thanks, Madhuker. -----Original Message----- From: Stephen Hemminger =20 Sent: 05 January 2024 02:11 To: Madhuker Mythri Cc: ferruh.yigit@amd.com; dev@dpdk.org Subject: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per = the new Kernel-version upgrade requirements. On Thu, 4 Jan 2024 22:57:56 +0530 madhuker.mythri@oracle.com wrote: > - /* Get correct proto for 802.1ad */ > - if (skb->vlan_present && skb->vlan_proto =3D=3D htons(ETH_P_8021AD)) { > - if (data + ETH_ALEN * 2 + sizeof(struct vlan_hdr) + > - sizeof(proto) > data_end) > - return TC_ACT_OK; > - proto =3D *(__u16 *)(data + ETH_ALEN * 2 + > - sizeof(struct vlan_hdr)); > - off +=3D sizeof(struct vlan_hdr); > - } Your version loses VLAN support?