From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6857A0C4F; Mon, 12 Jul 2021 08:31:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 518F840685; Mon, 12 Jul 2021 08:31:13 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 4D6374003C for <dev@dpdk.org>; Mon, 12 Jul 2021 08:31:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10042"; a="273764164" X-IronPort-AV: E=Sophos;i="5.84,232,1620716400"; d="scan'208";a="273764164" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2021 23:31:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,232,1620716400"; d="scan'208";a="629573926" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 11 Jul 2021 23:31:10 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 11 Jul 2021 23:31:10 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 11 Jul 2021 23:31:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sun, 11 Jul 2021 23:31:10 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 11 Jul 2021 23:31:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFYQjFxocyl6/Jc85wsSmdPM7mhvyk6AQ26eDTSHiDxB+Bb/6s1Mjn38E4RvBkDWKvbfRqAAQ9SbPEAmnWoWynU7QetPTMSy4pOLHqtcVBB+oSFjuzD4f+SULy1sUJutHlmtbPpcaaU9Xnp+Q3bYmnSjHUUTR5RgJE4YOB6Pxm001w68Oy5t6So0RgJqcVEzOh5GSZVFh/5s4D4Wf7AMdVgyutcaM96p0U+wywBSwNSf2ZK8w7as4wGkvxDABfJEPNgLHYckxZr+7j6xmQfn1TjA0yeS9nu17FJ9Z+wWPrC61Y3QNPwh0a4Wl+5HHc8ZWUk56fMj1LreWiV+BuMc8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x38sd3DM6qI2oPnvY4RHITfkGhG7/yq8/BovpYcotxI=; b=JlMW6BQWtrS+tgp2DTJSdjOdUd6jO9itOg+4G2eXxvB0n/R7/AAya2WVmiNOM8tOsoas27S2QM4PmNrrqOVMl5zAtEqrXbG4QEENFoaY6I3v6OXwPuhIs6gCDz720HsywVLrP/cqFDoPiTEGcjqV+ANTuX6HhCIlUHxGQfl/u9ORQHURyH8oclWb5RZoPWgcqPiQK3MvyYmja6vBrZfj2vYpS9uqroqLbd0BgU9i1XGt+IH5rKxVbOmeBa13bZq3SvYj/RmATnK5JgO0p1MKtTq0YBxZW6KtbAh++gGGww/w7o6rs9Ms8c20FIdOnF6gNCvi+YQE3hUPLBPRu2Kn8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x38sd3DM6qI2oPnvY4RHITfkGhG7/yq8/BovpYcotxI=; b=J15t0cdRZ9oFRF0RWgcw91gjDQNAHGUCDywFChb5772JcHf9k51nVd7KMl5VLusphkbUqIWNcaWwqLOIya1K2e/MxKjnbUEE1zPaEcHalFJ33+WGd+F6mY2Qn0XrilaptSvrMI/8OBsFyV5QgJPGDpQ2H6x5agwiZxoYrREBfPQ= Received: from SJ0PR11MB5006.namprd11.prod.outlook.com (2603:10b6:a03:2db::22) by BY5PR11MB4242.namprd11.prod.outlook.com (2603:10b6:a03:1c1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Mon, 12 Jul 2021 06:31:03 +0000 Received: from SJ0PR11MB5006.namprd11.prod.outlook.com ([fe80::2005:352e:369a:e5f9]) by SJ0PR11MB5006.namprd11.prod.outlook.com ([fe80::2005:352e:369a:e5f9%8]) with mapi id 15.20.4308.026; Mon, 12 Jul 2021 06:31:03 +0000 From: "Jiang, Cheng1" <cheng1.jiang@intel.com> To: "Pai G, Sunil" <sunil.pai.g@intel.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "Xia, Chenbo" <chenbo.xia@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>, "Yang, YvonneX" <yvonnex.yang@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost Thread-Index: AQHXYfMypZzXJBgBeUKN6fjBolWyqqs0mIKAgAMRdoCAASQggIAGKvAQ Date: Mon, 12 Jul 2021 06:31:03 +0000 Message-ID: <SJ0PR11MB5006E281BACC1AAE0D91008CDC159@SJ0PR11MB5006.namprd11.prod.outlook.com> References: <20210602042802.31943-1-cheng1.jiang@intel.com> <20210615141513.16163-1-cheng1.jiang@intel.com> <20210615141513.16163-2-cheng1.jiang@intel.com> <BYAPR11MB3814410FE0088A153C6C0F89BD1C9@BYAPR11MB3814.namprd11.prod.outlook.com> <SJ0PR11MB5006E0635DA584B5BFD106E3DC1A9@SJ0PR11MB5006.namprd11.prod.outlook.com> <DM6PR11MB3819FA69AE29A085EAD665DFBD199@DM6PR11MB3819.namprd11.prod.outlook.com> In-Reply-To: <DM6PR11MB3819FA69AE29A085EAD665DFBD199@DM6PR11MB3819.namprd11.prod.outlook.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fb4a1413-aaf8-423d-d852-08d944fe9f92 x-ms-traffictypediagnostic: BY5PR11MB4242: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BY5PR11MB4242AD4A02464B6E3E3BE16ADC159@BY5PR11MB4242.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KDx7n1SFcLNgmagWJh/Qi54VjxhZur75Ic0tatIVCPJEG3+uVAMRNoT2DMcP38YOIHQN4M+4y7OwW8UzWzfHMGvnQrq6r7Qo41C4vuVyarxBdbQ+9MRuGBV5WKa99rhEydC+ALkpEMf+Tq0WN+AItow2REjnZW/ccmY3pyPTkZ8uR3ZARvtO+6dLHWJ2AXeTSAVM/qo6DDonRzSENZ/Il5ca42oDtvOeZmH2RpCKWNZJFaXAUWygeM9rQ0yibIGMOgddKuPfQqi7wr0Ee6ovQeJLf2li03wgCjtw9Ynfe5Nl+p9ln2YDpQ1R+2k/KxdKOzNT4eUEoH2iFN93NZbVTnqeaovwKy+esO5ClOSWlbl1DbW29tAzkm9v0yQJpNFyQRiOZb5dqZ+qqQi5+xpdPuFtlFMC+rYixX9wp9kjT6btndVCEC9IY5qeY7kpIqtZqFGhdm8mScWt8WdLnvY4GcZf4TEeMjxceinlyv3Bbv/9lclPYHc1IdnYgZNLEcsqL1TV+WXJG83WxoAubnVsposZuqxZy+99sMjScQrgw78YTdZEdqRGpwRl6Ad5HxEkadMqfTCZmEWiMPyL+F2ZsMSn5MU0vWpVGXOg2/GBG0ecyFa11gFWj9D/Ru7+81sUWoEMlZoKiQS7SZTXjBhOwg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5006.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(346002)(366004)(136003)(396003)(76116006)(66476007)(5660300002)(7696005)(6506007)(4744005)(8936002)(6636002)(26005)(66556008)(83380400001)(66946007)(66446008)(64756008)(2906002)(478600001)(55016002)(53546011)(4326008)(186003)(52536014)(71200400001)(86362001)(38100700002)(107886003)(122000001)(54906003)(316002)(110136005)(9686003)(8676002)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yB5+rVHO8RxOAUvHnmeDeUzm/ajkwtA+k9QlsM3NdRa0j8BIEMFHSvyKorCv?= =?us-ascii?Q?R+cuSVoDmR4vau98GAbOyyhLo+6HWwgzQIH2hNRX/f8W9qQcfS82HjepCHbZ?= =?us-ascii?Q?nNhmqYOz/zCkqEp5wXr0tp5WQRqNloZa4s5hSvGBTqaBToAnh+bntAv/7VHi?= =?us-ascii?Q?Z5LJohfMmE1XK819IIXZw2Xoqz0KOlmt7cEDHC3RmXkjviI6DzUWEN8GQ0JD?= =?us-ascii?Q?mJfrBcVj752uuiNH2B5KDv5IK0k6GiXLEZyUoEHS1BuK2ShyZiA69yBmzQXZ?= =?us-ascii?Q?SHkUkyE6USJxv3uD7hS5BxKaEvFS1ZpnR0/S5t7kXifObc6pz1jOnCZta5G4?= =?us-ascii?Q?6tQfKPQGYS78+WP/VzPAi8+pTriFfa1mKRnvlVsAqB4arcIv5YjsT87FKQoS?= =?us-ascii?Q?FSW2VCpmG9zZrbJe4McQtalnBHMUUTAA6rDW7bB3s8Ypda3Rax/V8Oy/OqDB?= =?us-ascii?Q?1fSt+d8wqXO2i81G4fJUnqNNgV1tNITkFo7uzfyCrlPnCRoerAa7k3En1y9U?= =?us-ascii?Q?tPTEAEldgHf2L4Z3+HMuH8jjwRb4QfnNkmaCk8Vp0Il+fQyX0mx+rt8wL/zo?= =?us-ascii?Q?Zewy9/lePEBEIlTiSI0K2jOi6C4giBo4reFplcQVaFh0bBx34NRoN6xUJN7V?= =?us-ascii?Q?UYu93q8SInTYgOgaRiwm/rv26n6vVsSAno0JUo3aUnst2B7xE2ANf6tTwwz9?= =?us-ascii?Q?t6SZN90/p2ph520XuFzJvpESMjuztRQwp6qzDfmyIkza3DT5HDTXFpLdS59a?= =?us-ascii?Q?clJusqmEmwfaWYJ6FYMdIT7KiKPHn4wRGslJCEPoWjneKEOz5ZRAryF0vw8U?= =?us-ascii?Q?iB9onH0WXmWAO5SthBqZLgLFwi0jtqGsL+QLAWpATrkW1I+DV2ixjKv4wO9J?= =?us-ascii?Q?bGE8I2p6fWpHtP/c+qiiyQGK7wPqujMFTSmTFr0KkL/AcuHZ5ARRd1gfUv5p?= =?us-ascii?Q?7eAlUEOTYOEPmX4aAnn+ELkEpydDq6aK6en5HMy3flzi0Ks6KUoH6pKkp/VQ?= =?us-ascii?Q?2T1e6QGSAbbLSYxOj7wRmuwEYpTLKikUTv73cFhuOZ/MzeFtUYMEA+NLvgyb?= =?us-ascii?Q?TgzfUwszvnSlVhhpv4p+yPqutS+OUEnzDuxwFiyZadA+FHIVF0OFDn82SFRT?= =?us-ascii?Q?M7DN7J5rRpx2aG+xBgjZR/sM4EYEH7wlRuryy/0LLhB61Xocn9WP6171PS+P?= =?us-ascii?Q?NSmuA7MWYj/tUCt1Kh+7jVf89cZ1sDKx48eAW2K4sKWhReWyMT7D54LKzsMa?= =?us-ascii?Q?c0SBwt1t9ohxBJNcWknkhxihDd+CaeQxoi98qQO51rquZazr7+IZBrdoCPLN?= =?us-ascii?Q?MeQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5006.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb4a1413-aaf8-423d-d852-08d944fe9f92 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2021 06:31:03.7127 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hZamaMMFsFV7DYQPpaFv+lmajWGLHI/w0QRB3U2CnM+GyitZoQvoqtaEZolo5oeTnBugZGueeZIPPysxOHoARw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4242 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi, > -----Original Message----- > From: Pai G, Sunil <sunil.pai.g@intel.com> > Sent: Thursday, July 8, 2021 3:15 PM > To: Jiang, Cheng1 <cheng1.jiang@intel.com>; maxime.coquelin@redhat.com; > Xia, Chenbo <chenbo.xia@intel.com> > Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Yang, YvonneX > <yvonnex.yang@intel.com> > Subject: RE: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkt= s in > async vhost >=20 > Hi Cheng, >=20 > Repsonse inline. >=20 > <snipped> >=20 > > As for this one, I'm not sure why we need have the loop in the applicat= ion. > > The function of this API is that caller need to drain all the inflight > > pkts, it should be called only once to get the job done. > > Don't you think? >=20 > Perhaps yes, but my thought was to provide application the flexibility to > change the DMA device per call to check_completed_copies callback if it d= id > require it. Got your point. So you think this API should be defined as the unsafe version of poll compl= eted API, right? Thanks, Cheng >=20 > > > > Thanks. > > Cheng > > > > > > > > > + > > > > + return n_pkts; > > > > +} > > > > + > > > > > > <snipped> > > > > > >