From: "Dooley, Brian" <brian.dooley@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "gakhil@marvell.com" <gakhil@marvell.com>,
"Power, Ciara" <ciara.power@intel.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Subject: RE: [PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag
Date: Fri, 1 Mar 2024 16:08:08 +0000 [thread overview]
Message-ID: <SJ0PR11MB5056BE7EED381721D9EAE334835E2@SJ0PR11MB5056.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240301155251.5101-3-arkadiuszx.kusztal@intel.com>
> -----Original Message-----
> From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> Sent: Friday, March 1, 2024 3:53 PM
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Power, Ciara <ciara.power@intel.com>; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag
>
> This commit fixes a legacy flag, which was placed in a file that may not be
> included in a building process.
>
> Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
>
> Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> drivers/common/qat/qat_device.c | 1 +
> drivers/crypto/qat/qat_sym.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/qat/qat_device.c
> b/drivers/common/qat/qat_device.c index a27252ea4d..500ca0f308 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -31,6 +31,7 @@ struct qat_service qat_service[QAT_MAX_SERVICES];
> /* per-process array of device data */
> struct qat_device_info qat_pci_devs[RTE_PMD_QAT_MAX_PCI_DEVICES];
> static int qat_nb_pci_devices;
> +int qat_legacy_capa;
>
> /*
> * The set of PCI devices this driver supports diff --git
> a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c index
> efca8f3ba1..6c7b1724ef 100644
> --- a/drivers/crypto/qat/qat_sym.c
> +++ b/drivers/crypto/qat/qat_sym.c
> @@ -19,7 +19,6 @@
> #include "qat_qp.h"
>
> uint8_t qat_sym_driver_id;
> -int qat_legacy_capa;
>
> #define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
> #define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"
> --
> 2.13.6
Acked-by: Brian Dooley <brian.dooley@intel.com>
next prev parent reply other threads:[~2024-03-01 16:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <v4-00020240229093007.32298-1-arkadiuszx.kusztal@intel.com>
2024-02-29 19:14 ` [PATCH v4 1/3] common/qat: isolate parser arguments configuration Arkadiusz Kusztal
2024-02-29 19:14 ` [PATCH v4 2/3] common/qat: decouple pmds from the common code Arkadiusz Kusztal
2024-02-29 19:14 ` [PATCH v4 3/3] common/qat: fix incorrectly placed legacy flag Arkadiusz Kusztal
2024-02-29 19:19 ` [EXTERNAL] [PATCH v4 1/3] common/qat: isolate parser arguments configuration Akhil Goyal
2024-03-01 15:52 ` [PATCH v5 " Arkadiusz Kusztal
2024-03-01 15:52 ` [PATCH v5 2/3] common/qat: decouple pmds from the common code Arkadiusz Kusztal
2024-03-01 16:08 ` Dooley, Brian
2024-03-01 15:52 ` [PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag Arkadiusz Kusztal
2024-03-01 16:08 ` Dooley, Brian [this message]
2024-03-04 7:10 ` Akhil Goyal
2024-03-01 16:07 ` [PATCH v5 1/3] common/qat: isolate parser arguments configuration Dooley, Brian
2024-03-04 7:08 ` [EXTERNAL] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB5056BE7EED381721D9EAE334835E2@SJ0PR11MB5056.namprd11.prod.outlook.com \
--to=brian.dooley@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).