From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B68D045656; Fri, 19 Jul 2024 17:15:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9994540DDB; Fri, 19 Jul 2024 17:15:00 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id B52D04026A for ; Fri, 19 Jul 2024 17:14:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721402099; x=1752938099; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0Xctld4G5dHBm8mVtiPOL2Sr1ZOxUHGX0mIXry4sCBk=; b=hrTbrxewOPGsLcRz9dvOq3ruWReHgSRoWtMIEy/y9cpmePFSHgAEWGBx 9jI2p7mwgqATr8TedjePCKCHHAbmb19udP7t5iVgL+zVWrPHpHwrfW2IQ 0pAEoahXB7UkwZojml9hQ7vdlQN15KyqTOAVzg+1w3qCkRWQlNuCTtNT6 l3WvG8F8V1gZhyWdhPmE6v+puYhCjAi9eAAve7uS7iFY1l1vFxPJb1oIW Il/hFVnnbw+aaoiKq35xs7ACiAb1O2XgFjvUMSLxS0ucDCNPD3T53qNXf C7dAf/FJCWPNBb91Iwo4z+2on3jD/9UB6hNTqKdMQQwQcC8CqNVXbTIHQ Q==; X-CSE-ConnectionGUID: iL363UDsRy6pgEMHekhM3Q== X-CSE-MsgGUID: JruxZjsDQVyZjtwoL7Gpkg== X-IronPort-AV: E=McAfee;i="6700,10204,11138"; a="44442393" X-IronPort-AV: E=Sophos;i="6.09,220,1716274800"; d="scan'208";a="44442393" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2024 08:13:57 -0700 X-CSE-ConnectionGUID: ASn/zdpmQWCOf41s7OY9tQ== X-CSE-MsgGUID: 2ZuT9whtSX6Q9tfw0H4cxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,220,1716274800"; d="scan'208";a="50829772" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jul 2024 08:13:56 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 19 Jul 2024 08:13:55 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 19 Jul 2024 08:13:55 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 19 Jul 2024 08:13:55 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 19 Jul 2024 08:13:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vAvFBK4Slg9c0UP6sBNXqsDT5GIdCzDncqKeBbCVuEcBDwmil1gE1KFZh77J2olPZomA6Fu3TNkPkqq9DnaT+MozwfP//oUtn3Wa1y/FHe+bAHHrNvcky7Y2DR/UxrJWFxyMj7tNhG1yyaamCq64/nm4Gm+iIfJsibZYX0tWqvELN0yBPlPavROvJPvIiAIFZ/TqGFvOGo5t9W/8WrENyvxuS+2mzT/EvTyp9XegnZwnLX4zpq7eujBKXqSPljjWFrT00SLNGa0lTU+4chvksfbAqkau3WnMzJQs3jVOYvAP+/3jPOvsCPZNtJWnRVAP7DQyiadC+N6jXRb2mskyqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1JpPhLNoYEKozWeqFAcnvYbwr5BThKjH9eO4rYjaaFI=; b=JZfA6l2NU9OP/liwxRYb2vUtcejtGmiU87AjLwVprwUUN+GQ8o5YFg+hJsMbRpCbqIVjZhvcnUekhkuL5YrYbz142/LmSQIPvhobJS3T6P/kFq+721jeQphdMTtxlsO8R7+/SjagtRIUTshn7w7Jk/4Kf6+mFiZcEI/IKIsJsetI6hjZEFCgpy6QudYVb1AcZhoYweepSB4UV0KwFie7tFp2ZE4UeOPPGnKol3h4Ze0NmGQ/86FhoLGnYHh4To1NaC3YJF7A+7AoDfhWxL4m91E+nqQRBdiU6XpjSKiYNFE8lYer7a82xbrMCb3txkjCWZhhIjoY670S4DH1sC55WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5056.namprd11.prod.outlook.com (2603:10b6:a03:2d5::6) by MW4PR11MB5799.namprd11.prod.outlook.com (2603:10b6:303:181::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Fri, 19 Jul 2024 15:13:53 +0000 Received: from SJ0PR11MB5056.namprd11.prod.outlook.com ([fe80::4f35:279e:a725:ad08]) by SJ0PR11MB5056.namprd11.prod.outlook.com ([fe80::4f35:279e:a725:ad08%5]) with mapi id 15.20.7762.027; Fri, 19 Jul 2024 15:13:53 +0000 From: "Dooley, Brian" To: Akhil Goyal , Suanming Mou , "Mcnamara, John" , "Ji, Kai" , "Kusztal, ArkadiuszX" CC: "dev@dpdk.org" Subject: RE: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption Thread-Topic: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption Thread-Index: AQHaefNLOu/v4ORS7kShN9EvoLAyebE/LHyAgJGaR4CALN6kAIABP1+Q Date: Fri, 19 Jul 2024 15:13:52 +0000 Message-ID: References: <20240105100104.908543-1-suanmingm@nvidia.com> <20240319114623.1137757-1-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5056:EE_|MW4PR11MB5799:EE_ x-ms-office365-filtering-correlation-id: f37fe038-2860-4101-f276-08dca805669e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?xVBIuJ7KbFeTeg9sSrQa2QYooAX4gpopZ0sqiMUSTzcnHyr55Kbjh2PD99ZA?= =?us-ascii?Q?txPv5uiBjM9PqcBDSsRCkByyRAWEi2J1/gRUKtYVkMikIAFE4vavpzyDw/AW?= =?us-ascii?Q?akc70A4AH8XfQ34O1p6cF5wqYpM4YUYTAQuxdE5WcQm9l5oGo9Yd+Ptz0ktH?= =?us-ascii?Q?q4ITk84XCcgfZIRoFXVaFAzdHHYpQFUXvuIA+lG80Dm/0Ge/Y30CiZUjYhgm?= =?us-ascii?Q?lx4eRduObxOeVNEeRn/e+rZvnn5/K+tZ8wmoyfbBJtzRhUcvI4DBn+vpUZv3?= =?us-ascii?Q?obUhPStH/eH2pMtZguDKAzYBF56gBqZJIbG2887iEFuaXw7S8J2z7tXwXW7m?= =?us-ascii?Q?JQ7ZO6I/rcDdcFmCH5or8IrlwW/7AEIDNvMMC5VPqKfvspQFKileNE7IMrd1?= =?us-ascii?Q?99JYhstqN/+w7ewi0NVrmFbmicOgBmo3y5TdFvK7HgiexSj6Xng6CzhugGLe?= =?us-ascii?Q?qkit67/cvZH7yAwvHV4hYBRs4/eGMgD/4ZZzecnZ1UX9t/ey3cl1Qy2J3Zmv?= =?us-ascii?Q?J40M4C9nDChb7THAclUusrg7JtVqVqtaUx20PwLdixkG55tAG4Nifb+N7SYO?= =?us-ascii?Q?P6hzsyi5QwaThGNHvG9BoDal0BWTgUkujc+Lfj+CoYNda0PhzQV9L6/Z0gKk?= =?us-ascii?Q?J0EU9XZVvoPBHl4CpqCPnQp8rCTZKP+a2Ds/BbeNAQANvq41xKfbZZs3G871?= =?us-ascii?Q?m/nFplkUm3MR32CKq9tFe+4IuSMt1XiY3yem2Q6I3vzUR5/+o8LhVk72BQJO?= =?us-ascii?Q?tV3ff+Fbr1MvL6dXL5h4pyqszzX8u+WJfBWyO9TTV4tpch0iFDJ7RdwZb0ik?= =?us-ascii?Q?x6VgVXMbyXvfNuj91C74gv8LHgMQ82xWzP7rq/A1L4e03tnAgTG37Dy6267b?= =?us-ascii?Q?8N43pd/8VgqWSoHEvzO7vPoeQbPaIFb3qM3JfsUntRESdTzvYclHg+56pxU2?= =?us-ascii?Q?gznqv7z676Wh4CMYjetU9qTGeh/luG6fbS68HaNlfuQ7TaGak60ZoZ9tNcf1?= =?us-ascii?Q?zzWzB43FWWnWPi17RcucMU96ABYz8hhyuTriRexKVLXKkuRrmWxbjsUzl15s?= =?us-ascii?Q?qOlnb5vIzNjTVmUhbIowjKqaq48dAz+5vvhAAkRhnv0J9XuNui0y4bNSq6UA?= =?us-ascii?Q?N4isCKuvVd6byaGyxJC8fYXp3+Z7qL55RUjLw3F8pBJ1AwSjg0qcscstVBCr?= =?us-ascii?Q?tbDQZVooJHuOGKJNI+0epKnIP/Bi0QXs7CurqvwUsrp0FDc/8odjNckEN8Tm?= =?us-ascii?Q?b2hj7wlyIP+7fCNrSwyh5NKEHh/56huhCT4ol1SByapbdFM++5ZDxwq8eQCm?= =?us-ascii?Q?4JI4iYvC1AjN3s+ToE2sripwPPhQ/Lm9KBaiowJugPAfF3NqnY4B4Q2wZ6Jz?= =?us-ascii?Q?kT//Z8k=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5056.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Xkh0flrCBrkeQLNPxh7+8n2j2dDTZZGFrI9rKC5TuprbxaortfMJv28tmL5T?= =?us-ascii?Q?YEFS3oc2u4dpJ2JpFngoPzEXmQ0xyUJp3PjjKf+OmZ/68djGA3rfz3NajwXh?= =?us-ascii?Q?I4P+5dpIv1KPGURGlwckfaPM8sPqZ5BAFGFEJbCLGk+FaU0hxUxZTsHTFLWr?= =?us-ascii?Q?WrOKvb3+7fD8w3HHa6OqZURNBn+gtB29zB+ZGgXa+KQfGC0YjLwIREfBYb9q?= =?us-ascii?Q?QIitbQh7A3uedkZJuH0iQQc2DHwQrmpaocFR7b+do6zBRsxlK3jLKU9b42D0?= =?us-ascii?Q?uJunyeMBO/54chkca17vN2CeVyQV/YAnFcZWIUatsYKSXIWU6h3jGTGbJozj?= =?us-ascii?Q?fHUijbLgP9rQ06UeQyr5wizLJftTbTzXNHxbVq/bnjd77ubvQ7iGpM5J9nNQ?= =?us-ascii?Q?4/xeWcLxu1bJ5PSnI/GZ0huyLSVKgl+j5vC5XYZd382cw38CB0wBusk1rBBf?= =?us-ascii?Q?dbO+315RJ1NsutB9Q8qbdKr/BNiJCFOavIm6vMy6ZI6otGhEedBQZp4KsMkF?= =?us-ascii?Q?x7eELR4QHVwMH1K81+f5nEL8k2whzgOoHRqyqAXLaB8ZCmBAD2L8weSGtKBY?= =?us-ascii?Q?yC8Raq6LfWGQkyaK9gfcCTdRpkF+hBE7AOsB0H3sTpXx8TiaWa0BfHQUnEPW?= =?us-ascii?Q?ppKlPecz2QwG2X1ncn+abjWb/qM2uJz8zNBV8DwAA5S2FrVSdJUUpSI9dVVY?= =?us-ascii?Q?ynC9J8uqBVszV706FNS945EtM6DZYWxD2HyNOEdWafIElhvMDj4oHO8BTV6g?= =?us-ascii?Q?YwTu9w+ucFkp3wLS641SjZgdJPLhRCbLwZIfpMLB888QLfhc48O7zrE3GlUP?= =?us-ascii?Q?fRR+MjRE6RDDoO5Geql3rhZALqvb3sQbfY174eHUmxIzzaYIHzgzei3N5nEN?= =?us-ascii?Q?yKC2UHW7eq0dqeYUosv7sPkmy+a4GQ7wixHwU9a/QQLL39hasiNUbHiAv+wt?= =?us-ascii?Q?m3A89GsnLjVi+HL8ZKhQ/R9/cRvjyUvH1Ko/TCI4/6tU2ErXvVACZpWD6R1a?= =?us-ascii?Q?NbJcNP2VNnQ/eFZqd4IVMIYCQ3fZbkICeLx6Zew42ga3LnnANqbTCxPo8+0a?= =?us-ascii?Q?UX3kpg2xjzJhjREDiYOiv91WXlPEJjnNkSLkw61TD+7k3/U6gWySVh8G08hg?= =?us-ascii?Q?3+YrZiVZs7/L9yNQmKa+OlV1Cep2c/013MTY6Dm7w4LHcF1uZNysd0sie+GR?= =?us-ascii?Q?MnpJ2K8Rexhj2jFj/axx0Jo0XtvgRe7g5v3wM56tXbO6cAlfnhWVBh4/Nv6L?= =?us-ascii?Q?zECrDHP1E9W4/ZSnzf+N4zXxwYSYFfxtuuRi0gZm4xaWfIZPVDWRufWozWk7?= =?us-ascii?Q?/p3sNc2ynERIaSPzd1T2HuXDXfpdfHEoZNv6izPdTGmWxqr9ctN5ioIJAtE4?= =?us-ascii?Q?YyhqPuPZ3OqE4OyAH60ajeLMGawqvTp7d1ieVOkzdvlvxCqC+C7n7843qE6L?= =?us-ascii?Q?v2mEuYWtWdv77a7qtq3yUnYO79ceogIBUcMAExNiSZ7lJa+nyMc8+eiZoUfG?= =?us-ascii?Q?QpDQ7JOn+GLuS2Whg5Tf6hnmdhi2Av8/UHlzIAOLJaoazoGaMVc1HSK0GCDj?= =?us-ascii?Q?vGtJBAw+CydGSxkEPgMXgJwWVYkAOwS/IM/Mzt0z?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f37fe038-2860-4101-f276-08dca805669e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2024 15:13:52.9251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DHUvbkDW0V1XanKfqZ7wu2p5T/kdij01LLs0jRzeOBYDFR82bEcL7cXkU654xXjcV3IZJo6Z+1kBNSeeGP7heg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5799 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Suanming, This change looks ok to me. > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, July 18, 2024 8:57 PM > To: Suanming Mou ; Dooley, Brian > ; Mcnamara, John ; Ji, > Kai ; Kusztal, ArkadiuszX > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] app/test-crypto-perf: add throughput OOP > decryption >=20 > > Hi Brian, > > > > Since Ciara is no longer available and you are the new maintainer, can > > you investigate this patch? > > There were some concerns which Ciara highlighted. Can you check? > > >=20 > Any update on this patch? >=20 >=20 > > > > Subject: [PATCH v2] app/test-crypto-perf: add throughput OOP > > > > decryption > > > > > > > > During throughput running, re-filling the test data will impact > > > > the performance test result. So for now, to run decrypt throughput > > > > testing is not supported > > since > > > > the test data is not filled. > > > > > > > > But if user requires OOP(out-of-place) mode, the test data from > > > > source mbuf > > > will > > > > never be modified, and if the test data can be prepared out of the > > > > running > > loop, > > > > the decryption test should be fine. > > > > > > > > This commit adds the support of out-of-place decryption testing > > > > for > > throughput. > > > > > > > > [1]: > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttp- > > > 3A__mails.dpdk.org_archives_dev_2023- > > > > > > 2DJuly_273328.html&d=3DDwIFAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDnL7Si2 > wl_P > > > RwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DeTj0O7iYH- > > > xiTQ6dNUZpsOXPqnyC1O_- > > > > _IKt0j_yQ_N__vy0wIBLb_QyMQtodUrr&s=3DeDz_NLjqkUH2cYMilKEtdWImOPj > 5f- > > > CVKV5UW8P9frk&e=3D > > > > > > > > Signed-off-by: Suanming Mou > > > > --- > > > > app/test-crypto-perf/cperf_ops.c | 5 ++- > > > > app/test-crypto-perf/cperf_options_parsing.c | 8 +++++ > > > > app/test-crypto- perf/cperf_test_throughput.c | 34 > > > > +++++++++++++++++--- > > > > 3 files changed, 41 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto- > > > perf/cperf_ops.c > > > > index d3fd115bc0..714616c697 100644 > > > > --- a/app/test-crypto-perf/cperf_ops.c > > > > +++ b/app/test-crypto-perf/cperf_ops.c > > > > @@ -644,7 +644,10 @@ cperf_set_ops_aead(struct rte_crypto_op > **ops, > > > > } > > > > > > > > if ((options->test =3D=3D CPERF_TEST_TYPE_VERIFY) || > > > > - (options->test =3D=3D CPERF_TEST_TYPE_LATENCY)) { > > > > + (options->test =3D=3D CPERF_TEST_TYPE_LATENCY) || > > > > + (options->test =3D=3D CPERF_TEST_TYPE_THROUGHPUT && > > > > + (options->aead_op =3D=3D RTE_CRYPTO_AEAD_OP_DECRYPT || > > > > + options->cipher_op =3D=3D RTE_CRYPTO_CIPHER_OP_DECRYPT))) { > > > > for (i =3D 0; i < nb_ops; i++) { > > > > uint8_t *iv_ptr =3D rte_crypto_op_ctod_offset(ops[i], > > > > uint8_t *, iv_offset); > > > > diff --git a/app/test-crypto-perf/cperf_options_parsing.c > > > > b/app/test-crypto- perf/cperf_options_parsing.c index > > > > 8c20974273..90526e676f 100644 > > > > --- a/app/test-crypto-perf/cperf_options_parsing.c > > > > +++ b/app/test-crypto-perf/cperf_options_parsing.c > > > > @@ -1341,6 +1341,14 @@ cperf_options_check(struct cperf_options > > > > *options) > > > > } > > > > } > > > > > > > > + if (options->test =3D=3D CPERF_TEST_TYPE_THROUGHPUT && > > > > + (options->aead_op =3D=3D RTE_CRYPTO_AEAD_OP_DECRYPT || > > > > + options->auth_op =3D=3D RTE_CRYPTO_AUTH_OP_VERIFY) && > > > > + !options->out_of_place) { > > > > + RTE_LOG(ERR, USER1, "Only out-of-place is allowed in > > > > throughput decryption.\n"); > > > > + return -EINVAL; > > > > + } > > > > > > Not totally following some of this, why do we only want to add this > > > for OOP mode? > > > > > > For example an inplace command I can use before this patch but not af= ter: > > > ./build/app/dpdk-test-crypto-perf -l 2,3 -- --ptest throughput > > > --optype aead -- aead-algo aes-gcm --aead-op decrypt --devtype > > > crypto_qat --aead-key-sz 16 > > > > > > I get an error; > > > USER1: Only out-of-place is allowed in throughput decryption. > > > USER1: Checking one or more user options failed > > > > > > Do we want to always force the user to use OOP + test vector file > > > for these throughput decryption tests? > > > Or should we just add a warning that the throughput may not be > > > reflecting the "success" verify path in PMD if using inplace and the = dummy > data. > > > > > > I am not sure. > > > If we do want to add the limitation on the throughput tests, these > > > changes I > > think > > > are ok for that. > > > > > > Thanks, > > > Ciara > > > > > > > + > > > > if (options->op_type =3D=3D CPERF_CIPHER_ONLY || > > > > options->op_type =3D=3D CPERF_CIPHER_THEN_AUTH || > > > > options->op_type =3D=3D CPERF_AUTH_THEN_CIPHER) { > diff --git > > > > a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto- > > > > perf/cperf_test_throughput.c index e3d266d7a4..b347baa913 100644 > > > > --- a/app/test-crypto-perf/cperf_test_throughput.c > > > > +++ b/app/test-crypto-perf/cperf_test_throughput.c > > > > @@ -99,6 +99,26 @@ cperf_throughput_test_constructor(struct > > rte_mempool > > > > *sess_mp, > > > > return NULL; > > > > } > > > > > > > > +static void > > > > +cperf_verify_init_ops(struct rte_mempool *mp __rte_unused, > > > > + void *opaque_arg, > > > > + void *obj, > > > > + __rte_unused unsigned int i) { > > > > + uint16_t iv_offset =3D sizeof(struct rte_crypto_op) + > > > > + sizeof(struct rte_crypto_sym_op); > > > > + uint32_t imix_idx =3D 0; > > > > + struct cperf_throughput_ctx *ctx =3D opaque_arg; > > > > + struct rte_crypto_op *op =3D obj; > > > > + > > > > + (ctx->populate_ops)(&op, ctx->src_buf_offset, > > > > + ctx->dst_buf_offset, > > > > + 1, ctx->sess, ctx->options, > > > > + ctx->test_vector, iv_offset, &imix_idx, NULL); > > > > + > > > > + cperf_mbuf_set(op->sym->m_src, ctx->options, ctx->test_vector); > > > > +} > > > > + > > > > int > > > > cperf_throughput_test_runner(void *test_ctx) { @@ -144,6 +164,9 > > > > @@ cperf_throughput_test_runner(void *test_ctx) > > > > uint16_t iv_offset =3D sizeof(struct rte_crypto_op) + > > > > sizeof(struct rte_crypto_sym_op); > > > > > > > > + if (ctx->options->out_of_place) > > > > + rte_mempool_obj_iter(ctx->pool, cperf_verify_init_ops, (void > > > > *)ctx); > > > > + > > > > while (test_burst_size <=3D ctx->options->max_burst_size) { > > > > uint64_t ops_enqd =3D 0, ops_enqd_total =3D 0, ops_enqd_failed > =3D 0; > > > > uint64_t ops_deqd =3D 0, ops_deqd_total =3D 0, ops_deqd_failed > =3D 0; > > > > @@ -176,11 +199,12 @@ cperf_throughput_test_runner(void > *test_ctx) > > > > } > > > > > > > > /* Setup crypto op, attach mbuf etc */ > > > > - (ctx->populate_ops)(ops, ctx->src_buf_offset, > > > > - ctx->dst_buf_offset, > > > > - ops_needed, ctx->sess, > > > > - ctx->options, ctx->test_vector, > > > > - iv_offset, &imix_idx, &tsc_start); > > > > + if (!ctx->options->out_of_place) > > > > + (ctx->populate_ops)(ops, ctx->src_buf_offset, > > > > + ctx->dst_buf_offset, > > > > + ops_needed, ctx->sess, > > > > + ctx->options, ctx->test_vector, > > > > + iv_offset, &imix_idx, > > > > &tsc_start); > > > > > > > > /** > > > > * When ops_needed is smaller than ops_enqd, the > > > > -- > > > > 2.34.1 Acked-by: Brian Dooley