From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8539A0552; Wed, 1 Jun 2022 04:46:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51F9040A84; Wed, 1 Jun 2022 04:46:21 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 56BB940150; Wed, 1 Jun 2022 04:46:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654051579; x=1685587579; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FOIddG5JWGoeJXvuSyEKj3/ICFj1YDHxafalBHNZRi4=; b=ngBhDKYqCQLaxu4QcU1ThUdALUZroAny5XNUXYZ8jW5nBDljb4DG+t47 GFAmFWtpFcPpC2nypgBx7oy8uppD9e2UwZ30a051x4GzVv22cbR3tuz0E UHwT6WxvwqmT4XZLslFSVCTTUbXc0NfPTJIz4lXMDMPWq1KnYrtZWSL7Q Hc45wmv/m2QXNk6lUJ4/0lxQcfnyvizTmzvGLOt55UG1hERfydZTmZAPa ph1M9XJjvpmocVdbR4CMHt5hnvPDAOoeGvh/BWRPz1nFUwJt/o1t5rCG6 Of17GH/LGoiq2eKE/FSxnPX7UPf8QWr00x4I8VCbxOuSa1iRx9Fw9NK3/ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="257522753" X-IronPort-AV: E=Sophos;i="5.91,266,1647327600"; d="scan'208";a="257522753" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 19:46:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,266,1647327600"; d="scan'208";a="706859272" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 31 May 2022 19:46:18 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 19:46:17 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 19:46:17 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 31 May 2022 19:46:17 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 31 May 2022 19:46:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEME1uJRFTOESbsJ1PqCP9hGiShtWXuENlkKg3Amm35qmdUEYwOKkeI1nlisfwJ5cwb/9BDjTSSa92Pw16zhy1VqYcRjMjUI/EW0rl/mJeLustJ7adaG7m913C9dZm4j1vEEfc7N+5HuWzhznNLlE15QfVEfti6Oawc3blOP4ngDZ6msxztvNHPKcawQtjGqowUYC278w6Db4pS6V30d7UfCGoEdz0SvoqEw1JgFmKKbwwrHxZ0FJaI/kgFvVLv3rLo4rr1udRd4Ou2WrnJgl9awqwagBI/3DwCw3WRRAwLjX3YGEgZow2PICTHSQjwkHCNc0e3rFd/2bxW+YwZjDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RaE89bHdYPLSDh1tjjzY3cZ4AaMHtBozIhzDN06H35E=; b=MAfdQ6AyTBzfSXT0CwalYMwbzQcuKVtfu+JPQx6bJHGAVgaIuzxXfoQ/ZoSogZWUvKMQC3jsmj5kpZL1oVCBer9QVqePhQFKSB206iIS3XmXopPKJnt/2AYyES9A/4CSKDVh5+fEK7p+Rf8SpN+JBd6HGZRRqXVdraa52uwfDmZILwsmyWPMmT6/lwp/1kC5PpyKcf9Zdn4emKOrnap5kRrjCFMLli5xlBCauTHgDzMS2cqjAv46tm5oeyVUiRLad4fa6NqD3FA28an8SZ6UdwA5HSavTDQ7lK0NVSb8MyUQfPYINjsq2pPUOVnPo+CnTa7iuyjfW/TOwmEtpLtTag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5120.namprd11.prod.outlook.com (2603:10b6:a03:2d1::13) by PH7PR11MB6427.namprd11.prod.outlook.com (2603:10b6:510:1f5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Wed, 1 Jun 2022 02:46:15 +0000 Received: from SJ0PR11MB5120.namprd11.prod.outlook.com ([fe80::1dd1:f84c:5731:708]) by SJ0PR11MB5120.namprd11.prod.outlook.com ([fe80::1dd1:f84c:5731:708%5]) with mapi id 15.20.5314.012; Wed, 1 Jun 2022 02:46:15 +0000 From: "Zhang, Peng1X" To: "Zhang, Qi Z" , "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v4] net/ice: retry sending adminQ command after failure Thread-Topic: [PATCH v4] net/ice: retry sending adminQ command after failure Thread-Index: AQHYdNSiC4CZeAdpNU67dV/VNGeN3K043/yAgADoyoCAAAJagIAAByxQ Date: Wed, 1 Jun 2022 02:46:15 +0000 Message-ID: References: <20220520183112.26546-1-peng1x.zhang@intel.com> <20220531174827.357629-1-peng1x.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4706cb4-4f55-47cf-1cd1-08da4378e5a5 x-ms-traffictypediagnostic: PH7PR11MB6427:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wVlCTY/0h8lDI14Yaifvq3FtkxdsLejy8Hzr6NVU1T+HCOVzw23gnXQ+g2FK4/ruiAnQDfBDe89kJKcg5wm/60qe7cW6NPVUH7jAeMmFbNcAvXuKDhBfGW5sD1iDVZ4fG5f/wgbaap0PzuJvCiZNvp7HBmqpz6HA3GelKT1IOEfS0qJeZaIGo6fS/2mTg30PCERaPd8auEJbKoWIyMBa/Kh0plUkjAbmb05CzerUG9dTgDCsW+RymGXUiIMgrRXs8AeXEHACWJaoCUe3CxBvsaiaEHgQJMVowHSu1ox8nXoRFpixvByuBmGG/uc3dH2h8JDE0153hYBta9fZH7mNwNvF5KG0cg49KPlFJZwfXEHylHfCfDHQIsSvMxYsI2EzjqB2DHCOgM/DzvAm26CKty3ZZSvLB2VcmSYe3Zok7+jMUKqEh3NDYt4BpxFXh/q2SKCgZOBDMcE8tsmpz+aNr6DIUr38jkXrYRTj7m+9yGmO2MlvOJJOOwgNY5WqVtcn2fEXDpsIMGuBlOptDwotYAAxpaSVHjJXWj/s85ajF6BJtplwrLeSj3luqvoi8ME0ijaTqgE2f5rMLId66Ir7klfDtJH65sDF0xiQH58CSx34rndp3gzEP95z0Y/xkE6ZboZJbdpzaroiw/XZK/f74ye5r80jmtfL4SgZlv+bcdPtkhPGGQrD8l+2ohEKCjXYCtgbhrB7Vx5lgFg2oJqjFw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5120.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66446008)(8676002)(64756008)(5660300002)(83380400001)(6506007)(7696005)(82960400001)(76116006)(52536014)(53546011)(450100002)(66476007)(38100700002)(71200400001)(66556008)(4326008)(66946007)(8936002)(186003)(316002)(55016003)(2906002)(38070700005)(86362001)(26005)(9686003)(122000001)(110136005)(33656002)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?49iuBVreGI4+a+EvxVBBGiXCfMyhWwlc79RoKSX/E1YUmKRs5A/aJJs6LOjx?= =?us-ascii?Q?6y6+XoWXdJR64UVdJnFABFLGsUtVKCxy3rP9DvXtMyTBtXX060k20R7itMUL?= =?us-ascii?Q?NNBrx+EEcLIDjRMbTQsh97+OnLlMkgfc7hn+kDdaYNLv7UDuyfMokePIUpDq?= =?us-ascii?Q?PNG3oAilIKQd1qkOZA4gchez81Pk97JSuN3qZXa63ahpFezFw72eGuztdjA8?= =?us-ascii?Q?pniksaxGG+2xSwZ61G4RC01OSj7ecwqegISGwxLo9MZ14NHkvLvPy0bCDg6k?= =?us-ascii?Q?/U1HWufnDF97xFlIKgI0ImSMg5lM0Y7eD3ka5xqNpKezYOoOjhAQOmpix2gz?= =?us-ascii?Q?abiOfc9SoPx2Shl+Je2E/gKafokaQpTc/5cqp5J1Zdlc/yzOQcslq8+Lyzyc?= =?us-ascii?Q?6LfcfgHx4pCBFgW00NnIWEXkmAN+yOuh6TER+cX4jPyuhJ1WUD0vc05hV2JB?= =?us-ascii?Q?D+R0rzqd1wDJZ8hmcF0sgTiI+wytEGuKOGG/a0764Isgern88MtE/L0qniYl?= =?us-ascii?Q?/2MPgv8ld+7Iamn6WQZy78iBiY0I/a2STX5bTBLVg3RStUapln2Bf0nLxUR9?= =?us-ascii?Q?RAh/9cqPGfDwRljTa0e5O6u8BivdDi4KG4bWlYxIqmjO1OJLJrbCFpvtqlkf?= =?us-ascii?Q?GGe+8gl+5tiXhSsl43SlWLVvDdGGu4WrGlYzyfughJq6yF1eD0nP45yoPnBJ?= =?us-ascii?Q?lgr2CT9kDoFQFvBa0jiML6MdjWwM4DlHrFjLpvrUwmxN7eH9Nhon9jWIqNVj?= =?us-ascii?Q?gKxNO/LfXanNK/WXf+E7FhnLObMLATFxaTKjrOrOcKg6xG/0NfnstQZ0gS4d?= =?us-ascii?Q?/IZFmTXuXOHF611qpHQvGBLdJ0HDWVDolhsjSDEJF7YKb6pbszF7ac+mYJp+?= =?us-ascii?Q?ytt4JedgVaDl+oaobvS7Cg7hKcP4gjwwyOXVgzZzfpBi1zvw8PBIeiUOlPlW?= =?us-ascii?Q?7Q7RzKTWitbi2EoZ5FFe1mgj+8TWbeEu1BSBNkCl49Ts3LbYwHtIUc4ygPAJ?= =?us-ascii?Q?YYWlvWWME5z25e3hba+a3XTYK3CCvGKnac7o2q/nI2wDk9H/5XYKmmZCCsda?= =?us-ascii?Q?PqL1sIA4HXW/h+3QLuSKro8/nqW/x6VkIjE8ttXaLbfjg2eyyR8PknRWoDdF?= =?us-ascii?Q?ENLFrG7zhEjVxjKiu/0lmTZMhcmGsyP+gTHzJLJFR7OLq5zKP/Pk/UXAsPxC?= =?us-ascii?Q?JC04xG6+5Rb51TEmCpjQEpogdqjIOpHIkXbQ9y+i69OHmguTuV+S9QpnZLyD?= =?us-ascii?Q?23fRs6NFFn5LiQzM7QP860b0F0MjHnJXTMOtRYlNd/Mxli1KXFCLufJqxCog?= =?us-ascii?Q?z3SCPOfQCBN8xC6HFWZtMgK7NGXbOGJr8UlFpk+qIbl59pu95bK4eOpBnq0A?= =?us-ascii?Q?kObyq8Psalq9UbRivO6UtLtOwXZGvWJtEGqG6u9+9JumlmohcySO6GCzWsKw?= =?us-ascii?Q?4y7vmxXETbop9YfpQd2DHNXOJzHIvOx2lER8QPq0hMtWxOa09hr0AkuO3Vaq?= =?us-ascii?Q?sLe+aS57DZ5dxDo+C5zvHo+JBgVlJXFL9SEEQCaFBI7Ik5Z/Ribvd4xSBDRs?= =?us-ascii?Q?GzH91lQGMNDd7hhf/zJSprGtP2VBtsmj5rSuOiRpTaOsyD9iTassGV/mNFxI?= =?us-ascii?Q?SkGj6X4hXBf50M8tot/36xLYqmFmACpsJ1QGItTLO8Q8+YZUkWgHG6UZicbQ?= =?us-ascii?Q?djEb/uEA4tRTlfBc889m/11Lf39r6+fo5Wvx74z5IoA/QGhx85tavsk1ihK7?= =?us-ascii?Q?9hd2vNFanA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5120.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4706cb4-4f55-47cf-1cd1-08da4378e5a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2022 02:46:15.3974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5TK69wvp4H4FZ0s8lLZq/Lduj1dVg6rlLfAjtDU8HspLU3+1R0uuTdVk53z4r0/8bq8TLzCZonnTizou8fleDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6427 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Because currently just focus on the following given situation, and use 'hw-= >dcf_enabled' it should only affect on DCF. After having checked code 'ice_dcf_send_aq_cmd', it already have retry mech= anism.=20 > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, June 1, 2022 9:54 AM > To: Zhang, Peng1X ; Yang, Qiming > ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v4] net/ice: retry sending adminQ command after failu= re >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Peng1X > > Sent: Wednesday, June 1, 2022 9:49 AM > > To: Zhang, Qi Z ; Yang, Qiming > > ; dev@dpdk.org > > Cc: stable@dpdk.org > > Subject: RE: [PATCH v4] net/ice: retry sending adminQ command after > > failure > > > > I see, so ice_aq_retry_send_cmd function will conduct whether DCF > > is enabled or not with 'hw->dcf_enabled'. >=20 > Why not just enable retry in ice_dcf_send_aq_cmd? >=20 >=20 > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Tuesday, May 31, 2022 7:52 PM > > > To: Zhang, Peng1X ; Yang, Qiming > > > ; dev@dpdk.org > > > Cc: stable@dpdk.org > > > Subject: RE: [PATCH v4] net/ice: retry sending adminQ command after > > > failure > > > > > > > > > > > > > -----Original Message----- > > > > From: Zhang, Peng1X > > > > Sent: Wednesday, June 1, 2022 1:48 AM > > > > To: Yang, Qiming ; Zhang, Qi Z > > > > ; dev@dpdk.org > > > > Cc: Zhang, Peng1X ; stable@dpdk.org > > > > Subject: [PATCH v4] net/ice: retry sending adminQ command after > > > > failure > > > > > > > > From: Peng Zhang > > > > > > > > The origin design is if error happen during the step 3 of > > > > following given situation, it will return error directly without > > > > retry. While in current patch, it will retry again and again during= certain > time. > > > > If retry succeed, rule can be continuously created. It will > > > > improve success rate of creating rule under following given situati= on. > > > > > > > > The given situation as following steps show: > > > > step 1. Kernel PF and DCF are ready at the beginning. > > > > step 2. A VF reset happen, kernel send an event to DPDK DCF and > > > > set STATE to pause. > > > > step 3. Before DPDK DCF receive the event, it is possible a rule > > > > creation is ongoing and switch rules, recipe, or vsi list related > > > > adminQ operation is executing. > > > > step 4. Then result of operation is failure, it will lead to error > > > > return to DPDK DCF. DPDK DCF error code will be set as EINVAL, not > > EAGAIN. > > > > > > > > Fixes: 6bad5047be24 ("net/ice/base: return correct error code") > > > > Fixes: 453d087ccaff ("net/ice/base: add common functions") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Peng Zhang > > > > --- > > > > v4 changes: > > > > - Add retry mechanism if fail to send adminQ command under given > > > situation. > > > > v3 Changes: > > > > - Add the situation description, expected error code and > > > > incorrect error code > > > > - in commit log. > > > > v2 Changes: > > > > - Modify DCF state checking mechanism. > > > > > > > > drivers/net/ice/base/ice_common.c | 2 +- > > > > drivers/net/ice/base/ice_switch.c | > > > > 46 +++++++++++++++++++++++++++---- > > > > drivers/net/ice/base/ice_switch.h > > > > | 5 > > > > ++++ > > > > 3 files changed, 46 insertions(+), 7 deletions(-) > > > > > > > > diff --git a/drivers/net/ice/base/ice_common.c > > > > b/drivers/net/ice/base/ice_common.c > > > > index db87bacd97..013c255371 100644 > > > > --- a/drivers/net/ice/base/ice_common.c > > > > +++ b/drivers/net/ice/base/ice_common.c > > > > @@ -2127,7 +2127,7 @@ ice_aq_alloc_free_res(struct ice_hw *hw, u16 > > > > num_entries, > > > > > > > > cmd->num_entries =3D CPU_TO_LE16(num_entries); > > > > > > > > - return ice_aq_send_cmd(hw, &desc, buf, buf_size, cd); > > > > + return ice_aq_retry_send_cmd(hw, &desc, buf, buf_size, cd); > > > > > > this is the fix only for DCF, we don't need to retry in a PF driver c= ontext. > > > Better keep the same function name, but implements the retry > > > mechanism inside the function, and should only be triggered when it > > > is in a DCF context