From: "Jiang, YuX" <yux.jiang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU configuration before device start
Date: Wed, 10 Nov 2021 07:23:40 +0000 [thread overview]
Message-ID: <SJ0PR11MB51500419B458D38AEA2BB319FE939@SJ0PR11MB5150.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR11MB5150EDE5C573F72DC840433EFE8B9@SJ0PR11MB5150.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Jiang, YuX
> Sent: Tuesday, November 2, 2021 10:38 AM
> To: 'Ferruh Yigit' <ferruh.yigit@intel.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Ivan Ilchenko
> <ivan.ilchenko@oktetlabs.ru>; dpdk-dev <dev@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix MTU configuration before
> device start
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> > Sent: Friday, October 29, 2021 2:23 AM
> > To: Ajit Khaparde <ajit.khaparde@broadcom.com>; Andrew Rybchenko
> > <andrew.rybchenko@oktetlabs.ru>
> > Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Xu, Rosen
> > <rosen.xu@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; Ivan Ilchenko
> > <ivan.ilchenko@oktetlabs.ru>; dpdk-dev <dev@dpdk.org>
> > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU configuration
> > before device start
> >
> > On 10/25/2021 7:06 PM, Ajit Khaparde wrote:
> > > On Sun, Oct 24, 2021 at 9:42 AM Andrew Rybchenko
> > > <andrew.rybchenko@oktetlabs.ru> wrote:
> > >>
> > >> There is no point to do rte_eth_dev_mtu_set() before configure
> > >> since set MTU value is overwritten on configure anyway. So, setting
> > >> of MTU before configure is rejected now on ethdev level.
> > >>
> > >> If testpmd is going to do configure (e.g. just after testpmd start
> > >> with disabled devices start up or any configuration changes in
> > >> stopped state which require reconfigure), just save requested MTU
> > >> in device config to be applied on reconfigure.
> > >>
> > >> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
> > >> Fixes: be0433cf953c ("ethdev: forbid MTU set before device
> > >> configure")
> > >>
> > >> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > >
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Applied to dpdk-next-net/main, thanks.
> verify patch
> https://patches.dpdk.org/project/dpdk/patch/20211024164237.2116166-1-
> andrew.rybchenko@oktetlabs.ru/ on baseline
> 6cc51b1293ceac4a77d4bf7ac91a8bbd59e1f78c
> Test failed on nic XXV710 for 25GbE SFP28 158b/os Red Hat Enterprise Linux
> 8.4
Hi Ferruh and Andrew,
Since the patch https://patches.dpdk.org/project/dpdk/patch/20211024164237.2116166-1-andrew.rybchenko@oktetlabs.ru/
Has been merged into dpdk21.11rc2 main branch, we verify the main,
This bug(https://bugs.dpdk.org/show_bug.cgi?id=864) also can be reproduced, could you pls have a look again?
prev parent reply other threads:[~2021-11-10 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 16:42 Andrew Rybchenko
2021-10-25 18:06 ` Ajit Khaparde
2021-10-28 18:23 ` Ferruh Yigit
2021-11-02 2:37 ` Jiang, YuX
2021-11-10 7:23 ` Jiang, YuX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB51500419B458D38AEA2BB319FE939@SJ0PR11MB5150.namprd11.prod.outlook.com \
--to=yux.jiang@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.ilchenko@oktetlabs.ru \
--cc=konstantin.ananyev@intel.com \
--cc=rosen.xu@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).