From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86D7CA034F; Wed, 10 Nov 2021 11:56:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 772D44068B; Wed, 10 Nov 2021 11:56:17 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 9D8CB40683 for ; Wed, 10 Nov 2021 11:56:14 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="293477841" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="293477841" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 02:56:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="669763344" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 10 Nov 2021 02:56:13 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 02:56:13 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 02:56:12 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 10 Nov 2021 02:56:12 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 10 Nov 2021 02:55:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KdWofSyhLJoy7psN7qrF5y+q8QBpl5TD2UJQkrG10XRJRtg5Ut++vzR6i5AV53gu8NT9wTuplnWEvPlRXs0IzUCcrtHWH2USp9RUrvqz9SrrUDfXRzJDdAJLelxnSWIhtRgpms/zyOJMrFfmAp902ZyhxIywdncl63Erroz8WVV0UKCY13muRWSe/1SwJFspS1pDnB+zDJXSv1n6ngXRXZ8G+A547HvaLSyTEl463F8lE2PzjeiOZSRI7AXuR48wU4wiBcAvza+Lvcf4QB2baJBrAUZ6KEfyDUgFv/4+pcGmxS1K2N8j32WSXRJbR0KcXS2EeI77MRsX5spe0klC2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UbmSahIqaLx8wmHsp/7S7pTbzZeeEWbeZUeyljLgocA=; b=gPvpiGIptkd1Rjkd3gPIUFihtR6v3Du36AmWmQ0P6hR6Sf4hcx60RLG+4UhUipluQyssexJwlUrvtbPiCIUkWKScS34Q7u1JFpnN73f3xgFg7gMJt3ZcboNCn/vDksuVhE6KafsVAcw5jfIV5ljw1iTgOkm3iQOAIRiAtgtNZAsX6jbCHx2IHog37W8QYU1v8TKKBR5J+PHj7Qvb/oqFTJlMgHEpnrIpc2uIfUH8BLTHRBJViD2WLasukzAEBezgRf4o90IxddBdCR0NwEmnBv4Z+bteahiDugAJkqwv9ySsCfKoN6CqizrSnqkflms+o5rRmRa5LK44MKv3TASxag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UbmSahIqaLx8wmHsp/7S7pTbzZeeEWbeZUeyljLgocA=; b=zhlXmxjhLExMPQ1MgxiOBmIxeNZ9dV37jXVlCDO6a4pOEq1EvsIEygmeygJNXWZJ+d9idwfdVJ4mprJpm2tLY7G/I2kTKSW/kYA6nWCLCfvwBEvG5amHHSIOuyjveKRwFZAXei2RwpG69ROfh+4eFMOeuBDOFlzNy/ysWpBaZ5U= Received: from SJ0PR11MB5150.namprd11.prod.outlook.com (2603:10b6:a03:2d4::18) by SJ0PR11MB5769.namprd11.prod.outlook.com (2603:10b6:a03:420::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 10:55:41 +0000 Received: from SJ0PR11MB5150.namprd11.prod.outlook.com ([fe80::1c99:cc97:391:1406]) by SJ0PR11MB5150.namprd11.prod.outlook.com ([fe80::1c99:cc97:391:1406%8]) with mapi id 15.20.4690.016; Wed, 10 Nov 2021 10:55:41 +0000 From: "Jiang, YuX" To: "Harris, James R" , "dev@dpdk.org" , "Hunt, David" , "david.marchand@redhat.com" CC: "Harris, James R" Thread-Topic: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error Thread-Index: AQHX0l4fZ9rAgRtgXECcMyb49U5nb6v8nYEA Date: Wed, 10 Nov 2021 10:55:41 +0000 Message-ID: References: <20211105155351.350403-1-james.r.harris@intel.com> In-Reply-To: <20211105155351.350403-1-james.r.harris@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4537d392-60a6-42da-dccd-08d9a438a35e x-ms-traffictypediagnostic: SJ0PR11MB5769: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yJrjxeV80Jy3sYDJBmD2VmKaVc6BFLe7n4zl6itYjb2D/YbvAQFlJtH1yLMzt8hDKDGW90t/sNjzbE7X07X31axP+eJjwPgFBk+P+AGkxtwzaSZ+jKrdi3Q85xBygy4AK5X4lLAqmoFpVteV35lns5Jglpz/vep53n5iGPNqpAStEaNLWbI4maiFCHqEuN6ep4fTEhZ1LSt43ax/MC19sjDoNdqBow2CBxapUXaMY5/+h0q71tIWmrb5Lws6igG1ww8HKCv7x+HXQa5WKn/YmdDvJHBtHp8nvjOxAF/YUqKQKHSUGEbC11SanOliq5L3DzLiMjDBxRA423gad+HEeLPFmyZuhnk0KwvF6+46T7V5Ohqb6Cqz1xbFL7ZBslB9r790irhqXAY83ZCxtvVnb3HKtj4e4OCy8sgzOGdimH86X37dOUFAQ52tI78bDf+hFRZ9MLcCLFz9D7SmIr0LM+0bzefl30XbVxL34mGgNPURbrdPepFG5ruG/YMRqu1WYcD/jdN8ac6kQMtLvwmNos6sO6jk+NccRMPu/Xu8UngV0I4KkK8qI38Sm9opB0K6qw/idTvXJEhuuOtwB41fvqXYAEfWiYMIt/xNlJyWstCL5PPbya/42Cm+bVFTMsfDHSMxDXR9bXh02UuEOtx8ESbqm2YMpJR9AiJqs7WID8MfKoeZLvKsAnjsRMwOyB+RLHVpmS2skbYoC+zpE9dTOoGwIV4G0bK7xpGDHP2LwmKl7Dnr1eGkFePZpPkMXbRCq/FVDtxLm9MMTdeKHbCye2DLt/Xj8JVD0EHRPh9tEcA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5150.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(107886003)(83380400001)(76116006)(966005)(33656002)(186003)(66946007)(8676002)(26005)(122000001)(316002)(82960400001)(110136005)(38070700005)(6506007)(64756008)(7696005)(66446008)(4326008)(71200400001)(66476007)(8936002)(508600001)(66556008)(38100700002)(9686003)(55016002)(5660300002)(52536014)(53546011)(86362001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ucbi57FeHs0uhMfZO0u+2xPB1aZ6PfZrdTMffQ7jUkj48imFC+CFwcrZ6lkc?= =?us-ascii?Q?r316sXwEC5WGRCzzwzAvB9zrW0k4jjr2FcyIVn0RFunP0JhvsNRFvHtRDPul?= =?us-ascii?Q?TB/ggqX4wi14ucQlNh6ihFvC2E04UAdvIDFl4wlzoaicdxPShgHS9o6Bp65Q?= =?us-ascii?Q?DXSu39ZzGMTRh5KET9R2qW0B0Y5ugqmCqaBmv1vhhyCKkuIoLHNRjMEXdMjZ?= =?us-ascii?Q?z7IpuwiKA+L4gbeobT5xugw2eFDTesqIrkd9fH+kLeqmd2AcpXX9z5nY8LMb?= =?us-ascii?Q?1zqabqdfVtkF5ii2xxlinhHfO8MQmkhwrGi5ZXm/fSjPQrPvfJ7FPl4gSGRt?= =?us-ascii?Q?ITlab4Zgr5e98iwb7fIQTV+TG7PEbnQIC+hCkEEkm/tsa2iBR4HOIEoPJfAO?= =?us-ascii?Q?xuWPUbG4AZveT5cCMTizjG9GYZUtWYK4mJonfrPh2NnLY3C2JLFxpCjn+Pvz?= =?us-ascii?Q?DbRSH2CpQ5N7iHlmVVHA3A0DgzjwhEMkngTChTBEObfesspLprTSLxjf/AJf?= =?us-ascii?Q?kiWyCuwAwu0zN6kQVOckMYSu4A9krom53QV3GWBLFnDZ6Gte/hzVVt8HOKGa?= =?us-ascii?Q?hI5iEZoWDbl9O1yv4WgT8+ALKMr+VFVlv1JaWnXlK+QPAvfy4NAxmt2CuPHb?= =?us-ascii?Q?6ordEV6iLQJ/gb2yd/l7oEz4Irsh0wwjIuEuXWCbkvLVsncO1jZ/Ydh3PZBZ?= =?us-ascii?Q?hq79UEALaS2umFut7zI3PLzpwL6E4zPJhcCPyTYXh6Gh1nCA0Ue3E13bF0js?= =?us-ascii?Q?qi8zUYCz6eQCCQnpt+jz7009VYhIyVM67A4Bq2yq5e0+lniygGz8cg8tDcbM?= =?us-ascii?Q?sWalIn+GAanvXh8G1FmomTEV4S74GnaDmZHQzfNspnd7wSoi/l4mniZZdt2r?= =?us-ascii?Q?gj6hRPd5ygN+iIz96H05D29O0rWFzati+0yTn0bHy+U3ePmCEIwiQGhFE92q?= =?us-ascii?Q?nsv37cZihAsHMmcgQfJKKtvNFgLdbykIS50l25U/ZSmBOdmqBgj9j89bv2O4?= =?us-ascii?Q?HAToKXvVwhfZ4xW8OcJfe/kN0SvYVCOsofQq3aLaNB0SBmsTsYO5VGTYYv84?= =?us-ascii?Q?bD7sWMw9qupz9IA3pv6f8Uu4ICVBCyYmBwLjwlx5O09iF82S2SUsjcUVn+9L?= =?us-ascii?Q?HmHNO8i0wWL1dd0V/i7zDezlg+rzCqr9IsC8mbmYrsettHMH1NHRBBwxq8k1?= =?us-ascii?Q?kc6iem399fgIR94+FpU7pgc4GR2qt7oeCxWTxBVvazXtBFnKAKH/EvyHxTcV?= =?us-ascii?Q?vUJe3Sg5OyPULfen1A79BM5rBZ9Wq7sPpZZPF1VEahdM5wcyqS0d9Dr9rHZS?= =?us-ascii?Q?3dZQv4SQsGnsydn/LDxKGoyIkkHEzexfoGbXOm6tkIlNYIJgziOG4/8tpq06?= =?us-ascii?Q?1SuA0TYSKl+G+A5so38tSYus3S8oyzYYSNb9x0qQ6Sm/StVsHcXSvZYyqRmT?= =?us-ascii?Q?BzVW6BF7byekymsD++AegEYEMBhYDqDUEnac+NXVQAIaz2ECseZokZj+Cb6z?= =?us-ascii?Q?v6wDab1gSlM8o5UmEXmAywLrhTVYS717hKaL9h9McankhaQrW8pXWQYRpvMw?= =?us-ascii?Q?asw2bXnEkOmKRzxhEDepA94ku0dDu6RLvvcx0oipgAWIQfOCDiuiFF+vxy1J?= =?us-ascii?Q?Lw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5150.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4537d392-60a6-42da-dccd-08d9a438a35e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 10:55:41.4776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lw/cr/K4rbvoYIDsI+jVohieozbZj+i/5ZBhcbaypLM1AgLFa/uLhQ/AIlIU/G0/XSS6CwhoCdq9zyOOxIweuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5769 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Jim Harris > Sent: Friday, November 5, 2021 11:54 PM > To: dev@dpdk.org; Hunt, David ; > david.marchand@redhat.com > Cc: Harris, James R > Subject: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error >=20 > clang-13 rightfully complains that the tot_ppi variable in update_stats i= s set > but not used, since the final accumulated tot_ppi results isn't used anyw= here. >=20 > Original idea was to just remove the tot_ppi variable, but feedback from > David Marchand on mailing list was that the related ppi_av array in struc= t > priority_worker wasn't useful and should be removed. This allows us to al= so > remove num_dequeue_pkts_prev and pc from struct priority_worker since > they are only used in conjunction with the ppi_av array. >=20 > Signed-off-by: Jim Harris > --- Hi Jim and David, We verify this patch http://patches.dpdk.org/project/dpdk/patch/20211105155= 351.350403-1-james.r.harris@intel.com/ based on dpdk21.11-rc2 main branch(f= 4801fdb7828f45ddc4ada148b1b0a230a226570), still verify failed. Could you pls have a look again? Verified OS details: Tested Failed on OS Fedora35/Kernel 5.14.16-301.fc35.x86_64/gcc version11.2= .1/clang version 13.0.0/ninja version 1.10.2 Failed log details: [root@dpdk-Fedora34-64-gcc dpdk]# ninja -C x86_64-native-linuxapp-clang/ ninja: Entering directory `x86_64-native-linuxapp-clang/' [686/3119] Compiling C object drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fs= lmc_bus.c.o FAILED: drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o clang -Idrivers/libtmp_rte_bus_fslmc.a.p -Idrivers -I../drivers -Idrivers/b= us/fslmc -I../drivers/bus/fslmc -I../drivers/bus/fslmc/mc -I../drivers/bus/= fslmc/qbman/include -I../drivers/bus/fslmc/portal -I. -I.. -Iconfig -I../co= nfig -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../li= b/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/ea= l/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/k= vargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Id= rivers/common/dpaax -I../drivers/common/dpaax -I../drivers/common/dpaax/caa= mflib -Ilib/eventdev -I../lib/eventdev -Ilib/ring -I../lib/ring -Ilib/ethde= v -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mem= pool -I../lib/mempool -Ilib/meter -I../lib/meter -Ilib/hash -I../lib/hash -= Ilib/rcu -I../lib/rcu -Ilib/timer -I../lib/timer -Ilib/cryptodev -I../lib/c= ryptodev -fcolor-diagnostics -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -= Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat = -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prot= otypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compa= re -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-membe= r -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dnative -DALL= OW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DRTE_LOG_DEFAULT_LOGTYPE=3Dbus.fs= lmc -MD -MQ drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o -MF dr= ivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o.d -o drivers/libtmp_= rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o -c ../drivers/bus/fslmc/fslmc_bus= .c ../drivers/bus/fslmc/fslmc_bus.c:318:6: error: variable 'device_count' set = but not used [-Werror,-Wunused-but-set-variable] int device_count =3D 0; ^ 1 error generated. [691/3119] Generating rte_bus_dpaa.sym_chk with a custom command (wrapped b= y meson to capture output) ninja: build stopped: subcommand failed.bus_fslmc.a.p/bus_fslmc_fslmc_bus.c= .o