From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DF3CA0547; Fri, 29 Oct 2021 07:58:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCD4440688; Fri, 29 Oct 2021 07:58:23 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id F13A840395 for ; Fri, 29 Oct 2021 07:58:21 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="229323939" X-IronPort-AV: E=Sophos;i="5.87,191,1631602800"; d="scan'208";a="229323939" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 22:58:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,191,1631602800"; d="scan'208";a="580907425" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 28 Oct 2021 22:58:19 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 22:58:19 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 22:58:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 22:58:18 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 28 Oct 2021 22:58:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YPXVFIHA7xWImmbTwwmtKh9GVZqD8tW6vdOyXAvYggvWQJS8pZ/shi7juQ63WcorVEdVjTzoAYZuakICwnY/31qFBRl8S3/gyYc7kJ4uMg4K5/CyeOuZggbLgo/EfvwPlbfMjY6jIt2nXfHjJ3Uz/NOF2y7zPkA5MDGl2CFYnpnKDsbrKMavi8PlC36Fc57uOwssa8cfeZHCYG7mV7LZ6kVIZPV8F+0gYJ81BV4iKmoLfTSqKtzPB5VeK8nKTGEb8FiwaapvhB3BDzCQTDRAgBxEamMMIXne55620TvYkiKLeWDhbKtJIbd1l0P10yAk16dfatRV08vGF5ljn7sNOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ut3dz0dQe+qlO5/YJyeYiEUc3kCz2CMnbJk3EjTF1i4=; b=Hw1PyFzuzcTJfVCBo6owFIWS+nLKynTNjPTNHmELK7b7D1F0vd5T03rKCyolpJpv2rugXZHNolX4utGjv7jISj4xoJXFyebNxrerS5t/vjUSnCCDybS37Bf8xeUZN1P84eIj4qaiQ41VvH3yh9im1sz0rhF2gwjTnGEo5KhEJR+DdVJ78q8cbt0AwZJ1URJwHVMZDklXp2YmuCH3WTtn1djsCylvx1ptQ+J98SjNSQ3M3eWKnKym84RdJEbkTjHPs3Cyq+Q/6Iw6MVHU2Th0vr/szjAwnxjPXali952l1phZ/xdsQX5Hb88sNJ2It6AQu/V65Va3mgDtmHe9Wpnsdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ut3dz0dQe+qlO5/YJyeYiEUc3kCz2CMnbJk3EjTF1i4=; b=jVr2W/siuE1c/POPIrVQ2WsoWuLOf3ib5o0i698LxN91v5HSs3ck58fIX2g7s85jhbtvWgaFZcJNiLbsvJwSoqYbO4HkOUyhj7/yzQpnw1D1u9LDSCIIwzg1P7QFdvoWKjKlctM4iGnxfCputmf5uv7V439sm37+ALxGgb+r7eE= Received: from SJ0PR11MB5150.namprd11.prod.outlook.com (2603:10b6:a03:2d4::18) by BYAPR11MB2552.namprd11.prod.outlook.com (2603:10b6:a02:c7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct 2021 05:58:17 +0000 Received: from SJ0PR11MB5150.namprd11.prod.outlook.com ([fe80::1c99:cc97:391:1406]) by SJ0PR11MB5150.namprd11.prod.outlook.com ([fe80::1c99:cc97:391:1406%9]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 05:58:17 +0000 From: "Jiang, YuX" To: Andrew Rybchenko , Thomas Monjalon , "Yigit, Ferruh" , "Ajit Khaparde" , Huisong Li , "Ananyev, Konstantin" , "Xu, Rosen" CC: "dev@dpdk.org" , Ivan Ilchenko Thread-Topic: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device configure Thread-Index: AQHXxy5BdP6QE9dkJU+mkeR7lHjvNqvphQ9w Date: Fri, 29 Oct 2021 05:58:16 +0000 Message-ID: References: <20211022101828.649441-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211022101828.649441-1-andrew.rybchenko@oktetlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6f75d6ae-67de-40a3-dfca-08d99aa11a41 x-ms-traffictypediagnostic: BYAPR11MB2552: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:935; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BgAwnWn3zbPbqGlncf0f7ugSB2Mf94MqqZCPPta5LeFuKcC/Yn6UKRvmnHcpdBOHDi9ceEpS+D0M+z+YddNHUJWPuqquragd/0VUMAlRXZPe6l68qz2pMigbzSxgjsGItHYvpmbwUPUxhjO4nL/m5YG4TkHfszkvH7ACHa7UCRpORxGv+MS12TjUF+1k1NBeM1j/w/cmdsOQ551bAIj+qgUpWSnmEQG9Qi7inSjhwJAA2umgcToCJ+j+gMd0L648hnPPvox5FYg58En0BwEu3Pgmc1wEeSPZNs0s9qvHf8fYQp40WZUo1N66K57Ixj60uxS2zG46c42Cb/aDZaKLWWBFyqpyRvAxVmxB3Itu+1R7z04P6NAZDbhKNwsTwYB5gH9kX8CR/v2eSCAT3NFJwvfMr/1W3DmSpcatxL2bv15RQLJmaq8ElB6oJuYkl6WPgLZn+c3ejF0wi10bjxNGJjQXjLi4rQ+yQTPlFxEzJ0iAKgAuupcaCl8DfZ5BrDi61QPh84bBvfS48BpKhQdSzBU0V1c1w/tQpwCxAqXfelNaxcoZNumE61pmEehWcAnK0GA6G/V6go9U5MFArTIf2+tfj1omWH93ar56b3UUjdJaqgHsjhW7VtrTa1VgYeLLa+JLipQKzO2eZFhPKtdWJMJBuNRDuI/R5aHQ+Rmtig/74UitxLp1HApIJypVz/axJtzJ5rqQjAQrpvbKO1ErDZ7sMBNdxse2JdLqZvGb17BNAzX3qLwoXoET6hsyXe2x8PoLn38he+U7dJlQ1npDX4At8WwlWxm3+O+thCtv6Yshfcve4styBzlh2tFb0Qwd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5150.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(921005)(53546011)(6506007)(82960400001)(54906003)(4326008)(5660300002)(110136005)(52536014)(83380400001)(508600001)(316002)(66946007)(38070700005)(26005)(55016002)(186003)(86362001)(7696005)(38100700002)(6636002)(122000001)(33656002)(9686003)(8936002)(71200400001)(966005)(66556008)(66446008)(76116006)(66476007)(8676002)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D05OlcoCxprGPjzfoJhmA5vbx9/4fDcxWHr/kGz/DWKmKN+wUsxUJM0NzN15?= =?us-ascii?Q?avearpGOSxYtoVcxMKdFPRiWlcMxtC2DobDC3Q0JI8sX14Edx84tCuXFmWmT?= =?us-ascii?Q?FO+sMIJfEPJENXmO+294lXUq+CYFOfyheQgWcgdKIL2L3jf5YZRXqIeZLral?= =?us-ascii?Q?uBCdBN2SukqjFbO0HK3T924dSz5KLMWC7sxlO3w0fjwT8mbE+B9H/57NsUAT?= =?us-ascii?Q?WzFApHumol7kDq80jHuANSh69TsOhAoW8A3GUS2VO0pud/VRxpTsAxmXzBHB?= =?us-ascii?Q?lJrzaVufqTKTe+FsJMGpPW/+HbvEghRcWTg1UVoa80Ct8n9YWCltRm6ZG1WB?= =?us-ascii?Q?u4DxfxojLEos9oaFGLinXJWbQJn4DmdjPbIAH/EtWVJymWVr3KUBkqi/Xsj1?= =?us-ascii?Q?yr4AzMZ3odgWeAe7IzMx1vdUgiANDJVC5Ak6jXxb44/mJ7f+FyCP7kzWxdUi?= =?us-ascii?Q?zhD25xgEdNNNX2/mdowRf2t85z535TfbPFNRDk35x9yza5er5iru3woPSLuY?= =?us-ascii?Q?aLHEi48tm3jXCIPaWRdv4pTQv9XG8YHM+HWQ1xD8ZpStMMmf5lkYltYrBKIG?= =?us-ascii?Q?yUZ94rn7TgjOG2kSgmX1nXWxUIunLzxQWd7UcUkyKgVyIenOMlG4xvRuPsAY?= =?us-ascii?Q?MRjj2UVdRJcj8FEoSB6wZ2IZvoriazIUWcjDGa9U8/+zxiwpMpXbokmzP/H5?= =?us-ascii?Q?DF9NIznhyfSFKT/GwA8k93jVBnBzUc/Tfa/bPswE8DVy76nMD6BgWQrAlZgH?= =?us-ascii?Q?uoUNryHHi2KUr2JFsnVryt1zhyAvdzAQlTyA4mQxiTZrxRHDn2PGs8lkU7s9?= =?us-ascii?Q?+tNDj5gx6+Sl1M+nCVpPMWHvyzW9KJjDjx1sxqpKwkS6r/910UC9UJfb08Za?= =?us-ascii?Q?wb9L9dYLjtW9BOgOGms76pxYvaAgQCoPh/K7Ta5V3Mz+qheM1qOLdDJ227dm?= =?us-ascii?Q?Rcc73g7GxPB2OhO39QneINRP31At9RXJgOtLschMXApXqje9Gc/g8IvlpgvL?= =?us-ascii?Q?NPFHFiOvgKnGHfE9ZQhwhKW+sTWmx8jCmzIg5zF7GKq6B1yo+kYqMg4zw2dN?= =?us-ascii?Q?4j53KZQh8wiJ4nFo/QMRfMGAhxDgQovQcg0Wykxebnx8mMNfKU/AcNJzZ72j?= =?us-ascii?Q?nZg9kInddb01Up4RafOiHa1AYs+P0lULqSArqjE+WDwmd+d7ZfLzcJZqYMqO?= =?us-ascii?Q?uxVJkscJYbvVhKt83nUButaopVJcx12lhtqsPepjL0L2TMEQfQa2XR4/h5si?= =?us-ascii?Q?xN1x3hOYWLfCjTOVZUjh6aQYObB+Mx+y5Zn2bHvdbUrOGcmpBUgW9IAF7SYW?= =?us-ascii?Q?ITTN/ipup9YBxPdJtY6MdZtWV9TPqIE1ejZuoEFcl5b5eN1gmPXiOjosQyhd?= =?us-ascii?Q?uNVZHBIEji6LxA+LynzuAIoJ2Dv3fwRKAj8TK+m+4UqDIykZZdj0r7KNOGNJ?= =?us-ascii?Q?LeA0LM4t4m6ZiK1G/skGbYD9wMoLxegAiuL0d0zIqmrFx0VwPHxipYrsO1Hm?= =?us-ascii?Q?82ZXhl7fqv8zfUIVvAnZ+8X3BlF4wommpt9ZlO/a79JwNITGRhGxPZ9/f4+1?= =?us-ascii?Q?u1W56Y4PNJgS2ippS/Dre4so3YJXzJb61lx+pKVdf11jlh9eU2YSDXLsAyQ4?= =?us-ascii?Q?kQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5150.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f75d6ae-67de-40a3-dfca-08d99aa11a41 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2021 05:58:16.9676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zNG2tYK1euByu08Y/K/QA+Ze+5Lnn1SDONbgJsmRA/DwCNHSGgeoVI9ChqIdHQvNQynW252DM6CMSY5SACZEkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2552 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Andrew Rybchenko > Sent: Friday, October 22, 2021 6:18 PM > To: Thomas Monjalon ; Yigit, Ferruh > ; Ajit Khaparde ; > Huisong Li ; Ananyev, Konstantin > ; Xu, Rosen > Cc: dev@dpdk.org; Ivan Ilchenko > Subject: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device > configure >=20 > From: Ivan Ilchenko >=20 > rte_eth_dev_configure() always sets MTU to either dev_conf.rxmode.mtu > or RTE_ETHER_MTU if application doesn't provide the value. > So, there is no point to allow rte_eth_dev_set_mtu() before since set val= ue > will be overwritten on configure anyway. >=20 > Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") >=20 > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > --- > lib/ethdev/rte_ethdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index > 4ea5a657e0..0d7dd68dc1 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -3728,6 +3728,13 @@ rte_eth_dev_set_mtu(uint16_t port_id, uint16_t > mtu) > return ret; > } >=20 > + if (dev->data->dev_configured =3D=3D 0) { > + RTE_ETHDEV_LOG(ERR, > + "Port %u must be configured before MTU set\n", > + port_id); > + return -EINVAL; > + } > + > ret =3D (*dev->dev_ops->mtu_set)(dev, mtu); > if (ret =3D=3D 0) > dev->data->mtu =3D mtu; > -- > 2.30.2 Hi Ivan, We meet an issue based on this patch when test dpdk21.11-rc1. BugID: https://bugs.dpdk.org/show_bug.cgi?id=3D864, could you pls have a lo= ok?