From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BCA9A0C4D; Mon, 2 Aug 2021 13:21:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF7884114E; Mon, 2 Aug 2021 13:21:48 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 185DE4003D; Mon, 2 Aug 2021 13:21:46 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10063"; a="211564708" X-IronPort-AV: E=Sophos;i="5.84,288,1620716400"; d="scan'208";a="211564708" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2021 04:21:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,288,1620716400"; d="scan'208";a="666538709" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 02 Aug 2021 04:21:45 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 2 Aug 2021 04:21:45 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 2 Aug 2021 04:21:45 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 2 Aug 2021 04:21:45 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 2 Aug 2021 04:21:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M4Ok3z0Bci4C9EGcdHoVVuSGhBI2t89IcgXRJp/yrUlhjG9gIhqUiWaKBCuzj+kMAxR2KQ9IIs6btmoM9ecw4nIHy8ejJ70tgbPoRQmOAEwNLlfd/N8Vba3ek7pMzJcs1h7MXSmxSq/HcvQdbV02vBvaB8qb2mBQP0DuGpXsWM9gVP13xDch6pK7VRvrNm5wxQNqbIris9M2lHccWm2TGMJLsApQIv/gSyl9AdKLpUD74CykQW51pXAbPeGJExuHhy6BDqlYi+rPdvbWEax08Ej/PKjQjHCaZWsKaH+liUKDCWKpB1fli5OpsNvPLBdDXdp+B+C80mcjWj/pSVBCNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ddlZX0V46CpKsy4SXKcbEZJ4otoMLIz9oAkbZ6hYyKU=; b=mcwxZtdc6dKyaaioWmvPfv1vAsD5IPwQgLvN311lDR8rVodfUu/05JLK0SLvDqNJfY9wYL2emkYiy3NALOMXN+TfqdlupXYZfk3kxo5aboJxKljt0yVmxodaLuboWsQusP3FilKcQj/M3WUlOjsp5Hdz+c8qEKKiBqpxgpeXaztQbOCoQFdhDI0EjsFWhIUTTNKJ+dDzcIwksGGnBqrmTdDrVmlRRrp0byjKQYZA3FYD9ouFJY1urghuIDGqunHhrcvW5BSUvi97fO28b1l1Z0maVjC/XVOwJ24cI5Vavstcrf8aUGJlXcskIODR6xnInL/u0mWmNX8Z80qjqleIyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ddlZX0V46CpKsy4SXKcbEZJ4otoMLIz9oAkbZ6hYyKU=; b=ffqri/7LtocMfF6wHEY34q7ggozkz2aAj9MkrTp9frKMHTz5bcs+nyvAbZBhyAtfun3yrAmWVeeQin9cQtUJorq2O9iAUkesJczTS061v9wATc3SmMd1DlcOaJLkdvNQuAuiwE2rhUPfBWbjk4NM8hcBE3egAh5+GUTIakCWq9Y= Received: from SJ0PR11MB5150.namprd11.prod.outlook.com (2603:10b6:a03:2d4::18) by BY5PR11MB4292.namprd11.prod.outlook.com (2603:10b6:a03:1cb::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Mon, 2 Aug 2021 11:21:42 +0000 Received: from SJ0PR11MB5150.namprd11.prod.outlook.com ([fe80::15f9:1166:732a:313d]) by SJ0PR11MB5150.namprd11.prod.outlook.com ([fe80::15f9:1166:732a:313d%3]) with mapi id 15.20.4373.026; Mon, 2 Aug 2021 11:21:42 +0000 From: "Jiang, YuX" To: Thomas Monjalon , Gregory Etelson CC: "dev@dpdk.org" , Ajit Khaparde , Andrew Rybchenko , "Yigit, Ferruh" , "stable@dpdk.org" , "Li, Xiaoyun" , Tomasz Kulasek , "Ananyev, Konstantin" , Olivier Matz Thread-Topic: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel Thread-Index: AQHXhR5u+Hg8apBw0E+PfBWBLoCD6atba7sAgASpZMA= Date: Mon, 2 Aug 2021 11:21:42 +0000 Message-ID: References: <20210719083309.15428-1-getelson@nvidia.com> <20210729170141.26563-1-getelson@nvidia.com> <125205582.vBP58ymnIJ@thomas> In-Reply-To: <125205582.vBP58ymnIJ@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 73eec7c7-e0d2-4345-c41b-08d955a7b499 x-ms-traffictypediagnostic: BY5PR11MB4292: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1388; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cSr+nDHgEha6CK7GuPv6fllmcEupMFo+Fjtw6PIPACJdMADIxGQeeZ1t1ORPNDSP7D0hf3HarRB7ThwpfyvdwKb8C/TbOIW+WcBVZVjTRR3R+uKC+aGulPpoHj/m9/XW8IR2gKSWZsXGZ0ED8VJpCMMw8pGIJD/e7VSTXS+Jp6kTrTSTc8ZuUBCb2mD1f1mRsux077yONpgfiBeg5kdnKosnvzfCAKkmC9w9PpurUkA1r+Xp2OeSETZHgQANO1/9uN2OafI9aUWCjl3Ulx7t0eWQKJSxN1hZzwr9lMFJfytzlLQslM+k2ynYRR79cr2P407N8milXhfjgUj6YRxNUUgN5FGQXtvclvb14C9fY10niIM/8m656jHevE/QRAZPemTB/ScChK+OlFRWmqR31mE6MdYVg474DVWo2gw8Eh+j40K0iK8xdNV9emHgVv6FTradktWNK87OSBEtRIp64TIcaYwY817Npyi2FUuWqD5F+NYGtI9ZGA8Bo/MlGzSYtQ1W5a0/SpH5vZ4rrT6xzkAhDlIk9I+ZpvHZqQjkbMUqkA/CnFea92uV/DCuX/nYPIYKp0zlWKAlDjtCiU38TS64lVEggV/MhezQwdTTurBEDbavkjxBXFaAT/t30pTiyxmf6DTPyTO3wXe1REAAf0elPBmGM0pVvcQZvBOz3JH6sbArFSOd83incueQr85hKc+huQ/D9atKtx729wvInDPbWNdvEbc5xDDS6P89G3anxiGv7iAKNx7CjTuN9ddtUQHq0wKDFNZi0wVUWw/C1PXs8MNH309DFj2g/qxrymM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5150.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(966005)(76116006)(9686003)(7696005)(110136005)(54906003)(38070700005)(38100700002)(122000001)(55016002)(71200400001)(33656002)(316002)(86362001)(4326008)(186003)(8676002)(66476007)(66556008)(64756008)(66446008)(66946007)(52536014)(508600001)(5660300002)(83380400001)(53546011)(8936002)(6506007)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y2NThgX10a6sEleqoZ96oN1R3HWQq+AinYGmm2XNDdTiRP2yt4VnwJtP5Og3?= =?us-ascii?Q?F5fLXHFYJmYcf2S97X4g9BSuL+yyI78NqC+2jXXiPRFw/UiFDL4SnroZyqEn?= =?us-ascii?Q?rYe36D2z0T0Mgkj0FKujiYRSxcsjouhcXWKGgkr07ETerslmGh7zFtthpWzi?= =?us-ascii?Q?ezOT/BhKQIrLRSwZcdXan6i+xdo4YbWmfmTtH+sxvHoIQ0FZaccUfZ45sMxl?= =?us-ascii?Q?PEU5ikSpRIZI2c/V0FEIykJhEF23EI7QGrIR6qCTNeO3Q9D8uFGrdBbkVUAS?= =?us-ascii?Q?/MnxbTmgsatcQutk5GhvcISX8ehjVno6u493DEnNyeZ/yaPd1anJJ7lHE3LY?= =?us-ascii?Q?+1KRQqW7NLl4FNW5tfwACpPxeTJKSh/UMW9tiUDiXZy9kzepR2z1RuiBcAWI?= =?us-ascii?Q?dFzkbcyK8FPdWoJ92Eqa0aw9410zYUChBsqumw2tooVurUjN/z6RGv8YKtiJ?= =?us-ascii?Q?2/D16qqO1dgdbh1x2X4qg1TLN5r9iKv4mGjzCVcPTz6L2X21zO/F1AkGl4lT?= =?us-ascii?Q?NvxV0gUccd2p/HpKDE7pOmvpieslRg5RbbSpIpg7lz6D+b2ZmwWvr8y9XSmK?= =?us-ascii?Q?RPcBP6EE7Uz/7fno+ehLmzWV8u9G2xTxMlP1umy9Jrc0yncVBir84jhDvWdT?= =?us-ascii?Q?tNHvITbBAjsMTHFlWiZfyNCPdkrE0VMzJt1QeVL/Oyj7sz9OaIWIx77HVIsm?= =?us-ascii?Q?JVOGwB47mDj5MQY+8sPgmWU7KNvR1EAS8Ii/21RJ6HeOXZkx72Q0kTlUmIOM?= =?us-ascii?Q?expPGaGNzrHOdHp6Gg8VHvzlhVnyzl7SPuBbySPkpGmxzGdVxMtwgHWwQgOy?= =?us-ascii?Q?4jfsVvZn3txxkXnMWTzy4kmZcaPJ35kGH8gSiATTjWALddrAR9CpqMRrbcfJ?= =?us-ascii?Q?IwggHr9fXYzLDHw+S4jGcHAOu0fFG0dVd1DddqK2EAkWxrq9JYZtIbiB1xVg?= =?us-ascii?Q?Bw8KXRZ7yccK8RPIi2iFjVIMwJriS9qUHPjfMTR2Og1ilviyqFrARZZRmtKc?= =?us-ascii?Q?qJ8y5WFwN+Ya/R0izZiQC8uY022WW9Of12FKXyIWJXhN13JRVqa598K9ZfvF?= =?us-ascii?Q?6CcwWJ0fJK1B7vfpDxsWODU476wVDbihhicC/kXIhA7cuwLJf6i5OWk3K95W?= =?us-ascii?Q?LS5kPm/enFjdb8WyzR0MWgxErRZSg+38TahkmJ2kmm/sdcBbfR32DycAOA3T?= =?us-ascii?Q?V+9iN7XUFiLZN+4bhk/N7XrdWCChPWxCHy31wGhGH3HlX9VwkFeVsMaorqYN?= =?us-ascii?Q?2iBO9e6FXlsJGYRFjcYrjUCqrGtcma/BVOmJ1DLZ0L6T2sh0pg20pvcUA3zP?= =?us-ascii?Q?IfMAOoOgvC0dlWd/Qg4sZCtp?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5150.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73eec7c7-e0d2-4345-c41b-08d955a7b499 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2021 11:21:42.6296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wq1Q1OIiRO2Ravzy/xciMj4m06YnUv87e/4xiJwOpq8mlHLLMlwJ9GWp0xlDz55TWcRtr+a0IWdYUunxfry0Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4292 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Thomas Monjalon > Sent: Friday, July 30, 2021 8:04 PM > To: Gregory Etelson > Cc: dev@dpdk.org; Ajit Khaparde ; Andrew > Rybchenko ; Yigit, Ferruh > ; stable@dpdk.org; Li, Xiaoyun > ; Tomasz Kulasek ; > Ananyev, Konstantin ; Olivier Matz > > Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum > calculation for tunnel >=20 > 30/07/2021 10:39, Olivier Matz: > > On Thu, Jul 29, 2021 at 08:01:41PM +0300, Gregory Etelson wrote: > > > csumonly engine calculates TX checksum of a tunnelled packet for > > > outer headers only or separately for outer and inner headers. The > > > calculation method is determined by checksum configuration options. > > > If TX checksum calculation is separated, the inner headers are > > > processed before outer headers. > > > > > > Inner headers processing sets checksum values to 0 unconditionally. > > > If TX configuration offloads inner checksums only, outer checksum > > > calculation in software will read 0 instead of real values and > > > produce wrong result. > > > > > > The patch zeroes inner checksums only before software calculation. > > > > > > Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum > > > engine") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Gregory Etelson > > > > Acked-by: Olivier Matz > > >=20 > The previous acks were forgotten (it should be added manually in the patc= h): >=20 > Acked-by: Ori Kam > Acked-by: Ajit Khaparde > Acked-by: Xiaoyun Li >=20 > Applied, thanks. >=20 Hi Gregory and All, When we test checksum_offload related test cases based on dpdk21.08-rc3, we= find that received pkts with bad ip-checksum when send ip-checksum=3D0 pkt= s. We find this patch is the first bad commit id. Could you pls have a quick l= ook? More detailed refer to https://bugs.dpdk.org/show_bug.cgi?id=3D768