From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E922459E0; Fri, 20 Sep 2024 10:35:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BE1A43353; Fri, 20 Sep 2024 10:35:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 17C3F40669 for ; Fri, 20 Sep 2024 10:35:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726821313; x=1758357313; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WGyMN2hNRm78R7oNpKczG2bP7vasdJXC7FKu5XyrACY=; b=XM+jgKd7T6D+/nnxiA4uPysbK9qs0B+YMpY6NPzgg2qZ2GXpjs9ljVuw 8qPdriHvX4OLAIK4gAw1ac/1/VIku1jd9eH/IF/cyuoR71ga34GM+D8SV lErr/msra3T3dFReyBZb3Pwd/s30cTT5AI5MEWKaTex55a8DDat4bJqiz Pg4QdYXW1Oao8rc5sCRTXOMca+lTudVv0+7ZASlnEARJei3bNPyg9QG4O Oe5iLP89BqgNA+FcgN50Hal0/9PAGT4pa/ShZ8QNzELBk1gJBDUucxa+X O22KVmVgsXubCqvFExQPyvNNQW8gFcG9jfrKomVp01kwulHUVaCKLs4PR A==; X-CSE-ConnectionGUID: RlkzBJJKRBKSQo0D3Ax/Ag== X-CSE-MsgGUID: GH9me/6rSVCJXnowAWTsfA== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="29604957" X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="29604957" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2024 01:35:05 -0700 X-CSE-ConnectionGUID: Q98dDwLDRWWrQf74genY+g== X-CSE-MsgGUID: I8SEucIrQDmk90hZEyIoiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="93540173" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Sep 2024 01:35:04 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 20 Sep 2024 01:35:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 20 Sep 2024 01:35:03 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 20 Sep 2024 01:35:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wPQuP3oyYYRCfpTRBoJQHMyt5M+ttDPDDRr9dMCGKxi93NwU+vcZVtuexacNvEqMm6+p6o4OAKRNfe1e9/Pny3MbmpW9tDhlc9LFfBygjEcprFcPBRUtnrMyIwVDnzNhYWhTDDiMmmIHqwIDVrAx8aC5rlfsYNW3h2FMwP5E6S2RTMQkYbvgCLuAhnUnOc5u97b2z1q+S6tTtja18EAR/KFegwflFMG0x8K1LVhCOixIPU/8htqUmdpw+J8wUuzkPTbKrkFHt7v5BJmKRlhGTjjhLmpXrjYfpyI+x31AIj/B9f+tzVmi+AkiQYgyGLR9nMByIhrgg9qh6f4YrNflxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=85dqeWnyHfkmwwGNhElYFTMxXZeZP3qzb9dZF2AmPl4=; b=OGFHBY9agSRPq7gOP2CBouRwFac6D5aYwn67Js0m4eG+JgB467J0DpngKQY5eP60GyXKeohgZb70fpOYMg9n7GAhieTX+NdM04sns6EhjH7VOVaB5I3g6yaAXceOzTQyTch7NgZAtk3CNZVkTIbkIhhziSGNB5fltfvn5rS56N2M+Eqj00U6lI0v2zuQhsh2eJdTni/sYM18rcnVcYZqKRZukEgUvTr2s/omSSFM8fqV4vdG39jxhhexprM3OBa9isV8jqy7JiItRHAYWaKLvIRnp1r4maJYIOUT/a7M3JSlkBjyWMCD8HOv9HrUJltXQKzV7yZ2Ic4OoCCZDIOELQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5613.namprd11.prod.outlook.com (2603:10b6:a03:3ab::12) by DS0PR11MB6423.namprd11.prod.outlook.com (2603:10b6:8:c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.22; Fri, 20 Sep 2024 08:34:56 +0000 Received: from SJ0PR11MB5613.namprd11.prod.outlook.com ([fe80::615c:ca2f:d093:16a9]) by SJ0PR11MB5613.namprd11.prod.outlook.com ([fe80::615c:ca2f:d093:16a9%4]) with mapi id 15.20.7982.018; Fri, 20 Sep 2024 08:34:56 +0000 From: "Zeng, ZhichaoX" To: "Richardson, Bruce" CC: "dev@dpdk.org" Subject: RE: [PATCH v5] net/ice: support customized search path for DDP package Thread-Topic: [PATCH v5] net/ice: support customized search path for DDP package Thread-Index: AQHbCkIhlkdPOctHwUO1hH0mYf7YnbJevGyAgAGZmvA= Date: Fri, 20 Sep 2024 08:34:55 +0000 Message-ID: References: <20240913061537.2077253-1-zhichaox.zeng@intel.com> <20240919032934.800979-1-zhichaox.zeng@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5613:EE_|DS0PR11MB6423:EE_ x-ms-office365-filtering-correlation-id: e9dfd846-c817-48ca-dbaf-08dcd94f1b23 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?b7bXHX9IfKv7ghp1/Ss64xro0u6kdOOoPn1ABp2Gt25Y87fboIiUnTT52LrT?= =?us-ascii?Q?Xj77fi6Z6ocD5/BDp0Jz9+t3GB7hZ0NOnc43ZqyB5cB0aGCmah6psHgsI7Hv?= =?us-ascii?Q?zzcozpDcKC8KfwTuxwdJ2FXZ1LoOZZhFDOaD0k7YT43wR8MuFMGP3fsELpVK?= =?us-ascii?Q?1N3rtAfOBXJhhkPQuwpZG94MjjqFlMk8OJyhR00lxpBLlHibf6Joco4EnwLu?= =?us-ascii?Q?uISCh1c6LpQEfs+3wL2YF91BdqmYgOmohy7Mrtw2QKGa+6XL0sSdkwBf2W7E?= =?us-ascii?Q?W9AH51eTl8TXT1aAEMeNhnP0K8eplHEO9uyLN1FpCpaOAKRyaC1UrLroNa4v?= =?us-ascii?Q?NmrVAJ8ec8I4iy40+TwwJ39Vg1pS5Uf13ovc0Ul9Cse1zsDRbNndq0NEUogC?= =?us-ascii?Q?Bp237vcdFSBP/IkZl1CjbRw2UVTovugqgXpoljFN4HcC9BBwIvZf+Y0GldDY?= =?us-ascii?Q?B2fQ4knaRlF/eGilMBVjBYbwP+Qj5AlWV0lfuYxi6Huwtwjo3xpd8JBclB4q?= =?us-ascii?Q?YeXjBdeWK/zrdE1GjRbx6LxbQpnDHe40CAHTTlsZovBej9JvxoVDOi+OI1bW?= =?us-ascii?Q?RVfJ13+2dx2gifDkWsETj1A87hRl25ZQwV/9u3ea4PeODPSDZekNS+SchI2d?= =?us-ascii?Q?ilfspzGitnBHlHdZs5mvL6gB9OIpwtBWYWt8Mp5WPkfefdEsicozjvXKGcyB?= =?us-ascii?Q?myJ6YcUI8AlrVzsQvGo1SwGlD3KRqHBMaXfaR082erZkD+DSYPU42Sa3leiy?= =?us-ascii?Q?ZUmE+lDFJtv7zyL9tZ/c2eheildth9BY2Uw/mpvnQYxNg+O90HCPgZXL0nCq?= =?us-ascii?Q?ju70UekrRNenMzr3OaDkK7vjcJ1+bCoFZJ3cKoCK7bWhlwPTvHe8k2mFB2xM?= =?us-ascii?Q?u8AJ9mdY+kCheYJ4izhMmPlRRwcN4dwjcISj8/AXNJZ5MUKRsVUlUEkOPrW+?= =?us-ascii?Q?ZlRCkEbn69eVmr/nVLkFRrhkBuLGqL3+y7frmnRaqCBvVWdENaen5CKFS0Tf?= =?us-ascii?Q?n/u8AU8FTGFRHoVI9XGvBZkMZPwr3DkoGHbdWPlWPSxCD2Q6GyRD/w93HKFx?= =?us-ascii?Q?Ai4c/sbCcOgSU8gWo7ruHHLS3cS40S/p6FF/UtpCuNjsek5ya8OSj+snLrrd?= =?us-ascii?Q?/yAS3mYCOoH7DabNkeMwJjZrUhKkY+c02c7qMtzLkE8lxk4XW/ksWpyy0iM3?= =?us-ascii?Q?tlwogrgm7+/e+j9EH1E8KAwn5tvmeWduiuBJ4Ia7FT3HP/1ASm014pZD86Pi?= =?us-ascii?Q?8eYw9S9GsinSYvO5uRX4jiWSWY6NtGuIosGR+OJGD74oD7yu89OdOBV5gi2f?= =?us-ascii?Q?u08LsSKa/UkNwe2EkTWcko2Ik5RtgWjQVLFJ7BOjMKgvFS1rQB9vjJx5rCg5?= =?us-ascii?Q?X+wKN2NyKaaaSEoIi5RfLP7nZiX6Xq28kZxYl6FMceb6kJmCmA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5613.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a3WdsFk6ACr6VHYRMHlGqnZYA7kv4+HhqF6XiH442UO+0pWZYlD952ZmwDkH?= =?us-ascii?Q?NexiCazEoS7Y48LzTQoaL7h59I2wfXa5S6XeBT/RgqzA8Ef3gxDj5GQmNTAN?= =?us-ascii?Q?LctH52mYqgte14klzm7Fik+kTqzY9Lyqv/N/6SDHv7PgkA70De9otWQWPHX3?= =?us-ascii?Q?CFmpgc3G1ZdfQO1/XsuWPOt+yhZjep9RgixUn6RIUehYeRy53TBPISti611t?= =?us-ascii?Q?UB8T0dx3QEj5BykGseRZAHpA3GVG6zznu8VpSh93aUnfFYP5esLPBqBgZZls?= =?us-ascii?Q?tJt5yG9rUhmkOqz+/MaejgVbegSNeJ7GtiWB86pmj5kpBm+GQgy1UiG3s73u?= =?us-ascii?Q?sYKcwCNg+QYGxG9b8hzftpnd15bwAFgjwcEvy4yc7Uzix/1iGfwuuoQJQHOu?= =?us-ascii?Q?P6e7hcdDQQnXrff+Takaf/HcxQMQG5Irn222Exy+Zl4yJubvaA1YP8qeAkg2?= =?us-ascii?Q?Hgh3Z3p01q0BoisR2OL5i2NgJM0V9LmBctpgVTTgiXgXLkVpTuSpbDYQcTAY?= =?us-ascii?Q?g7ieSvux9yUBe4wJCvmnrfp4unZ1Bj1l2F1oWqLxGo0X8A0jIGKiamaKulKr?= =?us-ascii?Q?ttLHL+FNBOmjbIKcYyCDKm9k1ngetUrXnkIvvRVCoi9gZhCesygDs8ZudwKP?= =?us-ascii?Q?kJ6KZ8lIbGuCo2RkcMF6EJFcWfK4XJdb6Q08aFuU+VoHWEUh0r/UIqxnv8Hg?= =?us-ascii?Q?SOxz0SeiHL00fzuVDpOHPvsQv1Bt5Hw+9xTnw7JKQc0m7XT+Qc3MH5lmFx2Y?= =?us-ascii?Q?gE36PkYiUG1h73FIXiq6X9wvE9clqxUQHxjY5jPzaDu2zbAMXdwtWhpdOrbm?= =?us-ascii?Q?qmne6210BqPFhlEHbVZOozVgmbRYWXwxmEmqfRT3flfpHQuNsUF9uCq03QvX?= =?us-ascii?Q?o5W8JJlpjsWqqLs8fV3Wr7mwBrEN0kbCZ9zBU2+7yKADwnbS16pfD/wf1wUp?= =?us-ascii?Q?d/xQivXPISe0n7emcxXkdYSFRj33AdbMTnTmUFeISPUKFhMWGx4fMLBTQd3F?= =?us-ascii?Q?lZNKom1bQbT3K31nihzCwNoAzWBfV/QkIA8EZI1OiejtbMIw7rZjOvEFlHTQ?= =?us-ascii?Q?7WuvbwdIJWETlbZgvDnu+UBIHpxkct6Zw1Cqb+XU+hbxC7lFTiK++kXBzBOQ?= =?us-ascii?Q?twzcygNXnEPSPToiiQB1YHSXYU8v6wBZeOD/h/ChamjLzl6IsG1OLtCWGlvu?= =?us-ascii?Q?bWSdk7i1M5/oEAojwo2QOKulWZOpDQGB+m2tbWhI/Z8IcU1pezzA3WFCV8Rg?= =?us-ascii?Q?nGhaYXwTCfMvlPKMenUCooBT4/jQvRvKrWbzioIKGgURRpx/7XsSUGB1aZvx?= =?us-ascii?Q?xSNhJtETRRU6OG5aeJ7yifrYqs7d8YKD//Mi6b+JwKJJeYenb+8WKPyn8NO5?= =?us-ascii?Q?issppmI5PzCUkdYbI7BQPnAfySkKYgSIcSsZ2rThrjLssUXIjqZ/+AswJgzb?= =?us-ascii?Q?/mUMu5s1xRneKM2p7D8sUsv0IMs2jSCTguUux9abzQC9Oz3A3Mf/UhfERfAI?= =?us-ascii?Q?yVkplPCODnOEZswSG9xedn5P+PvR2gAujvQqpRYkgcbGDmUV3sg3dUwoWh3j?= =?us-ascii?Q?1yHG6q+hFSHtKiWFNWhQosTloRy5CzERAyMKmzy6?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5613.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9dfd846-c817-48ca-dbaf-08dcd94f1b23 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2024 08:34:56.0507 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h1PCZPWZJ49Hb32lzchJL6i7MA9Qfu8zFOQc1mqcckpljrMxItWDLX6EiudLjqrE5Bcnc1D8eGh+PZJA4tyKEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6423 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Bruce, thanks for your reply. > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, September 19, 2024 3:50 PM > To: Zeng, ZhichaoX > Cc: dev@dpdk.org > Subject: Re: [PATCH v5] net/ice: support customized search path for DDP > package >=20 > On Thu, Sep 19, 2024 at 11:29:34AM +0800, Zhichao Zeng wrote: > > This patch adds support for customizing firmware search path for DDP > > package like the kernel behavior, it will read the search path from > > "/sys/module/firmware_class/parameters/path", and try to load DDP > > package. > > > > Also, updates documentation for loading the DDP package in ice.rst. > > > > Signed-off-by: Zhichao Zeng > > > > --- > > v5: update documentation, fix code logic > > v4: fix CI error > > v3: update doc, fix code error > > v2: separate the patch and rewrite the log > > --- > > diff --git a/drivers/net/ice/ice_ethdev.c > > b/drivers/net/ice/ice_ethdev.c index 304f959b7e..f0389cc4ee 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -1873,21 +1873,61 @@ ice_load_pkg_type(struct ice_hw *hw) > > return package_type; > > } > > > > +static int ice_read_customized_path(char *pkg_file, uint16_t > > +buff_len) { > > + FILE *fp =3D fopen(ICE_PKG_FILE_CUSTOMIZED_PATH, "r"); > > + int ret =3D 0; > > + > > + if (fp =3D=3D NULL) { > > + PMD_INIT_LOG(INFO, "Failed to read CUSTOMIZED_PATH"); > > + return -EIO; > > + } > > + > > + if (fgets(pkg_file, buff_len, fp) =3D=3D NULL) { > > + ret =3D -EIO; > > + goto exit; > > + } > > + > > + if (strlen(pkg_file) <=3D 1) > > + goto exit; > > + > > + pkg_file[strlen(pkg_file) - 1] =3D '\0'; >=20 > This line is unnecessary and, if it were necessary, also incorrect: > * fgets already guarantees to null-terminate > * if it didn't null terminate, then strlen wouldn't even work so this > statement would be completely broken. >=20 > Also, as this line is unnecessary, the lines above it, and the label belo= w are > unnecessary too. The string read by fgets ends with "\n", my intention was to remove the new= line. > > +exit: > > + fclose(fp); > > + return ret; > > +} > > + > > int ice_load_pkg(struct ice_adapter *adapter, bool use_dsn, uint64_t > > dsn) { > > struct ice_hw *hw =3D &adapter->hw; > > char pkg_file[ICE_MAX_PKG_FILENAME_SIZE]; > > + char customized_path[ICE_MAX_PKG_FILENAME_SIZE]; > > char opt_ddp_filename[ICE_MAX_PKG_FILENAME_SIZE]; > > void *buf; > > size_t bufsz; > > int err; > > > > - if (!use_dsn) > > - goto no_dsn; > > + ice_read_customized_path(customized_path, > > +ICE_MAX_PKG_FILENAME_SIZE); > > > > memset(opt_ddp_filename, 0, ICE_MAX_PKG_FILENAME_SIZE); > > snprintf(opt_ddp_filename, ICE_MAX_PKG_FILENAME_SIZE, > > "ice-%016" PRIx64 ".pkg", dsn); > > + > > + if (strlen(customized_path) > 1) { >=20 > Is this really the best way to check for validity of the search path? > I would tend to ignore length and use the return value from the function > "ice_read_customized_path". Again, maybe check the logic used in the kern= el > for validating the path read. Will use the return value instead of string length and check the logic in k= ernel. >=20 > > + if (use_dsn) { > > + snprintf(pkg_file, RTE_DIM(pkg_file), > > + "%s/%s", customized_path, > opt_ddp_filename); > > + if (rte_firmware_read(pkg_file, &buf, &bufsz) =3D=3D 0) > > + goto load_fw; > > + } > > + snprintf(pkg_file, RTE_DIM(pkg_file), "%s/%s", > customized_path, "ice.pkg"); > > + if (rte_firmware_read(pkg_file, &buf, &bufsz) =3D=3D 0) > > + goto load_fw; > > + } > > + > > + if (!use_dsn) > > + goto no_dsn; > > + >=20 > This is changing the search path logic compared to v4. Does it match what= the > kernel does in finding a package? >=20 The kernel searches for DDP packages in the CUSTOMIZED_PATH first, then the= default path. Regards Zhichao > > strncpy(pkg_file, ICE_PKG_FILE_SEARCH_PATH_UPDATES, > > ICE_MAX_PKG_FILENAME_SIZE); > > strcat(pkg_file, opt_ddp_filename); > > diff --git a/drivers/net/ice/ice_ethdev.h > > b/drivers/net/ice/ice_ethdev.h index 3ea9f37dc8..8b644ed700 100644 > > --- a/drivers/net/ice/ice_ethdev.h > > +++ b/drivers/net/ice/ice_ethdev.h > > @@ -51,6 +51,7 @@ > > #define ICE_PKG_FILE_UPDATES > "/lib/firmware/updates/intel/ice/ddp/ice.pkg" > > #define ICE_PKG_FILE_SEARCH_PATH_DEFAULT > "/lib/firmware/intel/ice/ddp/" > > #define ICE_PKG_FILE_SEARCH_PATH_UPDATES > "/lib/firmware/updates/intel/ice/ddp/" > > +#define ICE_PKG_FILE_CUSTOMIZED_PATH > "/sys/module/firmware_class/parameters/path" > > #define ICE_MAX_PKG_FILENAME_SIZE 256 > > > > #define MAX_ACL_NORMAL_ENTRIES 256 > > -- > > 2.34.1 > >