From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43025A00C3; Fri, 17 Jun 2022 18:47:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 853AB4281B; Fri, 17 Jun 2022 18:47:15 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 2EA8640F19 for ; Fri, 17 Jun 2022 18:47:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655484431; x=1687020431; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PX/VRSQo8sTN9kAyXqCDTQ+JxOkcJuXZON5KnD3C5cI=; b=ni1caxYVgfnBwSRCyQeOjdHrDyMUnKDhY/lBdG9n//GbEPZIP+DbSRol DYZaAJ5AkbMLgbyrjksv6UFgTsoT8DyBHwSgsrL4GKcXRsPQyIEnxRiv3 YEw6J8+2z/pnAz242kWLoirtRUL9E/TEmblDk042AZnt7IaywNqCPPmL+ kyg3VNFhhM75r9GKV/LnCCznZp333E+7dR0eYgtSc6SrtU/yqd5B+KApx rRFkD+B8KtVCAqpOV57nbDlotf0rSCxFUcZth+Axwj64sfIjtyE/SWuxZ WfAQdnL+uwm9jtBpsBU5bdLSpvUdLnHnW0rqPSkZz23uXsymwwKe75008 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="259329295" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="259329295" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 04:48:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="653599137" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga004.fm.intel.com with ESMTP; 17 Jun 2022 04:48:41 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 17 Jun 2022 04:48:41 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 17 Jun 2022 04:48:41 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 17 Jun 2022 04:48:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nuGU16RH0mRxHzd4Jz/a90+tcW+g74A7gV9JqnyyZ3Sc6/EWbt3C4zW95AayI2my6PrhBOs/q0OEnhRuAVmGPcYJbL0ZjAZLgfndcIugvvs6IJlUrUqZS2PPgi9hLonaWt5hS/I/kQfn2WDdOwJ/WxcfvONHsWrkSGIsywfFmLQw5NUai8gSPNR2VsiF+5TYplPs/CZf4RY3+EijsVZwfeSJAdDgK6ifxLd2XGQb0CTJZNZK28BdugHmulE47Y24PNen41g8/vPHt/HbjArdssTPd0lGadJp2NcG3GJQcmzFgM9e1pZPrLnFc2E2yaUPclW1AAGVEKl8jWuhFXHeBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bXW1WRDlnA6KUE3yc89ytTWPkjwwism1QUdCHyH/asY=; b=dh3MxxvsObzfbOEKOoPY+cYEDmtkB8Dt3XuLcSjdw5li7/RrPE2X4tiT7gzIHQXvE1MSTpO47Yw2mivI/tnoKZFGYl8MJkMlmEhtbdEB73my1KbxX8n9Lpy1j7nRqLiu4/E8YSPTVIR+l8XBi0/qZkqeYJ5KtyYjC8VYFL/I3ml995UTCUq3p2WV+tRSHWTzcvoBCNsOUxEAi9KjAiFDb1Eri16/XBp49SYE+EixxhkGzkOuy7hWmGD0QUz2RATc7I1Fy4+DIjio2asjuFbnrE7hg3BvnsmTnNFCOn14mLzIVhMAcpHFTKEnijz3UKl4VyQuRNHzJMYGLo6Djf5yIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5677.namprd11.prod.outlook.com (2603:10b6:a03:37e::22) by SN6PR11MB3502.namprd11.prod.outlook.com (2603:10b6:805:da::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Fri, 17 Jun 2022 11:48:39 +0000 Received: from SJ0PR11MB5677.namprd11.prod.outlook.com ([fe80::34b2:c887:27e7:2966]) by SJ0PR11MB5677.namprd11.prod.outlook.com ([fe80::34b2:c887:27e7:2966%5]) with mapi id 15.20.5353.015; Fri, 17 Jun 2022 11:48:39 +0000 From: "Dumitrescu, Cristian" To: "Danilewicz, MarcinX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Liu, Yu Y" Subject: RE: [PATCH v4] sched: enable CMAN at runtime Thread-Topic: [PATCH v4] sched: enable CMAN at runtime Thread-Index: AQHYfwVF2YJ4SUq2d0WahKy+Fm5W661TgS4w Date: Fri, 17 Jun 2022 11:48:39 +0000 Message-ID: References: <20220608094220.1015411-1-marcinx.danilewicz@intel.com> <20220613090909.1161271-1-marcinx.danilewicz@intel.com> In-Reply-To: <20220613090909.1161271-1-marcinx.danilewicz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 565b2fff-42a7-4b03-a801-08da505751e7 x-ms-traffictypediagnostic: SN6PR11MB3502:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CMBo9dikxtGJ9KDI1ZmsPr9UtsiZYuF8ZGsFkZrkXTqXX/eJDxLvTb4fOIEnz3u61mzytaaQy9X04t48R361fHwjv/7cE38fmMz4sAS4vDA9IdunFDwIaE7F1LkEDDRLyXSfIhTOH7kJ95W40upZly0EjqGnNPvrL3QYL7VzzNNTmtz/uoTHEqfcFhDWI5lv3pGvYSpNO8oyTe/PTkGacKWG2O/AWe4Wity8TNMMOqPxsRtkrVP6xw9zH5uaT2396Jmnbu4BHVSEMKxOBuqIfmgZr5GdgKAV27RxL0wZqFzsL3LKqY4wbXvfgq44ArZE9g8B/sIIMgLLv6k5T3i8+hsaAdh/YDwn3OuthXAq0hjk9tTW7l1ALgAA2AJS93aHgd9wdV3pas9tIuUzagF23TmJgCSNHC/Ffo08Tfw2svoY1S4FhyoE3Iscm0aBh7lkuKBVhLq4DSy86N8sEt5S8MhtsTgNnM2JD1K4JN7pU0ZbuN/kv6d7QRhAbEzp7O8xLKK3lEwIZA87/M+lq4z1ypM2Augdm7YKpYbUG5DTxE3wytYgFl1fMsYphYIBuK1NAI3UtwUYA7nUyk3BQT9LVZgapuB8sSb0iMPk/toPdNE/rqHI/gvIc0Bk5VrK9H8euncv/sRpAitXYOUzQTCi+j0showOgV7EmEA5np+XS2s1VMmrwiHEcP3SMMq62nmXqJRKlqnn3bCpu2RaPy4YVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5677.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(66446008)(8676002)(66476007)(2906002)(82960400001)(66556008)(64756008)(76116006)(71200400001)(52536014)(38100700002)(38070700005)(107886003)(66946007)(6506007)(26005)(7696005)(110136005)(4326008)(55016003)(316002)(6636002)(54906003)(8936002)(33656002)(5660300002)(9686003)(53546011)(83380400001)(86362001)(498600001)(122000001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FbtBqSEBvHyKwc7o/9dUygZo4tGvvo4LDu5TLVa4U1JqygBfU3kWcea0FKvP?= =?us-ascii?Q?BvHL7iyqWa/AFcSrKc5bbeA4Jz9FXxox4u4/CtSllio870NS8V2NnUQT6r6x?= =?us-ascii?Q?ai34sCedTxf5qVpW/kqTTrkouupzuydd+OA0ia514NhxquVULX+xfUhi3EDn?= =?us-ascii?Q?yZ6XoVwdCwRPl/li76LTCChagyq5vw0sh99VCFHsW2+woOf7QKdoVfP7LDo5?= =?us-ascii?Q?rhXf90hExqypp7ZGLpQj2aVxxXsYCfqO70aKuCmSRJsrva/6gpRR62XufgCm?= =?us-ascii?Q?MwaNt5PAdB9KYrbv+eMLhV3YbpK2nqgXt6RFR4rApMZ6EV4teiDBXwBfDLQw?= =?us-ascii?Q?QC7ehyCbAE5hZw1F3BCF902V/Jbq/s6JVWRjxKR+NpEBeEtCMnv5HEQaVDeN?= =?us-ascii?Q?fw/9QAmwurmC+2C0lNXgdsHVSOqe3PcqHdsULUHT6qKh8zfwUvJW5d+AnoST?= =?us-ascii?Q?nN9gesMPhvB2Ycj+kyy24VQrf3hxiNvqYEzL/P1htkb2zMWFuXUNekuI/kWB?= =?us-ascii?Q?9ykcpEBx3XUygmWisWqUH32zRn5Ty0IZsngnYAlWcAKWXH8+8YJ1ykNcDWFQ?= =?us-ascii?Q?nJ0ar2fuYS34lLuk+WSJpGwYKBk0XX+6ntetwYAq52EmRJXQwoyTIZhtWadM?= =?us-ascii?Q?6qglqW/mM1zXlG5IOZ/3LddR8vgz6KsBfveB67Pz9rXMLlcaBixFRCIM75z5?= =?us-ascii?Q?icO5Nu7ALOn2Q8Ss2YBFnECEEO4h2+uQee+pk3oDHPGsef1niH8dZB/wg0iL?= =?us-ascii?Q?1qBj7HABt8nGK+MeSwYBxxazpzq+OSbhQGwKjD0vipddz/5KLzK2Co4qD2tG?= =?us-ascii?Q?+yBO7Bkj+yt9qfmahJsDB0Ltpos4l8tXsF6LFJSKHjVY0pWc7N17i+c/tMHd?= =?us-ascii?Q?S2WMMNi69vmyOP+tupYneEr97AGeCj+/jVyoFah6IGxcjFJTZv76Ja4pMj1b?= =?us-ascii?Q?dsiTA7tr1dkJTNUi+ToPOPY/eNsmKLUKi15iAvWG28+NwANOBRzCinEF8wa/?= =?us-ascii?Q?gV6o26fGHE5piS6hyjlDFFxjsJgJ6TZ5iAYj1Cqd8bb0FU9ACMBRVRgSkxR7?= =?us-ascii?Q?sq0CBpb07oj8yQe/+28aPN8lCqKZaRms2oATfc06+0KzFaPG+LEUicvWAbha?= =?us-ascii?Q?b72aU9hG/EXlh1Wn3IQX7NMlDu7q632qJIQskqh1UNuXmcojSM8jkgwUgiH5?= =?us-ascii?Q?LGiRJuxIp9nrvIEu6GNQUWTHUFQD5hvb0URqUIBuqoxhsp7zQKjspnmuLxY4?= =?us-ascii?Q?5EL5qbtjwUniXxvZuzx/3iyTZpX+E8bTnGWuUMP5RYxaKedM19YMEHc398TO?= =?us-ascii?Q?j6JETEwqDpiBhBPB2CLSXTdE9U+O49XDhsRTXKTIOeGu5Lb2wSRAuKE9AGYT?= =?us-ascii?Q?S+e+ZMGILkSMsejTfDKFpAoq2ahBdTdQ4NETmqruOQLH8oIFcWovtvE29qDB?= =?us-ascii?Q?LnHo9bR2pDFagywiy/9vY8EiAAXpv9GcyOWEvEVDi691ps3snzYM82K2re69?= =?us-ascii?Q?L+occr4ke7skmmxcsdYYJbhNFbbpkP9JUV/WBpTStGhw8r18NIUOEngRBlIv?= =?us-ascii?Q?Zp3FlRuX6hT9PRzOgP6BiOqRqyN7OuqC7FhTxz+oQIkVik/N5QTXvdOpPDY0?= =?us-ascii?Q?3ccSWEiJjQIwGpSQL2dzV6N1IQoxiR/Xa2ia+kHLNc7n38aQLXqgc7uaHNIH?= =?us-ascii?Q?j/HQNfdT6P/ER7FyJfjcj68xg7QaUFFOy+Y4ZyPMlR/TRFpdYB1KEN4WwutG?= =?us-ascii?Q?r8Vm4RwnkzIYBSZeyI9/OUN4WgfiLAE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5677.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 565b2fff-42a7-4b03-a801-08da505751e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 11:48:39.2390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MspKEAA1MyZ53ZFlTuXx2qwcij0PLZSMeTu+nD4mc0lrXCYA/Xz3tBwtF2v7Mi7ZWL4c0mV8+Oq/zDpVXzv2aZoI98vOAub6qVdb9KEPE/Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3502 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Danilewicz, MarcinX > Sent: Monday, June 13, 2022 10:09 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v4] sched: enable CMAN at runtime >=20 > Added changes to enable CMAN (RED or PIE) at init > from profile configuration file. >=20 > By default CMAN code is enable but not in use, when > there is no RED or PIE profile configured. >=20 > Signed-off-by: Marcin Danilewicz > --- > Log: v2 change in rte_sched.h to avoid ABI breakage. > v3 changes from comments > --- > config/rte_config.h | 3 - > drivers/net/softnic/rte_eth_softnic_tm.c | 12 -- > examples/ip_pipeline/tmgr.c | 4 - > examples/qos_sched/cfg_file.c | 11 +- > examples/qos_sched/cfg_file.h | 2 - > examples/qos_sched/init.c | 4 - > examples/qos_sched/main.h | 2 - > examples/qos_sched/profile.cfg | 130 ++++++++++----------- > examples/qos_sched/profile_pie.cfg | 142 ++++++++++++++++++++++ > examples/qos_sched/profile_red.cfg | 143 +++++++++++++++++++++++ > lib/sched/rte_sched.c | 47 +------- > 11 files changed, 359 insertions(+), 141 deletions(-) > create mode 100644 examples/qos_sched/profile_pie.cfg > create mode 100644 examples/qos_sched/profile_red.cfg >=20 Marcin, Code changes look good to me, but still not able to cleanly apply this patc= h on top of DPDK latest with git am, can you please make sure this gets fix= ed? Applying: sched: enable CMAN at runtime error: patch failed: config/rte_config.h:88 error: config/rte_config.h: patch does not apply Patch failed at 0001 sched: enable CMAN at runtime Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Regards, Cristian