Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to internal header file

["Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>]

> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Friday, September 10, 2021 3:09 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to
> internal header file
> 
> On Fri, Sep 10, 2021 at 02:36:50PM +0100, Cristian Dumitrescu wrote:
> > Start to consolidate the data structures and inline functions required
> > by the pipeline instructions into an internal header file.
> >
> > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > ---
> > Depends-on: series-18297 ("[V4,1/4] table: add support learner tables")
> >
> >  lib/pipeline/meson.build                 |    4 +
> >  lib/pipeline/rte_swx_pipeline.c          | 1373 +--------------------
> >  lib/pipeline/rte_swx_pipeline_internal.h | 1383
> ++++++++++++++++++++++
> >  3 files changed, 1388 insertions(+), 1372 deletions(-)
> >  create mode 100644 lib/pipeline/rte_swx_pipeline_internal.h
> >
> > diff --git a/lib/pipeline/meson.build b/lib/pipeline/meson.build
> > index 9132bb517a..ec009631bf 100644
> > --- a/lib/pipeline/meson.build
> > +++ b/lib/pipeline/meson.build
> > @@ -18,3 +18,7 @@ headers = files(
> >          'rte_swx_ctl.h',
> >  )
> >  deps += ['port', 'table', 'meter', 'sched', 'cryptodev']
> > +
> > +indirect_headers += files(
> > +        'rte_swx_pipeline_internal.h',
> > +)
> 
> internal headers should not appear in meson.build at all, as they are not
> for installation. "indirect_headers" is for non-internal, public headers
> which are not directly included by apps, but included via another public
> header. For example, rte_ethdev_core.h should not be included directly, but
> by including rte_ethdev.h which will then pull it in. [The reason these are
> separated out in meson.build is for header sanity checking, to check that
> normal, non-indirect public headers include all their dependent headers]

Yes, my bad, fixed in V3 just sent. Thanks, Bruce.