From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66768A0C45; Mon, 13 Sep 2021 19:07:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6CE140151; Mon, 13 Sep 2021 19:07:18 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 4C0E54014F for ; Mon, 13 Sep 2021 19:07:16 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="221770944" X-IronPort-AV: E=Sophos;i="5.85,290,1624345200"; d="scan'208";a="221770944" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 10:07:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,290,1624345200"; d="scan'208";a="515521478" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga001.jf.intel.com with ESMTP; 13 Sep 2021 10:07:15 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 10:07:14 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 10:07:14 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 13 Sep 2021 10:07:14 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 13 Sep 2021 10:07:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUzAaP0prDigbRxDBJpHWzCYrdE3HGDA8svnHhhnZ5YGNVAkhtPDMSeA8jfZ2iTAK539n9OayWmyHrSDgr7KsYGMjqP3/ynHBlsriyC5QH/RCLPpvK5CtUVy8CETMvn99bfTru/2xbNy2Ndfrr34qNTZzpvihYGheCqfv4goVcDYQX94IqE+iORcAd/wNpIeZtt9BEGor3TcA7sQlf1h8WQnRVZU7pE9Baq8J8w90iS39S+NspuMCmeK9asT8e3Byl08ygJe7kTGppmP6I7hAOsCBgL+/csMlhUxnhFF9W6bRyX0DcHmaU0xTXeLTHqgo5GnZ0tF5gsOTBGyTRA4CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UvHGz29bhOaaaZifCvoHYX5yBFBHXpnQlOtNANdEkZE=; b=JlvVsCkcFroa62uh10vxRlulj48VrCi3A0rSQSL0wOynbUJ3TfS132lJ06o16vBkDebvtga7WuRq+gFr2vLE8K6aRhFLpB14/CT5bFZN8DxgkWf1hGK5DOW2DCEnbrVKfnXVG/Mk06173jg7BeRZ9+uRNgoq4qXhKABaFwbhCajhm291Mrw2LLFGd6fkCYgMz4MRpCzRcwauOlj33rg7ZRDURanxwHlV/C9h9O0lBEujxDW8lLW2BNqLO9PR/70WEGKT67lXYpjmghPb/T4Gpt4dduVyOHsaIzGgGpDb9PoNQUjMNlb/+slFTFo6QN/mie3VPS1yQrdEYuQ1WDHv3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UvHGz29bhOaaaZifCvoHYX5yBFBHXpnQlOtNANdEkZE=; b=eNtH8175it0KZk8dNeD6aKiXrhJ40ZvjpZJCtArDhGfFGaFSMby4iNgmswB5ygGGDuTYMamIvPMpYMeD/p7Bu5kTUCPAEaYpWyt+4qvqE041hflcIGYIMzGMJN5TRn5+jASE8tz+s9/ukXHf3wNxjZqQxfd5Q6Ab9/YIyg7q8nM= Received: from SJ0PR11MB5677.namprd11.prod.outlook.com (2603:10b6:a03:37e::22) by SJ0PR11MB5631.namprd11.prod.outlook.com (2603:10b6:a03:3ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Mon, 13 Sep 2021 17:07:11 +0000 Received: from SJ0PR11MB5677.namprd11.prod.outlook.com ([fe80::d8f9:7238:8809:3412]) by SJ0PR11MB5677.namprd11.prod.outlook.com ([fe80::d8f9:7238:8809:3412%5]) with mapi id 15.20.4500.019; Mon, 13 Sep 2021 17:07:11 +0000 From: "Dumitrescu, Cristian" To: "Richardson, Bruce" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to internal header file Thread-Index: AQHXpkkQHQBMREmt9kGWpReoSozoNKudTleAgATokTA= Date: Mon, 13 Sep 2021 17:07:11 +0000 Message-ID: References: <20210910123003.85448-1-cristian.dumitrescu@intel.com> <20210910133713.93103-1-cristian.dumitrescu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cfce39dd-ca69-4a3f-8762-08d976d8ed6a x-ms-traffictypediagnostic: SJ0PR11MB5631: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q1NC2ZXp2wovME57FI+l9G/T0JSe8B0zwQWXd9VkuzkR/bfSptLRrpR9J01KIzwVDKqh1Uf0Vk/VTH/401/g+r0iSnIWLbmRgMeVeoSYhIwT7fX8fO601aXigQRSp8w/+wX8uAiZvO5fnV6X7h5Hh3UX4566Up/wxylWsDq1y8zjy05W2K0Pa5LZm5cWZx3ZteZHadbvhjg6UVvxMx5Yt1xGl9l2eddIir3ycVoSc4Q+paInEi+bFFosK3miLeCuF6NIoI9B0mL4B+ytMRfk0bcRUH1qh3G7MuzsO1F0hJkrDETL+2VwZqZbGw+4FeZ797DgyP376esU+sBhzjbHNPiI2jANiWyX/HB1mSA8zZ9oXtRduuALyh/Fedmn0verfDLmYpPyQqPFa2/yiq6DQ++AztMpHiQv0eRagVCUO28yCzqv22wQmt2kG4dZ2YPnPJ7osSnD/b/FEHDnfD5NU3xuq/tsruXztiKSLwpGKCv6qq7VJ77mP6yVsU0+hN05ThnUAqeFMDz+Iv4ldQVPYszSOMZ8MATrnxj9mcTBVv+COfngKDEjTvIhmPybF03U7Kj58Y9eQ2O+Q8pa5xn6zNGYxllBoka/9jWtuKBK/oZpgMlXL4puEpPbuRJS7B0jOhoNGkam+wRAwBu5jXTEQZaczK0iesQAySbSWkIOKJwNLliqxy+pVyjSADGYfM1eltjvOeAlqPanASB76qbHjA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5677.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(136003)(396003)(366004)(186003)(6636002)(6862004)(26005)(8936002)(6506007)(53546011)(7696005)(8676002)(76116006)(4326008)(5660300002)(52536014)(71200400001)(55016002)(66476007)(66556008)(9686003)(64756008)(66446008)(66946007)(86362001)(2906002)(478600001)(316002)(83380400001)(38070700005)(122000001)(38100700002)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mRTdWNWnNhtZraj27JKpNLFStvHsqDWAs+nH2EI07aILqOic6Y0/UvFeAZH9?= =?us-ascii?Q?5VHyqP43zZLyXd/iEXtNlGkY6pkFOfYMP1sYSbq7tNcu9zs5XrrjTT/A70GZ?= =?us-ascii?Q?17+3mGTBL0+ZPwg/fzjG21LZq+MdYctA+JPgyIfjREvXCcwdoMBuwdHtTavZ?= =?us-ascii?Q?BjBeq9g8y1CjtzkrIGqKNHdg5n55U6+dQ21kluHu5/Zaz4tzQzF6VsdxjUy2?= =?us-ascii?Q?4FhJ1jiKbH9FCH3pV8cXs0XL3LmLnMOgP5KmzT8+4z9dGJAGLitakkEwF4gS?= =?us-ascii?Q?Dc43UCPrVdpo2ZWTs5bNOYmVl6flPfkZ4us3kB3kVFcHp+cWZdSAbRJxixAF?= =?us-ascii?Q?/pZpLUi2tQwolHp6wrZ3iOtVFvn4YzXi1LGC07WXEk9gmIKpd9nHgBDnKf+u?= =?us-ascii?Q?bfn5fkfbfcIOTZJRGNFCq4G+KpwYiFNuc4FuD/MDXva5ayPTlnTG7EpMQ6/w?= =?us-ascii?Q?UZWK2Zo6R2i4VZkmSIOXO8XjFY1i0GK5LrZsutpg4qKGOTKWJx2hOPdMRhVS?= =?us-ascii?Q?ya0jC3X1GKvQEuGb+/I0SqnggUUXKQ+eBGLf6qoK/IAqPVbvlRzpUrdsZUS0?= =?us-ascii?Q?AhHTT1RQ7SHcKvoaMF8Jno+1Sh/UVUKDiBWY3mwtnveWNAEMwrrUxV3OsPgg?= =?us-ascii?Q?FdCA82Tx1NSJmZgfP0HoFpVCGKABn8r173HMrDlhDpNV8KjntD7ghDMg7S5Y?= =?us-ascii?Q?ChOK3X4m7eBqJK6CV/8ciVczp0MKINdRc4uw+vGTClPEo/7x5UOBWBU4KOEW?= =?us-ascii?Q?tC/g543t2nF1ibHzBhqYe832BDt8wsIJHeLfsRCNQReDKjoIGYCm+Ji+6nex?= =?us-ascii?Q?iHKGjE48c39dWK9nkLsSXZiymkImgGbS/mHOj4AcoMefKDRh/WL4GvaROv/r?= =?us-ascii?Q?oaLMgLFQr2xBjxyKp5RTt3t/R3dISQzZIEm1+uX3G3UmSo5NhcK+4HX7LtCy?= =?us-ascii?Q?Ui1fNQOBEMEy/5oTvKZs30qZw9TZA+zYvP2BZmd5rxrYGaEZiJBEP29AXHC+?= =?us-ascii?Q?73EZIi7COsYorT1gl1zjSt2bDj35G2rxWYta36huTNE4kJZIkOSDFDHw2rrU?= =?us-ascii?Q?TH74kDY5/p2KCoLqM5LNSVOhfFKKcq1gk+b/nER7s6owDOdykr+1R4jJxrBF?= =?us-ascii?Q?iUm34WYdBRg/3md5CPtXwNlB8YsBA4azPJ9FlRhiCgSZNNw5cjipd3GWoEkX?= =?us-ascii?Q?A8MPbtTaNF3RWcsAeRTlXXXqMrcEoLPdHHKzXwvIAkCeZSv7PV9pbGEh+S2Z?= =?us-ascii?Q?H1B16092330flYKUuRBwVBgPmndniJxBlfujDJrhXi+ZYPxjplZK+2jL7rJg?= =?us-ascii?Q?A1k=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5677.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfce39dd-ca69-4a3f-8762-08d976d8ed6a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2021 17:07:11.6925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xGrNUBZWT261tQmAd6CoPGwI+m8WDWucFpPzWqQrLc7NJDO7wgFq1EFkNBz+sPJ/3wknEGkQBqtK3AG/O5J7Gc9EEbIhseaVAqRpORkYx5k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5631 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to internal header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, September 10, 2021 3:09 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures t= o > internal header file >=20 > On Fri, Sep 10, 2021 at 02:36:50PM +0100, Cristian Dumitrescu wrote: > > Start to consolidate the data structures and inline functions required > > by the pipeline instructions into an internal header file. > > > > Signed-off-by: Cristian Dumitrescu > > --- > > Depends-on: series-18297 ("[V4,1/4] table: add support learner tables") > > > > lib/pipeline/meson.build | 4 + > > lib/pipeline/rte_swx_pipeline.c | 1373 +-------------------- > > lib/pipeline/rte_swx_pipeline_internal.h | 1383 > ++++++++++++++++++++++ > > 3 files changed, 1388 insertions(+), 1372 deletions(-) > > create mode 100644 lib/pipeline/rte_swx_pipeline_internal.h > > > > diff --git a/lib/pipeline/meson.build b/lib/pipeline/meson.build > > index 9132bb517a..ec009631bf 100644 > > --- a/lib/pipeline/meson.build > > +++ b/lib/pipeline/meson.build > > @@ -18,3 +18,7 @@ headers =3D files( > > 'rte_swx_ctl.h', > > ) > > deps +=3D ['port', 'table', 'meter', 'sched', 'cryptodev'] > > + > > +indirect_headers +=3D files( > > + 'rte_swx_pipeline_internal.h', > > +) >=20 > internal headers should not appear in meson.build at all, as they are not > for installation. "indirect_headers" is for non-internal, public headers > which are not directly included by apps, but included via another public > header. For example, rte_ethdev_core.h should not be included directly, b= ut > by including rte_ethdev.h which will then pull it in. [The reason these a= re > separated out in meson.build is for header sanity checking, to check that > normal, non-indirect public headers include all their dependent headers] Yes, my bad, fixed in V3 just sent. Thanks, Bruce.