From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 017474414D; Wed, 5 Jun 2024 07:48:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9563402CE; Wed, 5 Jun 2024 07:48:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 57B3240269 for ; Wed, 5 Jun 2024 07:48:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717566529; x=1749102529; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PDVNgVkuO9n0CYLwo2afrAOeuRxDDwJ/D4XwkL/SHSY=; b=XCtb21O3F1geBGnnf1AMfeh20AjvOEUql7wd+AE3KIzf8zeqfSXlfPzI XYkOkPXTwrjLnKci1A7KkYaYTnrLO1VWvLVXkgEpdkiaV6ORKtxrWIlB7 B/PTqNavCVKMYAEzQojDO8Hrw7cENw7d2e8YTnAN34mLxB105eeXYMlHi NuefiHv1nt1amAlTBM8s2U6ZxpIO74zCZ29b0Ieki8SMKK0rBo8XkXYYb MMvKtZIS/hXsDJp8uRaAhZqenU1Ldr56r9kX40xqZ8TNORPW0tOuCMNsT tTQ4K3HWqLRpkQyNL6KiroM7osxZ5ZqBFPUXD71AJ9ysUFJZHXNHy17Uy A==; X-CSE-ConnectionGUID: z0scc8XLQPS9EN7ipp1SYA== X-CSE-MsgGUID: J1Lff2ftSk6bmQ5kYbu+Ig== X-IronPort-AV: E=McAfee;i="6600,9927,11093"; a="36669705" X-IronPort-AV: E=Sophos;i="6.08,215,1712646000"; d="scan'208";a="36669705" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 22:48:47 -0700 X-CSE-ConnectionGUID: JtfHunhES1mq0MwpbI2vfg== X-CSE-MsgGUID: vvqCVYJTS0aViZ3vDj/HNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,215,1712646000"; d="scan'208";a="42588592" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Jun 2024 22:48:47 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 4 Jun 2024 22:48:47 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 4 Jun 2024 22:48:47 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 4 Jun 2024 22:48:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PhJC+2UUQrd4AmWDUzBcoRVZp/zguEJu6lDlseq/2fo10nb9Nxyl7sE5eoq4wwqoxMwVxpCfPqveFLhfoOIxibV8+3LfKIVMivzQEZQSG9qksHPlxg3ZE6LQ3pvDdHFCZT8ZrmVhu+MRgT0Bi+SZp6K1R467LeLqL/gnwIoH1daA95pOM4NnyVYyy4fdMp0IIa7CbvAc57VeMDZoBQDnIOYhasVYCxqTwt1G91DDVhmBWEj/0swmts8hafLGWBLEurXMolNlparQp9Q/+KJc8BqOtaloj87OuDSjgyGNuy0Wqsa5wJVET1/m3j8mJ2krMYeeenkBuv9UAV/6Wg6HHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C9J+22/Q2VHbo2uzQ9Nt/2bWcRNhkP25l5aGy/twCa4=; b=Pa8rM/luc3eFcoMXTUgzSp10zH8ckt1r15goZ2xsXcFDHJzNqY04BMsFKjI//6UZu9tD04KsW9S0jhzT59tTGLpcvFbZzmIgKztwDB0UUZv8GaJ6/tqgY+wcY0jIybi8147Xi5rwMcpVl0SbioLCv7p4OdYHCeGRV99bhCm/4+og87yAsqML0I0MagviJBnZsK8CB8FlrYZyLAdKy13qmexwz5pcICTjSSzxpE+YxaYFSrm3u35H2Zn+G5uDMCskckrzvI5Y7czFBPAUKKcY0Pp1bZTHY3CWB3DvhhMrlLQK3CDVrFGpcsB/0kTNb076mqq/6I9zRmhOqgVjcvBrDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5918.namprd11.prod.outlook.com (2603:10b6:a03:42c::22) by SA2PR11MB4986.namprd11.prod.outlook.com (2603:10b6:806:114::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.27; Wed, 5 Jun 2024 05:48:40 +0000 Received: from SJ0PR11MB5918.namprd11.prod.outlook.com ([fe80::891b:9bb3:428a:c72a]) by SJ0PR11MB5918.namprd11.prod.outlook.com ([fe80::891b:9bb3:428a:c72a%5]) with mapi id 15.20.7633.018; Wed, 5 Jun 2024 05:48:40 +0000 From: "Wani, Shaiq" To: Stephen Hemminger CC: "dev@dpdk.org" , "Richardson, Bruce" Subject: RE: [PATCH v4] net/cpfl: get running host ID for CPFL PMD Thread-Topic: [PATCH v4] net/cpfl: get running host ID for CPFL PMD Thread-Index: AQHasnWIW9hLyqEN3UCVilXAFlweCLG30IeAgADhRRA= Date: Wed, 5 Jun 2024 05:48:39 +0000 Message-ID: References: <20240524040553.487093-1-shaiq.wani@intel.com> <20240530093958.801348-1-shaiq.wani@intel.com> <20240604091741.3855caf0@hermes.local> In-Reply-To: <20240604091741.3855caf0@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5918:EE_|SA2PR11MB4986:EE_ x-ms-office365-filtering-correlation-id: 79af0a29-03dd-4b30-8d06-08dc852326bd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|1800799015|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?Ov//Oj1f2Ucqy1odEKUJqIuSwhbBu1iAsPPliaHkxsSmamp5J8yGBMdWfI1D?= =?us-ascii?Q?/MGmRy5F0xYYLEddE1/9NanSNhdS9zJ36xnxajpyF3vNwze1HSQXDWAXk6Ru?= =?us-ascii?Q?raRYoWlokQqKwUnSCC5/1ru6NRNSngHrV6rrpVjMd5j6zS/GX2zx25S4ioAT?= =?us-ascii?Q?NhB58pjRbtyN4o1Zr3/1Yq0KF7uxxcCmKFISfem0UJ6Qvw8spwJy5yI372hd?= =?us-ascii?Q?UP1HyXVzcpCcTE5pEGQahQBB7G/dPDboZ0yVueyUqyDtoLwAA19464lq6Kd1?= =?us-ascii?Q?0ZBt2edjIbqH+aOrrcT4yr0tsPsKfwwqQb95zm55wtAqQx0dfL32Xna8NGyE?= =?us-ascii?Q?QjNjvDDkCw0L5ZNsjvYOc7+hgWpOiDx/KzeZkVWQYRee8b7fW9R7ekgJq40H?= =?us-ascii?Q?mAKDtnReS9aoodm8qM4xnSw5W+AFPCf69Bs39aWurb7o+ksGfVSxfm59/K4R?= =?us-ascii?Q?FY4uTzy8eWB8DrH/QedNO7iyKV9aYOmKxXHem24yuos4GvJP7OleORuvHPGH?= =?us-ascii?Q?3TbN7Sx+0YcA4zzunOrMqKThBmyOtbz8QCs9KV/0sS62nFppMqqIiciHlrj/?= =?us-ascii?Q?c+nlT/9ihXQd0MUX1LXoaWMQyXkMKx9UeeAmGfD1OpYayQp23ob5Ec0k3S2E?= =?us-ascii?Q?wRECYDYU5JoeuJAnl0Z3H233d+274QSSBPFh0uNsTtdywsmLaQGXabOw26E5?= =?us-ascii?Q?7CRoEL6l9xfIT3NShU86mNG+Rg9GcpZXuYV1iHZk9BdxeebKYDKJLIeMx/Gi?= =?us-ascii?Q?MEvs+9BcNWLtytjr+8Ax+iusMLVO7EjZMaOO0U7mSaJ/J+jaeqqKucgzLe1y?= =?us-ascii?Q?IRHSx7EZH9uGFmJi1PJGfj7ewNs4/RJhIzQNfPkS0nHqVdmmGtlZRrFBfxMh?= =?us-ascii?Q?rH/vF27RZKyhZ0xzXIoFqFRLHLCTOjd7g2lAkqv9Dl+ioXwwHoqQdTz5Kz4k?= =?us-ascii?Q?8k2YNt+nURLaHFa/Mcf35emDLerYs1WPukCLejPySHBcP9ClGHL9yo3MvnIp?= =?us-ascii?Q?cnnoB8I1IIcRffXqy5smwwcYbvFS18qiVSZHrwxJ5jedO0rmLZ1TnWoHk0VB?= =?us-ascii?Q?Gbaam1zrNwe44Mh6Miym/2SGsxBfKkWDW6smTie3vj8QVF1ibOHB24lVtTey?= =?us-ascii?Q?aBEZBvP5n0W4G76c4lWRngwU1jp8C41cIsvj9erLRT2FkJ5Sjer/BAkYZrwo?= =?us-ascii?Q?7dQygnofdzhvwUuBWoUt2DotC38stTSL4NNbSbRIWNsL/is3LAAgUMoXFSZX?= =?us-ascii?Q?4apTcSqPCecilshKeQwwv8u0SzYZlsqfOk0QPfpkMavDA0FWT1xuz4b+upAb?= =?us-ascii?Q?THd8Noq4Vx46EuaFNLogax/s+p1yQWLskyqAsH+81gUL/LOeCbzGq/F8K1+G?= =?us-ascii?Q?z3nZnOQ=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5918.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KATcAfULkppmZ36z3sayt3JilnTEGXjMHIlTuL01vAQBAtJDaK/iegcLXaFJ?= =?us-ascii?Q?97GR57bJ/+EiJwj5KeFJU4QERbb4IXN3jqtpoH2WIfuG02QOfvczIeYVLhhV?= =?us-ascii?Q?M9VRvYcChUgkv/WfeTmE5jleuyfLF9wAZVUONN6gdFWFy5enOh2DaXPOPB8h?= =?us-ascii?Q?Ivls6Ju9nvqo8SqnjeG2isLCv2OLlwGUrZygDNkxpGG/ifewS1A0svC1EGK4?= =?us-ascii?Q?XY2UWRG1MJmW67gQJQyo9DR7Bljfp1815wGds8q18gTA0T529zJU9vhSNedE?= =?us-ascii?Q?5uDN6/oHmYez0fU5ql7wFST4Gjq9Ey96ZfAJP5K4e2KNtpCIgHpG04rMaQ19?= =?us-ascii?Q?S+CJAJx/AzqiiSsPsQr0WCgP4DojAf2K62gA0rcJReN09mzzKG7A3cd6XGU8?= =?us-ascii?Q?YWOWQigWofA+JJDMUBgWEPw3sXa0uRt1hf6QkfJ2cmePNIjcIn0UfziY8oZB?= =?us-ascii?Q?cLtDgGD7GN+EniwmVbUAE7K/sxtGWRoeGrWpiDh8Vm23ujL1PcjbcVFtBD4u?= =?us-ascii?Q?yqQ2S5bo+v8q4ih3lo2dDovJd0krkTEHPTLEro2X7mW0jS4iFtNV6TUyu5ub?= =?us-ascii?Q?mu2FwvANUgk99IGtoGnugeZQU9nMEecuZ0sniYdgZiRpZncSM3htkwKinmOX?= =?us-ascii?Q?l6VqyJEbT+U0gZmN/8YvUzhYH7FzebZUO9ZA/OecPq4JgLefENnvf2QjvOt2?= =?us-ascii?Q?/oC0HYAwxRNC7L/RFM3+kwo+HeNEZpFaaRmAAjsDE4h2KZbUAc8f+8rdUxf1?= =?us-ascii?Q?zc5ugH660qsxrxhjndywguAC9YGqWNELp1dricSDnvCgg6+/T0K4/oGU4abe?= =?us-ascii?Q?oDm1wgL29DwlfWATiyf539Og+t697PlhBIGgLRWTCQzlTyP4a1YvGPqcdcu9?= =?us-ascii?Q?65lEP6+uCDjAmzM5XSI+YBsKaQPEg3yUfltM2I0fCJGZIAgayaWRcCKg9gUD?= =?us-ascii?Q?bG4wgaS9upcesVQKEGMaFBGy5xupIOvnhhkuLA9jzrNmsZty1yR09nKSVpGa?= =?us-ascii?Q?zZPHmm1vf8ZuCyjRxBbs/0UHsHAxD9ZibRRwF+I1/ryZN+SgGjNYcWT5JYHl?= =?us-ascii?Q?PCqko4mc5QSJVGD83MGi4vxeFPwghTgUsW6P/98YjjzPzjQf7sF0tduvk4FJ?= =?us-ascii?Q?wcJFoRWiZnf+99VUlVDxsKGZ66xaKe+lvUBsgx2C0XQVi0MTxjea1mONxjX0?= =?us-ascii?Q?gCocn2rWK8wgIVuSg0I6vug0pnwT0HpyWYEUA5XlVz2Q7im9Nge49H/J3YHf?= =?us-ascii?Q?RP5WjnJlBr1brmQgUJBj4UtPghUxput4G8VZp5VnFmXtUbi0m1nh/bvBmEDC?= =?us-ascii?Q?NqfbMXpnu36at4RVTLiu0XP+QlraIrxnyOGmwFjQqE3zC4cwXDD34X3A4xSN?= =?us-ascii?Q?PLOgxhpmuIHo3QWDMKf6JkiBAeTwFGXvhgO4PLPYKYMIZCmLNUqrffTLWgnX?= =?us-ascii?Q?UXHkGknWBHzV5DlcFZpzrmn7m1SH1VlOKVQ1SQ75WaVw/gAzjKFsg2K7nlo9?= =?us-ascii?Q?oo3e/aZknT3qn0NZYzl8G8zgUhvH04jqq2zobvUlpY1AmSQ7KQRwkVrtS+GU?= =?us-ascii?Q?i0DkRCUYMiePJhCf51n0ZCUV3XFB+dFY8kxnZeoq?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5918.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79af0a29-03dd-4b30-8d06-08dc852326bd X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2024 05:48:39.9701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fymyb+3SJvt6FeN6ZYRb94tL7JWt6dB9DAaKIxGO9rDJhBLlcgly4cGk/NaQIpmE9FKB7ZV3Q/DciA1JO4UZlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4986 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > + if (uname(&unamedata) !=3D 0) > + PMD_INIT_LOG(ERR, "Cannot fetch node_name for host\n"); > + else if (strstr(unamedata.nodename, "ipu-imc")) > + PMD_INIT_LOG(ERR, "CPFL PMD cannot be running on IMC."); > + else if (strstr(unamedata.nodename, "ipu-acc")) > + host_id =3D CPFL_HOST_ID_ACC; The nodename in uname is the same as the hostname. This can be changed by user, is that ok? We are making an assumption that user will not have hostname as ipu-acc or = ipu-imc. If this is okay, I will upload a new patch taking care of the blank line be= tween the functions. Also, please put one blank line between functions, it makes code easier to = read.