From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0D4246102; Fri, 24 Jan 2025 22:22:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E05540267; Fri, 24 Jan 2025 22:22:09 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 69BCD40151 for ; Fri, 24 Jan 2025 22:22:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737753728; x=1769289728; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=E4tVt4canrJUL1qgrV8RX010Il5HP72IcSLgT/Qx7MM=; b=UY6ZT/rXxXp2oBPC0AyrBHY4b2WRdH0uVt75f/q/vKl2GwkUm5wLsFsS 1MYEG1UynIwbth8g8gMbtlrRTtwKIrwuK1xiQsZRpnFZHdvF4HwfSeism 00ylwZUmuRdtAwrkFg+WQT0BFyM9PwNC2nrj12YB5+ODSfazeq0GOWufJ cL1DEyh/tbmqzf65cD1UcweJxy/xMC8MqheYaHDql9hTUvIbPA5DqRWru NPt9NskYqvkYPAyrLn8SfJyM4r4seCggoXUN5PW3xIuqorvNhyhMK1QOl aEgV7KFyCT7ypnM7/DN2nHF8OKbeDlkLF5UcF3JgCBIjrauqO/NmNdONc Q==; X-CSE-ConnectionGUID: azJqbgRpR4+v85IKFnNkgA== X-CSE-MsgGUID: cli+VKUzRie+SSRixlvfKQ== X-IronPort-AV: E=McAfee;i="6700,10204,11325"; a="42061523" X-IronPort-AV: E=Sophos;i="6.13,232,1732608000"; d="scan'208";a="42061523" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2025 13:22:06 -0800 X-CSE-ConnectionGUID: YOVCvHLCRq2AD8vZdtnv7w== X-CSE-MsgGUID: pdIvkXM+QPKTSutcivFDpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="113015190" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2025 13:22:02 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 24 Jan 2025 13:21:59 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 24 Jan 2025 13:21:59 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 24 Jan 2025 13:21:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JgYz32ZT9uafvOpC0M7ymVueDnvNNmDgqxbz28OFpAegkCljGqgNDVS9qPPIxdYkBf7o1UMzn2bKqGnayfjKcf7BXyjqc7Uc1EZw0VzdSdlEICOK8GzkevE0skK9rRgpgJ8bDU6jE+sHer+f1KnNN0FYFEl0rydlBy2PwuoEGqPqpih677bVJDBUlk3Dra5Ajfhn5R07jjdMvOIztl+uaMNGBUVgEx7tpKuTHrCOy9vU/tDOAhHk3Trpj6Zn1LgJf81srKRbxa2Rasy7C2JNwUPx6MU9GVL3F/Sb0cdzJfl/LkR9VQOplfdokT/Y7GbYjhB70QBqWdDCkOJadqw+ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E4tVt4canrJUL1qgrV8RX010Il5HP72IcSLgT/Qx7MM=; b=A7j7xCPMp6osQB9Uat5wBSLP6Yv9RN6wsxNCDttLLaSssd++Ex3pb17Yy/iT85peXv9aGJXHpZlS3m5NzQifXLHZ8DiDXSa8Bmee/gJTebsXygmk6RCaTLWSaWiNi+MyaxQ7IQhIKVZKXqv4xe6MmOXoxU6Cfy0uMYEgCd1c+mX/R+BxSTUc1Mu8/UYSJEA/JeqmP/r4id18sQSEC1Ckgg5plCqC7ULnEVAwrvoY7qaEQ9NcAS5r8yPCry3HnddrjRCYFsDDTBTphNK3jaapXfbTLd9oxGeB+WJL9GEUeKjsuVHJL7NYAnyrnVuiOwcj44Nt/93V1yMxENZVyVQO5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB6694.namprd11.prod.outlook.com (2603:10b6:a03:44d::17) by SN7PR11MB8042.namprd11.prod.outlook.com (2603:10b6:806:2ed::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.17; Fri, 24 Jan 2025 21:21:56 +0000 Received: from SJ0PR11MB6694.namprd11.prod.outlook.com ([fe80::37fd:2328:c9e0:9d57]) by SJ0PR11MB6694.namprd11.prod.outlook.com ([fe80::37fd:2328:c9e0:9d57%4]) with mapi id 15.20.8377.009; Fri, 24 Jan 2025 21:21:56 +0000 From: "Chautru, Nicolas" To: Stephen Hemminger CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "hemant.agrawal@nxp.com" , "Vargas, Hernan" Subject: RE: [PATCH v2 3/3] baseband/acc: add internal logging Thread-Topic: [PATCH v2 3/3] baseband/acc: add internal logging Thread-Index: AQHbbeuOi9lkK02gFUqQztsexFnPJ7MlAAqAgAEkyKCAABMuAIAANmxw Date: Fri, 24 Jan 2025 21:21:56 +0000 Message-ID: References: <20250123225519.2469167-1-nicolas.chautru@intel.com> <20250123225519.2469167-4-nicolas.chautru@intel.com> <20250123152425.0663a626@hermes.local> <20250124100058.5b4de64f@hermes.local> In-Reply-To: <20250124100058.5b4de64f@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB6694:EE_|SN7PR11MB8042:EE_ x-ms-office365-filtering-correlation-id: a378b1bc-b1bf-4660-9cd1-08dd3cbd2175 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?yeddx31rh3MnnBAb33EEko8OJ6OYKBe9lIJm+V3l6q2/V24ssU6Je/U7Wmll?= =?us-ascii?Q?iOFTf6Qnks8boZ5L4EcNgCWxjjPuzNJyqNRkG7SoGJSBrIysCfXjgXMxXx6P?= =?us-ascii?Q?rmADpXYhKYATGQb7/BuHg3uIW/bZXIUpRmgnhiX+JmxYM1jdthGFBx6q5PjW?= =?us-ascii?Q?P4lgX/yO9nRABW1ke1NTqkQndWhJjRy109ahFkt4C0BJfF3DzlLyXrru29FM?= =?us-ascii?Q?6eKcqZAR0Q6a+HbTOkhZWu5eG/k0+d8mXHDzbujdivwQALNkVry4btyDkaPh?= =?us-ascii?Q?DJhiT1VQMlCenmcLWU205bAHS6UtFg80TZJPwHRZKs51bAvb66HHNyIfdEbO?= =?us-ascii?Q?fhiIOAUvcGnIrdbWxko2o5xVToaWRErA/ib9O3mcLJexUhdH5SlFXGTIkNhv?= =?us-ascii?Q?qpjurGZvST3G15p5mGLXb+sv98evcHnBzleOyJM0eceV6PKEqyqw1DdwYlpZ?= =?us-ascii?Q?5neU07Z1zT8CWQUzLijar2G6PXrs9lHWBeopYwonX5Tm7Cnb3CMLbeonvcAN?= =?us-ascii?Q?+em+M2u4PxRhX6J0i+X6BRduOSh8pIjmS4Ft+juyxHQXmpHhTViDzS4donfX?= =?us-ascii?Q?Ke+YmQJlDQvu52O5hfVzaDsomJErB9goH/HxYWINt6WRsOH84VbRoa/a90si?= =?us-ascii?Q?lQoAI3dooj4vj1HfFNWWH1s4/FC2VBUFvVeOSHs5G6wFOyvTMNkXr8ZIJi/r?= =?us-ascii?Q?TyWbN8H9TSNU2cVH18K6BH+P1xih0Ny5WeMTA+7UGAlkk5xyXkrAlhE8Y/ss?= =?us-ascii?Q?tAa9U4ZauPp4pB6IYV1qTR8IEWLPN2g/Qa1aTMnLjvPp1vA0CqnR5Di3XjNF?= =?us-ascii?Q?hPh/4571Tpsu6/KcUMuEm5ooGl/8SoKj4hL965kauYaV4RNlqMkrgL9klrKq?= =?us-ascii?Q?Z67JNFRNo92p0sCjUW+taOVYB5wyM2mQjP+hpwGQXv7aJ01M5NktKx50ZmMj?= =?us-ascii?Q?6Xj7HSU1TqjJ/eJ6nyfiaDHt7pbDDRhOnUhFcZaGRcMSGj5iqiZFl06+4oxn?= =?us-ascii?Q?2Ag/q45XED8easSsgNUfJQZDAfMQTfWYL1rBZDilvkAU3fU97QC9vLnyuVfo?= =?us-ascii?Q?lQxwZojlFB0/PNJ5CWspbgARYg1W/k2PJdJ7On+Ios1wZF6zgbAOtw4q62+9?= =?us-ascii?Q?JMsoET5hshTc92HeUprlsKSsMX1y+CrnteSiEwiWav7VIQEwbolR7kpVUNr5?= =?us-ascii?Q?4HVobWfqEFEbahTo6yIWfPRui9ZXQ1puYgUm6AuXEhnt9l2VKavSFEDn8xjF?= =?us-ascii?Q?9x9is2TC8HgIJkboQoFk9XhXFN8E2Cyb94mKQ+GRZ+JsmuJvnGu6PkUqvnh1?= =?us-ascii?Q?2leNqjhSiOndJPbHhxQny/pecDMtkltd/elLMOvuFvGNGcc02VcCZoWPFyde?= =?us-ascii?Q?fRAcHTAMm1Q2gGhTOMigSKZ+s1CdiI9Q5DWypLv5wO9CBpQKldP8QgJ8EK95?= =?us-ascii?Q?kO2ivzBvWCwZL+B8kvLWWm/uyp5fWVer?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB6694.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9JZg40+V4GoIFCS0Wkqq/lJMXdmotZzCouLrOJJGmTgoqwR1rsmD9R8UgiO7?= =?us-ascii?Q?7mC3uP2Obn11ALxvBIROTWtI1viKsluo21ONBW3maHZb4/pLiv55/AkYSKju?= =?us-ascii?Q?YbUxOuZRD4I3omrkMbBPbfY123AbEiHn2Nl1x8Vwc0Rg8OBH8HRG/hFA23nH?= =?us-ascii?Q?H6fIKJtKJ/UE7I6aKjXyRZcy/o1xx1iPXWwkuZsZBsiUEZHrJjbVU+7YUCy8?= =?us-ascii?Q?xwdgIkewPUVBOBz9H2T3ds/96Z7WSBp+nxmOiaIqGOygdbnGFBEuAYBpVB1P?= =?us-ascii?Q?UBVQbwu3Bu84ptB8cffMEM+MpLfPHwAQ5LDiyoY5iiEiMZQlLWxEmu/cQKle?= =?us-ascii?Q?yiaqW1drAfKj1zlPMsSKPZFXOOesjpb/DD6Obgi4mlIpMZ00YfPzWM/u5yD0?= =?us-ascii?Q?iv9MzFXTO9Xb+cca3V8VYeFoE7C54zuxtJqP7bNsnq3DvWJRvFXgctJDGFAq?= =?us-ascii?Q?+FjyRGwuVsVqxkL3lNTm6j/82Az2ULRK/oRws30CJL6fniGSKrv4SCIyj8xR?= =?us-ascii?Q?XSRrT/FDncER1QYcbcmYpx+0cutbunJ2j+potvjLB4EMX1lQ6bWdl1MXATdz?= =?us-ascii?Q?qvq0a7ENMWAiZ94qm7C6iEugDnIy/dhd/6NVKDpFw2GUTy6RfdVKakhcWHTL?= =?us-ascii?Q?HrmKlJURt1h/CFs6uAK85PTqQr1+O5sqHvCClV8sRTLw17VBF9D6zgbZ/CKj?= =?us-ascii?Q?26uonWvl4/c6fFsjpGmw1pgngDxxnpgC3dmVBZ0/Zz7Y1cWS1HVD29cyHCDP?= =?us-ascii?Q?utmH5/3mbZFPKxFf64oA2473OouWvmkuQbNcZjNn6gtxXX3Q8oM4TLMfeyHR?= =?us-ascii?Q?5hkpIQq24e915gxSAD7YvOYsHlrupJC6HCSGwDrgZnu1Ri5h71lagpQS+ZYY?= =?us-ascii?Q?Z3j6ocCxcluYIXJPoeTKG1OapzHHPqRg5RY/xoFAA3u6QFUT8GDQyR/kGn0R?= =?us-ascii?Q?AwbcRHdoYQOCEGzVRqtHAVVo5sOOD39h4Wj1+Ms+VUVwl7ZIgOjsRIvzpbpn?= =?us-ascii?Q?fodcAzoIxsZ4DI5RoUqC98m+/yuTqt4U35GgcxYPhZVD8i34fcGEz1s5k+iU?= =?us-ascii?Q?UzXhNTtVhu7WYAqYYykAEEB/5rMTgedlaC2olflC1jkYiKQjeX8cnHmgNKBR?= =?us-ascii?Q?1G/iWcfq+fSe+KCkusPpqhV6Bk2TllWflW1gRh282/LUlct/vR8bJ3KTX1L4?= =?us-ascii?Q?Tgb0JJdLv37mDDbr5+H5dryvaNdni2ZM1iHauO8ToxgEhb0xiro/DXLXhUtH?= =?us-ascii?Q?5uWZbJdlQdYDSzV0MdPizjDV8ZZIiEZe4ieA6uNBzKnp8Pd/Wk7THrIYh+E6?= =?us-ascii?Q?8p6RBqYmbeQuSO236W1sBZN3IQzLWmvonxuxvvQSytVuVt7E9mWZCk/jwS4g?= =?us-ascii?Q?uDR0mWPKm2Yc/OMHe17Di55v378vpyFsZbe+ybKNK9rf5X0HP1YkRmdwYdqQ?= =?us-ascii?Q?gy0QD+QwB09htJFkaCa43DxFgLaKIZp7UrDyA6BkDq7pThYenb6TR7UVmQ+/?= =?us-ascii?Q?NnyNDh5fpnd0CNbGfSZvQ4zxYpSONViXiBOW6D6zAAfM0gQecdg4jLG0cWu0?= =?us-ascii?Q?Pg4Tbu6Vczsl65C5FpeDfu7ahxgOQtWYDwTy1MdB?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB6694.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a378b1bc-b1bf-4660-9cd1-08dd3cbd2175 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2025 21:21:56.4045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OTo6V1/J1qiwXU21bJkYOjWT0M7oenqz3/7ID5LekviMdqVsn6J8Xsl+Ad/GECF33QIWtWuiF1bym7hhBxwH6rb5kSnUvcz+YQzKYGZfNjI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8042 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen,=20 > -----Original Message----- > From: Stephen Hemminger > Sent: Friday, January 24, 2025 10:01 AM > To: Chautru, Nicolas > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; > hemant.agrawal@nxp.com; Vargas, Hernan > Subject: Re: [PATCH v2 3/3] baseband/acc: add internal logging >=20 > On Fri, 24 Jan 2025 17:52:43 +0000 > "Chautru, Nicolas" wrote: >=20 > > Hi Stephen, > > > > The commit message may be misleading, the logging interface doesn't > change here. Note also that I reuse existing trace point framework for so= me > of the error logging when relevant (see previous commit). > > Here the scope for that buffer is more limited, not a new logging metho= d > really (the commit message is misleading). > > The queue_ops_dump() already provides api to dump device specific > information related to queue into file (logging in real time is not an op= tion) > based on information already in PMD memory. > > This new buffer is purely there to add storage for the string out of > rte_bbdev_ops_param_string() for failed operation on that queue, so that > extend that capture as this info is not stored by PMD. > > The name of the buffer could be renamed probably, or I could store copy > of the actual operation instead of the string in case that makes a differ= ence > for you. > > > > I guess it would possible to move this to trace point but I thought it = would > be quite convoluted. That information would fits nicely in the queue dump > capture, and this would require adding trace point for each operation typ= e (I > don't believe it can manage arbitrary string) and would be a bit of an > unconventional use of trace point. > > > > Any thought? > > > > Thanks > > Nic > > > > > > > -----Original Message----- > > > From: Stephen Hemminger > > > Sent: Thursday, January 23, 2025 3:24 PM > > > To: Chautru, Nicolas > > > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; > > > hemant.agrawal@nxp.com; Vargas, Hernan > > > Subject: Re: [PATCH v2 3/3] baseband/acc: add internal logging > > > > > > On Thu, 23 Jan 2025 14:55:19 -0800 > > > Nicolas Chautru wrote: > > > > > > > Adds internal buffer for more flexible logging. > > > > > > > > Signed-off-by: Nicolas Chautru > > > > > > Inventing another device specific error log seems like a short > > > sighted concept. > > > Why doesn't existing DPDK logging work well enough? > > >=20 > My feedback is that why can't you just use DEBUG logging for this. In practice this logging cannot be enabled as this impact real time workloa= d. This is disabled by default for deployment as too intrusive, ie. logging= some warning causing application to miss the tight real time constraints.= =20 Hence meaningful logging is being done in practice after the fact using tra= ce point (ie. rte_trace_save()) and/or using the bbdev queue_ops_dump() whi= ch are both called outside of real time constraints when we can write to fi= le system.