From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: "Marchand, David" <david.marchand@redhat.com>,
"Vargas, Hernan" <hernan.vargas@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"gakhil@marvell.com" <gakhil@marvell.com>,
"trix@redhat.com" <trix@redhat.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v1 1/1] drivers/baseband: fix device queues initialization
Date: Wed, 17 Jul 2024 17:13:36 +0000 [thread overview]
Message-ID: <SJ0PR11MB669490406CF47CCAE271FC39F8A32@SJ0PR11MB6694.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yW8CPfF66ZZO3uy6trV5sMRjPr4wNiJ3-VX4UQdGy0Ng@mail.gmail.com>
Hi David, Hernan,
This is not a fix per se (ie. no bug vulnerability), just keeping code consistent as the PMDs already set such unused queues to zero in the code (see existing code).
Just keeping that existing coding style for the new operation for code consistency.
We probably don’t have to fix on stable branch, so we may rephrase this commit as a cosmetic coding consistency change.
Thanks
Nic
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, July 12, 2024 5:26 AM
> To: Vargas, Hernan <hernan.vargas@intel.com>
> Cc: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com;
> maxime.coquelin@redhat.com; Chautru, Nicolas
> <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> stable@dpdk.org
> Subject: Re: [PATCH v1 1/1] drivers/baseband: fix device queues initialization
>
> On Mon, Jul 8, 2024 at 9:14 PM Hernan Vargas <hernan.vargas@intel.com>
> wrote:
> >
> > To prevent incorrect readings, initialize FFT and MLDTS queues to 0.
>
> All calls to bb drivers info_get are preceded with a:
> memset(&dev_info, 0, sizeof(dev_info));
> dev->dev_ops->info_get(dev, &dev_info);
>
> So I don't really follow what this patch is trying to fix.
> Can you provide details?
>
>
> --
> David Marchand
prev parent reply other threads:[~2024-07-17 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 19:09 [PATCH v1 0/1] " Hernan Vargas
2024-07-08 19:09 ` [PATCH v1 1/1] drivers/baseband: " Hernan Vargas
2024-07-12 12:25 ` David Marchand
2024-07-17 17:13 ` Chautru, Nicolas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB669490406CF47CCAE271FC39F8A32@SJ0PR11MB6694.namprd11.prod.outlook.com \
--to=nicolas.chautru@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).