From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CC4B46130; Fri, 24 Jan 2025 18:53:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A85241101; Fri, 24 Jan 2025 18:53:28 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id 01E9C410FA for ; Fri, 24 Jan 2025 18:53:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737741207; x=1769277207; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ofb0UBSUsvdJh7huoTFFVrlf9JHEiw84Xmkov7NPMiw=; b=KQXiZ2cCQ6L/5qiFuZ8sb+4yeooMUzCAR6u+586nL1fD+shnzFzj5yI6 70RoonDiRTset2c04RQilQc9+djAdx3t4QocHhAUUvoU+AWJaTpf6ato/ /Bw0HGvvWQKf0au59lTayORPjYW1kIl7jy5p3vpwtv1fVSef9zepyFwTt 9dIrDfx6Uu1N/VtSilrokuV5HplX1NjcabqX+uQkz4PJr5YHxeivcge9H sDvGeTdN7BY1IiVGS+YCCocwMrowNJaG5HF21ipdQqFgYQ7pWQNBs2ElO 9ARdwrtLZJeSQxffeuqtxR/YfzmgKpWC1N3uhCvHXYMeWxyCg8CQiF8ly A==; X-CSE-ConnectionGUID: V1QL/AzCQCusgVRHkGEBjw== X-CSE-MsgGUID: 79esDc0STzCOiIK06w3rbQ== X-IronPort-AV: E=McAfee;i="6700,10204,11325"; a="38449647" X-IronPort-AV: E=Sophos;i="6.13,231,1732608000"; d="scan'208";a="38449647" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2025 09:53:26 -0800 X-CSE-ConnectionGUID: f0R6NHpxQX2LOtOLZ2T3ng== X-CSE-MsgGUID: kuKOnmKqSLOrkk13sX+M9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,231,1732608000"; d="scan'208";a="107951981" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2025 09:53:26 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 24 Jan 2025 09:53:25 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 24 Jan 2025 09:53:25 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 24 Jan 2025 09:53:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hUOa/H6G8Y15+hQkV7PNs2QVErV+i1uNBH5cDmnifuInPeHStX62pTNcCd5toKI7OKD966lsZNsP+adfE4hbpewwIASWpMw/ClhGf/kQc9HKibRPow4qVY2NjM9jNbeOmdZmeNMTXsbI3lP7e19yJI8wNoPwOQUgv5OMTiD5Nkw/QBoQUEkP1xM47sScNzp8LEH7iQ4S+NtpRftkkMH0dlH22KKBOSQFgf0X/PAHl1xHWFXWNEEpDhvLBH7gP42mYgc9E5D/MpaGQ8yCaAWATuQQhwqqKOfgDeTqH1baXo4t/ZMH7ZM4nH6/HzIdJ/3RV+H600/rVngpM6uJejAL/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ofb0UBSUsvdJh7huoTFFVrlf9JHEiw84Xmkov7NPMiw=; b=CMJaGDF5QoSCzSfjk4HOIRdm+uQCSOwfAviVqIj18s2pA2m8OIRqAjeF3+IBiqmezdO4fWEPHE7Wg5Z84TuUpoEl0u6Ij0zuOqqZsWqVuR3lXG4+Czrm66g+L57k/wvGUHf7z7bpeG35sCTwXr0dWhvF/KlPY0Tx50ajxGYRg1SPVFaK8merL78ss0YqkW+fhDVWcIoWqRXtdzez7+NZEiJ4XV2tEBOLZ38SwSq8or1pQtpcjod8sfYPaRqDEqADVstFBTEQk7eiIKs53tmDjOjS0GaB+03LjudavPjN5L92tqS0mKgTmRUAFI2NeXDEy9L4cPzYyfD9MaVeSBOTAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB6694.namprd11.prod.outlook.com (2603:10b6:a03:44d::17) by CY8PR11MB7777.namprd11.prod.outlook.com (2603:10b6:930:71::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.17; Fri, 24 Jan 2025 17:52:43 +0000 Received: from SJ0PR11MB6694.namprd11.prod.outlook.com ([fe80::37fd:2328:c9e0:9d57]) by SJ0PR11MB6694.namprd11.prod.outlook.com ([fe80::37fd:2328:c9e0:9d57%4]) with mapi id 15.20.8377.009; Fri, 24 Jan 2025 17:52:43 +0000 From: "Chautru, Nicolas" To: Stephen Hemminger CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "hemant.agrawal@nxp.com" , "Vargas, Hernan" Subject: RE: [PATCH v2 3/3] baseband/acc: add internal logging Thread-Topic: [PATCH v2 3/3] baseband/acc: add internal logging Thread-Index: AQHbbeuOi9lkK02gFUqQztsexFnPJ7MlAAqAgAEkyKA= Date: Fri, 24 Jan 2025 17:52:43 +0000 Message-ID: References: <20250123225519.2469167-1-nicolas.chautru@intel.com> <20250123225519.2469167-4-nicolas.chautru@intel.com> <20250123152425.0663a626@hermes.local> In-Reply-To: <20250123152425.0663a626@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB6694:EE_|CY8PR11MB7777:EE_ x-ms-office365-filtering-correlation-id: 55b6e565-32b8-4586-73c6-08dd3c9fe726 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?J8X8DH73Z2sx2dr0i3GAlkul7shwZfPGCGIGCLCrrgFJmyNLNzVNUFofX7uz?= =?us-ascii?Q?kc0HBgKDW0ksGElFEn91kQmsYNJDCrnWSeh6jFYmFYXTUY4xuv4KqRJD22j8?= =?us-ascii?Q?/FOona0THWPljt3ZuPwaRO3QHuPp6U7mG0XT+o2apWdldYLB4Siok6kNsmzD?= =?us-ascii?Q?BBhXcBG/4JUIkjltm0EzyFGWeQzjLGCLmDk8PTEY0HHb29lAIjqe8yqNPGqa?= =?us-ascii?Q?wasS6LTLOG1ZM8klflof4XM4pf50Q3O0sO95u3HG9yGRy1e6oowCCCxH9vBs?= =?us-ascii?Q?KWGmRTk2I55kr+ZXmbDcgPe5ZPgiRRWHOOeXlWDqPB51j/yjeMIWU17UPrQT?= =?us-ascii?Q?ei/qrAs75w0COtqFUSJfH6AAOFlpLRmdHUUK3MaZ1j9LLp5i2PJz32b1OYkU?= =?us-ascii?Q?XCxXlKiNxX1yKjYCQR0nO7txUh4sqqHV7OALTMKOaXSjZSjpboCRh5DvQFMQ?= =?us-ascii?Q?gaVA+kZZZ7HpvxiF7rjKQn6MDhzc6cP+5HggnxSAQAUlFpZwpoLM4pXAGsMk?= =?us-ascii?Q?sR0a3baHoXQgWsqDOh1Gl+TBz5uYDRtS5vlVW+cKR/L8CGPRV893rD1QfdYX?= =?us-ascii?Q?4uj0Sb1jJ0GHqaIoN9S3T9KSDCt46Qw+l+lZbHYAOhD+j7pKqYF8GtMVv3ZU?= =?us-ascii?Q?bgOBOP0f0T+xdCM15iXlOYXy19QKPsHb9xifdb6XMAq3um0b5/1xG3uusN+C?= =?us-ascii?Q?bO1Ihq4I9Bn521UPyWvkH4rw/DiU+fcWQIAZohCq7uByAn83u4J4MoKJEnut?= =?us-ascii?Q?WSr5+4wEA2Uza4LL+GN014bxJBTMLXA2HKH4NnlHlt0beGxNb0iPjS/FaTHl?= =?us-ascii?Q?WCBqd+7lb0Pu8J7JpZrR4Ay7HyuOEjccps3R8BBZb3/DAbM6OvFWyiRic4WC?= =?us-ascii?Q?laywfB/l5U8DVwi2Jrld5SZAs0vjagkSYkfHxeWnfVgZcI0LC+/cGbvV+VnV?= =?us-ascii?Q?KOzS7021K/pd3iKoRH8DMINreGTam/3mQJh1Q6l+ChoeqYxQ330O/dNe8aFp?= =?us-ascii?Q?giLMJPZV475eG9oDy8X8Jgqe/aLQdpnZSj2R/6acz2kzNTMp+rXRW/8mduxQ?= =?us-ascii?Q?vwEfW55D6Nu3l+LyFtgKoyb2YzVZQDqzqlpu5CrQfwYBhQ1PB8/qU790uUNH?= =?us-ascii?Q?oF3aSXjWpN1Y+gwnUyHdx3lwEsQoJjN2fl6ME0vlA7kyZ3S4916uigS/ZUnD?= =?us-ascii?Q?Phmm1jw1Mkut2RA58PfxNvd8XzUOOakepUhBAPc0U6NsAT4g0ljKSMJybawq?= =?us-ascii?Q?hm8VU4h6WbO/n/8N81R52sGqq8YzoDIehS3kPr2wkhM5OZkaFpFe+ApU3XRU?= =?us-ascii?Q?UbCGb2NJyT7gowxQ6LfajzAdoxxpCtPYXHUo/4rx33G9MfdDDHhyhC9HiTFt?= =?us-ascii?Q?T7L9m7r4/P0VldPR13fONUzzrOMTyTP2uGq51dbyfqWk8RD38vQoZ3NIBN+Z?= =?us-ascii?Q?sFkqt8hnolC51GSYbLy1b2hMmoINVQ2m?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB6694.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lMQvk6Pzk8rmDs3dfviuARYku6jr5O8GxQbyM5xkQfxGnQy7QTuD8SDWM18g?= =?us-ascii?Q?IPvEXJFsYAYgIoXQ6p8nR0lY1Ljw1QQmAgqVb8reUWl9YTDulstmFdf2OF2P?= =?us-ascii?Q?J9AtONsis53Gb5v6sFkjZXz7JkZ8XmQEjAv3jmu1RoO8QLI3y7TPkEsllhJJ?= =?us-ascii?Q?JsC0ySL9cPmBltTKamicNboGZB0ZL8GGgposJw/dkWyGsodEl4uNP4AVTNM4?= =?us-ascii?Q?K/9mh9pzFvJkXlgHnSEufCIyYkntsUxhXnCSorMiwEaCgBqBlbsKKA3G+Lqm?= =?us-ascii?Q?MpLs76IOOYJmGDYVWH/p6qa1r/qsELr7AB8rnEYOHh8x3OrtcDQgz8+cvcWc?= =?us-ascii?Q?P7rb7XE3E9CCHuKL3JkSbXFj3xQjnmMEcKKIUakbbIp7rNjCkDCcudSmSbG6?= =?us-ascii?Q?Tywx89dGMqjWqxthC3obYVHL2K62thpvIQOc1ang54MHa9WRd936z5s04gFt?= =?us-ascii?Q?XXeQeU+lJzH5wnhiqpsWUEz93w9GxShIEZQENIhzv/JscxglMmatVe7rsrNU?= =?us-ascii?Q?Kcqu/wxSHyliWXl6U/5gpXfqdL/Akoo9Ybv3AODIScFq5j9hMtdd9/eeBBj3?= =?us-ascii?Q?BBPiZ7OJzgT8VHjYjQc2bSNvzLhvcouInst9BC3/tB/iu0S+i9kykRPtC2tM?= =?us-ascii?Q?+RbObDCw7AUTRctSCk4qIhD1DC7EPBci2CMuV2X4+EtGraniLKfyyfTw4XMc?= =?us-ascii?Q?UBFsY7o4B0m9DwdBV++PLvsT8HN0NXx5sTNT0fCcqnphE1lSd0m6SzpvNgcN?= =?us-ascii?Q?u8q2hEXgRs+FRYoAJMEOaPlJMwP2i9qx9zxTLT8Ec5gzatfNtMK4ld4Nk67t?= =?us-ascii?Q?65TBrE0arMTHj6kHszCp3XcvL/WiPuW+GblCEsvDF84kt/AmXnNBQ8vLAyg1?= =?us-ascii?Q?Bl08dBcazQ7wj+ItACxGOTsTuq5G0ULN6U5D0tWQGRV/JDcBUAB205Xps0Nc?= =?us-ascii?Q?wCtukMQrdxVyRZqSaTh519ZGMlLjkEZTYHgEpokS57GhQ8Dl0T1JnRAWuo8w?= =?us-ascii?Q?PrbxBlgvMMe1OjM3HectDwFKBaF+uVgR06/vfh3DDoIzT5q7pKoVSu7ywtyn?= =?us-ascii?Q?46d1hw9bqw7Ss5p5rsPhrWUYbCHkB2mp5HPA6gPolX1BkgiEJqJktCEK86OB?= =?us-ascii?Q?xIWHVgGU9tVcMfLP/UON5zWxqvrjgoXwf685u2JbYE5hJLygWaQwB5q545V8?= =?us-ascii?Q?TM0v0PtdnFNmemQucyQx/FAGt6DeAOk3kmtSXxppe1uf+mYmnsr2i7RkYIkh?= =?us-ascii?Q?s1WxodLRJJCy3KnI1DKmBXa+ybUCrtEgStke3OZCL9pGTC29nK8NbD8Qel6R?= =?us-ascii?Q?sPmhaDrpf70AgCLtsLJo5y5ar6Bc2bBu7hR+5wqZ3Ui6x8YPVoTDpJ1m3aNc?= =?us-ascii?Q?PT8h19+6amFVeaPVFvm0kMVSQzKOSbNqwbGq/2zFsG1TPi5MCJhF07+rfI0Y?= =?us-ascii?Q?dKV0lrQcF8rKew1rTRmtFRUSH8NU7rbCzu2eFDaWmvObZ/tyj5wwqNhICYpG?= =?us-ascii?Q?yOti5a6pHT0lr5joGwgsJLwdcmcRdF9LZOvbyhxAcVGrjCkgfiHQkqlC5YGJ?= =?us-ascii?Q?mwZFZomfZvNJnjyJph9jfVoVAYyBkaIrxtYKJANh?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB6694.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55b6e565-32b8-4586-73c6-08dd3c9fe726 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2025 17:52:43.1911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nqJthamZ2Xzw2AdGKQStoea7XAS31Tg7nNzxsdGiGQ7SOrn55gTYDerChnEeIbAZ3XDLxJ5z8Xk/mVOanJwuNH9//6o8C2LoDgIvhRFWCZc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7777 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen,=20 The commit message may be misleading, the logging interface doesn't change = here. Note also that I reuse existing trace point framework for some of the= error logging when relevant (see previous commit).=20 Here the scope for that buffer is more limited, not a new logging method re= ally (the commit message is misleading).=20 The queue_ops_dump() already provides api to dump device specific informati= on related to queue into file (logging in real time is not an option) based= on information already in PMD memory.=20 This new buffer is purely there to add storage for the string out of rte_bb= dev_ops_param_string() for failed operation on that queue, so that extend t= hat capture as this info is not stored by PMD.=20 The name of the buffer could be renamed probably, or I could store copy of = the actual operation instead of the string in case that makes a difference = for you.=20 I guess it would possible to move this to trace point but I thought it woul= d be quite convoluted. That information would fits nicely in the queue dump= capture, and this would require adding trace point for each operation type= (I don't believe it can manage arbitrary string) and would be a bit of an = unconventional use of trace point. Any thought? Thanks Nic > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, January 23, 2025 3:24 PM > To: Chautru, Nicolas > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; > hemant.agrawal@nxp.com; Vargas, Hernan > Subject: Re: [PATCH v2 3/3] baseband/acc: add internal logging >=20 > On Thu, 23 Jan 2025 14:55:19 -0800 > Nicolas Chautru wrote: >=20 > > Adds internal buffer for more flexible logging. > > > > Signed-off-by: Nicolas Chautru >=20 > Inventing another device specific error log seems like a short sighted > concept. > Why doesn't existing DPDK logging work well enough?