From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A210645E29; Wed, 4 Dec 2024 07:21:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C9E040648; Wed, 4 Dec 2024 07:21:06 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2129.outbound.protection.outlook.com [40.107.243.129]) by mails.dpdk.org (Postfix) with ESMTP id EA89240261 for ; Wed, 4 Dec 2024 07:21:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B28YuD0ezZJ7LvZsD3p2gYZWKptPt2b/9UihZJiUVCYDYA7jth+SWk24Zyg7FyWqVipWQ4OQr+UhL/kvtvAgzctZO4CMkkFFVQQXeA9KPPbMeXwFgfqqnb2+C5ZpFR1HVDc/2yCSpyvEY0nnDyrzVOR3oBSyg3naIqPA1qzlSCJUFnF2lmzmA0Wce3lNVDUyCc/2/tLfWeYlsICu1FyFqsEohqR3mx0BejmIRO7A4UrDDaB4uCkqeLuhnlj+ZaoRVp2vXpF63AhGPayee8rR1RIC2xtnuviJQl1G3n9PvL4ZG4qYGu7v2TRUwcObMchuFppFzW/MUgns8C8DqOmVBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+e4EPf2xCIWYQJzRZZvhguPINVP/6sqHUrAvZrWX9Uc=; b=jkHROsj5wuI+7Olw4kXURwK8Nvu7fDHO6KV6if5mfPq3voACorXBvJE9c2+SPP+NTxSaEBZNw7mpbO0zFMPe+++gJRr/t9YQ2v2lIIr0sKWW/vnqSQkKW0t/jzzbwxEMVkv2rsleUi2GPm5phr00h16yyU1wc92IXHs+iQDR55od5idGmTuGavRvFZUecl8vvjJHZD24eC3lN0pNzwX64pO51sk9t4Hd3IZgpoIc3+82i1w03SnkLAAapBJJeorJ0TGOO/m6kxsxuaf4Yc646M85KQ5eUDcS1LtNfwp1/rzlLSvMCX4NfWxOgAh0ROZeYJUpgbbkaLAVO+PaTH7zJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+e4EPf2xCIWYQJzRZZvhguPINVP/6sqHUrAvZrWX9Uc=; b=MV3fSI/vz/xJUD15Rapn6sojI66tYAGH1HFa4ktO8rBRJz+HwCn2Xbd6Qjg7h4qKADO9MrmVK4H/G7cBY0b3Xj045X6G+2Rl6SpLB7TGS6X9cclmYwOLNwQe7rg0HnjMaY9tkTejcrhPpM2u92FX6INq5RQV9mByanIiyn2IweU= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH8PR13MB6200.namprd13.prod.outlook.com (2603:10b6:510:25f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.11; Wed, 4 Dec 2024 06:21:00 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8207.017; Wed, 4 Dec 2024 06:21:00 +0000 From: Chaoyong He To: Stephen Hemminger CC: "dev@dpdk.org" , oss-drivers , Long Wu , Nole Zhang Subject: RE: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size Thread-Topic: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size Thread-Index: AQHbG40XSb6lQwFNg0u+VEUxhVrKQbLVRDIAgACtrIA= Date: Wed, 4 Dec 2024 06:21:00 +0000 Message-ID: References: <20240624020355.3712965-1-chaoyong.he@corigine.com> <20241011032412.3672788-1-chaoyong.he@corigine.com> <20241011032412.3672788-3-chaoyong.he@corigine.com> <20241203115758.7a74ebcf@hermes.local> In-Reply-To: <20241203115758.7a74ebcf@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|PH8PR13MB6200:EE_ x-ms-office365-filtering-correlation-id: e271f145-5aa6-440b-541c-08dd142bd2a0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?1xE9G1+szgEvrFXn+2Qx3ZtUz00VfshYXk+EFcswLJUllBw40OgFJ5B9/xmN?= =?us-ascii?Q?kvSkmgZW79g3yj8QqdSl9bH5fArgtzYiTRC5Z+en//jG/JKG1tn+6mhS0sy5?= =?us-ascii?Q?Pclf4EoyQjhZTh/oHgmvt7+Qmgl8DvuwNQfbJcZFgdkWOLR8Fxoz7q1gHJ8y?= =?us-ascii?Q?Sb9OZ8UTt//Y2OyeXMP8Ka4CBA/g+giPiLBZIWj9z6JxErJtsxPSnQoliXzx?= =?us-ascii?Q?jouZM0Xq1c3E/pOKVpn9XGQKMGMQbs1vIUKUlYTO/O4injnmsn5tlPm9TqGx?= =?us-ascii?Q?NjYqyJzW/q2NZTHOxu26ZbNxNUmM+MoPkFXAo1N6cJRBaloVpuVVnF9Eenp4?= =?us-ascii?Q?5SLb4d3rl82VsxQrYG4IX9BoFNjRvg4LeiDnMcE3mocsvHJBjIBcXypyiRGl?= =?us-ascii?Q?YDUPHcY2b5sK7cy0f0kjQj8e3Bu5spvJ5bh/ondFVEN1Tce+afHSVbi2jvmA?= =?us-ascii?Q?46RDdDdqCLC/9n58VAzspxuC6T6vO8hIFjKeocRZYrkWE5hXxGKCM7P6BI98?= =?us-ascii?Q?gHviiD6fMAPhumZW6MM/nSn/wTKoNjDXX/o/cMCs8KYKR95JWzII1o0jHGNZ?= =?us-ascii?Q?OxvDNoftS9vC7T4TGD3bO2ihbtxOMpnfPiB9gbMCtdmY12HYksJgOnjS8cjE?= =?us-ascii?Q?aThtTmopuL8WrO2rNuABbs7d2+GJVaC/5WTKlvQnoRB+M+VHCGSa8iMfbUVK?= =?us-ascii?Q?qCrZtxy3uTjv4+kPo5IrhaOFSLhS/TTEQJJvH2gciMh78dJFsp8/WgbjG5QM?= =?us-ascii?Q?wowiIRnVgNKwPwyyChdL8PE8A88ctdzIWcaUhNjcNC8SOPYAQOzDw7H76qrk?= =?us-ascii?Q?0aWlPrL3DpVmrFvytgrExmG4rgkjZucqbzw76ZMoQipDsbAgDl9vrkGqO+Ah?= =?us-ascii?Q?7p5qqNvguZujpOjWt4R0Jkz/5yU+p7bIxYjj5/OV3UYv/bqQ8R9MbH8Dt5Gk?= =?us-ascii?Q?53zk/bDPsf7fhRfKOd1jwwaISgQez1/y2T6qhTiTv6MOaM04E5vOasomG4JR?= =?us-ascii?Q?DNLCMxRW/JkdCMCRPhNfQMifqvKqnblqf8qKKL96/2RGqP68v93QgyPPmkhI?= =?us-ascii?Q?hG7/3PkOq6vSkx5x7Q6a50eYZkStIoIPtG+mpGm572RRGw+ZbBg4IStJNEX0?= =?us-ascii?Q?lRv2nBWOeYGlvzaMQvYElNd3O+Ss0I0hEDKsadQc93Sq99fWj6vzyXDAXLah?= =?us-ascii?Q?CWseqCZLdJRtU9X12PdswvHHGszctBjOfqy7LqaiTzwEBz7fci1ia/KAwybV?= =?us-ascii?Q?PjkrTn9gwZ3PSD4+gNoEq/LOPO7fa+DXAWVK8Wi8GH1CgTquTSzGJTue+Upy?= =?us-ascii?Q?huJiOBz+BABlfs6ZXMcLE6pmxGPPa9xnsH5UCSmA7qGz/GwbJKvc8Ueyv7Dc?= =?us-ascii?Q?zmm7yis1JSdjTyCLDonKQlpA/iiNp16aMCvrcfv3TUxokd0NFw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AdpmuRE44zd9/aHMYVWPhlS9ohoTq1eOmViYsnEOfx1s/QYyhkPGXZtaX4hU?= =?us-ascii?Q?4d9L/xRG5VK1+55n97woRQhrbPyr4qVbw2ybQVG0Tgdhe/uSoB+2V7QUnvX/?= =?us-ascii?Q?c0vdpxksZJjxkiByleavOJfh4L+A5AYJ5RMFSM7tia+Wk998HO96loQ5SRZ2?= =?us-ascii?Q?Ymi/74mpRf9+em8eGdyDa4NwpD3XtrQcJRysHDuq/oepNGtkiSq5tUBTn5Rp?= =?us-ascii?Q?w7sMGMg2mgublVzcD4/bAJjhEOIU0NvWymLtFEFMcK2WczWw0dHUkM4c10A5?= =?us-ascii?Q?13tGH5WXPXYbOPow1dh+I+wtVGFa0WlEeM3dv2n2rkS/KmTgVxS02keONbPa?= =?us-ascii?Q?0OJuprPOYhmPLDQywkLyI67MCHqX9W/b0+n6ghjiluo0Ixk3WA5mP1m1C/3B?= =?us-ascii?Q?WH+J1gdmKPrGYYg4LuKsWRAwlk+eIeTAojKt30jETWDIEtmdZNi1Vuq7PzQG?= =?us-ascii?Q?urhrA8GO04Q4cxDdjv8O+5AOG2a3Eb6l2OgaqYh5dYlZTEGRc/byKzvrwMvr?= =?us-ascii?Q?UME/+28pH8N+OhLU8B+Hgjd+t58IYpvOQ8cRO1tPoWDtmAAmfEBY75ftt4yA?= =?us-ascii?Q?ykwnXC78BrtvblPU/mMJbUbxc94IO9JpqnxL0HFuy2UbywaVxdBUz3Xk4ICl?= =?us-ascii?Q?aP2Eorx7WWy5azs0ATEwBi0KCoCOEY3LbbuWuxhODK+JWwllayWLTI8gTz9k?= =?us-ascii?Q?9Qs0+EnvjIPJZajv/hu5WTDggjW4OfM/p6X22+nrS0sIwDZf9UtavYE7BjkO?= =?us-ascii?Q?bkyJCd4XXxCQOE6MxkLvAZzFJxA7yPf2y7VY97XqADv5n0hD+a2mTcba6h1Q?= =?us-ascii?Q?ne274tDoK1E+tB1aVitNTXMMMatN0l0IOi51GmIJljeIxdQ5zSxCMFdXJVv/?= =?us-ascii?Q?Hs/LSxppE9ylkaQmYqO+tbCn4+oKuEAy2rjxFJb+3TCjj35rAG7lqVCp8uih?= =?us-ascii?Q?LH2oFs2QEHg00DoT/IEUwiO4jdADZzst0g6FF/LYryiKGHsO6Hapg4F5CfhT?= =?us-ascii?Q?Y++Iakm0pR/5jBe5fFRhzUvY1ugS5ru8SF9FOON1tAHWi7c1f+xCfuacScKZ?= =?us-ascii?Q?oxy3W8QTQtrf0IWS7db4aGLJcEPzQboqz3YXA9VIwDC4UpBtJPGFGFvqgssG?= =?us-ascii?Q?Im1R3GxhgVWoTe9E3HPOYA7pRRAmBa4I8oQmC89mWFxsuZiEq4qSwvchQidB?= =?us-ascii?Q?OTXpXD/thoHqjJmFzl8nFjyvkQaF5Qe1d9osSZ1HM1Wh2ePWSVYT1YAY5YSE?= =?us-ascii?Q?7gthtERpYAfyMgRsCVY72cz8/NZEfiEovxowL5YPgCUZwoNRz7c9xjto3hJH?= =?us-ascii?Q?t1hzSBUaES+mApCVT69/xAI1B5MxViDuVEgt/pPJb2wDtKcO60ddLbI8LZ8j?= =?us-ascii?Q?5koDz0AG9c/vlz8bSFCN+ZxLHJaWbWhUNvBa9qbu/SCjfRgey/HKXRdH6kT/?= =?us-ascii?Q?Ufp3tBYCl9OU8YhjTeAicmjGyxGifNYVUJZvNtO8nISCOVVFDxYCTHRbvyxI?= =?us-ascii?Q?JRpiC90qnzcQh8DF5rrP6+lc7dYbe5oF2W5AruIoJ2dO4QuJ3v7aqAXXvtJ/?= =?us-ascii?Q?+PoKBsTvUieIGQGaQxWK2uCQynA0OxgjW69Xtr3j?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e271f145-5aa6-440b-541c-08dd142bd2a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2024 06:21:00.5732 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NdvN3QK26l37fKVF2wsegY1RLIcBpJyuaFvFEaK9M0Y4olqs2QTUUG76IUjXCcrjQjNiiKL7EywZXG4Isdpc74tnGF1MGJPan00p+Wkofw0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR13MB6200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Fri, 11 Oct 2024 11:24:12 +0800 > Chaoyong He wrote: >=20 > > From: Long Wu > > > > The testpmd application can not modify the value of dedicated hardware > > Rx/Tx queue size, and hardcoded them as (128/512). This will cause the > > bonding port start fail if some NIC requires more Rx/Tx descriptors > > than the hardcoded number. > > > > Therefore, add a command into testpmd application to support the > > modification of the size of the dedicated hardware Rx/Tx queue. Also > > export an external interface to also let other applications can change > > it. > > > > Signed-off-by: Long Wu > > Reviewed-by: Peng Zhang > > Reviewed-by: Chaoyong He >=20 > 24.11 is released, this patch if still of interest will need to be rebase= d. Okay, we will send new version patch later. >=20 > The definition of what a "dedicated queue" is a bit confusing. > If it is only for LACP packets, it should never need to be very big. > Only under a mis-configuration and DoS kind of flood should there ever be > many packets. Yes, the dedicated queue is only for LACP packets now and it doesn't need b= e set very big. But if we use a hardware queue as the "dedicated queue", we must consider t= he hardware capability. The minimum queue size of some NICs may be larger than the hard= code dedicated queue size. In this case, I think it is better to add an interface to set t= he dedicated queue size.