From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
Niklas Soderlund <niklas.soderlund@corigine.com>,
Long Wu <Long.Wu@nephogine.com>
Subject: RE: [PATCH 3/3] doc: announce bonding function change
Date: Tue, 18 Jul 2023 01:15:58 +0000 [thread overview]
Message-ID: <SJ0PR13MB55450936E14BE07054519FB39E38A@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <e81c8975-fcaf-5bab-5843-c994dd8adde4@amd.com>
> On 7/14/2023 9:15 AM, Chaoyong He wrote:
> > In order to support inclusive naming, some of the function in DPDK
> > will need to be renamed. Do this through deprecation process now for
> 23.07.
> >
> > Signed-off-by: Long Wu <long.wu@corigine.com>
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
>
> <...>
>
> > --- a/drivers/net/bonding/rte_eth_bond.h
> > +++ b/drivers/net/bonding/rte_eth_bond.h
> > @@ -121,8 +121,16 @@ rte_eth_bond_free(const char *name);
> > * @return
> > * 0 on success, negative value otherwise
> > */
> > +__rte_experimental
> > int
> > -rte_eth_bond_slave_add(uint16_t bonded_port_id, uint16_t
> > slave_port_id);
> > +rte_eth_bond_member_add(uint16_t bonded_port_id, uint16_t
> > +member_port_id);
> > +
> > +__rte_deprecated
> > +static inline int
> > +rte_eth_bond_slave_add(uint16_t bonded_port_id, uint16_t
> > +slave_port_id) {
> > + return rte_eth_bond_member_add(bonded_port_id, slave_port_id); }
> >
>
> This will make old symbols disappear from shared library, since they are static
> inline functions and not object in the shared library.
> And this will break the ABI, you can see this from the CI test:
> https://mails.dpdk.org/archives/test-report/2023-July/427987.html
>
> One option is to add old functions to the .c file, and keep old function
> declarations in the header file, with '__rte_deprecated' attribute.
>
> But I think it is simpler/safer to rename in one go in v23.11 release, so this
> patch can update only deprecation notice to list functions that will be renamed
> in v23.11 release.
Okay. I will revise as your advice in the v2 patch, thanks.
next prev parent reply other threads:[~2023-07-18 1:16 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 8:15 [PATCH 0/3] announce bonding macro and " Chaoyong He
2023-07-14 8:15 ` [PATCH 1/3] doc: announce bonding macro change Chaoyong He
2023-07-17 15:13 ` Ferruh Yigit
2023-07-18 1:17 ` Chaoyong He
2023-07-14 8:15 ` [PATCH 2/3] doc: announce bonding data change Chaoyong He
2023-07-17 15:03 ` Ferruh Yigit
2023-07-18 1:13 ` Chaoyong He
2023-07-14 8:15 ` [PATCH 3/3] doc: announce bonding function change Chaoyong He
2023-07-17 15:13 ` Ferruh Yigit
2023-07-18 1:15 ` Chaoyong He [this message]
2023-07-17 15:14 ` [PATCH 0/3] announce bonding macro and " Ferruh Yigit
2023-07-18 1:48 ` [PATCH v2 " Chaoyong He
2023-07-18 1:48 ` [PATCH v2 1/3] doc: announce bonding macro change Chaoyong He
2023-07-18 8:09 ` Ferruh Yigit
2023-07-18 1:48 ` [PATCH v2 2/3] doc: announce bonding data change Chaoyong He
2023-07-18 8:05 ` Ferruh Yigit
2023-07-18 1:48 ` [PATCH v2 3/3] doc: announce bonding function change Chaoyong He
2023-07-18 8:05 ` Ferruh Yigit
2023-07-18 8:28 ` [PATCH v3 0/3] announce bonding macro and " Chaoyong He
2023-07-18 8:28 ` [PATCH v3 1/3] doc: announce bonding macro change Chaoyong He
2023-07-18 11:39 ` Ferruh Yigit
2023-07-18 15:53 ` Stephen Hemminger
2023-07-19 1:24 ` lihuisong (C)
2023-07-26 11:47 ` Morten Brørup
2023-07-18 8:28 ` [PATCH v3 2/3] doc: announce bonding data change Chaoyong He
2023-07-18 11:40 ` Ferruh Yigit
2023-07-18 15:53 ` Stephen Hemminger
2023-07-19 1:32 ` lihuisong (C)
2023-07-18 8:28 ` [PATCH v3 3/3] doc: announce bonding function change Chaoyong He
2023-07-18 11:40 ` Ferruh Yigit
2023-07-18 15:52 ` Stephen Hemminger
2023-07-19 1:31 ` lihuisong (C)
2023-07-19 1:37 ` Chaoyong He
2023-07-19 1:53 ` lihuisong (C)
2023-07-26 9:06 ` [PATCH v3 0/3] announce bonding macro and " Chaoyong He
2023-07-28 13:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB55450936E14BE07054519FB39E38A@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=Long.Wu@nephogine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).