DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
	Niklas Soderlund <niklas.soderlund@corigine.com>
Subject: RE: [PATCH] net/nfp: add the feature of RSS based on VXLAN inner layer
Date: Fri, 14 Oct 2022 01:15:40 +0000	[thread overview]
Message-ID: <SJ0PR13MB55450B0875C8510DB8A44C469E249@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <4f13ce91-32ed-02d5-867e-7f4e974518ef@amd.com>

> On 10/10/2022 7:28 AM, Chaoyong He wrote:
> > Add the logics to support the feature of RSS packets based on the
> > inner layer of VXLAN tunnel.
> >
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> >
> > Depends-on: series-24819 ("preparation for the rte_flow offload of nfp
> > PMD")
> >
> > ---
> >   drivers/net/nfp/flower/nfp_flower.c             |   2 +-
> >   drivers/net/nfp/flower/nfp_flower_cmsg.c        |   1 +
> >   drivers/net/nfp/flower/nfp_flower_ctrl.c        |   2 +-
> >   drivers/net/nfp/flower/nfp_flower_representor.c |   2 +-
> >   drivers/net/nfp/nfp_common.c                    |  33 +++++++
> >   drivers/net/nfp/nfp_common.h                    |   4 +
> >   drivers/net/nfp/nfp_cpp_bridge.h                |   2 -
> >   drivers/net/nfp/nfp_ethdev.c                    | 111
> ++++++++++++++++++++++++
> >   drivers/net/nfp/nfp_ethdev_vf.c                 |   1 +
> >   drivers/net/nfp/nfp_rxtx.c                      |   1 +
> >   10 files changed, 154 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/nfp/flower/nfp_flower.c
> > b/drivers/net/nfp/flower/nfp_flower.c
> > index 3e97f5c..da96d2f 100644
> > --- a/drivers/net/nfp/flower/nfp_flower.c
> > +++ b/drivers/net/nfp/flower/nfp_flower.c
> > @@ -10,9 +10,9 @@
> >   #include <ethdev_pci.h>
> >   #include <ethdev_driver.h>
> >
> > +#include "../nfp_ctrl.h"
> >   #include "../nfp_common.h"
> >   #include "../nfp_logs.h"
> > -#include "../nfp_ctrl.h"
> >   #include "../nfp_cpp_bridge.h"
> >   #include "../nfp_rxtx.h"
> >   #include "../nfpcore/nfp_mip.h"
> > diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.c
> > b/drivers/net/nfp/flower/nfp_flower_cmsg.c
> > index 750a629..b719eb2 100644
> > --- a/drivers/net/nfp/flower/nfp_flower_cmsg.c
> > +++ b/drivers/net/nfp/flower/nfp_flower_cmsg.c
> > @@ -5,6 +5,7 @@
> >
> >   #include "../nfpcore/nfp_nsp.h"
> >   #include "../nfp_logs.h"
> > +#include "../nfp_ctrl.h"
> >   #include "../nfp_common.h"
> >   #include "nfp_flower.h"
> >   #include "nfp_flower_cmsg.h"
> > diff --git a/drivers/net/nfp/flower/nfp_flower_ctrl.c
> > b/drivers/net/nfp/flower/nfp_flower_ctrl.c
> > index df908ef..961ca34 100644
> > --- a/drivers/net/nfp/flower/nfp_flower_ctrl.c
> > +++ b/drivers/net/nfp/flower/nfp_flower_ctrl.c
> > @@ -6,9 +6,9 @@
> >   #include <rte_common.h>
> >   #include <ethdev_pci.h>
> >
> > +#include "../nfp_ctrl.h"
> >   #include "../nfp_common.h"
> >   #include "../nfp_logs.h"
> > -#include "../nfp_ctrl.h"
> >   #include "../nfp_rxtx.h"
> >   #include "nfp_flower.h"
> >   #include "nfp_flower_ctrl.h"
> > diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c
> > b/drivers/net/nfp/flower/nfp_flower_representor.c
> > index 0e60f50..8db73e0 100644
> > --- a/drivers/net/nfp/flower/nfp_flower_representor.c
> > +++ b/drivers/net/nfp/flower/nfp_flower_representor.c
> > @@ -6,9 +6,9 @@
> >   #include <rte_common.h>
> >   #include <ethdev_pci.h>
> >
> > +#include "../nfp_ctrl.h"
> >   #include "../nfp_common.h"
> >   #include "../nfp_logs.h"
> > -#include "../nfp_ctrl.h"
> >   #include "../nfp_rxtx.h"
> >   #include "../nfpcore/nfp_mip.h"
> >   #include "../nfpcore/nfp_rtsym.h"
> > diff --git a/drivers/net/nfp/nfp_common.c
> > b/drivers/net/nfp/nfp_common.c index 07781a1..ec6a669 100644
> > --- a/drivers/net/nfp/nfp_common.c
> > +++ b/drivers/net/nfp/nfp_common.c
> > @@ -37,6 +37,7 @@
> >   #include "nfpcore/nfp_rtsym.h"
> >   #include "nfpcore/nfp_nsp.h"
> >
> > +#include "nfp_ctrl.h"
> >   #include "nfp_common.h"
> >   #include "nfp_ctrl.h"
> >   #include "nfp_rxtx.h"
> 
> Are above header inclusion changes related to this patch?

Yes, it does relate.
In this patch, we use a macro in `nfp_common.h`, and this macro is defined in `nfp_ctrl.h`,
so import the dependency relations of this two header files.
If we don't modify the related files which use these two header files, the compile process will fail.


  reply	other threads:[~2022-10-14  1:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  6:28 Chaoyong He
2022-10-13 12:03 ` Ferruh Yigit
2022-10-14  1:15   ` Chaoyong He [this message]
2022-10-14  8:42     ` Ferruh Yigit
2022-10-14  9:30       ` Chaoyong He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR13MB55450B0875C8510DB8A44C469E249@SJ0PR13MB5545.namprd13.prod.outlook.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).