From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4615045B0C; Fri, 11 Oct 2024 04:23:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2D85402E5; Fri, 11 Oct 2024 04:23:51 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2123.outbound.protection.outlook.com [40.107.102.123]) by mails.dpdk.org (Postfix) with ESMTP id 6643D402E1 for ; Fri, 11 Oct 2024 04:23:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yQN54vGawnwzCMzloZrMWh/ThHWgUveAlYsIm3wAK6wbYuCZdIlxa+goq3yws6KWIynJpG7pJ5DHhjDHHty1iaj4FRgtEoP4keXz9KHCE8PsAzwDH7e+5fjxI4TrytXcjqtsoqpA8INnHm2SxKyiviv2FiSlz4yCcyoEVCm8gBDdZPu4dct0x1Uw1H2kW/pgl8+/Y9Jc4XCzkPpGAzUXZ4Y+2jsrFrtcM5gh2A5P+Inllkixd8Vwtsji5dnFXMloeJ58yTwhCq9sjL30MLmk2fqi3cn8OXhlbHs/mjFZEHQbEsVhjfQT1Y97e9bkQFc+9yUsd6Kwvd72kOAueWuN4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GJA6Tjx1MLdnDnqsSTnCUDslKK+BaLZeAbdsKh4/Jtk=; b=W8gGwddVp0zLwsdQpd/oMDzl91cOcBLf3k60Qa9raSDfiRv885mo6ViSMIxTbB4Nq4Q0mFNCg/xMvtMI+oo6dlp3Czj3W0q+krhAwWv/scoT5uqcac897yFwGhgqmZZz1efZyuqLl3yaWG4c/sHWiZuIo9RjDytaE5oiC6uBjUIRuwsdo5p6fUv7STdO+7JPdgujMoPtMUGWmL+WWRjoi/09FrtSspWeoyZBATr1DoMnxAEfQqAgRZoNLOYGHMIFgefAYRUyaFMBJCBqgIKJUJ4daS1ZFwCHv8VrZh13tQcNuGNp1l5LdjAlunPIUcI8M6HZrNbr06mdFUO+6kY2hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJA6Tjx1MLdnDnqsSTnCUDslKK+BaLZeAbdsKh4/Jtk=; b=v3Z7YfqBfiVDmyiM9hG1DRz04UakJaYOBFMVyyDHJkUCNcFqNZlA053DdrWPeh/YyyzGQ6JDrmV5FrmxcISLPawR15ysPfkD/1/ZuGiZx0qDViXET5avOfu10AV81hrxExRkFeJc2zksR5wsT/p2vsBonosFd/q02VUUhEVQwEc= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by MW4PR13MB5839.namprd13.prod.outlook.com (2603:10b6:303:1a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Fri, 11 Oct 2024 02:23:45 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8026.020; Fri, 11 Oct 2024 02:23:45 +0000 From: Chaoyong He To: Stephen Hemminger CC: "dev@dpdk.org" , oss-drivers , Long Wu Subject: RE: [PATCH 2/2] net/nfp: enhance the flower service framework Thread-Topic: [PATCH 2/2] net/nfp: enhance the flower service framework Thread-Index: AQHbGuh+i+FMN9AB0kWVEVUdDiiUPrKAEvoAgAC/RtA= Date: Fri, 11 Oct 2024 02:23:45 +0000 Message-ID: References: <20241010074557.3622716-1-chaoyong.he@corigine.com> <20241010074557.3622716-3-chaoyong.he@corigine.com> <20241010075508.18b0e840@hermes.local> In-Reply-To: <20241010075508.18b0e840@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|MW4PR13MB5839:EE_ x-ms-office365-filtering-correlation-id: eff63809-e5ef-427e-25ce-08dce99bbb59 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?ENJQlutphW8dDVdsaU01wbDodBogeqfb4+tGb4yOhB3Vy5QZCwop/w6rQ0Es?= =?us-ascii?Q?h2InWIE1mRlxH3TrzxZUuBha3bmEna4pZmkxheeCvfcUo+HpIRAsNHGLXxSL?= =?us-ascii?Q?py4ThfA5JZPu/jk+r4Awm8iimjuL9Xh4RpGpWw4p9tI1whqhCXToro9YNjeq?= =?us-ascii?Q?zIUSKrpjfM8Rk1tQzR0I52LH+k63lFQXr+Gawo4dk2u1ovU/BQucP8V0l9vr?= =?us-ascii?Q?8ukmDdMkyavMHZlNwOU1qgsV0Gi5jBR2uYNnZTrN88AOxqFUpyX+tY80WpjP?= =?us-ascii?Q?DmkhZAr22nxaSEC6bFwqQ3W1YKy86T/USuiOynmf+09d9Hv7RDKzvSa5qcUf?= =?us-ascii?Q?iNgfMDZ92/ccgURk7m7ehwBWXO937k+n6ezJSYnGpwvidkzT52tLG0iLHkU/?= =?us-ascii?Q?eTHe1s8z0WOgtQBgJn3LpMjYImgVRyXzAylGOQHjTzeu+iFAdvJ9yZCDvFmC?= =?us-ascii?Q?kP0IWtDdlVkQhQm9v1i268WSfg3pZWMhc2jBW89bj0Cu/YeGdzAsd3Ap7WUB?= =?us-ascii?Q?m1/MSGMlrG5uJKDbcUILP2GSYQQRs16hnsjTss0t6gDwg81WKxP8QnbuWLu6?= =?us-ascii?Q?6GF/hH2/pUEF9nznod+9xKA3YxIvTMZ3HfOzg8jy/xfh1PXnr5E6ryuXaFPu?= =?us-ascii?Q?sL4JoAN68WR6hPrOvDBV4lpM5xmHMnGWf/nj5jITqPXA05ht8RWYdDL8064e?= =?us-ascii?Q?9LqghqlG0ACRu2czafLHD37K/LzN4Atlz3xG21Wh6KUqFvgzqWyuH2XWUGxc?= =?us-ascii?Q?0hmXkSgieAHMW9aMfcl+4+3qrVtgQ1MwJV9LIdGQSbRwcNbjfXVO+AHUuUFZ?= =?us-ascii?Q?4cfUwDQglCFBI9UKPuplzP/ezlYVrvCKbY17J7tjH/Z/VHF4/VUeYtsl7Ard?= =?us-ascii?Q?K61Uhxwl2dDLpcHSql79ICQ6goGkYiD45jS3CfF8cftrh1vnLeYmgs8uh/d3?= =?us-ascii?Q?KuRL7f3gZe1+vfU9o7l//haajLjSCWcJFcTGk7BLZCYYXG7PQkA34smFuKfB?= =?us-ascii?Q?AmFFtA/uZz1EIGiXZtSKxnErBeZCccNoaKwerzFooEmcKxb2LRUNsJItsKBP?= =?us-ascii?Q?Bjl/PwaODcE79PTpchHe70tVIA2chOuLawPNMHEtjNDRXIbddUAzDBqBcF6k?= =?us-ascii?Q?OpRZnNC8e6S/EUsdvqnFPpeH4JIFuqa1ZXwDmQ/AeDsNH+elMblSQq6dScSl?= =?us-ascii?Q?5hANEP8LyvBL6nVZT68NJSJoB9wBqlZCq7TPaQaUjc3bIYTHmXzKWkUnJNKy?= =?us-ascii?Q?em66DWCQrKNqVs6mUsHodcUDIvXPMVeN6gnhGHm1B9nSlVKsqyzY3IZVHKZl?= =?us-ascii?Q?CoSr+fP7p1mfXm7W5wvSX4x+u7Q6ExWZQTdAC9YxNAls0g=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ofcrMxTbk3xNWJi8U69ty/c4RAcg/1il4BZeKLssEYf7NPqfV/n8Ye84GTxI?= =?us-ascii?Q?tjiGA8fIctXCl3fzx9ma+rs3vrL4hzOIAjCqhhRSm94bdiYsa9e63Ts4XmcB?= =?us-ascii?Q?nVD71gcxpy6HFjdF68MJy2k8Rsx0uBoMppCmI8Du6dDn//xnW9Mu38Rj0/Qr?= =?us-ascii?Q?lBReRhkoguZBbhaZbaNu5FHfASxQVJ2HmrTY/uAlrygJ3UgPb5GnA7gTuuBr?= =?us-ascii?Q?wxQBSYf5PWqdL9JZFUHR+mS53HDOE9pf7SyEymLbLrprtZUsq8U1NAkXW2Tn?= =?us-ascii?Q?EwdSbPxiuD2yOu+1eAIvwce3wbKkUovbtEuwzlxRga3e+9CTs9LQgZLmVzUv?= =?us-ascii?Q?40bAwrfY2Te4nj0MOODLepBob5vJ/6iIs724k64DdKnz/iriZhmKC2ysE/zW?= =?us-ascii?Q?BjDh8L5MaWFqrjPOFbEf0zULkxvjdGV0JpNxoS5DigyYkkUcYqYsg8wv9fVk?= =?us-ascii?Q?WqZUHQYFzoBFmXJWjP9Iibt1IUJ0XNUUDK5J4SdUzWnL/vsFx4RXKTChKM/S?= =?us-ascii?Q?eHaj3zHSriNeT2QFFfKC8Ztdkc3cLMBdVtXMbTve4hklD0Lm6Sn+zOEPGgOQ?= =?us-ascii?Q?Nn1CFr1f2ErhdkBq8W+TXuA0CdCyrrWwQSu14bfeqSl9m8OPzvvdKB553Wav?= =?us-ascii?Q?WwdG6g1xrVMEZ9OMt5tmHBP0KqsdUrS19a+/nzTrIOFTUdKJQMVO1sOixskp?= =?us-ascii?Q?BNVAJZvAjkXRdC4ehwJZS4AIuTpeOPOtCjsEm9X0zcqEjhx6aQrkIys4vsIp?= =?us-ascii?Q?4vbFEqiKg0FiAS3HxkRRtmmF5wQ4ADPKuPj5PQgcSMT0TNiMTURkBIdMaDKi?= =?us-ascii?Q?oE6TgtyXGBY3oyBbH8nejNP2ZCQKkTeEM/RJuG1X4nrjt3ZRMWvaE6FqlYFb?= =?us-ascii?Q?PaV297+CYv/rUfv91s+bW6Ks6VTHa1Zrfb6qqjNDQkwinKL8MbgGvWT6d1QG?= =?us-ascii?Q?uwdR0IJuT4rVbZbgGxnkT+rN8va3TBsdz/gO2ELTipCCt8JsbXxmbioHxHZr?= =?us-ascii?Q?9/FezqaJIS04VngORZnX6n2E8pxtybx4xNEYpJwXgRGNOfon/Eo1PDBdvDGw?= =?us-ascii?Q?b4zedIhjoKpWfdcKpBiQN2n3PC1oQcBZU/GZZqBZfKP0lGimtir6bOdy+2lK?= =?us-ascii?Q?SEQMgh52+r9gGvwYJcnwzi8Y7/UTezqpeBXCzL6NIRQ4dG4QZyM6ptGxN50+?= =?us-ascii?Q?D+QlZ4q14LszVC09kUaw0VgyCjpD3EAu81XR7cqkXUZM3SoBaVdS3zH+Lz3x?= =?us-ascii?Q?i0rhTLOMHEX1MROwFzizSfuP82i7KzWCQu1X2L3QvxVKcdmi5kU2S0FNUv8d?= =?us-ascii?Q?CHOez6gDtCtRp6/s8H+5gDo4kUL3H5K0gvAWXVvuED23Cvvb4ZOsm6oAgDwe?= =?us-ascii?Q?C8TwsQNtD67NXVumA84BCKny0SYMVjLzo0OTFoW9sh3zKA7WK9BxlqpZs4Fq?= =?us-ascii?Q?q0EBtNF+f/ZrbyJtKMxm5Xwbkz3kt+LqzafOfSpk7edxOD9MaxvfsCi2W+TV?= =?us-ascii?Q?L7vdmEWQ26SF2Yt95yuh7VzHxclBfTcHaG751dY6JWN7dt1pRAe2j3HTKGbf?= =?us-ascii?Q?VaURk9NzBQoHvpmnnBKwjxzcwew5cSfhyxz99kR3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eff63809-e5ef-427e-25ce-08dce99bbb59 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2024 02:23:45.2083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uq1uAshuC/+7tQCobBu/j/neAR4x48aJ8wLWEKYf+9H6v7Sv8IHQM8akyUohB1ELZRPuneyxFvnAV74kblo9xRC6sIXujEy14GRZMvTDx48= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5839 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Thu, 10 Oct 2024 15:45:57 +0800 > Chaoyong He wrote: >=20 > > +static void > > +nfp_flower_service_alarm_func(void *arg) { > > + int ret; > > + uint16_t slot; > > + struct nfp_net_hw_priv *hw_priv; > > + struct nfp_flower_service *service_handle; > > + > > + service_handle =3D arg; > > + if (!service_handle->alarm_enabled) > > + goto alarm_set; > > + > > + rte_spinlock_lock(&service_handle->spinlock); > > + for (slot =3D 0; slot < MAX_FLOWER_SERVICE_SLOT; slot++) { > > + hw_priv =3D service_handle->slots[slot]; > > + if (hw_priv =3D=3D NULL) > > + continue; > > + > > + nfp_flower_ctrl_vnic_process(hw_priv); > > + } > > + rte_spinlock_unlock(&service_handle->spinlock); > > + >=20 > The alarm handling is in a non EAL thread, and service is an lcore; does = that > matter to this code? It does not matter to this code, maybe the name of this function and some v= ariables introduced a few doubts, but the logic is okay. Thanks for the review.