From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC60B45B02; Fri, 11 Oct 2024 05:02:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D0EF402EF; Fri, 11 Oct 2024 05:02:30 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2095.outbound.protection.outlook.com [40.107.92.95]) by mails.dpdk.org (Postfix) with ESMTP id 25C6E402E1 for ; Fri, 11 Oct 2024 05:02:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IwdL3CGc+7DAh3J/Q2csdoa/JVPwutkIgJyPwT7OcwcdeO/BB3nkONoanHtdQfhs7Pu5AeCnuB27K09cjvzzW6M21KzvlFYvh/tI6Jrr93jsz2oROnqUnP3UMrfKP/GcSSvMAEcTF43Dp2e+gSpU96M44U7HBTVzH36g/kpjKU2SM7LA74YGDX7E8ur0gwhfDoUNePplBZEeQAcu9xFCVlzDA602yMwk0bY2Omq53FhyyYDbAhGjLY42TxKpOk4C6DGKw62P/YWQXoiL7dq+/phqnqgcDnLmzMCoanuCttO1tHSIoyj4ngq+ItdRtTzjpuJFMNZW+qscoVf4u0+2tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G/l9UmCb0mn6eQbY7C1gilNX9neqMGQBkgL6ypwU9dc=; b=cDOy4nRpV048vNq402iOvyd95Kb0q1uk7pLWRvFAgmv8ahdcz/NQ1DvjAvhzgTbwv0ETtZ6/KxOOMwXxmcGRbp5iQn7jyM7Kjd8uZUj3JCfGyUEPGnwHNUajusJnV+9Bc49pNYSuAzAi+gaxWEcPnD/+SjBbTxm7qJwR9OWTzUF3zZaNhwec0dq0yqRigoBnu13++gRiMBp9FxOOddYT1bvklZ79AdoXnFUwvIyX8qla4xg6dv1QjGsjWFxCagbZmkgRypU1Twoa6rLWH8JvHYlXAubXiYlC5p+nl9ibY9vvuveZBSdX/MG4eaUmtcF36+l4T9xkrHYKWisRv8k6yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G/l9UmCb0mn6eQbY7C1gilNX9neqMGQBkgL6ypwU9dc=; b=L/ldTapxm+n/bQ1EvbOePny+SYDMYdCLNoCLjWeLIiCgZ5lfqyxBUbLhbVJ4fMY7HvBFz7l+opOhMAO17peJcrL0vy9B3GCxP8a+RgwD7fC0RvSzNRnDjx7Ws6PaSt/eNWufuMRgL6CWyPNa85x590VBs90iCrD9WFaBp50VUoc= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DM6PR13MB3642.namprd13.prod.outlook.com (2603:10b6:5:24b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Fri, 11 Oct 2024 03:02:27 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8026.020; Fri, 11 Oct 2024 03:02:27 +0000 From: Chaoyong He To: Stephen Hemminger CC: "dev@dpdk.org" , oss-drivers , Long Wu , Nole Zhang Subject: RE: [PATCH 1/2] net/bonding: standard the log message Thread-Topic: [PATCH 1/2] net/bonding: standard the log message Thread-Index: AQHaxdrQPeqhjwI5RUyma+gTUdbkKrKA86GAgACUPjA= Date: Fri, 11 Oct 2024 03:02:27 +0000 Message-ID: References: <20240624020355.3712965-1-chaoyong.he@corigine.com> <20240624020355.3712965-2-chaoyong.he@corigine.com> <20241010111021.1cb1b520@hermes.local> In-Reply-To: <20241010111021.1cb1b520@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|DM6PR13MB3642:EE_ x-ms-office365-filtering-correlation-id: d1a2c4ad-4741-402f-3239-08dce9a12362 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?DmBnmJsa3NzZMciHgWKnpUiZ+Z61eO9a19Kks88Z5Rp4q2UiX7g89+NqwkT9?= =?us-ascii?Q?hsFo7ankTJGmZM7ztM27NitLSof0Rtqz9bFuTeIOJB8ute7pIWzWXZy0yjDM?= =?us-ascii?Q?MbZx546PPNv590XlJbFPBL2dWqZ9Rg6La/OdbXzYPe6tipJ+vRNfiKxr5riG?= =?us-ascii?Q?cEROD2TmeN2PnF0UOMHm4gUs4htWhTb/7aMeRU6bGrTTlZe9n9H+pqXhAXUy?= =?us-ascii?Q?Q1Rvg0ynRl1JAChk1xY9bFCwdFYLurmUO2A3ks2f3bdCs0yqRD3NGmhO42gt?= =?us-ascii?Q?qQ1O2xFylb759jy8s2iE0rNZWUqC0pfG+MG4u/0KIldQPck+wnCIu3eCRSx/?= =?us-ascii?Q?lsdz0vRF3h54Gnq3ZWG88aYzEMXVOHZBq4RN7RlizbLrL/hw4HhXjcEYH/KU?= =?us-ascii?Q?YlaVuR7G3z5ynSWjlybkI3nLT1v1oSa+o0lVHvhWlK8N5YrkfjUdlro2db4l?= =?us-ascii?Q?5zj6axSXu0D9OF026R2m6+qgzBe5cuSOVAFC7MjAym+QVeOx3cIM+xq4KkJV?= =?us-ascii?Q?HHbO1mIrjKXtKkhGNylcWSKzBAu8ChgVYbR0DedTHubNMm8PxXA5o2+gflcw?= =?us-ascii?Q?EO6A2aop6QOZyPOrO1tFpDomlBIcO69tbnZnkYtFry3r2YaKD/fwfO7z2iZh?= =?us-ascii?Q?o4QPYNsnv3s1BgCyR+XzMNYIwxUwSXushHUdyjUbuK3MpxclneWWkfGuDx6N?= =?us-ascii?Q?2AD3RxyEiHqe6xfIYwiWrxFaINGj/5rWV0fIeyVSRrj+YQLA9kNNGQUnKp69?= =?us-ascii?Q?xKumsiuSHckGnKt7DTE/vjL7rXpmr0FzwXwGXgLPhn/YUcGGRTjlGP+e+LEQ?= =?us-ascii?Q?FkubYvWPkPRvdCSSCTugk6S9eTXzW0px+XAJNzFk7/O2Nnp8F1TMc8gdk/+V?= =?us-ascii?Q?slhpMoVdzGNdLueAmd8LuqAdN6HRKBaRuynQBrbWr2eRwBLbxUuzVb926Zp+?= =?us-ascii?Q?C/6hJthiAD4yAWP1yGC21N1PuqByx8IIHVv8HE4Hg7v0VH6AELDSlDIZafxD?= =?us-ascii?Q?3GplgM9MVpKqbeF5mIg9sTCBrpgBMkKe6wluihFTyFfqYIhI61+o9D5Bm/27?= =?us-ascii?Q?Dj2g5ah4+vsFc/ZGA53hWxhMOZLfONpbRBU9VRWxkM3WUPtmP1C7dXRCElBa?= =?us-ascii?Q?qsU/9NjrXbCFaKR9xtZKmdSCYTSmg1WB0TjsJ0KD30lksGzTu8VrHOo2p+hm?= =?us-ascii?Q?0xspsufja7nE+c0/uXxPp5wj1GmwuUuNyLzXtyOBt9zWn3mNlhAwok2QYjw4?= =?us-ascii?Q?lOcWthbz8y+3Pmahfmi32mvorcQEX5QXCWHgDTPHFAi2vWwTirMEBivxftwk?= =?us-ascii?Q?wIbM8JeSzjLF20RenKFggLTdKQNIXBFkXtwZGuJXXou3xQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hPWeCnEawqehEbflLYQRTorzCvIwNBl53cknI7tK4FhxgikTPicBd1fUZf55?= =?us-ascii?Q?sNi6pWNnHaAbXYNucN107PA2BvAtqvdXvvoCWFI9k1td90nXEB8Guqk2kdKH?= =?us-ascii?Q?2KueOdnMysJ30MPWlBfxbqxQuoJKpoiqjIBxo1zSK07pojxKYX1/u1apnzQi?= =?us-ascii?Q?Rf41D9tpTB85QsFTF+ZvCH/GgmWgCfMJdslF5wOzyxFNOqyOYrNLsj2AeXHn?= =?us-ascii?Q?h1s3fRSvCN8tvthCFGlcqMvWo3+gbFJ7d9uD07lJ8sfWzcZwbNjTOgwjF6Y5?= =?us-ascii?Q?FZcFlrjlZb9M0WKcP+feoiiMiD3m6ZqjOXhVa8aUrd0br4sggA+t8qPfZZrm?= =?us-ascii?Q?J6tzCjSQTJTebAoS+3JRp2j21t9XGnNnaa6GSlSv69FcOUARn3gOKlW2u2i3?= =?us-ascii?Q?j7ox0OY0H/3uvo34nlGDUS8W9yiACGE/Fy035rfJhNe2v12RHT3QODKqAYQ6?= =?us-ascii?Q?qwhdekmxY1DGMPfVg9d1TEd3/LKFZB4wuFTwmdUsmdqM11wVDI8GJiFEcfi4?= =?us-ascii?Q?mzSOcfDhnaa1pISPbcuw0WE5YQ9Mger2ZtXtg8/TPyS8v7E+pLavV+YjuQc8?= =?us-ascii?Q?g0iU/kbNNgsE08SKa1gWBL8ZKtO3aMEyR9yAoHL0pqVlCc4aobDwg7y0aGh0?= =?us-ascii?Q?5iOgQIXQco4jfsMGRBzY8NjH8tiwhR6zFvUoZqxZfdWbHVSLb/SKR8gbawj1?= =?us-ascii?Q?f7nKfR5kWxQFKY15Og3Lg9KsKPOJtESuTTnRoOGW5IDZdNtTU0I6bR8RB7iN?= =?us-ascii?Q?fVQUnu9szwNgJL5dJ/wVbgs2JK4Galord+zUxmgFgCM8d3xK1gy11TqEr7/j?= =?us-ascii?Q?pc5kUbzPWbwckAzTIG5FgX/ymI1ph6LY34noqPt1XZCnPrdTsKLLXKR+uhyQ?= =?us-ascii?Q?aKhSVHGavmeACPKP2nSS03HUCbdOMTCMIYh2Lb2zS0aoGcRjgpzQ1hvn7j34?= =?us-ascii?Q?SiDemlTFJhzNTY0iqPw61PkQtnY7WpJoRVI8LaedPYeSWA76crmoJ3RgB1Kd?= =?us-ascii?Q?FxKq17ejwYyfZmHdMfvbgDGNiF+eZB3SgJX/YKFvhNryOsn01S+z2/3vrfiv?= =?us-ascii?Q?OmycM1kCTMEIYpdBGZU3g2rpnt6Cvwf12p8BFywjwgOJK956j10sfDiDoGi7?= =?us-ascii?Q?GBX8ZJ1Q0qu4O2HP8R4dOR3rzU228e+aI2jM5nz8iibdQMmxTv8OH6WD8dXo?= =?us-ascii?Q?Bf6KYq5O0gIVJpSfbt2LtLQeivW+G6dk5bI4wDo8gvSfDzbtuFDN1HYaTEqT?= =?us-ascii?Q?gy/X94YFnG5bI1USvwDN5Jevcj65DKvRoZ3GJOBga6+9ZjRcqJtVqiEWTIjD?= =?us-ascii?Q?KUzfqAXiEfUfh523Tufb3VTBtpPYgru4ENoq5AqANm3ANc/jm6xjEGSFkCRY?= =?us-ascii?Q?g1fZFQOqq4jv6qAb8bbjLQ8V1gjcUxQEe+cDJsF9b77r7cGdJXDnKL4+hr7S?= =?us-ascii?Q?qfRlIqqFw3CsAAKEgzuQggldZaiOA8F5C1T+Zmda4ky3/2cDnl45sA7fIcEQ?= =?us-ascii?Q?7UqagVP31bm0zkb762T+d2qJIn2dWlVAvsbakdtlnu7MKp14lG8I0Pr+oucD?= =?us-ascii?Q?NjwjVAsoBOlrgX6rrnj6LKbEIcHar23PmWuNfWTU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1a2c4ad-4741-402f-3239-08dce9a12362 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2024 03:02:27.2037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qGPMdfZE2+1qlZ8UsaLldscT1uekWptNomV+9YYwSeqrLqQ8WAG9lMYYEfZsaIPun9lUALJHKyy19nXsp4OKf4wJfR1KTf2wxL5R4j1EdoM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3642 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Mon, 24 Jun 2024 10:03:54 +0800 > Chaoyong He wrote: >=20 > > From: Long Wu > > > > According to the check rules in the patch check script, drivers and > > libraries must use the logging framework. > > > > So standard the log message of bonding driver by using the logging > > framework. > > > > Signed-off-by: Long Wu > > Reviewed-by: Peng Zhang > > Reviewed-by: Chaoyong He > > --- > > drivers/net/bonding/bonding_testpmd.c | 42 > > ++++++++++++--------------- > > 1 file changed, 19 insertions(+), 23 deletions(-) > > > > diff --git a/drivers/net/bonding/bonding_testpmd.c > > b/drivers/net/bonding/bonding_testpmd.c > > index 8fcd6cadd0..45b636fea7 100644 > > --- a/drivers/net/bonding/bonding_testpmd.c > > +++ b/drivers/net/bonding/bonding_testpmd.c > > @@ -34,15 +34,14 @@ static void cmd_set_bonding_mode_parsed(void > *parsed_result, > > * of device changed. > > */ > > if (port->port_status !=3D RTE_PORT_STOPPED) { > > - fprintf(stderr, > > - "\t Error: Can't set bonding mode when port %d is not > stopped\n", > > + TESTPMD_LOG(ERR, "\t Error: Can't set bonding mode when > port %d is > > +not stopped\n", > > port_id); >=20 > Since the message may now be directed to syslog etc, avoid putting tab > characters in. > Please remove the '\t ' from the message. Okay, will do in next version patch. >=20 > > return; > > } > > > > /* Set the bonding mode for the relevant port. */ > > if (rte_eth_bond_mode_set(port_id, res->value) !=3D 0) > > - fprintf(stderr, "\t Failed to set bonding mode for port > =3D %d.\n", > > + TESTPMD_LOG(ERR, "\t Failed to set bonding mode for port > =3D %d.\n", > > port_id); > > } > > > > @@ -98,23 +97,23 @@ static void > > cmd_set_bonding_lacp_dedicated_queues_parsed(void *parsed_result, > > > > /** Check if the port is not started **/ > > if (port->port_status !=3D RTE_PORT_STOPPED) { > > - fprintf(stderr, "Please stop port %d first\n", port_id); > > + TESTPMD_LOG(ERR, "Please stop port %d first\n", port_id); > > return; > > } > > > > if (!strcmp(res->mode, "enable")) { > > if (rte_eth_bond_8023ad_dedicated_queues_enable(port_id) > =3D=3D 0) > > - printf("Dedicate queues for LACP control packets" > > + TESTPMD_LOG(INFO, "Dedicate queues for LACP > control packets" > > " enabled\n"); >=20 > Don't split messages across source lines, should be able to fit this in 1= 00 > characters or break line after INFO, > Okay, will do in next version patch. =20 > > else > > - printf("Enabling dedicate queues for LACP control " > > + TESTPMD_LOG(ERR, "Enabling dedicate queues for > LACP control " > > "packets on port %d failed\n", > port_id); > > } else if (!strcmp(res->mode, "disable")) { > > if (rte_eth_bond_8023ad_dedicated_queues_disable(port_id) > =3D=3D 0) > > - printf("Dedicated queues for LACP control packets " > > + TESTPMD_LOG(INFO, "Dedicated queues for LACP > control packets " > > "disabled\n"); > > else > > - printf("Disabling dedicated queues for LACP control " > > + TESTPMD_LOG(ERR, "Disabling dedicated queues for > LACP control " > > "traffic on port %d failed\n", port_id); > > } > > } > > @@ -178,14 +177,13 @@ static void > cmd_set_bonding_balance_xmit_policy_parsed(void *parsed_result, > > } else if (!strcmp(res->policy, "l34")) { > > policy =3D BALANCE_XMIT_POLICY_LAYER34; > > } else { > > - fprintf(stderr, "\t Invalid xmit policy selection"); > > + TESTPMD_LOG(ERR, "\t Invalid xmit policy selection"); > > return; > > } > > > > /* Set the bonding mode for the relevant port. */ > > if (rte_eth_bond_xmit_policy_set(port_id, policy) !=3D 0) { > > - fprintf(stderr, > > - "\t Failed to set bonding balance xmit policy for port > =3D %d.\n", > > + TESTPMD_LOG(ERR, "\t Failed to set bonding balance xmit > policy for > > +port =3D %d.\n", > > port_id); > > } > > } > > @@ -239,7 +237,7 @@ static void cmd_show_bonding_config_parsed(void > > *parsed_result, > > > > bonding_mode =3D rte_eth_bond_mode_get(port_id); > > if (bonding_mode < 0) { > > - fprintf(stderr, "\tFailed to get bonding mode for port =3D %d\n", > > + TESTPMD_LOG(ERR, "\tFailed to get bonding mode for port > =3D %d\n", > > port_id); > > return; > > } > > @@ -292,7 +290,7 @@ static void cmd_set_bonding_primary_parsed(void > > *parsed_result, > > > > /* Set the primary member for a bonding device. */ > > if (rte_eth_bond_primary_set(main_port_id, member_port_id) !=3D 0) { > > - fprintf(stderr, "\t Failed to set primary member for port > =3D %d.\n", > > + TESTPMD_LOG(ERR, "\t Failed to set primary member for port > =3D > > +%d.\n", > > main_port_id); > > return; > > } > > @@ -348,8 +346,7 @@ static void > cmd_add_bonding_member_parsed(void > > *parsed_result, > > > > /* add the member for a bonding device. */ > > if (rte_eth_bond_member_add(main_port_id, member_port_id) !=3D 0) > { > > - fprintf(stderr, > > - "\t Failed to add member %d to main port =3D %d.\n", > > + TESTPMD_LOG(ERR, "\t Failed to add member %d to main > port =3D %d.\n", > > member_port_id, main_port_id); > > return; > > } > > @@ -407,8 +404,7 @@ static void > cmd_remove_bonding_member_parsed(void > > *parsed_result, > > > > /* remove the member from a bonding device. */ > > if (rte_eth_bond_member_remove(main_port_id, > member_port_id) !=3D 0) { > > - fprintf(stderr, > > - "\t Failed to remove member %d from main port > =3D %d.\n", > > + TESTPMD_LOG(ERR, "\t Failed to remove member %d from > main port =3D > > +%d.\n", > > member_port_id, main_port_id); > > return; > > } > > @@ -467,7 +463,7 @@ static void > cmd_create_bonding_device_parsed(void *parsed_result, > > int ret; > > > > if (test_done =3D=3D 0) { > > - fprintf(stderr, "Please stop forwarding first\n"); > > + TESTPMD_LOG(ERR, "Please stop forwarding first\n"); > > return; > > } > > > > @@ -477,10 +473,10 @@ static void > cmd_create_bonding_device_parsed(void *parsed_result, > > /* Create a new bonding device. */ > > port_id =3D rte_eth_bond_create(ethdev_name, res->mode, res- > >socket); > > if (port_id < 0) { > > - fprintf(stderr, "\t Failed to create bonding device.\n"); > > + TESTPMD_LOG(ERR, "\t Failed to create bonding device.\n"); > > return; > > } > > - printf("Created new bonding device %s on (port %d).\n", > ethdev_name, > > + TESTPMD_LOG(INFO, "Created new bonding device %s on > (port %d).\n", > > +ethdev_name, > > port_id); > > > > /* Update number of ports */ > > @@ -488,7 +484,7 @@ static void > cmd_create_bonding_device_parsed(void *parsed_result, > > reconfig(port_id, res->socket); > > ret =3D rte_eth_promiscuous_enable(port_id); > > if (ret !=3D 0) > > - fprintf(stderr, "Failed to enable promiscuous mode for > port %u: %s - ignore\n", > > + TESTPMD_LOG(ERR, "Failed to enable promiscuous mode for > port %u: %s > > +- ignore\n", > > port_id, rte_strerror(-ret)); >=20 > This could be NOTICE level since it keeps going. Okay, will do in next version patch. >=20 > > > > ports[port_id].update_conf =3D 1; > > @@ -550,7 +546,7 @@ static void cmd_set_bond_mac_addr_parsed(void > > *parsed_result, > > > > /* check the return value and print it if is < 0 */ > > if (ret < 0) > > - fprintf(stderr, "set_bond_mac_addr error: (%s)\n", > > + TESTPMD_LOG(ERR, "set_bond_mac_addr error: (%s)\n", > > strerror(-ret)); > > } > > > > @@ -603,7 +599,7 @@ static void > cmd_set_bond_mon_period_parsed(void > > *parsed_result, > > > > /* check the return value and print it if is < 0 */ > > if (ret < 0) > > - fprintf(stderr, "set_bond_mac_addr error: (%s)\n", > > + TESTPMD_LOG(ERR, "set_bond_mac_addr error: (%s)\n", > > strerror(-ret)); > > } > >