From: Chaoyong He <chaoyong.he@corigine.com>
To: fengchengwen <fengchengwen@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
James Hershaw <james.hershaw@corigine.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>
Subject: RE: [PATCH v2 1/2] app/testpmd: add support for setting device EEPROM
Date: Fri, 13 Sep 2024 10:07:13 +0000 [thread overview]
Message-ID: <SJ0PR13MB5545515CEB3BFD91695546709E652@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <302ed2ef-7210-419c-9a30-4386c8730a89@huawei.com>
> On 2024/9/12 14:54, Chaoyong He wrote:
> > From: James Hershaw <james.hershaw@corigine.com>
> >
> > There is currently no means to test the .set_eeprom function callback
> > of a given PMD in drivers/net/. This patch adds functionality to allow
> > a user to set device eeprom from the testpmd cmdline.
> >
> > usage:
> > testpmd> set port <port-id> eeprom magic <magic> value <value>
> > offset <offset>
>
> this should be a high risk command (it will modify the eeprom of NIC), if use
> mis-use may lead to serious problem.
>
> if add it, I suggest add acknowledgement from user.
Yeah, we'll send a new version patch to see if it can make it better.
Thanks for your review.
next prev parent reply other threads:[~2024-09-13 10:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 6:10 [PATCH 0/2] add two commands for testpmd application Chaoyong He
2024-09-12 6:10 ` [PATCH 1/2] app/testpmd: add support for setting device EEPROM Chaoyong He
2024-09-12 6:10 ` [PATCH 2/2] app/testpmd: add set dev led on/off command Chaoyong He
2024-09-12 6:54 ` [PATCH v2 0/2] add two commands for testpmd application Chaoyong He
2024-09-12 6:54 ` [PATCH v2 1/2] app/testpmd: add support for setting device EEPROM Chaoyong He
2024-09-12 9:05 ` fengchengwen
2024-09-13 10:07 ` Chaoyong He [this message]
2024-09-12 6:54 ` [PATCH v2 2/2] app/testpmd: add set dev led on/off command Chaoyong He
2024-09-12 8:38 ` fengchengwen
2024-09-13 10:06 ` Chaoyong He
2024-09-14 1:49 ` [PATCH v3 0/2] add two commands for testpmd application Chaoyong He
2024-09-14 1:49 ` [PATCH v3 1/2] app/testpmd: add support for setting device EEPROM Chaoyong He
2024-09-14 7:50 ` fengchengwen
2024-09-14 1:49 ` [PATCH v3 2/2] app/testpmd: add set dev led on/off command Chaoyong He
2024-09-14 7:27 ` fengchengwen
2024-09-18 2:38 ` [PATCH v4 0/2] add two commands for testpmd application Chaoyong He
2024-09-18 2:38 ` [PATCH v4 1/2] app/testpmd: add support for setting device EEPROM Chaoyong He
2024-09-18 2:38 ` [PATCH v4 2/2] app/testpmd: add set dev led on/off command Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB5545515CEB3BFD91695546709E652@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=james.hershaw@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).