RE: [PATCH] net/nfp: fix duplicate call to rte_free

[Chaoyong He <chaoyong.he@corigine.com>]

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Saturday, September 28, 2024 5:58 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Chaoyong He
> <chaoyong.he@corigine.com>; Niklas Söderlund
> <niklas.soderlund@corigine.com>
> Subject: [PATCH] net/nfp: fix duplicate call to rte_free
> 
> Calling rte_free twice on same object will corrupt the heap.
> Warning is:
> In function 'nfp_pre_tun_table_check_del', inlined from 'nfp_flow_destroy'
> at ../drivers/net/nfp/flower/nfp_flower_flow.c:5143:9:
> ../drivers/net/nfp/flower/nfp_flower_flow.c:3830:9: error: pointer 'entry'
> used after 'rte_free' [-Werror=use-after-free]
> 3830 |         rte_free(entry);
> |         ^~~~~~~~~~~~~~~
> ../drivers/net/nfp/flower/nfp_flower_flow.c:3825:9: note: call to 'rte_free'
> here
> 3825 |         rte_free(entry);
> |         ^~~~~~~~~~~~~~~
> 
> Fixes: d3c33bdf1f18 ("net/nfp: prepare for IPv4 UDP tunnel decap flow
> action")
> Cc: chaoyong.he@corigine.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/nfp/flower/nfp_flower_flow.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c
> b/drivers/net/nfp/flower/nfp_flower_flow.c
> index 0078455658..64a0062c8b 100644
> --- a/drivers/net/nfp/flower/nfp_flower_flow.c
> +++ b/drivers/net/nfp/flower/nfp_flower_flow.c
> @@ -3822,7 +3822,6 @@ nfp_pre_tun_table_check_del(struct
> nfp_flower_representor *repr,
>  		goto free_entry;
>  	}
> 
> -	rte_free(entry);
>  	rte_free(find_entry);
>  	priv->pre_tun_cnt--;
> 
> --
> 2.45.2

Thanks for helping fix this bug.

Acked-by: Chaoyong He <chaoyong.he@corigine.com>