* [PATCH] net/nfp: fix duplicate call to rte_free
@ 2024-09-27 21:57 Stephen Hemminger
2024-10-10 2:11 ` Chaoyong He
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2024-09-27 21:57 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, chaoyong.he, Niklas Söderlund
Calling rte_free twice on same object will corrupt the heap.
Warning is:
In function 'nfp_pre_tun_table_check_del',
inlined from 'nfp_flow_destroy' at ../drivers/net/nfp/flower/nfp_flower_flow.c:5143:9:
../drivers/net/nfp/flower/nfp_flower_flow.c:3830:9: error: pointer 'entry' used after 'rte_free' [-Werror=use-after-free]
3830 | rte_free(entry);
| ^~~~~~~~~~~~~~~
../drivers/net/nfp/flower/nfp_flower_flow.c:3825:9: note: call to 'rte_free' here
3825 | rte_free(entry);
| ^~~~~~~~~~~~~~~
Fixes: d3c33bdf1f18 ("net/nfp: prepare for IPv4 UDP tunnel decap flow action")
Cc: chaoyong.he@corigine.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/nfp/flower/nfp_flower_flow.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c
index 0078455658..64a0062c8b 100644
--- a/drivers/net/nfp/flower/nfp_flower_flow.c
+++ b/drivers/net/nfp/flower/nfp_flower_flow.c
@@ -3822,7 +3822,6 @@ nfp_pre_tun_table_check_del(struct nfp_flower_representor *repr,
goto free_entry;
}
- rte_free(entry);
rte_free(find_entry);
priv->pre_tun_cnt--;
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] net/nfp: fix duplicate call to rte_free
2024-09-27 21:57 [PATCH] net/nfp: fix duplicate call to rte_free Stephen Hemminger
@ 2024-10-10 2:11 ` Chaoyong He
0 siblings, 0 replies; 2+ messages in thread
From: Chaoyong He @ 2024-10-10 2:11 UTC (permalink / raw)
To: Stephen Hemminger, dev
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Saturday, September 28, 2024 5:58 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Chaoyong He
> <chaoyong.he@corigine.com>; Niklas Söderlund
> <niklas.soderlund@corigine.com>
> Subject: [PATCH] net/nfp: fix duplicate call to rte_free
>
> Calling rte_free twice on same object will corrupt the heap.
> Warning is:
> In function 'nfp_pre_tun_table_check_del', inlined from 'nfp_flow_destroy'
> at ../drivers/net/nfp/flower/nfp_flower_flow.c:5143:9:
> ../drivers/net/nfp/flower/nfp_flower_flow.c:3830:9: error: pointer 'entry'
> used after 'rte_free' [-Werror=use-after-free]
> 3830 | rte_free(entry);
> | ^~~~~~~~~~~~~~~
> ../drivers/net/nfp/flower/nfp_flower_flow.c:3825:9: note: call to 'rte_free'
> here
> 3825 | rte_free(entry);
> | ^~~~~~~~~~~~~~~
>
> Fixes: d3c33bdf1f18 ("net/nfp: prepare for IPv4 UDP tunnel decap flow
> action")
> Cc: chaoyong.he@corigine.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/nfp/flower/nfp_flower_flow.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c
> b/drivers/net/nfp/flower/nfp_flower_flow.c
> index 0078455658..64a0062c8b 100644
> --- a/drivers/net/nfp/flower/nfp_flower_flow.c
> +++ b/drivers/net/nfp/flower/nfp_flower_flow.c
> @@ -3822,7 +3822,6 @@ nfp_pre_tun_table_check_del(struct
> nfp_flower_representor *repr,
> goto free_entry;
> }
>
> - rte_free(entry);
> rte_free(find_entry);
> priv->pre_tun_cnt--;
>
> --
> 2.45.2
Thanks for helping fix this bug.
Acked-by: Chaoyong He <chaoyong.he@corigine.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-10 2:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-27 21:57 [PATCH] net/nfp: fix duplicate call to rte_free Stephen Hemminger
2024-10-10 2:11 ` Chaoyong He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).