From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90FCA45AFB; Thu, 10 Oct 2024 04:11:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A58A402D8; Thu, 10 Oct 2024 04:11:50 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2112.outbound.protection.outlook.com [40.107.93.112]) by mails.dpdk.org (Postfix) with ESMTP id 879884025C for ; Thu, 10 Oct 2024 04:11:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eMsEo/9sAiPBHevcmWoqRkJTzYqdbs8cs1STzGiBNZYRheVVWlfKcGlVMLeqRhGQgZIPtNh7DzZirYOKSOJptGeh0pCGQn2JC+4QhklPaYApwHlEzqBP8p7W0NAIL5Iu+sGVNDkTgZoBk6li8bV1CuuHlXON9xewyZHYZHnefnQ+Ja16r+ExjRRglI8lWT0CaVUG9pOesAS3HqZqM8Hg7pIBAYIMoVMSCKcbz3F08eh7IoDKdQkfwWUXZ5pvLNUK6oeNYXmNNuStCmBDdgCMlEtjDobFWW8Y1TU0zXUEHbkQEmPew/7z3QQPmfeWPkw60QHhw7p78hvnGQct+LbRQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6PbB7HWLBBWXBy+P38IBmWPAnB5V+3ofZhVw2PIWmVM=; b=KE9H4utxQhLk+HdodlIRKW2VbzWXBvyDoL0AvmEoaINyjfX40/T2FneZoaFOw5JmcFE8b0z8cwksKmHOUAiHZk3r+Pp7DzFhOcmFCPbjcSH95Lyz3vtlpF9ye9A+kScYPXmnXkb04hQ+1T/p1MhAn9W2U3TvZPSCb3qcp4Phpi84KdmBlVM7pAGIA5nShlRW7QwhD+eX1QilO9W8jz2y0yi6gWEhvbFK+kAzEWoSBcIZ0oyNkfHk5q5eB/EU7SREOlfuwVDY+SJpeFNIkPe+nEdh1BzT/lQAAQBbTlZpcyCtuSiTamOTguU3lrJDlkvw/UxIMgjF9SoY9RV03pU00Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6PbB7HWLBBWXBy+P38IBmWPAnB5V+3ofZhVw2PIWmVM=; b=vIaD/4XtLdymBAQOd35SglFFVECbigZBd5C1BCpCTLB8miRaAQzolFm0wqSo0GOBIzszRt0z+SVFeiZI/SZPJks4e9pBOzLmy47g+hYtOuRzAoSabj6kxsDPh9UD6bUIfYYjrDv0uuWICc17dfZ1toOe9sIOmIP/8fPlBhCK4Zc= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO1PR13MB4885.namprd13.prod.outlook.com (2603:10b6:303:f1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Thu, 10 Oct 2024 02:11:45 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8026.020; Thu, 10 Oct 2024 02:11:44 +0000 From: Chaoyong He To: Stephen Hemminger , "dev@dpdk.org" Subject: RE: [PATCH] net/nfp: fix duplicate call to rte_free Thread-Topic: [PATCH] net/nfp: fix duplicate call to rte_free Thread-Index: AQHbEShW5Tpnxm2ikU2uEDPWnovBOLJ/UO8Q Date: Thu, 10 Oct 2024 02:11:44 +0000 Message-ID: References: <20240927215753.606098-1-stephen@networkplumber.org> In-Reply-To: <20240927215753.606098-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|CO1PR13MB4885:EE_ x-ms-office365-filtering-correlation-id: fb862b2a-060c-46a1-8a8c-08dce8d0e34f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?ETq3CCzWuKWZmothXR2O8JwbXr2usfq5fIS71Muf2ZGRncqVOS6WN6ScZX?= =?iso-8859-1?Q?0I2LeL5xsVAqy68z0RqxFoRv4yh4yKgSgFHnPY0ozzM6JtTc/c7MP0K7dk?= =?iso-8859-1?Q?6fSr8Bg4rupBiwW+uYz1593q3Kvw7ArSlwTbiseaYRbKmZCigrZ22LdNy/?= =?iso-8859-1?Q?k7FekSCvPUuJL11EMEFEcoxGJRwsAOM0vVZ1HyQt0ZAckuw6o8zI2/e/kA?= =?iso-8859-1?Q?Dh/JYoaji6pQJJW29ife5Lm3oHoB+YWc+EEdtL7H1CV5Cw6Lu7gkbQ7KGX?= =?iso-8859-1?Q?1rn+GHpjgRVbxTcV6UyX+Qi9sT4BZ1Wo7i2CJGyYVlBFG7papf0T116x9o?= =?iso-8859-1?Q?6eA24y1LOm/m5PCTf1Im2V1VIG+rK1F9sa/v5HYg+HDcXB4fXjRXwTjxkW?= =?iso-8859-1?Q?OkhHJen4o+h1roaOtWiPtw4F91d6bMPKWVWLGJ3oAW4pjLVibu1GVIhuok?= =?iso-8859-1?Q?4snipT/wO/fGjpCHuaZKuQYqpCj+4RodwqHbfnJqoj+ajLNCyLJ1zChD1Z?= =?iso-8859-1?Q?SAR5pWJmw+cYiL4wQK0X6Fl0SKdJ1I82AC+wN/G9P950gajmgiI72iqHs+?= =?iso-8859-1?Q?8mNwsYG+7l34vkFeimNQDesNo3QGAJ0CW631GMOEMCED7cE1p6ZkFol8+E?= =?iso-8859-1?Q?FS80zEUIK7/nV3fcHhC+e1GPmjRy6hyH4CCM6OZiw8Mg5RCgxfz8maF6Nl?= =?iso-8859-1?Q?pNw3D9pRXVRIJFvuxNrWnI3kzQS8QSdpj3xDjjEH91R/d5Cxj1WgWMuUGK?= =?iso-8859-1?Q?CjZlxM53baTXqrBgSr4YoM7IDEgjjMpjGx2IKfX/2oYyAWZYEl/9NuYj8T?= =?iso-8859-1?Q?IKSG2ZFazzf2jm7oGKPFn+09nqXLgbIe9RcKwFx3Syym9vr+9EooFGBksD?= =?iso-8859-1?Q?/5WKX3LDPmmnb1jgjhamyLg/baZoh8nNL4QdrrH/HR+xcmHa/o3KnAyuWD?= =?iso-8859-1?Q?n0D7h2Q/qA6Ige3/GuFzKE91UsIbozqbl7+VfsHlo5C8MdkF5ipZVqhen2?= =?iso-8859-1?Q?GDwU33rXXEE6tqgstaFu924mZ21TC0UyRss442LOOpr+frl9RdMZLYRcbn?= =?iso-8859-1?Q?vrPFLFHRGNrhyEY1utqyeSd9YoQ6GfTcj6bLWGtoNEUF5NRuEWOzO/MO1c?= =?iso-8859-1?Q?SkIg4PKbaynUFU2FWy8g+M2vMhUjhIl+HuqU3gwkhOO0hANq0h5QRPgPKu?= =?iso-8859-1?Q?5Hq8MHZlOdENF0z7n23BRiMn2RBFQao4CJnr/He/VX1Ayb7M+xSXjwAebZ?= =?iso-8859-1?Q?giIgZrdPe/cHAvWqYsG0aLJwOEnYAWfc68NUR0DvfrkD8vn79kKlXwkATS?= =?iso-8859-1?Q?UTK2QkrdVFwJGj7+qybgfhj7YNBY43HpQBQe7+zt3AQTGJDicj+EBCtp7M?= =?iso-8859-1?Q?KrHITVArPYVxuey5iYe94xRxo1nRu+wA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?nYxFSTj6Z8N5B/xxwgYwrsvI/Zrq8k3GUVMw10RT0XmlQ1nFtLq1lABqag?= =?iso-8859-1?Q?G/ykH3KUAYK2B9r3dDixZxOlfkzFR/old7GSEyFxjZAHsFPn2o7VJNO/CX?= =?iso-8859-1?Q?JogeE6tIHJxVXUb2NpqUNeUuJWoDuUgaedPdneTXfGZOn1fmumkNmw1Bo2?= =?iso-8859-1?Q?BasHhXnbwsDUFo1FA4OoVg7xDo91d/9MGnJ0Ws/vKzAvAajVN18zf9E7Er?= =?iso-8859-1?Q?/vCbqDDpGTNxmBJkTIFvXyTatPucMhlHxOi1UQ6jl3UrKcqiAUCF9Nrtav?= =?iso-8859-1?Q?WtCy2ukH9kQ9JAjpIY9XpEjpoK47fAJ/I3DHlL4iNJlaOv/ip/UsHgGoJl?= =?iso-8859-1?Q?29fvINN1Q3m5UaKsNRj2Wy1O+l806CHqTyXUs+KPbZWHY4SA/26e2mwz+/?= =?iso-8859-1?Q?e3aBzRpIPxkew6TZ3NBChdu0C7JkdY91kHBDyJXrT2NYICKvVaV1z3s25T?= =?iso-8859-1?Q?rw6J81C0sttwZOWvjLVAKZtyncbGKvJOaC/uK1AvCYfbYoFboglG91h/5q?= =?iso-8859-1?Q?kvctmuGl/2RCNR1LBQRxyDfbGToxpYOl/zSfbCqs7DL35cV98L9SP3aNDB?= =?iso-8859-1?Q?lD/J192IoQWw3Jzy5fYWcYRaPYXpPrCvtbgjGDC3ita4cJSrBvhPMNx5Kz?= =?iso-8859-1?Q?bmH0wTICA7xrkUQooelNSSoVFcn+c/mzKXmA5i9wyA5viSa4rgurx0Sj/D?= =?iso-8859-1?Q?x7CUUlTlebLstuDAHpOnvwH24TG0UEuToSX259dQdSYZ73JzZk0/l5xcgp?= =?iso-8859-1?Q?sq8TkZ3iXzYQARMNhiDjZB+z6uDYAb57HI1M9GlyFP+HtyUX7zhvY0hA7d?= =?iso-8859-1?Q?pZ037YqXyK7sJVqVJqg/aMUtPD6qLpoUx3WZwDTVvzNKWcs3jCH84eE7nX?= =?iso-8859-1?Q?1cYQ019e2iMflYKFLWKdiihLOY7Yud4GlLeyL0nkJY3uHPbaQFJ4kgHzEJ?= =?iso-8859-1?Q?txjmeYRK3z90y/xZkucCvakPYB4+BShAwpgoR42z5Mo27tUgPk3IgXSxBa?= =?iso-8859-1?Q?e/Qc++qxfkxnbW+lfqnc594K8L75sYjQ8uO0wlY1y/mYtVnLU5zk4jSEnF?= =?iso-8859-1?Q?m3rl6zsEOQ6vLCkN7YsZA9Q2W+oP5gID7JqBQKhmgys1Q8lG3VEvSEiexB?= =?iso-8859-1?Q?HsRy0hW4t1CoO5tUEg2AXPdvo5KXvGi4bLy2D5uCw7rsddCTIreeKQ4tds?= =?iso-8859-1?Q?/4qPcKhucujRp/VIpeNStOle6BPJelkf7FkDUybUHlh4XwaocTCj6E9fm3?= =?iso-8859-1?Q?gRFQ5QdFKNIY6cQVqVDX/jCWYJPSPnvuRs3MD2UHv+wyqaiw3SQQ97/Gdd?= =?iso-8859-1?Q?5vUhPQmFFv52YFZHJfydpDDLiu95VfzaBrRTT9upN+66FpdTxGl7ksZ66C?= =?iso-8859-1?Q?sZCe+3pupQICwM2cLOo6dviLMpaa+FXRA3ULXk7YRQ1wo59VTLIgPypFVi?= =?iso-8859-1?Q?FbZU35H003yf93QZcd0Sg/SDj5fxXHIuhIgYmIbZnVsrPo3F47y0pfn/3e?= =?iso-8859-1?Q?0dUhqUgoG7WHf/FbYsUXzWN5ga5TCWJad+OaAtTkKwlAWOi/lddWPE/7OD?= =?iso-8859-1?Q?xfkQzoymbjRxoiA3Gq0ykMp85DvZ9EdYzrPEqEzCVaGgD7SCgeyx/1O98v?= =?iso-8859-1?Q?OQE2lA++/4dwxQdUSOokrHbTlsPJFTCvsc?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb862b2a-060c-46a1-8a8c-08dce8d0e34f X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2024 02:11:44.4171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d3x3S60LSU4jn5BWg7Bhg+Qc0c2YHN6zGzpb7+4RQcBCLQeuS2D2QltCiKZ/d1wNWB/VtRmF6LwnI4N/1ZHCzjo+4lqzyrQ/RPn25OBgmgk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4885 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Saturday, September 28, 2024 5:58 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Chaoyong He > ; Niklas S=F6derlund > > Subject: [PATCH] net/nfp: fix duplicate call to rte_free >=20 > Calling rte_free twice on same object will corrupt the heap. > Warning is: > In function 'nfp_pre_tun_table_check_del', inlined from 'nfp_flow_destroy= ' > at ../drivers/net/nfp/flower/nfp_flower_flow.c:5143:9: > ../drivers/net/nfp/flower/nfp_flower_flow.c:3830:9: error: pointer 'entry= ' > used after 'rte_free' [-Werror=3Duse-after-free] > 3830 | rte_free(entry); > | ^~~~~~~~~~~~~~~ > ../drivers/net/nfp/flower/nfp_flower_flow.c:3825:9: note: call to 'rte_fr= ee' > here > 3825 | rte_free(entry); > | ^~~~~~~~~~~~~~~ >=20 > Fixes: d3c33bdf1f18 ("net/nfp: prepare for IPv4 UDP tunnel decap flow > action") > Cc: chaoyong.he@corigine.com > Signed-off-by: Stephen Hemminger > --- > drivers/net/nfp/flower/nfp_flower_flow.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c > b/drivers/net/nfp/flower/nfp_flower_flow.c > index 0078455658..64a0062c8b 100644 > --- a/drivers/net/nfp/flower/nfp_flower_flow.c > +++ b/drivers/net/nfp/flower/nfp_flower_flow.c > @@ -3822,7 +3822,6 @@ nfp_pre_tun_table_check_del(struct > nfp_flower_representor *repr, > goto free_entry; > } >=20 > - rte_free(entry); > rte_free(find_entry); > priv->pre_tun_cnt--; >=20 > -- > 2.45.2 Thanks for helping fix this bug. Acked-by: Chaoyong He