From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CDAC45451; Fri, 14 Jun 2024 04:30:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E63B9410E4; Fri, 14 Jun 2024 04:30:43 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2092.outbound.protection.outlook.com [40.107.100.92]) by mails.dpdk.org (Postfix) with ESMTP id C25C8402C6; Fri, 14 Jun 2024 04:30:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bzd2x+dIqMLWFjjXm3P9UG2IOSuad8XyucMJ7IWKxZa4F00f5npGhr0NU72Ba+ObWfxE5bzc2PuDb9UBB8cjz7aQmPIkpoBrd+ABKUQGhyxIUdzrYpgV3CjDNjYLNqDy0IHr5CPTEPD1xWen4+NrGA0i29hpibQng79ZYSxBI6lxpjRBCqav6VR0/XmW5wy193xoSel1kbmuWrfKFCaczIG6oTPMmzIXjkwZB3U/+1pwAlNX/qQjhL5RlNWtoisf4zgIalcwppThNnhfUeNjxXf21hUHXXsgLwv9yxVJG2rk0IEYfVZxvY34DSkEQzEgvDmf1fQqbPFwg8/zHeNqAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t94xlbqigLDV4eZWNkh+KlcCYvmVF5bjsSgBxDlfAHo=; b=NXSq3HqHXpeoAYlGzmtrIx4eGF0JvbOkqxQzCvzHt16HMCJlcyEetZJKBx/9GIVcRXOaYOCTbsKIM6xcmua1nIdKcT4F6DKEY1m3MeTNorLR0T4s5XJDu+e2XhwJlOh4JUk6ZbQCJmxV5RggugCtAGKWYO8KeawyVa+sWnVRXIgO554IOEsajlLeSS3YDbYtxp5UaxLMhVtcr+IOSY303nm2tQtVYyr8WyQxgHLZ4anVCKxg98/DVg6sEQ6JeJrgk79Ga90TRq6VMmdo8N3en292LE6fqUHoJQs5ak8r9I6GlLKPnmbgz7Wk8Qf4THua46JLIZEzhBOHG19Zv4k7xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t94xlbqigLDV4eZWNkh+KlcCYvmVF5bjsSgBxDlfAHo=; b=TvtLP5Q+ZjkdVAO/SVr2xwE0emO5uQWkCacoP7rRNq2Vnc5ewVjAk+tSYQDV5q5jcR4fzl49VHCiwQgchPpsWNMzf2PR2qJgkPxPjq9qlUO/z6LrzfUkrjPyybjk6H2sF+JVZbSW2J2j3I9Tj0TuZxvyWZcLDMVz6YQ24rJaijM= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SN4PR13MB5774.namprd13.prod.outlook.com (2603:10b6:806:216::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.21; Fri, 14 Jun 2024 02:30:40 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%4]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 02:30:40 +0000 From: Chaoyong He To: Maxime Coquelin , "dev@dpdk.org" CC: oss-drivers , Xinying Yu , "stable@dpdk.org" , Long Wu , Nole Zhang Subject: RE: [PATCH 03/10] vdpa/nfp: fix the logic of reconfiguration Thread-Topic: [PATCH 03/10] vdpa/nfp: fix the logic of reconfiguration Thread-Index: AQHal64y18gLYc7PZEen00lWmVaAIrHF3m6AgAD3kKA= Date: Fri, 14 Jun 2024 02:30:40 +0000 Message-ID: References: <20240426074831.1729792-1-chaoyong.he@corigine.com> <20240426074831.1729792-4-chaoyong.he@corigine.com> <4249e219-5aac-4998-8844-677bddd35585@redhat.com> In-Reply-To: <4249e219-5aac-4998-8844-677bddd35585@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|SN4PR13MB5774:EE_ x-ms-office365-filtering-correlation-id: c124b616-420d-40df-0950-08dc8c19fbaf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230035|1800799019|366011|376009|38070700013; x-microsoft-antispam-message-info: =?us-ascii?Q?8KGkpptCdjs8UvHtpKTgxg/s83O1H1T70yGb8Y3cNppG/T+mDA1uxYWVuA50?= =?us-ascii?Q?7ynsxoHiw1EdrUMVqlKzc9j8vtke2thNLwv2s5tyinhf9io5/mJrvYszONQW?= =?us-ascii?Q?EoFXsWfOy+Zsjq8ppbDwvz/C/hAlITtHOhRymKWe5srPx0xYxJ6GFr7RNHHp?= =?us-ascii?Q?4s1Pxt9akMnuKjJXP7hkU8dMpRdmGr1hg1/wc7HOey+n8JkVFm7qsU1B24qx?= =?us-ascii?Q?svCYMhuODc3bFVUgNn9aLvV1xujV+upk3y1HWIEa0J5jJPONwzFKqGdwPvyc?= =?us-ascii?Q?bSp1SBEwjs0FJiofUA5QkMahQbAhrQxSqByjjo9VVk7mQ3cvuBzKd+Kw0MAH?= =?us-ascii?Q?z6riuQtSqVB2mHgayyWj9X6sihCNE5qtVtcT2Ik22thJbXOD0PtHKKDMUC3D?= =?us-ascii?Q?B4/oqP2ZycHnyK6+/k61ddFjQqTF3fhcpHstikQuwqa+gnAZKVlopu3fcCES?= =?us-ascii?Q?JVAUj3LdkI81sMgA/mEQLNpTE4Ure2nV65XC2JIFay5MF8DGLQMBQ8BquFhd?= =?us-ascii?Q?UbCH1AAVF1F2QMjKiNmtJc9apzSuqUNGjyiIeI23JcVtIJh+CZrWQRiyGurK?= =?us-ascii?Q?QAlDDK8nUOIw1z+R1x2CzMQs7GWIFtqj12/i6V0sAT+lvKJnuZnSnhIbh/mr?= =?us-ascii?Q?QDARRIFpqtNan335j5xsgZCNTUH9zKnulMXNstDvPwJS+BV8K7WFhcw7BFmf?= =?us-ascii?Q?8C6rl7cSXuNOqOLhBi10FUINvWv7t16cUlL/ZQGhJ0wzA3iMgpoD1K6c8Y5l?= =?us-ascii?Q?/WzO8v7mGXJ0LBKVChdwL/4jRjbuPl4qp3pj2RrL8oMxf5Pv7wRJbIbmN/AM?= =?us-ascii?Q?8mqJ93zAxz8+mD8yj7rpKabHJ5/wF318qIYfPDu/V5zt9FzrY1xebXzHgRFH?= =?us-ascii?Q?LKZ1LLKg7h1YmON+fI/GMBI68T+STtCeDs0bJY55rGvLpLMkOXASoRK9Kt4c?= =?us-ascii?Q?IsA/o0EUetKI9Vrco9EDpiH/4AVsxi2Vlno+cf3v7gb4Q1XDjZqUUVFCjLWu?= =?us-ascii?Q?DVCaLcJKlbNbgTvuCTtpDvbvyQRvvIonqyf1yI6WB/9IkkISgfMU10BGgzTU?= =?us-ascii?Q?cKG5O3ynCfVEgTVhphJPchgjiRjayCZfHlaMhmoyijj8SBKscjAqYx54xA9N?= =?us-ascii?Q?MJQWbKDZszKgoOfZ6tPcTKAJhO0yJLxbHXrziL9aubOl3y0UiNK25YONt5j/?= =?us-ascii?Q?DEU7iC5G0K+kurBNSmRH8S/M5OhJvHS3kMLuF6V/A+fia5MbT6PFczVyPeys?= =?us-ascii?Q?luN4ziP8VnM9fN3a5jpSNwQ2BDFxXfccHARsOvJDWiYxZ4wlBGN+Y7l/XiKh?= =?us-ascii?Q?9uZnAxn1Wnv4QiTn6boElWTcQnzvSyBW3fQGji8xOewpKmQe2yci4PO4Vvu0?= =?us-ascii?Q?bfrqzTk=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230035)(1800799019)(366011)(376009)(38070700013); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SeHnnJ2OL052llE1O3Kzinn8YoQG5zU25WlTKyNe3t61CeOdWBoUZjUMBAAA?= =?us-ascii?Q?bddfFXDorzAL6esJtGtuNruZzH4r1m/IWaTX/giI/7M1bhDO00j/69SgdWEB?= =?us-ascii?Q?cVMVacGvvMBGTzERx2xXoTPGgze68A8pJ4JzNDa7oXFMfx8ResQoDRcuQuZR?= =?us-ascii?Q?y4L7WUTY61oUaP+Kh5Dx4yEseYFsx5bvDTOG1UjHNRVh8J33W54PH+KHs8sT?= =?us-ascii?Q?HiQoexSdspuN9GdozTekwiQ68YkEpPtRUPqHPegtBRDiSBJqVW6tix8jwHC7?= =?us-ascii?Q?suBl4W225w7XdiN7MU/DW9qvy9hKHEryQ+3+Xq9x6ndEoc4I9r3tfa0/7oTX?= =?us-ascii?Q?8ttCIUnxU5HEyRkVwX5Ij86JLmeUkQodjMDT4tTyhUdzdagCWXAg/OX5xlGE?= =?us-ascii?Q?NQombuqFLVCdqRYfKqLtt2S9t68So0Bp9qJNekd1DlymLhe9HJZEqxXA+IAm?= =?us-ascii?Q?d/Rm2EEAc//ZQ2Q/zZ3TtjfDwEC2zatO3gWD9JeohHpBBP43L2w+tbhima2+?= =?us-ascii?Q?jEVjv3dC/Xcy4mCJ+ftUewSbq2XbkoontxZPZy/FEmt0hYv3eqpPV10e8ESR?= =?us-ascii?Q?DRoPyBh1c/tDaK8Zdd90hYlq5T92Ao9pye3EfNp7lFyw1hhV9i2dUR/IDmIe?= =?us-ascii?Q?HYSG1H2ww+IkrD+X3gsM56BWEW8VD5rAMMniKOdsBPi1OMLg8p5OT7ouiyur?= =?us-ascii?Q?6vDRgCNqbY/4K9Vp+Z+Gkgo2aiPIcL0n7xG4Vu1THsyV4n2zWdJNEO+hGWcO?= =?us-ascii?Q?x59vYAm7IOGUoAelIA9xBxypxTK7mKSkGHi8snRZFVL9rkIAeMWjuMG6rftY?= =?us-ascii?Q?eA6YbKIvKk0gwflX57nR7ubQq8HRMHR7T9VNoSUxzvQvcH87m2D00Zohou2S?= =?us-ascii?Q?U0wse71usK08HT8cHs8jQwGgB3DTbZi+xf3EvoZaWJTCaNjdK9BPDUgX3AuO?= =?us-ascii?Q?ruUogYYqHUT/nW0dtYrgegnmsjBvA1jQmZ725pJtcPa1cUkhqXyN+eDTk4PY?= =?us-ascii?Q?kIcGVYLvb4WgFKod/6UyMJ4BZc7ZdBj78SCNTz1tqLhPA1JIey6e4Y0qHFxi?= =?us-ascii?Q?5zSNTW+G8yj6Nq/4fFr0VChEvmDSrCt8M/Y12mVYPQZBB4ftymk62Gvzo3T8?= =?us-ascii?Q?9poz8mhNkm5J7I5CSvfjFONVloa5prRdesD7qBFc1nkCLqXrjK/SiogkFwyR?= =?us-ascii?Q?e6enkQwdubVyxc3QpU0M25V0Iiroq6BZ3OhLzeHYd4l7MaojO0PG23zYI1Fq?= =?us-ascii?Q?2nJm2ZSWfLbLlLskgXYOZTLA7898Ipdt3DCXAMs9YRPUYeU5LeYRBKEWRUHa?= =?us-ascii?Q?yLp55MmKLpYRINwcaX7ZKQI7wQzQEuUauLO7PS57wSC7MIebtQEt/d6oKn10?= =?us-ascii?Q?CPE+FlYqYXh+TWMonmkrKoaeFg+3zUGeQ47MPMWxiQhCDFmInhx985jY73xF?= =?us-ascii?Q?jkh3ulniSKP849YNWDRCnqha6t1Esm8Ue3idX/9sTnRtZgkSF6cg5vvYp2DV?= =?us-ascii?Q?abiW6OJNj6kJLV3Ey91YoBCE/bPQoz9Wz1Fruuo192Mz1eZxkFrRxKIzsqwn?= =?us-ascii?Q?Qzcuarf/Fq7S/PC/3p0+MVINdTgGeDWuwV/d+GWm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c124b616-420d-40df-0950-08dc8c19fbaf X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2024 02:30:40.4191 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sqha1Dfr0TUm71+PS8+WvBf9FVbWNUIPr4ieYDTZLUqJpEOzQEd7qEZp3Hpc3h+dlhsV6E+dAzk6rT2EiwmpkZDznUgMnkkIBwvTySNjFg0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5774 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On 4/26/24 09:48, Chaoyong He wrote: > > From: Xinying Yu > > > > The ctrl words of vDPA is locate on the extend word, so should use the > > 'nfp_ext_reconfig()' rather than 'nfp_reconfig()'. >=20 > located* > extended* >=20 > so it should* >=20 Will fix in the v2 patch series. Thanks for your review. > > > > Also replace the misuse of 'NFP_NET_CFG_CTRL_SCATTER' macro with > > 'NFP_NET_CFG_CTRL_VIRTIO'. > > > > Fixes: b47a0373903f ("vdpa/nfp: add datapath update") > > Cc: chaoyong.he@corigine.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Xinying Yu > > Reviewed-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang > > --- > > drivers/common/nfp/nfp_common_ctrl.h | 1 + > > drivers/vdpa/nfp/nfp_vdpa_core.c | 16 ++++++++++++---- > > 2 files changed, 13 insertions(+), 4 deletions(-) > > >=20 > With commit message fixed (I can do it if only change needed in the > series): >=20 > Reviewed-by: Maxime Coquelin >=20 > Thanks, > Maxime