From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AD4741D37; Wed, 22 Feb 2023 07:48:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08D8040697; Wed, 22 Feb 2023 07:48:01 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2127.outbound.protection.outlook.com [40.107.92.127]) by mails.dpdk.org (Postfix) with ESMTP id 085C140693 for ; Wed, 22 Feb 2023 07:48:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O35apUffFLeFD+OBEf97tpBJdI0minLvad/SsshITFA7nxaJZaTia3FgXwnjPEmbBhpn2x8Mt/3Sf5Co1eUusLkAvCLwQFl2i90ndHxnauSkUk15+3xLD/PLyRV+24vhvhua5AKjRYNwp5NSoboVjE7U52uHXL+F24YhMb02ySmY94mJ9wUi8bco3O1PNMLLgZ2/8VO/mmemvMosWkLpRizX8HW21A0VaBmYqf3IBVKFOB23TwNFcBi6p2yqFb5rvKMLciWSsO1iyxLb+LZ3rF70zalg72nqTMK8s1VplDEUtTyx1/XA9tydiaH4sytKkJpHaW5zZlI8q7K1xM74Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hEHkxWvs3AlfLhb3K0rbcvLm/ZexNx4Wd60hE6O93t0=; b=Kvtn8qvYL7rtpoETRAKiB697KZFMPevrFyvmWIJMmSnDaG1y7vjcoTLSNJCqjG0W4rd5OPEIJPFFC3hIUE8H17rPofMlw9tYby8Hx/8EoamP4th3ZvssT//4U2dhafJWcngYkUvvAjS8QliNmrsGBWXAzIushMOlQjxcSYx5RuMry2nKUAeFhWlu4M+hLlPnF+f2C1NPA+jFxQQf1FJkbM+lCAaQHIebLaY7rWdD5rfApdfv7/6JK2B+1gUHvkAVsiMQTcYfuhLjB0VvHLKBk40FstQk2Wj346Nn0elbR+JTQR3XzaTFlUUvofw/xWP5FTWcxlUgn3XuddNm3mzKrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hEHkxWvs3AlfLhb3K0rbcvLm/ZexNx4Wd60hE6O93t0=; b=TqwniWdIQ8qTavHKlmM+LRuoCsok63+4/0tey3UbPZYZuy0SeshT/lKoy6N76/C27Fx4uhKx9bPDsQMlYoFX1+Wxz0VndXlh+nhBdmIVtpDiCNdb6gkRkQsMIH5bS0BFBlV5RxDEnOUBpg7ujHWZrTNySY7HRtIUvW2EqszcVTE= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SA1PR13MB4976.namprd13.prod.outlook.com (2603:10b6:806:187::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Wed, 22 Feb 2023 06:47:58 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 06:47:58 +0000 From: Chaoyong He To: Stephen Hemminger , Simon Horman CC: "dev@dpdk.org" , oss-drivers , Niklas Soderlund , Long Wu Subject: RE: [PATCH 1/2] net/bonding: add independent LACP sending function Thread-Topic: [PATCH 1/2] net/bonding: add independent LACP sending function Thread-Index: AQHZQdZ10g6+btM5X0WhLc1KUBLV8a7R+1GAgAWhWwCAAHE9gIACgXcw Date: Wed, 22 Feb 2023 06:47:58 +0000 Message-ID: References: <20230216071514.29418-1-chaoyong.he@corigine.com> <20230216071514.29418-2-chaoyong.he@corigine.com> <20230216114727.561e8abf@hermes.local> <20230220083133.02283b8f@hermes.local> In-Reply-To: <20230220083133.02283b8f@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|SA1PR13MB4976:EE_ x-ms-office365-filtering-correlation-id: 08546aa7-c67b-4a88-78aa-08db14a0bbea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KsCT5Cqlq7jj09+zOjZ28P+EZOm41oMhswHxUhWnNchOL43ws1PuOsb+lXMK2qf1r5mpfaVgjXhWEGPxAyP42QgkpPPgZimAZhvdfdxvGETiyBWlykBm08X+hw/DCL9SyEtPClm1NmKxOcUzRj/HyvQjeITyXo/MwYaC+9v3Y9vahM1jYhu2nAPoWmcH+oNIXObY+EQymHMiRKvuuSCyW8eEyocFqc2Yklcc5hYSFWmx8zMFUxTC59bWuItnCX1CQwtywhzi2Azj40eWfIeKP5WEY/o8JypeMg3Ff2Ssrli0Lae7s2G9VJtHqZUbSVh/nS4FtVo7UzAbPPsABpzDoeDCqqa0z4Sejuha/BzgEvJGvWYL5ulVasUpeX2/vViMJ79gWaXwzX7opHftDA69luIxLYLwipXcJv4R9kPp+VpUwHQofbRps8+rxmPyKCd5hLjy5YV2568K2qgsHWBUTQMC4lC6SUVgYoT2rpQQ6QbXzRjvhhZV4HSG/7vcxWYEH8E0GMw9ZEH4Hu/JFZmlDBcAUyuk12MpdmG6gvdz8m0+Cxo6HPJ3OhnMT0/a55ykhBt+UmTYI61pThDU8aoiFfE6uuS8ZTQwdowyX5C79xzCDrTY9iCxc2X0vUEPRxlriSzUDEcCj0jLhoA7vHXZBZM+hCeSM/Fiz1Bhy6nPcLfB9T29E5+BwNtTcfe1U0A+8lYeFpfh/zSvqgIdt/Se5x0ly4cBuM8fS9e83ciZanu15qenEgabXGENZmtr7/wW x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(136003)(39840400004)(346002)(376002)(396003)(451199018)(38100700002)(41300700001)(107886003)(66946007)(64756008)(4326008)(66476007)(76116006)(66556008)(8676002)(66446008)(33656002)(6506007)(8936002)(7696005)(86362001)(478600001)(52536014)(6636002)(110136005)(71200400001)(54906003)(2906002)(316002)(9686003)(26005)(55016003)(5660300002)(38070700005)(186003)(44832011)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ZbU8jazAaE7nhOfPEihPoCocCxbxt5qGwg1Kcc2nHEciYPoewFABajoWv1u?= =?us-ascii?Q?C74+V+P5ePBPplXC8AK9lYiXfzAqEA6B3UBfcT3T/QZepVhvSWKNc+ZtMBNI?= =?us-ascii?Q?MGRJ2AdOEw0KXeY6MaRDOpmDHXIpS4oNdabdR0TEP7rSJXZEkpcDZfQPtwey?= =?us-ascii?Q?pF/C8Mv1shqtpDCyKvudQdYhm4YxdsI/1BevgP6QX1QxbI5F0P+ROelEwd0N?= =?us-ascii?Q?chRxniNWp1jiL8WdKYkMLOXNz3vGYAL+2trp+pb10MpXY/5cqbHs0yW1aot+?= =?us-ascii?Q?NqNLY1Dc4XgHm8V+4rcZxEgVAXC5lpt7v3hBbo3ndcTM/vkSdvSn25gHJ5uZ?= =?us-ascii?Q?8uFztfzSytlHMuaT5XaLgPAihPcRnpbx1xvSkyZ1IHIoW8YpyAJCNyPZy3Zw?= =?us-ascii?Q?tfh724xTXMCzy1oPAaFR0tzTYyBSUFfxHqaPp9essGfbvR1JP4PesD19hKoJ?= =?us-ascii?Q?ybgSlXvzD3ZLuk5iULlM4QBQAEH5rUAVxB0J+QsH3d3BOvL+10QnJ1e9vwwn?= =?us-ascii?Q?j1fqGcEphlz5c6cQ4MQmlApRwDO82gKoe3xp3kjfpn+3kQJNyNSDVi8zf2Ke?= =?us-ascii?Q?D84x3OXypaSoqlC7iBsAkrMtwpN3DfrGtZ1WzHs1eiSfyK90g7vlimb3MgTE?= =?us-ascii?Q?+/fMIA7rbQGJjzHPG1ay8/EuoB9dDYFdjmg7ItVQRzXJoCQ7Trn9MaOe6qiP?= =?us-ascii?Q?xacD4PviaBZmoW/40kpsO4/jO6J0UmBwVnnd+uBMvjawKQKKHYLmL+k4QFPO?= =?us-ascii?Q?RJTJk/Zp6kqY30/Pi+/+furitOoiozmqpsrXLd4w5KMV0n7iAl/6h0VGKJIK?= =?us-ascii?Q?BKUPdPLB+jew8rInWxA63gMdTAc6Go+oRysy3t+YDaiEFHZHMw5icTwkFGlp?= =?us-ascii?Q?NtohlJ8hEEvsRsrhDHk79935Y4SGFFKIct1jfbBJFtLJHLjgtshzmXOnv1WS?= =?us-ascii?Q?Q+0WFYYW1IKwVcDlbRzk60e43NeTaFNPicmw+vn63hWLbqwrSjP78HaBJpAg?= =?us-ascii?Q?8gHnO0ENCh0mvk2UMeULfphvDXjbr0U+KSm0xgaOpvFehRhh+TggoGsSFF17?= =?us-ascii?Q?sVQ+dKhi244ftUUVmYG7Ae6PpngH7KZouZdVHTMJdPVaQoZPtWMSRQJ7SzWw?= =?us-ascii?Q?1SD6Zh1XaXttwZcem6TB4PNLHqEDxIw4OgrQoeKX3aDGAi5a6NZCxjkS3TVx?= =?us-ascii?Q?eOPdLDDEYhpKbJ/ORnjbQ0chUFE6Zy1xg0/eDLCWiAPeGHubYrllTqVEwQoN?= =?us-ascii?Q?gRdXeOtTz+fKARcJllpusLLbtMRJ1Vk2WzCHbP7yTqyROJwUZtYTQaDMfBVf?= =?us-ascii?Q?XodTz7bqaNhucpjfqGoaFgIMgZHo0zpXYfmhyrX7f7OWKsB1jXHBbrzsyzj3?= =?us-ascii?Q?lUsuvBrMVstSQ2Mg9Ma7ytBbR+EGljYrg9Ie/xQY+oQMLm+PnInLbYBrXzHu?= =?us-ascii?Q?veiULglBVoofv+B+g/74DUEHJIgsHZlwPZS2h2NtYUNXaQSq58IM2+gKqPxY?= =?us-ascii?Q?pNE4m2wZ+NJ4HC647CLLVTEzI5zQ5UiaOCguXui0nBupmMHPnMgomEam1Gvl?= =?us-ascii?Q?UGhZ+Wvf8odtWBNG14TWVSx4N9swC1n6CUIU818ix9yZJZGQRzzgWruYN02e?= =?us-ascii?Q?Tg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08546aa7-c67b-4a88-78aa-08db14a0bbea X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2023 06:47:58.2929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wQHEJKLW8/gnc3pcHCj6Y4C82QmGB9/7Gpo3F8rhwI21BbndFCSGbsVKehYMAyfvjXf025ApbE/hmwcDrpzbRkA/vvG1qdjAkvOvxr7st7M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4976 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Mon, 20 Feb 2023 10:46:16 +0100 > Simon Horman wrote: >=20 > > On Thu, Feb 16, 2023 at 11:47:27AM -0800, Stephen Hemminger wrote: > > > On Thu, 16 Feb 2023 15:15:13 +0800 > > > Chaoyong He wrote: > > > > > > > +void > > > > +rte_eth_bond_8023ad_lacp_send_one(void *queue) { > > > > + uint32_t i; > > > > + uint16_t slave_tx_count; > > > > + uint16_t active_slave_count; > > > > + uint16_t active_slave_ids[RTE_MAX_ETHPORTS]; > > > > > > Thinking ahead, all of bonding driver should remove the usage of the > > > terms master and slave. Perhaps you don't want to introduce new > > > usages that will have to be fixed. > > > > > > FYI - there is no usage of master/slave in any of the IEEE > > > standards, or operating systems other than Linux. > > > > Thanks Stephen, > > > > could we agree on alternative language? >=20 > I did a little looking around and did not come to a great answer. > Looking at FreeBSD (and Solaris) they use lagg for the aggregating device= and > laggport for the devices associated with it. Applying same logic to DPDK > would be awkward because it already uses the term "port" > in multiple ways. >=20 > Cisco uses the term "port channel group" when configuring link aggregatio= n. > Going that way maybe use channels as the replacement for slave in code li= ke > this. >=20 How about we use 'main' and 'member' ?