From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E746A41CB0; Thu, 16 Feb 2023 11:41:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0CE142D13; Thu, 16 Feb 2023 11:41:17 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2119.outbound.protection.outlook.com [40.107.94.119]) by mails.dpdk.org (Postfix) with ESMTP id 73D2240EE3; Thu, 16 Feb 2023 11:41:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HxOhJVDVCCU87JKqC/EU3xDpPSIUIVJxXjOVSWrVrfue1h9XumeWxMfI78O9MpxyME1WZFCOgGWS8lPZp4vJeSkfWI9Qje9s0Ztg1PZnpQqv/UNwkfTRD66Nr0pH+3qTqOcHqkEvdQqPdsthM4eN4Jcvg1FZ9zjCuBT6qYNmKA/zCoFAiAaYglYVPr0WIjQskdquRlqost/AgE6XYvonG9OQwvkOBaU6zytGOUrCVD5vWqVLaDsX1kS81Zj9spf5nLfq/koexC/O6FCMLSBQAS5cSCPy3DSSBMAEVCUabI+pNvhZhDwE+TglkCY0tslmBgjph0/MxreMOACVgKwDHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tz12wEkcPh3P7FyxnrRGt8dwpjGOyEzkgAKjds2aO8c=; b=clBiAlaQ6yLlhJ4FabS3eugoQxzp0VzJRRvu/1oLOqXtTJmsSgyrD0H/EvTGQIsSpGF7YYzKCJTW/X7WhDNyjplNviCfsVSZtWQ3WnE4J+h5IZz+2pdybdrM7AwSGhCAPlu9vwpHSTle8xhpwRbpRzxTZfOduRKizLVz0DbCOMI5SnSO3LPSSMufhFrK/YaqN8bKCP7Nyel4jYbDkN9Wa5DaFQ8E4tJLN4fQKUqbN/NkMuka4k1Pfvn8gXuhBA3NFvNH4o645FZLGvvy8RgH9sdSjdSt/ss/HJdmGZtGbLeQjtykf2cKAWFEipk3iDgjFJSA+mUHblEPclZRuLNf/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tz12wEkcPh3P7FyxnrRGt8dwpjGOyEzkgAKjds2aO8c=; b=mwI38uO5KLtdLBwHqIREkxEM21n+DPsAKmg63JH5/wkUNcvcJKH17iyrGaBsW24CwUgxcpDdj4Y7NqS7SG5XYGsAICVOg0cKPF9P1M78NC3Cz84ldtLWpNSpbVExg0UDXunSREtfu1GaHSiDgJ2fqyQrLcmeVcVpmI30vb40N0M= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3796.namprd13.prod.outlook.com (2603:10b6:a03:22a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Thu, 16 Feb 2023 10:41:13 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%5]) with mapi id 15.20.6086.026; Thu, 16 Feb 2023 10:41:13 +0000 From: Chaoyong He To: Niklas Soderlund , Kevin Traynor CC: Ferruh Yigit , "Xueming(Steven) Li" , "dev@dpdk.org" , Luca Boccassi , oss-drivers , Nole Zhang , Kevin Liu , "stable@dpdk.org" Subject: RE: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk Thread-Topic: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk Thread-Index: AQHZO5349Gr5UzWOC0G7Lf53/wKjpa7QD1OAgABEgICAAAucAIABDC0AgAACWwCAAABQQA== Date: Thu, 16 Feb 2023 10:41:13 +0000 Message-ID: References: <20230208091544.22122-1-chaoyong.he@corigine.com> <1856a555-e7d5-6dfa-6cf0-c4e170b81482@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3796:EE_ x-ms-office365-filtering-correlation-id: 438253b5-81ea-4f56-5d59-08db100a531d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vWDSVH20zf6c/xA9DwDd22oRluar6PRTVm4bEOAJMjZg6rsOvQuwWGDzs3AArwcvVu5qx7iFsiXBjsrszMOGrO7P5bV1+Na2DV574uYuRQWYYRyaGUKxr0frg0ZVxg6no/lu0GlWCkUwRfq5ANWFxXtn6S+uMkf/7FfHUJFuhY04SxPFbaodjEZ0FX4BogYjItowJs/rKAwunR2cpB+aG9XbMVcVGG3q0KkQCnzVRd3uUuJeQM7kxAhK+n4d0hxfuC51wOMh5SvYJIu7ZEiVoomR4wKnkDupOgeuLQqnpNypl9S5LGOxil9V9ikZLuurLKqlQprZ6E/I4BxjoCasVbFj+op7uiE9OcBAxJZ1Drj5ZKcKAE5bJCt5+Uw0oQUBQEvAASjBYGS9waB6xv+urKREZ4mwWRAJcTkI/XkubEC1eT7RqrX8nqDZb9aZt1jvvJ6pcJCttKZsG6rRSkT11imXghctfredN3eZwgP+I34Dfa5cqwZE2i4tHqTZF2RTKGFv+n9+sDVQtOO/6W+FTAMTotY/0nx+wBGOlhjCL79US9h0+64xkEb+GfKRCu6+nCeZ/pd9OOaHtlQ6ryU+G/mZFZRFDAtUy18x7AcDEE+kcPlrOJyfDtADzSdPk3+FnnIyvG3MbaWfH75cxmt/5eGmC8DSAE3wnkByRihZohTDZ9cR6faMczVkloD45D4f/ns/8skWWMnpuUGdjPwT4DMAih5Caoeg9UbDOaDQzDI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(366004)(39830400003)(136003)(396003)(451199018)(66446008)(64756008)(76116006)(66476007)(38070700005)(83380400001)(66556008)(8676002)(4326008)(66899018)(41300700001)(38100700002)(66946007)(66574015)(52536014)(8936002)(316002)(54906003)(966005)(110136005)(44832011)(5660300002)(122000001)(7696005)(33656002)(86362001)(2906002)(71200400001)(26005)(55016003)(186003)(9686003)(478600001)(53546011)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?EU8m5QA8UIT1I6AKRirV43Sl8FC57ry9pixJMpo5Jr6/VFncayUvr3ANEr?= =?iso-8859-1?Q?ZRSN4G9QVmIq80dPIVOPnYWQRmvCcdDRz0+okhl2R6cKpa1ZCDviPtimxT?= =?iso-8859-1?Q?1Agwl08qNLbfcb6KCj43Gwi4RXbJmuQM5H2M2P9O1LisRWZuD8o7y5eIEK?= =?iso-8859-1?Q?DtMg6SEs3quw+lXRslQZ1gmwX2snWQ1OJXWtR58iFhucHtJyb64X7595Tu?= =?iso-8859-1?Q?8lOBwgKKlSkCQXJ2F3Y49SsHUaGo+3GdPxCWd+kXo9DqNqm0K82CyIRgAm?= =?iso-8859-1?Q?8M43f2+xxE2+Pg2zKhFqS4UVjuEQ0UBFhaWxN+YYsNV0KfrzOJvI6gA2L4?= =?iso-8859-1?Q?ztR1H23R87TnR07zvNgmqM+oh4LkrJ8uzznybJymQxhaNZnipIWdfm00JD?= =?iso-8859-1?Q?GrDdfVen25Llx6MjGB4I2En8uAiChXlsaigLXxg7i9zTzrxOIpOZnxxfYK?= =?iso-8859-1?Q?epYU1UXzoYYeCQpdWfyyGs8zPEi0L5+5sEGPmSd4t14QXJgW2MAj6JQErg?= =?iso-8859-1?Q?lpSJap29JtYCz1wMw6s0i48YCCIGXZyLcV5/xKp+ooeDbTq2tOypZQmJQ0?= =?iso-8859-1?Q?4YSJhj+fsX31iqcoJFJbhXw7F9AC6KK1T1tQj+kJ/oxXu7C31+TyXQVNaM?= =?iso-8859-1?Q?HD59LJioFbsQxzw//RjqGWR82zre/MsTfu6xywl/7bKe7UDwlVb8BZQ6xU?= =?iso-8859-1?Q?PiOj5jchzo9aRX0hDqbRvRdUWcEVuRWY8vlG3njb3hp2R5A9s6IZ3XNEBz?= =?iso-8859-1?Q?VH9ApxSOD+6jq+WO1dD78mcel1KTS3hKV+Ln3uW1lP31iiUveg74X2h7s6?= =?iso-8859-1?Q?LttVOfjtO9ZdWTn6Bwjr8NCIGvQiYeb1aGTrXJ8SoNYH+LunGS8FAUm/Kz?= =?iso-8859-1?Q?Fg/4rflrgsTsjRRhjsClNSIzGiuV+XFdXYWDWXBntWjG2yL1r4m79hwSw9?= =?iso-8859-1?Q?pOAiG3ucrRwqKCFTzvyv1rmzgz9bHBGhVInTg/DKFItnXF7XPRKlyaaU4G?= =?iso-8859-1?Q?JBXgDPeEJTQsF3q4Tp5Kleg7ZIvf6njLrfBsIvlFZMhl27ivF0Ol24yh89?= =?iso-8859-1?Q?X4lp9adJw1K8DgKD63N5UBTsB2aorMuL6R+VKL8K1kIp4IUM36OAZSXoEG?= =?iso-8859-1?Q?vJI/h0Ar8697zxjGsBHK/8bdpGH4Iu10EjNIYQpDUzz1pEgUW795EKWrfI?= =?iso-8859-1?Q?k46bw42HTYMbP6lTJzVI7ZuHrki7dBnBhiwJIJhCAKYNJIuWeEhS8s5k7M?= =?iso-8859-1?Q?3xZxVxyNHSONQNZAUs71g2bFM02Sm1hBu8IzRgsZSQFFpQEC72Dw4XfrYY?= =?iso-8859-1?Q?zItdVGQ9ze4ELbWE7iyrJjBcsu6/LaJ1yRoXxwuTqwvtYB3cElpYw/Ybil?= =?iso-8859-1?Q?hpSM5yjvWpz7lJW26+ozBdOC6uEDdVHFRVG645aunJhJM9JZO1CfqP9kW1?= =?iso-8859-1?Q?wj0EySgjbgOMzEjCs4S+RUU1R25in6aJ1ycF6FusG932EIZQ8/KIodMxxe?= =?iso-8859-1?Q?uVdS1L/7EhI2fSw2TESCZcU/xN8nlRre6blyOQNSWTKoCtnh/Zyvm9tdfU?= =?iso-8859-1?Q?qB8EuljFH3dJyTAoptkMrixC7dzrJJFK9XR54VJcDZrhpsQeinCDi/ZsyE?= =?iso-8859-1?Q?4u8XlShEDozCfpSfiEGYkNsiNfvfh+n8MqF1nkUlDm7IqjT8g5Dia44g?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 438253b5-81ea-4f56-5d59-08db100a531d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2023 10:41:13.2739 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZpBogjxZED45XsvXO5riHId4UqZmzsibDJ95xIsVoRoCKYBG+hyTM3yaauZNP7LIy4Y0eqDpBJegFoOEmKGxzCQK/Hoqf4ZP6gToDvZmCUA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3796 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Niklas Soderlund > Sent: Thursday, February 16, 2023 6:37 PM > To: Kevin Traynor > Cc: Ferruh Yigit ; Xueming(Steven) Li > ; Chaoyong He ; > dev@dpdk.org; Luca Boccassi ; oss-drivers drivers@corigine.com>; Nole Zhang ; Kevin Liu > ; stable@dpdk.org > Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware wit= h > NFDk >=20 > Hi Kevin, >=20 > Thanks for your input. >=20 > On 2023-02-16 10:28:34 +0000, Kevin Traynor wrote: > > On 15/02/2023 18:28, Ferruh Yigit wrote: > > > On 2/15/2023 5:47 PM, Niklas S=F6derlund wrote: > > > > Hi Ferruh, > > > > > > > > Thanks for your continues effort in dealing with NFP patches. > > > > > > > > On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote: > > > > > On 2/8/2023 9:15 AM, Chaoyong He wrote: > > > > > > From: Peng Zhang > > > > > > > > > > > > 48-bit DMA address is supported in the firmware with NFDk, so > > > > > > enable this feature in PMD now. But the firmware with NFD3 > > > > > > still just support 40-bit DMA address. > > > > > > > > > > > > RX free list descriptor, used by both NFD3 and NFDk, is also > > > > > > modified to support 48-bit DMA address. That's OK because the > > > > > > top bits is always set to 0 when assigned with 40-bit DMA addre= ss. > > > > > > > > > > > > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") > > > > > > Cc: jin.liu@corigine.com > > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > > > > > Why a backport is requested? As far as I understand this is not > > > > > fixing anything but extending device capability. Is this a fix? > > > > > > > > I agree this is a bit of a grey zone. We reasoned this was a fix > > > > as we should have done this from the start in the commit that > > > > added support for NFDk. Are you OK moving forward with this as a > > > > fix or would you prefer we resubmit without the request to backport= ? > > > > > > > > > > I am not sure, is this change have any potential to change behavior > > > for existing users? > > > Like if one of your user is using 22.11.1 release, and if this patch > > > backported to next LTS version, 22.11.2, will user notice any differe= nce? > > > > > > > > > @Luca, @Kevin, what is your comment as LTS maintainers? > > > > > > > A bit difficult to know. If NFDk is not practicably usable without it, > > then it could be considered a fix. If it's just extending to add > > nice-to-have functionality then probably it is not a fix. >=20 > I think we can treat this as a nice-to-have and not something that makes > NFDk unusable. As stated above, we marked this as a Fix as we *really* > should have done this in the commit which added NFDk support. >=20 > @Ferruh, would you prefer we send a v2 or will you drop the Fixes and CC > tags when/if applying? >=20 Actually, the DPDK app using the nfp card with a firmware of NFDk will core= dump without this patch. And that's the directly reason we consider backport this patch. > > > > It would need to ensure that it is tested on 22.11 branch and there > > are no regressions. It is only relevant to DPDK 22.11 LTS so Cc > > Xueming who will ultimately decide. > > > > A guide below on some things to consider for this type of backport is h= ere: > > http://doc.dpdk.org/guides/contributing/stable.html#what-changes-shoul > > d-be-backported > > > > > > > > > > > > > Signed-off-by: Peng Zhang > > > > > > Reviewed-by: Chaoyong He > > > > > > Reviewed-by: Niklas S=F6derlund > > > > > > > > > > > > > > >=20 > -- > Kind Regards, > Niklas S=F6derlund