DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	oss-drivers <oss-drivers@corigine.com>,
	Niklas Soderlund <niklas.soderlund@corigine.com>,
	Nole Zhang <peng.zhang@nephogine.com>
Subject: RE: [PATCH] app/pdump: make dpdk-pdump can run multiple simultaneously
Date: Mon, 8 May 2023 03:17:53 +0000	[thread overview]
Message-ID: <SJ0PR13MB5545A5E662EB813DF5B7A8379E719@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <20230506084738.4f686809@hermes.local>



> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Saturday, May 6, 2023 11:48 PM
> To: Chaoyong He <chaoyong.he@corigine.com>
> Cc: dev@dpdk.org; oss-drivers <oss-drivers@corigine.com>; Niklas Soderlund
> <niklas.soderlund@corigine.com>; Nole Zhang
> <peng.zhang@nephogine.com>
> Subject: Re: [PATCH] app/pdump: make dpdk-pdump can run multiple
> simultaneously
> 
> On Sat,  6 May 2023 16:52:06 +0800
> Chaoyong He <chaoyong.he@corigine.com> wrote:
> 
> > From: Peng Zhang <peng.zhang@corigine.com>
> >
> > The pdump doesn't support start the multiple separate process for
> > different queues or ports to monitor the packets, because it apply the
> > same name for memory space. This commit will use the device_id, port
> > and queue to name the memory space and it will support this function.
> >
> > Adjust the value of RTE_MEMZONE_NAMESIZE to adapt the name length.
> >
> > Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> 
> FYI - app/dumpcap does support multiple ports already.
> Why not use that?

Yes, you are right.
I will abandon this patch, thanks for your reply.

Should I change the state of this patch into 'Not Applicable' or other?

      parent reply	other threads:[~2023-05-08  3:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-06  8:52 Chaoyong He
2023-05-06 15:47 ` Stephen Hemminger
2023-05-08  2:52   ` Nole Zhang
2023-05-08  3:17   ` Chaoyong He [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR13MB5545A5E662EB813DF5B7A8379E719@SJ0PR13MB5545.namprd13.prod.outlook.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@nephogine.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).