From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6623345B0C; Fri, 11 Oct 2024 04:38:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52314402E1; Fri, 11 Oct 2024 04:38:27 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2090.outbound.protection.outlook.com [40.107.243.90]) by mails.dpdk.org (Postfix) with ESMTP id 06ED6402E0; Fri, 11 Oct 2024 04:38:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qM9QD483Lo0R0SBar3MM/E8/JyXo7w6LhicZ/IEGHfgIKgiYt+Z+jRTHa7p33pxMJ4XsSQiRNeSK6IAXikoko9KzsUaY3VN1yybsHGQI1zLRK+AIVs+TSxhqIiIUeKGqt4emeYgRGtUmeRxzAaWSitCivy2VGymfu3nE7t90FpGtfwOJANQ+UDioUsozyg9wdEi6JY2SX23RJQz4+D6krdVybLoHqyfenmfYbUn2b38QzaSNcz2qYxRW5r/8VArW+8HBitkvPp/VYAy3vFSPKBgBEje7aPmgagL8SNxkfWI1GV1ZAJmxIxPDgYPKHuY3U4X8IjdT5oiucDxEWrYGyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uANVeihvf7S+p6g4Rh0qDmyeTvmwiOLd6XbvrU+fTpg=; b=gplEFev2VC96zdklGpauvDqXuiRbylB5qhTwUI745FzIBQYZllPpQZAOyT5811HDax64AM19hdz1CY8/bM0T8sAdMnub3/Blj08Bmt4xrfOAUWXgIcnksl67cMckObM1G2mv5EzqgSbCTy9Qdj6Q9BorIj6+IeEZUw/1KgaUJhK1EgQPQXVeff05Uh3NHFjDlzUT6S9W+UPiLc1hT0S5qeeAfPbPmli2xpRnZotBu4O2r1Z7Ap4yFKzrhky7idPp2Sb5x2c+L6jeNAhgnZ/55Caw6q/olOKU040TGas8dgg7bcIDJjh0Jhgc6wgsCwM2M63DEXjlKaHXDALVJay10A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uANVeihvf7S+p6g4Rh0qDmyeTvmwiOLd6XbvrU+fTpg=; b=Il6/pCGxIIBFwuqXo1/DRGF5yl6sYpA/ruW7y8e65gOeHTaEyimx8qUAr9SnIx0BTNtwzeJA/RJYZvDsSXjNoTLeopekz5tOQHB5vycbfpCyZRmV96Etg9gEdjoEgN9Vrz+tHweh+j2TTHjV1WVk5S0pEA0hWH55JxfERkJLilg= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3731.namprd13.prod.outlook.com (2603:10b6:a03:219::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Fri, 11 Oct 2024 02:38:23 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8026.020; Fri, 11 Oct 2024 02:38:23 +0000 From: Chaoyong He To: Stephen Hemminger CC: "dev@dpdk.org" , oss-drivers , "stable@dpdk.org" , Long Wu , Nole Zhang Subject: RE: [PATCH 10/10] net/nfp: fix memory leak in VF initialization logic Thread-Topic: [PATCH 10/10] net/nfp: fix memory leak in VF initialization logic Thread-Index: AQHbGvVMY3hU/Ow8wk2JIKLMeBbUsLKAGb+AgAC9RrA= Date: Fri, 11 Oct 2024 02:38:23 +0000 Message-ID: References: <20241010091716.3631747-1-chaoyong.he@corigine.com> <20241010091716.3631747-11-chaoyong.he@corigine.com> <20241010081943.5c17953c@hermes.local> In-Reply-To: <20241010081943.5c17953c@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3731:EE_ x-ms-office365-filtering-correlation-id: 31c5b1fd-209c-4122-a28e-08dce99dc70f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?DAQU2qgx+Qm+xbn8rbdl0G01PUj5ZIUlpiNuNkVGAT6FVTUba9X8dhgU9MO9?= =?us-ascii?Q?BGhLY5kujCQCQtqyrUEjpww0vbaWOxoftfiMaszSb0CLbP57+RRID/HnKAvF?= =?us-ascii?Q?01tdCAK04bs/BcCZctxIau9tYEdxano/bdViKDdBpYBT5ghBcg+OuLATD1S7?= =?us-ascii?Q?TP5GUYDVhZsEKNKDvLKofsBxRL86NmOuwV7qSEgCh0AMtb3ZNUH88fvpODFg?= =?us-ascii?Q?DpRyejWH07CogPNvKcFsKOyRp86KyOTLmWCQPMoKXxBwsuBYSmEMthICuVGL?= =?us-ascii?Q?rDExEux4LAJf00JDIOdnNVC3UTnIaaqempsrA+lKJXbevx5e6rE6noJ8dcPE?= =?us-ascii?Q?LXlBtBgZabHYc2Ng7szupbOfyakFY9Wna1tW5AHYKIjhN3lY88LLFG1rcftH?= =?us-ascii?Q?3TmgFkt1CwDst4LGBrQXTYwA/8IIZaN4sEtlEsgIyyqtW5GqU8HBFs28Lqkt?= =?us-ascii?Q?zwGV9xE0i5HoLyUWyOQwIXQA7iZn1w7PuVAYMTgnWqwWp3sx6FMiuKE3vWze?= =?us-ascii?Q?ZUcFDygxuQJImexNKPS7SRuD+R74bltY5faJhuTJOhRpW3wU5nXLT+96xeAE?= =?us-ascii?Q?lnXy3v3EbfZmgAiVZSOGLvLwdhHZifls/HsZ0SBSMbvykivL+RQTU+5peNyU?= =?us-ascii?Q?qDl0BoLUTndb4+2kgr707/L9ciiCRnpyizrOlkxzPRnKG2Bu/QTdppIyD0CL?= =?us-ascii?Q?oJH8ZOFDSJ8iXCCfdPcXPoCQ8OPbKGwj05KXtc+gMnZXkiWV7AV3eJGNxvja?= =?us-ascii?Q?fC89sabpSy0jMdFFYXZZEd0dRF7OmXi3UUo2JPE3C817AgkwGTUf0hEL+zgp?= =?us-ascii?Q?VVh0ViSSj6uvFrsFMdLQYEGrDI/Emu1Kqw6pit7llpaWxFRDNcih9XVDnj7F?= =?us-ascii?Q?VsgFM6DIL/k1ESRn4QjM7fqcy8UxNTIPNVr0DZEnt6yPjwYjk51HWTCdHv+7?= =?us-ascii?Q?j56035h2wOaXpW/RwJm0yAjQ/++gEpQzb9vIv8+X+975HA65hnmdNFmY/i19?= =?us-ascii?Q?b3giBB79ak0QJhe1xY+ot/sk9hHxTZ0YJcNxfG7Ujig5f+xA64nGtOugldT9?= =?us-ascii?Q?YDSYShqT/8e4CY3OAMwMjBKGirj8ttIyd78KbIlRqt2ibdMpkivgrRwI9UaT?= =?us-ascii?Q?Dj5GkwgCLdwDgXUmUaDaEAztFTGWpZh4YOnsj2AbYM8uOd0rXFlY8dYuz3Tz?= =?us-ascii?Q?K7jF4+hBCnn6P/agy+ECOKLAqOdBj997wMmanXhlGYtEgMwi/9GoY5WVJPc+?= =?us-ascii?Q?9gRNEjnLifckkmb8T4oqBbwwguiL/TTumZE+GazU6NcVXF86/+XeACmCRyBd?= =?us-ascii?Q?oa6rruDhHaE1xe7IglbE0fUCMlFCXKVuzRVctO6NfBLyhA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?97yB54OOiog+QeqUxSxVpBfxJqv+KTROWQze+wx7o+ii+2eCx5kOgS6Qg3lo?= =?us-ascii?Q?eZPDEJFvGZOg6DBxmZyBEPVEUijwPNnhs/frz0F1lsmmKpXd6HfnDAmDn5dB?= =?us-ascii?Q?gUDmifxA6EksX7ruHsi9K8kv7q6cX74gf+TMzoxTvOQi/p8FBkvU12m6a4zw?= =?us-ascii?Q?uYsDgS+kuRUyCFlDl6pwONtaV5nkx8SCS6FIA8FVG2qKKLEX7XAaNMvxI2Ot?= =?us-ascii?Q?VVm7EcxBfplyy2U5OwI5vL8KAqRkcNENOwDMWucIo7oXjVPHSbMcw83lVZq8?= =?us-ascii?Q?mQxFSIijJrp6hnTsLko16wnW/Mhj1gJfVSnhrPM/tXabzCAGlnpDOaYZcqSA?= =?us-ascii?Q?n0Pspywe+bRP1cBH/GXSx2yaLif1ctih8PdD/pwT+DG/DS4yvyP5O8JbcCBn?= =?us-ascii?Q?lTbCBolT4f5b7RQjN4xLBvYMHkKRviyScahb505p2vU0IJF29FpgHkz1gUEA?= =?us-ascii?Q?RDqBo1Yq4yMxXG4fGybzagEcepHi92YCESPEvMj4NztUOGlMYetk1Prvx1m/?= =?us-ascii?Q?MIIC08ynr9/Api8XkVAZqIPmDf0ibVCNObyQwETUfIe+XA3xyqVIIMaixAMd?= =?us-ascii?Q?ViERWsCsWAsgo/OHQt834sqy4vDz7v0AemwG759+o9s4ah3IV+EbHAxYWELA?= =?us-ascii?Q?pAX4Pv8vWAFUhXisBHXGRiHb3o1iMxp4v0/GLF1Cv/eOgafpZgOubg6c7NEv?= =?us-ascii?Q?qyXcZvSDspoNccxJ6JpV8G+SOKQ6fe/4Caika8nu4G18IYsAO7UqMB5uUB7N?= =?us-ascii?Q?rnsbpM8aWqeyVje+kyAwRfbLk0J6nTUeiJ2bks4VpPEl7bg2d+tYK3Qb9FT+?= =?us-ascii?Q?geLnabOVLH+tT7OYQMgVRghl76evAFurcdfC/4Qd92N8aQGqZsigW4V0QPH/?= =?us-ascii?Q?hgMs7vHDWHZtS0Nzfj/YaBv65vjilEbXWfyVWEhs7L63XITBDx5wTwy9moQD?= =?us-ascii?Q?/okCByOCm5VKnCBMvUAukBomis5smix4dliL3X2HZkM0kAsdX4ras2Eewn1c?= =?us-ascii?Q?IH3EEGgdpSonNXp/tzhvrG8bWS57e6S8DurO5nFK/OsVjGq5QVkZrv7oQV8B?= =?us-ascii?Q?sJTQ2816ZNTkL/TlRG4F4TStvfqxtV61iiiYmH/ZGcKRv4ssMwgnjPEmbwvN?= =?us-ascii?Q?xODYW8FXhlnhmsf36nzhMyqUe+S1KLxk5jx+T+emxV00Oucr79gk2xugmbur?= =?us-ascii?Q?PVcaOe/bsstsrAGRxM84yv5Ef7OjNU64RrYnNLyi7Boy40fRk3LfKYSyDxmr?= =?us-ascii?Q?C+Ne9h4GQTtz3oquIC467thleagbgr1mw8T5EL1haVXIqHgA1C+WQ7nZZRbz?= =?us-ascii?Q?lsxqgA3uUhicoEVKG4ldQavZsOdOXsyHHTUEiDkPYKlASqoz9ne2ovSq/KVx?= =?us-ascii?Q?EHTKrn/PGqazJxi0qeXz4yiNMKB6/RJ7Kz4Fy9NV/cpr/8BmfulCyHRfaHR7?= =?us-ascii?Q?ez0J0UysE4eGHASXnU7bDsiPIirxrqlR5JN4NLxUK9F4psajbD07BhOMXRJM?= =?us-ascii?Q?Agcx9sj8o0v9arM48PS12/Vh/2lzjuZlbbCjCO3ui3mPYrsdnv/Bs8rFY00u?= =?us-ascii?Q?qtCZ8eitj1BaziqX1Ua00122qnhZ/ENViTqE2yM8?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31c5b1fd-209c-4122-a28e-08dce99dc70f X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2024 02:38:23.8164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9hYtgnliFrL/X36M+jwbbgzyAvwbkviv0lDk59rbhkaMlXzvTNKysqb7HCYiZoUE/oi580N9gbvxemw10c5INYZBfmGws4yHqdS5LN1vQtc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3731 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Thu, 10 Oct 2024 17:17:16 +0800 > Chaoyong He wrote: >=20 > > Fix one memory leak problem in the logic of VF initialization. > > > > Fixes: d81e2b514dc9 ("net/nfp: move device info into process private > > data") > > Cc: stable@dpdk.org > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang > > --- >=20 > The code as is looks fine, but would have been better to use rte_calloc()= when > allocating eth_xstats_base. Yes, I think what you said is better. Will do it in next version. Thanks for your review. >=20 > Acked-by: Stephen Hemminger