From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
Long Wu <Long.Wu@nephogine.com>,
Nole Zhang <peng.zhang@corigine.com>
Subject: RE: [PATCH] net/nfp: add support of UDP fragmentation offload
Date: Tue, 20 Feb 2024 07:54:27 +0000 [thread overview]
Message-ID: <SJ0PR13MB5545A9C162B8CE9EDE2E493B9E502@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <85ac4c1d-6801-46e4-a337-01f1b47cd05d@amd.com>
> On 2/17/2024 1:54 AM, Chaoyong He wrote:
> > Add the support of UDP fragmentation offload feature.
> >
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Long Wu <long.wu@corigine.com>
> > Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>
> <...>
>
> > diff --git a/drivers/net/nfp/nfp_net_common.c
> > b/drivers/net/nfp/nfp_net_common.c
> > index 72c9a41b00..99c319eb2d 100644
> > --- a/drivers/net/nfp/nfp_net_common.c
> > +++ b/drivers/net/nfp/nfp_net_common.c
> > @@ -312,7 +312,7 @@ nfp_net_log_device_information(const struct
> nfp_net_hw *hw)
> > hw->ver.major, hw->ver.minor, hw->max_mtu);
> >
> > PMD_INIT_LOG(INFO, "CAP: %#x", cap);
> > - PMD_INIT_LOG(INFO,
> "%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s",
> > + PMD_INIT_LOG(INFO,
> >
> +"%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s
> %s",
> >
>
> This seems getting out of hand, I assume this is done like this (instead of multiple
> print lines) to prevent line break, if so what do you think add a new macro that
> doesn't append \n automatically and refactor this code (in a separate patch) ?
Yeah, that's a good point, thanks!
I will add it into my to-do list, and send a patch at the suitable time.
next prev parent reply other threads:[~2024-02-20 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 1:54 Chaoyong He
2024-02-17 16:47 ` Stephen Hemminger
2024-02-17 18:02 ` Morten Brørup
2024-02-17 18:11 ` Stephen Hemminger
2024-02-18 10:05 ` Morten Brørup
2024-02-19 10:26 ` Bruce Richardson
2024-02-19 10:28 ` Ferruh Yigit
2024-02-19 13:30 ` Ferruh Yigit
2024-02-19 13:41 ` Ferruh Yigit
2024-02-20 7:54 ` Chaoyong He [this message]
2024-02-19 14:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB5545A9C162B8CE9EDE2E493B9E502@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=Long.Wu@nephogine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).