DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
	Shihong Wang <shihong.wang@nephogine.com>,
	Chang Miao <chang.miao@nephogine.com>
Subject: RE: [PATCH 02/10] net/nfp: add TLVs capability parsing
Date: Thu, 28 Sep 2023 02:02:28 +0000	[thread overview]
Message-ID: <SJ0PR13MB5545BEC2CB2B5B6B930444719EC1A@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <69a54bcf-2095-4761-98a0-d55f93d13090@amd.com>

> On 9/25/2023 7:06 AM, Chaoyong He wrote:
> > From: Shihong Wang <shihong.wang@corigine.com>
> >
> > Add TLV capabilities to the BAR, TLVs is fit for expressing
> > capabilities of applications running on programmable hardware.
> >
> 
> Here application referred is bitstream or FW, right?
Yes, it is.

> And PCIe BAR is used to exchange the capability information.
> Not for this patch, but I wonder is there a value to add this kind of parsing to the
> PCI code, if it is a generic usage, Chaoyong what do you think?
Basically, it does have value to do that, the kernel driver already have these logics for a long time and using it for some features.
For our PMD, it's the first time we import this and the main reason is we need to support the mailbox channel between driver and CoreNIC firmware.
The mailbox channel is needed for IPsec and other features we will try to merge in the near future.

I have to admit the ` nfp_net_tlv_caps_parse()` function now seems does have some unrelated logics, I will try to remove them in the next version patch.

Do you think it's okay?

> > Declares a TLV capability start at offset 0x58, up to 0x0d90.
> > The used space can be wrapped with RESERVED.
> >
> > Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
> > Signed-off-by: Chang Miao <chang.miao@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> >
> 
> <...>


  reply	other threads:[~2023-09-28  2:02 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25  6:06 [PATCH 00/10] add the support of ipsec offload Chaoyong He
2023-09-25  6:06 ` [PATCH 01/10] mailmap: update contributor entry Chaoyong He
2023-09-27 14:19   ` Ferruh Yigit
2023-09-28  1:50     ` Chaoyong He
2023-09-25  6:06 ` [PATCH 02/10] net/nfp: add TLVs capability parsing Chaoyong He
2023-09-27 14:19   ` Ferruh Yigit
2023-09-28  2:02     ` Chaoyong He [this message]
2023-09-28  9:30       ` Ferruh Yigit
2023-09-25  6:06 ` [PATCH 03/10] net/nfp: add mailbox to support IPsec offload Chaoyong He
2023-09-25  6:06 ` [PATCH 04/10] net/nfp: initialize IPsec related content Chaoyong He
2023-09-25  6:06 ` [PATCH 05/10] net/nfp: get security capabilities and session size Chaoyong He
2023-09-25  6:06 ` [PATCH 06/10] net/nfp: get IPsec Rx/Tx packet statistics Chaoyong He
2023-09-25  6:06 ` [PATCH 07/10] net/nfp: create security session Chaoyong He
2023-09-25  6:06 ` [PATCH 08/10] net/nfp: update " Chaoyong He
2023-09-25  6:06 ` [PATCH 09/10] net/nfp: support IPsec Rx and Tx offload Chaoyong He
2023-09-25  6:06 ` [PATCH 10/10] net/nfp: destroy security session Chaoyong He
2023-09-26  2:49 ` [PATCH v2 00/10] add the support of ipsec offload Chaoyong He
2023-09-26  2:49   ` [PATCH v2 01/10] mailmap: update contributor entry Chaoyong He
2023-09-26  2:49   ` [PATCH v2 02/10] net/nfp: add TLVs capability parsing Chaoyong He
2023-09-26  2:49   ` [PATCH v2 03/10] net/nfp: add mailbox to support IPsec offload Chaoyong He
2023-09-26  2:49   ` [PATCH v2 04/10] net/nfp: initialize IPsec related content Chaoyong He
2023-09-26  2:49   ` [PATCH v2 05/10] net/nfp: get security capabilities and session size Chaoyong He
2023-09-26  2:49   ` [PATCH v2 06/10] net/nfp: get IPsec Rx/Tx packet statistics Chaoyong He
2023-09-26  2:49   ` [PATCH v2 07/10] net/nfp: create security session Chaoyong He
2023-09-26  2:49   ` [PATCH v2 08/10] net/nfp: update " Chaoyong He
2023-09-26  2:49   ` [PATCH v2 09/10] net/nfp: support IPsec Rx and Tx offload Chaoyong He
2023-09-26  2:49   ` [PATCH v2 10/10] net/nfp: destroy security session Chaoyong He
2023-09-27 14:20   ` [PATCH v2 00/10] add the support of ipsec offload Ferruh Yigit
2023-09-28  2:05     ` Chaoyong He
2023-09-28  9:33       ` Ferruh Yigit
2023-09-29  2:08   ` [PATCH v3 0/9] " Chaoyong He
2023-09-29  2:08     ` [PATCH v3 1/9] net/nfp: add TLVs capability parsing Chaoyong He
2023-09-29  2:08     ` [PATCH v3 2/9] net/nfp: add mailbox to support IPsec offload Chaoyong He
2023-09-29  2:08     ` [PATCH v3 3/9] net/nfp: initialize IPsec related content Chaoyong He
2023-09-29 10:00       ` Ferruh Yigit
2023-09-29  2:08     ` [PATCH v3 4/9] net/nfp: get security capabilities and session size Chaoyong He
2023-09-29  2:08     ` [PATCH v3 5/9] net/nfp: get IPsec Rx/Tx packet statistics Chaoyong He
2023-09-29  2:08     ` [PATCH v3 6/9] net/nfp: create security session Chaoyong He
2023-09-29  2:08     ` [PATCH v3 7/9] net/nfp: update " Chaoyong He
2023-09-29  2:08     ` [PATCH v3 8/9] net/nfp: support IPsec Rx and Tx offload Chaoyong He
2023-09-29  2:08     ` [PATCH v3 9/9] net/nfp: destroy security session Chaoyong He
2023-09-29 10:05     ` [PATCH v3 0/9] add the support of ipsec offload Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR13MB5545BEC2CB2B5B6B930444719EC1A@SJ0PR13MB5545.namprd13.prod.outlook.com \
    --to=chaoyong.he@corigine.com \
    --cc=chang.miao@nephogine.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=oss-drivers@corigine.com \
    --cc=shihong.wang@nephogine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).