From: Shijith Thotton <sthotton@marvell.com>
To: Aaron Conole <aconole@redhat.com>
Cc: "dpdklab@iol.unh.edu" <dpdklab@iol.unh.edu>,
Anoob Joseph <anoobj@marvell.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] Re: [PATCH v2] app/eventdev: add crypto producer mode
Date: Tue, 4 Jan 2022 15:49:53 +0000 [thread overview]
Message-ID: <SJ0PR18MB44290E30EE1F64CD74BF4429D94A9@SJ0PR18MB4429.namprd18.prod.outlook.com> (raw)
In-Reply-To: <f7tfsq3bjva.fsf@redhat.com>
>>>> >>
>>>> >> In crypto producer mode, producer core enqueues cryptodev with
>>>> >> software generated crypto ops and worker core dequeues crypto
>>>> >> completion events from the eventdev. Event crypto metadata used for
>>>> >> above processing is pre- populated in each crypto session.
>>>> >>
>>>> >> Parameter --prod_type_cryptodev can be used to enable crypto producer
>>>> >mode.
>>>> >> Parameter --crypto_adptr_mode can be set to select the crypto adapter
>>>> >> mode,
>>>> >0
>>>> >> for OP_NEW and 1 for OP_FORWARD.
>>>> >>
>>>> >> This mode can be used to measure the performance of crypto adapter.
>>>> >>
>>>> >> Example:
>>>> >> ./dpdk-test-eventdev -l 0-2 -w <EVENTDEV> -w <CRYPTODEV> -- \
>>>> >> --prod_type_cryptodev --crypto_adptr_mode 1 --test=perf_atq \
>>>> >> --stlist=a --wlcores 1 --plcores 2
>>>> >
>>>> >This patch has some perf failure as shown below. Could you please look into
>>>> this?
>>>> >105300 --> performance testing fail
>>>> >
>>>> >Test environment and result as below:
>>>> >
>>>> >Ubuntu 20.04
>>>> >Kernel: 4.15.0-generic
>>>> >Compiler: gcc 7.4
>>>> >NIC: Intel Corporation Ethernet Converged Network Adapter 82599ES 10000
>>>> >Mbps
>>>> >Target: x86_64-native-linuxapp-gcc
>>>> >Fail/Total: 0/4
>>>> >
>>>> >Detail performance results:
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| frame_size | txd/rxd | num_cpus | num_threads | throughput
>>>> >| difference from
>>>> >|
>>>> >| | | | | expected |
>>>>
>>>>+============+=========+==========+=============+==========
>==
>>>=
>>>> >=================+
>>>> >| 64 | 512 | 1 | 1 | 0.3% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| 64 | 2048 | 1 | 1 | -0.2% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| 64 | 512 | 1 | 2 | 0.0% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| 64 | 2048 | 1 | 2 | 0.3% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >
>>>> >Ubuntu 20.04
>>>> >Kernel: 4.15.0-generic
>>>> >Compiler: gcc 7.4
>>>> >NIC: Intel Corporation Ethernet Converged Network Adapter XL710-QDA2
>>>> >40000 Mbps
>>>> >Target: x86_64-native-linuxapp-gcc
>>>> >Fail/Total: 1/4
>>>> >
>>>> >Detail performance results:
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| frame_size | txd/rxd | num_cpus | num_threads | throughput
>>>> >| difference from
>>>> >|
>>>> >| | | | | expected |
>>>>
>>>>+============+=========+==========+=============+==========
>==
>>>=
>>>> >=================+
>>>> >| 64 | 512 | 1 | 1 | 0.2% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| 64 | 2048 | 1 | 1 | -0.7% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| 64 | 512 | 1 | 2 | -1.5% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| 64 | 2048 | 1 | 2 | -5.3% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >
>>>> >Ubuntu 20.04 ARM
>>>> >Kernel: 4.15.0-132-generic
>>>> >Compiler: gcc 7.5
>>>> >NIC: Arm Intel Corporation Ethernet Converged Network Adapter
>>>> >XL710-QDA2
>>>> >40000 Mbps
>>>> >Target: x86_64-native-linuxapp-gcc
>>>> >Fail/Total: 0/2
>>>> >
>>>> >Detail performance results:
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| frame_size | txd/rxd | num_cpus | num_threads | throughput
>>>> >| difference from
>>>> >|
>>>> >| | | | | expected |
>>>>
>>>>+============+=========+==========+=============+==========
>==
>>>=
>>>> >=================+
>>>> >| 64 | 512 | 1 | 1 | 0.1% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >| 64 | 2048 | 1 | 1 | -0.5% |
>>>> >+------------+---------+----------+-------------+------------------------------+
>>>> >
>>>> >To view detailed results, visit:
>>>> >https://urldefense.proofpoint.com/v2/url?u=https-
>>>>
>>>>3A__lab.dpdk.org_results_dashboard_patchsets_20534_&d=DwIFAg&c=nKj
>We
>>>> c2
>>>>
>>b6R0mOyPaz7xtfQ&r=G9w4KsPaQLACBfGCL35PtiRH996yqJDxAZwrWegU2qQ&
>>>> m=
>>>>
>>>>dPDgmKiLC_KqhgjwZrodyFlBdlFPgckVr9IW0c7t2cIHpkw6u9pGqgElFqqwuU1v&
>s
>>>> =E
>>>> >ajYUFziZY27q6LB4p5sOGuFlty3VlOjbMsLXaQ5MeI&e=
>>>> >
>>>>
>>>> Performance regression is reported by nic_single_core_perf, but is using
>>>> testpmd to measure performance. As this patch does not touch testpmd, the
>>>> issue could be with DPDK CI. Is it possible to re-trigger CI ?
>>>I have don't have option to trigger CI from my side.
>>>So, I have added dpdklab and Aaron to the loop.
>>>Please check with them.
>>>
>>
>> Thanks Abhinandan.
>>
>> Aaron,
>> From DTS, I only see testpmd being used for nic_single_core_perf test.
>> This patch is not touching testpmd, but still got failure for the perf test.
>> If possible, Please re-retrigger CI for this patch.
>
>Seems this was superseded - I am guessing no new test needs to be run
>for this:
>
>https://urldefense.proofpoint.com/v2/url?u=https-
>3A__patches.dpdk.org_project_dpdk_patch_736dc424a780b9547033f76f8911342f
>f06d3f87.1641292088.git.sthotton-
>40marvell.com_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=G9w4KsPaQLACBf
>GCL35PtiRH996yqJDxAZwrWegU2qQ&m=qAw77KHlJ3Gr9aLNyRrJFhgKWJM-
>y3Rgjlf3TZlNeM4vM7hontySZ4inIBL6ehjB&s=uWo5o2-
>22qVZRfYgG3swzbFeYJYtzrjJTPxsgBZGo30&e=
>
>Is that correct?
Yes, the patch is superseded.
CI is passing for v3. nic_single_core_perf numbers may not be consistent.
next prev parent reply other threads:[~2022-01-04 15:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 19:53 [PATCH] " Shijith Thotton
2021-12-21 8:51 ` [PATCH v2] " Shijith Thotton
2021-12-30 11:56 ` Gujjar, Abhinandan S
2022-01-03 6:04 ` Shijith Thotton
2022-01-03 8:46 ` Gujjar, Abhinandan S
2022-01-03 9:14 ` Shijith Thotton
2022-01-04 15:28 ` Aaron Conole
2022-01-04 15:49 ` Shijith Thotton [this message]
2022-01-04 10:30 ` [PATCH v3] " Shijith Thotton
2022-01-21 12:25 ` Jerin Jacob
2022-01-23 16:56 ` Gujjar, Abhinandan S
2022-01-23 18:44 ` Gujjar, Abhinandan S
2022-01-24 6:09 ` Shijith Thotton
2022-01-24 6:59 ` Shijith Thotton
2022-01-25 14:15 ` Gujjar, Abhinandan S
2022-01-25 13:39 ` Gujjar, Abhinandan S
2022-02-08 17:00 ` Shijith Thotton
2022-02-14 15:26 ` Jerin Jacob
2022-02-14 15:31 ` Gujjar, Abhinandan S
2022-02-08 16:33 ` [PATCH v4] " Shijith Thotton
2022-02-15 6:03 ` Gujjar, Abhinandan S
2022-02-15 16:08 ` Shijith Thotton
2022-02-15 16:46 ` Gujjar, Abhinandan S
2022-02-15 16:56 ` [PATCH v5] " Shijith Thotton
2022-02-16 4:47 ` Gujjar, Abhinandan S
2022-02-16 7:08 ` Shijith Thotton
2022-02-16 7:49 ` Gujjar, Abhinandan S
2022-02-16 8:44 ` Jerin Jacob
2022-02-16 8:54 ` Jerin Jacob
2022-02-17 5:33 ` Gujjar, Abhinandan S
2022-02-21 13:10 ` Van Haaren, Harry
2022-02-22 7:03 ` Shijith Thotton
2022-02-23 9:02 ` Gujjar, Abhinandan S
2022-02-23 10:02 ` Shijith Thotton
2022-02-23 10:13 ` Van Haaren, Harry
2022-02-23 16:33 ` Gujjar, Abhinandan S
2022-02-23 17:02 ` Shijith Thotton
2022-02-17 6:56 ` [EXT] " Akhil Goyal
2022-02-18 12:00 ` Shijith Thotton
2022-02-18 12:11 ` [PATCH v6] " Shijith Thotton
2022-02-24 4:46 ` [PATCH v7] " Shijith Thotton
2022-02-24 6:18 ` Gujjar, Abhinandan S
2022-02-24 7:58 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR18MB44290E30EE1F64CD74BF4429D94A9@SJ0PR18MB4429.namprd18.prod.outlook.com \
--to=sthotton@marvell.com \
--cc=abhinandan.gujjar@intel.com \
--cc=aconole@redhat.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).